)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"841641aa2eca342cfd989a590233a5d3a454cc50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"ed86dbd0_faf9d9cd","updated":"2022-05-04 19:55:37.000000000","message":"Well documented.  Makes sense to me.  Thank you.","commit_id":"fbfc5ab788a5b596a2bfe0d6480dd01e681648eb"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f60b637f990e44e373db219641eff73058b74083","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"1938006e_586c957f","updated":"2022-08-15 23:38:38.000000000","message":"Still reviewing.  A few points noted inline.","commit_id":"1d4c8a2fbd24abff7c968ece745ba605cd05f220"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"641ab38cc13a4bc7b61e0d4c651b440b8544959c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"ba5f9f44_480a571b","updated":"2022-09-14 15:35:38.000000000","message":"I think this change makes sense to me.  Walt reports that he has been running this in his production system for some time, so that helps confidence.","commit_id":"856d3e108035ac1ed9c6a3cec4de47b1eb6ad18b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4bffbee09f23066e29f92d30675efa07cf810d08","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"87382c0e_0768ad6e","updated":"2022-09-14 21:27:34.000000000","message":"It\u0027s good to get the computations in one place and having the capacity factors treated consistently.","commit_id":"856d3e108035ac1ed9c6a3cec4de47b1eb6ad18b"}],"cinder/utils.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f60b637f990e44e373db219641eff73058b74083","unresolved":true,"context_lines":[{"line_number":720,"context_line":"                               provisioned_capacity: float,"},{"line_number":721,"context_line":"                               thin_provisioning_support: bool,"},{"line_number":722,"context_line":"                               max_over_subscription_ratio: float,"},{"line_number":723,"context_line":"                               reserved_percentage: float,"},{"line_number":724,"context_line":"                               thin: bool) -\u003e dict:"},{"line_number":725,"context_line":"    \"\"\"Create the various capacity factors of the a particular backend."},{"line_number":726,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"c0a878e2_b9fee4ae","line":723,"range":{"start_line":723,"start_character":52,"end_line":723,"end_character":57},"updated":"2022-08-15 23:38:38.000000000","message":"I wonder whether this should be an int (because of how it\u0027s treated at line 761) but also because of the way it\u0027s defined in the queens provisioning-improvements spec.  (I\u0027m worried that someone will pass a reserved_percentage of 15% as the float 0.15, which will be treated as .15% in the calculation.)","commit_id":"1d4c8a2fbd24abff7c968ece745ba605cd05f220"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"76b2470998fd0870aa051771082e0fb9b40a4b79","unresolved":false,"context_lines":[{"line_number":720,"context_line":"                               provisioned_capacity: float,"},{"line_number":721,"context_line":"                               thin_provisioning_support: bool,"},{"line_number":722,"context_line":"                               max_over_subscription_ratio: float,"},{"line_number":723,"context_line":"                               reserved_percentage: float,"},{"line_number":724,"context_line":"                               thin: bool) -\u003e dict:"},{"line_number":725,"context_line":"    \"\"\"Create the various capacity factors of the a particular backend."},{"line_number":726,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"28bdea51_110f6d41","line":723,"range":{"start_line":723,"start_character":52,"end_line":723,"end_character":57},"in_reply_to":"c0a878e2_b9fee4ae","updated":"2022-09-08 19:17:53.000000000","message":"Done","commit_id":"1d4c8a2fbd24abff7c968ece745ba605cd05f220"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f60b637f990e44e373db219641eff73058b74083","unresolved":true,"context_lines":[{"line_number":726,"context_line":""},{"line_number":727,"context_line":"    Based off of definition of terms"},{"line_number":728,"context_line":"    cinder-specs/specs/queens/provisioning-improvements.html"},{"line_number":729,"context_line":""},{"line_number":730,"context_line":"    total_capacity - The reported total capacity in the backend."},{"line_number":731,"context_line":"    free_capacity - The free space/capacity as reported by the backend."},{"line_number":732,"context_line":"    reserved_capacity - The amount of space reserved from the total_capacity"}],"source_content_type":"text/x-python","patch_set":22,"id":"4cf99677_7c54947d","line":729,"updated":"2022-08-15 23:38:38.000000000","message":"I hate to be a PITA, but it would be good to handle all the parameters together using the usual sphinx syntax (you can probably copy \u0026 paste from the next function), and then describe the computations you\u0027re doing.  It would also be good to say that \u0027gb\u0027 are expected to be gibibytes (just to be explicit).","commit_id":"1d4c8a2fbd24abff7c968ece745ba605cd05f220"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"76b2470998fd0870aa051771082e0fb9b40a4b79","unresolved":false,"context_lines":[{"line_number":726,"context_line":""},{"line_number":727,"context_line":"    Based off of definition of terms"},{"line_number":728,"context_line":"    cinder-specs/specs/queens/provisioning-improvements.html"},{"line_number":729,"context_line":""},{"line_number":730,"context_line":"    total_capacity - The reported total capacity in the backend."},{"line_number":731,"context_line":"    free_capacity - The free space/capacity as reported by the backend."},{"line_number":732,"context_line":"    reserved_capacity - The amount of space reserved from the total_capacity"}],"source_content_type":"text/x-python","patch_set":22,"id":"a5fb0afb_b8b112ab","line":729,"in_reply_to":"4cf99677_7c54947d","updated":"2022-09-08 19:17:53.000000000","message":"Done","commit_id":"1d4c8a2fbd24abff7c968ece745ba605cd05f220"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f60b637f990e44e373db219641eff73058b74083","unresolved":true,"context_lines":[{"line_number":789,"context_line":""},{"line_number":790,"context_line":"    def _limit(x):"},{"line_number":791,"context_line":"        \"\"\"Limit our floating points to 2 decimal places.\"\"\""},{"line_number":792,"context_line":"        return float(f\"{x:.2f}\")"},{"line_number":793,"context_line":""},{"line_number":794,"context_line":"    return {"},{"line_number":795,"context_line":"        \"total_capacity\": total,"}],"source_content_type":"text/x-python","patch_set":22,"id":"03efdb97_263702bb","line":792,"range":{"start_line":792,"start_character":15,"end_line":792,"end_character":32},"updated":"2022-08-15 23:38:38.000000000","message":"why not round(x, 2) ?","commit_id":"1d4c8a2fbd24abff7c968ece745ba605cd05f220"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"46373950ee7c59500b019e90e04a9681cc2a56d6","unresolved":false,"context_lines":[{"line_number":789,"context_line":""},{"line_number":790,"context_line":"    def _limit(x):"},{"line_number":791,"context_line":"        \"\"\"Limit our floating points to 2 decimal places.\"\"\""},{"line_number":792,"context_line":"        return float(f\"{x:.2f}\")"},{"line_number":793,"context_line":""},{"line_number":794,"context_line":"    return {"},{"line_number":795,"context_line":"        \"total_capacity\": total,"}],"source_content_type":"text/x-python","patch_set":22,"id":"d58b85a3_a5d10dee","line":792,"range":{"start_line":792,"start_character":15,"end_line":792,"end_character":32},"in_reply_to":"03efdb97_263702bb","updated":"2022-09-09 15:50:42.000000000","message":"Done","commit_id":"1d4c8a2fbd24abff7c968ece745ba605cd05f220"}]}