)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"bb4d5531285e8f9fe5bf0db950255bb5a62fdc92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"030d52ed_0d679038","updated":"2022-03-04 19:57:17.000000000","message":"Looks good to me. We should make sure to check the third party CI results since we are touching a few drivers, but I wouldn\u0027t expect this to cause a problem.\n\nThe packaging dependency was added two years ago here: https://opendev.org/openstack/cinder/commit/521057dd97d1656838e861d8c189f9611b7d6c6c\n\nSo no concerns adopting more usage of it.","commit_id":"8605e4d7d91dc795a365e2dde5147e4aefe14856"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"361e3eedbbe33b0bd71ff4824b6a9a78c78c7f38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a1fec8fa_a2f00ad4","updated":"2022-05-11 14:39:19.000000000","message":"I think the few comments could be handled in a follow-up patch.","commit_id":"8f50a9fd28bce8e78ad191566bad287af18f12a1"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"543134ac0bb295e509b5be1f582c401014e55288","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"76e4974f_e6e6a60f","updated":"2022-04-20 15:03:13.000000000","message":"LGTM, though there are a couple of minor nits","commit_id":"8f50a9fd28bce8e78ad191566bad287af18f12a1"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"48b9a2dc7fd688df3a7b674e6af06cb128c3eaaa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"66a25c90_626b1e0f","updated":"2022-04-21 13:48:10.000000000","message":"Looks good to me. Nits are fairly minor, so I think it\u0027s fine if it went in as is, but leaving to someone else to merge just in case we want to address those first.","commit_id":"8f50a9fd28bce8e78ad191566bad287af18f12a1"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"62e362b93bbbe4b1a2057ae36fc34c89d15807fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"77d5755a_8900d5e5","updated":"2022-05-11 19:47:20.000000000","message":"recheck","commit_id":"8f50a9fd28bce8e78ad191566bad287af18f12a1"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"ec541a1e3514e17c694da398fcaca62efb433946","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a6998bec_e315dcdd","updated":"2022-05-11 17:22:17.000000000","message":"recheck","commit_id":"8f50a9fd28bce8e78ad191566bad287af18f12a1"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"48bd64b4caf4c7d8ad61c888eaaad44775993d19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f8476bf2_8d39fab8","updated":"2022-05-13 14:12:30.000000000","message":"recheck","commit_id":"8f50a9fd28bce8e78ad191566bad287af18f12a1"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8da8b5a111b9fa6879ad907dcb8278c8e25048eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"057e0e88_252ccff8","updated":"2022-05-13 08:32:54.000000000","message":"recheck cinder-plugin-ceph-tempest : nova API failures","commit_id":"8f50a9fd28bce8e78ad191566bad287af18f12a1"}],"cinder/volume/drivers/ceph/rbd_iscsi.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"543134ac0bb295e509b5be1f582c401014e55288","unresolved":true,"context_lines":[{"line_number":93,"context_line":"    def _create_client(self):"},{"line_number":94,"context_line":"        client_version \u003d rbd_iscsi_client.version"},{"line_number":95,"context_line":"        if (version.parse(client_version) \u003c"},{"line_number":96,"context_line":"                version.parse(MIN_CLIENT_VERSION)):"},{"line_number":97,"context_line":"            ex_msg \u003d (_(\u0027Invalid rbd_iscsi_client version found (%(found)s). \u0027"},{"line_number":98,"context_line":"                        \u0027Version %(min)s or greater required. Run \"pip\u0027"},{"line_number":99,"context_line":"                        \u0027 install --upgrade rbd-iscsi-client\" to upgrade\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"a0ec8c11_19d24a97","line":96,"updated":"2022-04-20 15:03:13.000000000","message":"nit: this now fits in a single line","commit_id":"8f50a9fd28bce8e78ad191566bad287af18f12a1"}],"cinder/volume/drivers/ibm/ibm_storage/ds8k_helper.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"543134ac0bb295e509b5be1f582c401014e55288","unresolved":true,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import eventlet"},{"line_number":23,"context_line":"from oslo_log import log as logging"},{"line_number":24,"context_line":"import packaging.version as dist_version  # pylint: disable\u003dE0611"},{"line_number":25,"context_line":"import six"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from cinder import coordination"}],"source_content_type":"text/x-python","patch_set":2,"id":"0def9eaf_1cb5709e","line":24,"range":{"start_line":24,"start_character":28,"end_line":24,"end_character":40},"updated":"2022-04-20 15:03:13.000000000","message":"nit: this is no longer dist_version but pack_version","commit_id":"8f50a9fd28bce8e78ad191566bad287af18f12a1"}],"cinder/volume/drivers/pure.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"543134ac0bb295e509b5be1f582c401014e55288","unresolved":true,"context_lines":[{"line_number":355,"context_line":"        )"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"        array_info \u003d self._array.get()"},{"line_number":358,"context_line":"        if version.parse(array_info[\"version\"]) \u003c version.parse("},{"line_number":359,"context_line":"            \u00275.3.0\u0027"},{"line_number":360,"context_line":"        ):"},{"line_number":361,"context_line":"            msg \u003d _(\"FlashArray Purity version less than 5.3.0 unsupported.\""}],"source_content_type":"text/x-python","patch_set":2,"id":"09326d1c_88fe366d","line":358,"updated":"2022-04-20 15:03:13.000000000","message":"nit: This should fit in a single line now","commit_id":"8f50a9fd28bce8e78ad191566bad287af18f12a1"}]}