)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"8f839574a10c6845884d6d1f03cfb6d9c63751ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e599bd36_2609e8e7","updated":"2022-03-09 13:47:50.000000000","message":"Looks like there are few logical changes and not just pep8 I advice either to put them in a different patchset or if they make sense together at minimal explain them in the commit message","commit_id":"6d8aec64306d0aefc17869808b669e7a1a5447f5"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"093cd0b6d1d7b073927d6fd11848f176bd66b381","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"162fba3a_7d8dbfd4","updated":"2022-03-29 15:23:44.000000000","message":"These changes need to be included in the previous patch:\n    https://review.opendev.org/c/openstack/cinder/+/831154\n","commit_id":"6d8aec64306d0aefc17869808b669e7a1a5447f5"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"6706b64cbe11e8c40b6ddd2113a5da1bf8cb395e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c8dec084_72438f75","in_reply_to":"85981845_e2e591e4","updated":"2022-03-09 14:05:21.000000000","message":"I Think you should advice with one of the cores, you can reach them in the IRC","commit_id":"6d8aec64306d0aefc17869808b669e7a1a5447f5"},{"author":{"_account_id":34588,"name":"DataCore Software","email":"cinder-ci@datacore.com","username":"Arun"},"change_message_id":"4b33e67308e4374977c803f285030d55a5921275","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cd863519_4a27ccea","in_reply_to":"c8dec084_72438f75","updated":"2022-03-09 14:12:07.000000000","message":"Sure, Thanks.","commit_id":"6d8aec64306d0aefc17869808b669e7a1a5447f5"},{"author":{"_account_id":34588,"name":"DataCore Software","email":"cinder-ci@datacore.com","username":"Arun"},"change_message_id":"b6364d9ec241728a8781aed53d19e7bcb2c6b67e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bb5f7b44_9c20a5ad","in_reply_to":"cd863519_4a27ccea","updated":"2022-03-10 11:11:18.000000000","message":"Ack","commit_id":"6d8aec64306d0aefc17869808b669e7a1a5447f5"},{"author":{"_account_id":34588,"name":"DataCore Software","email":"cinder-ci@datacore.com","username":"Arun"},"change_message_id":"09359432fb20636556b3683496208e3ad1864c45","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"85981845_e2e591e4","in_reply_to":"e599bd36_2609e8e7","updated":"2022-03-09 14:01:22.000000000","message":"Thank you Yuval,\n\nYes, these are not pep8 related changes. I was running tox and these bugs are found as part of the unit test. I missed it during review.\n\nCan I update the commit message or should I revert these changes?","commit_id":"6d8aec64306d0aefc17869808b669e7a1a5447f5"}],"cinder/volume/drivers/datacore/driver.py":[{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"8f839574a10c6845884d6d1f03cfb6d9c63751ab","unresolved":true,"context_lines":[{"line_number":612,"context_line":"            volume_virtual_disk \u003d self._await_virtual_disk_online("},{"line_number":613,"context_line":"                volume_virtual_disk.Id)"},{"line_number":614,"context_line":"            source_size \u003d src_obj[\u0027size\u0027]"},{"line_number":615,"context_line":"            if volume[\u0027size\u0027] \u003e source_size:"},{"line_number":616,"context_line":"                self._set_virtual_disk_size(volume_virtual_disk,"},{"line_number":617,"context_line":"                                            self._get_size_in_bytes("},{"line_number":618,"context_line":"                                                volume.size))"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff17b270_b24b1718","line":615,"updated":"2022-03-09 13:47:50.000000000","message":"this change is a pep8 fix? \nif not I suggest updating the commit msg or put it in the a different patchset","commit_id":"6d8aec64306d0aefc17869808b669e7a1a5447f5"},{"author":{"_account_id":34588,"name":"DataCore Software","email":"cinder-ci@datacore.com","username":"Arun"},"change_message_id":"b6364d9ec241728a8781aed53d19e7bcb2c6b67e","unresolved":false,"context_lines":[{"line_number":612,"context_line":"            volume_virtual_disk \u003d self._await_virtual_disk_online("},{"line_number":613,"context_line":"                volume_virtual_disk.Id)"},{"line_number":614,"context_line":"            source_size \u003d src_obj[\u0027size\u0027]"},{"line_number":615,"context_line":"            if volume[\u0027size\u0027] \u003e source_size:"},{"line_number":616,"context_line":"                self._set_virtual_disk_size(volume_virtual_disk,"},{"line_number":617,"context_line":"                                            self._get_size_in_bytes("},{"line_number":618,"context_line":"                                                volume.size))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9dc5ad59_e876f52b","line":615,"in_reply_to":"ff17b270_b24b1718","updated":"2022-03-10 11:11:18.000000000","message":"Done","commit_id":"6d8aec64306d0aefc17869808b669e7a1a5447f5"}],"cinder/volume/drivers/datacore/fc.py":[{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"8f839574a10c6845884d6d1f03cfb6d9c63751ab","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"\"\"\"Fibre Channel Driver for DataCore SANsymphony storage array.\"\"\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo_config import cfg"},{"line_number":18,"context_line":"from oslo_log import log as logging"},{"line_number":19,"context_line":"from oslo_utils import excutils"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a698ec6_09136190","line":17,"updated":"2022-03-09 13:47:50.000000000","message":"same here","commit_id":"6d8aec64306d0aefc17869808b669e7a1a5447f5"},{"author":{"_account_id":34588,"name":"DataCore Software","email":"cinder-ci@datacore.com","username":"Arun"},"change_message_id":"b6364d9ec241728a8781aed53d19e7bcb2c6b67e","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"\"\"\"Fibre Channel Driver for DataCore SANsymphony storage array.\"\"\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo_config import cfg"},{"line_number":18,"context_line":"from oslo_log import log as logging"},{"line_number":19,"context_line":"from oslo_utils import excutils"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"97dae3cd_211cba61","line":17,"in_reply_to":"9a698ec6_09136190","updated":"2022-03-10 11:11:18.000000000","message":"Done","commit_id":"6d8aec64306d0aefc17869808b669e7a1a5447f5"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"8f839574a10c6845884d6d1f03cfb6d9c63751ab","unresolved":true,"context_lines":[{"line_number":165,"context_line":"        return online_devices"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def _get_initiator(self, host, connector_wwpns, available_ports):"},{"line_number":168,"context_line":"        wwpn_list \u003d []"},{"line_number":169,"context_line":"        for wwp in connector_wwpns:"},{"line_number":170,"context_line":"            wwpn_list.append(\u0027-\u0027.join("},{"line_number":171,"context_line":"                a + b for a, b in zip(*[iter(wwp.upper())] * 2)))"}],"source_content_type":"text/x-python","patch_set":1,"id":"d83a5dc7_8f9549fe","line":168,"updated":"2022-03-09 13:47:50.000000000","message":"this doesnt looks like an pep8 change can you explain it?","commit_id":"6d8aec64306d0aefc17869808b669e7a1a5447f5"},{"author":{"_account_id":34588,"name":"DataCore Software","email":"cinder-ci@datacore.com","username":"Arun"},"change_message_id":"b6364d9ec241728a8781aed53d19e7bcb2c6b67e","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        return online_devices"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def _get_initiator(self, host, connector_wwpns, available_ports):"},{"line_number":168,"context_line":"        wwpn_list \u003d []"},{"line_number":169,"context_line":"        for wwp in connector_wwpns:"},{"line_number":170,"context_line":"            wwpn_list.append(\u0027-\u0027.join("},{"line_number":171,"context_line":"                a + b for a, b in zip(*[iter(wwp.upper())] * 2)))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9bdd5f7c_f91389a3","line":168,"in_reply_to":"d83a5dc7_8f9549fe","updated":"2022-03-10 11:11:18.000000000","message":"Done","commit_id":"6d8aec64306d0aefc17869808b669e7a1a5447f5"}],"cinder/volume/drivers/datacore/iscsi.py":[{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"8f839574a10c6845884d6d1f03cfb6d9c63751ab","unresolved":true,"context_lines":[{"line_number":336,"context_line":"                        lambda node: node.Name \u003d\u003d initiator.PortName,"},{"line_number":337,"context_line":"                        target_iscsi_nodes,"},{"line_number":338,"context_line":"                        None)"},{"line_number":339,"context_line":"                    if not iscsi_node or not \\"},{"line_number":340,"context_line":"                            iscsi_node.AccessToken.TargetUsername or \\"},{"line_number":341,"context_line":"                            update_access_token:"},{"line_number":342,"context_line":"                        self._api.set_access_token(target.Id, access_token)"}],"source_content_type":"text/x-python","patch_set":1,"id":"e1f2d622_70b2613e","line":339,"updated":"2022-03-09 13:47:50.000000000","message":"I think this change is unnecessary","commit_id":"6d8aec64306d0aefc17869808b669e7a1a5447f5"},{"author":{"_account_id":34588,"name":"DataCore Software","email":"cinder-ci@datacore.com","username":"Arun"},"change_message_id":"b6364d9ec241728a8781aed53d19e7bcb2c6b67e","unresolved":false,"context_lines":[{"line_number":336,"context_line":"                        lambda node: node.Name \u003d\u003d initiator.PortName,"},{"line_number":337,"context_line":"                        target_iscsi_nodes,"},{"line_number":338,"context_line":"                        None)"},{"line_number":339,"context_line":"                    if not iscsi_node or not \\"},{"line_number":340,"context_line":"                            iscsi_node.AccessToken.TargetUsername or \\"},{"line_number":341,"context_line":"                            update_access_token:"},{"line_number":342,"context_line":"                        self._api.set_access_token(target.Id, access_token)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9367ec20_5e07f417","line":339,"in_reply_to":"e1f2d622_70b2613e","updated":"2022-03-10 11:11:18.000000000","message":"Done","commit_id":"6d8aec64306d0aefc17869808b669e7a1a5447f5"}]}