)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f38bb6c994e578948a5e4a0365d2e16e5adba6b1","unresolved":false,"context_lines":[{"line_number":15,"context_line":"to set it when using functools.wraps.  The primary reason to"},{"line_number":16,"context_line":"set it is to cache the generated inspect.Signature object in a"},{"line_number":17,"context_line":"case where you\u0027re calling inspect.signature() multiple times on"},{"line_number":18,"context_line":"a function, which we don\u0027t currently do."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I47cbc373d985dde98bdb176f0ff0561783629f7d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"2af5acbd_62d273f7","line":18,"updated":"2022-03-10 16:00:37.000000000","message":"I\u0027m amazed I didn\u0027t add the \u0027functools.wraps\u0027 decorator *also* when I was doing it, since I\u0027m pretty sure I added these somewhere else for exactly this reason. This is of course the correct thing to do. Note that many decorators in nova already had this decorator and I still added the \u0027__signature__\u0027 line because it seemed necessary to allow me to compare e.g. the \u0027nova.db.api\u0027 and \u0027nova.db.sqlalchemy.api\u0027 functions, but I\u0027ve since realized that was only necessary because the local tooling I\u0027d written to do this inspect relied on \u0027inspect.getfullargspec\u0027 instead of \u0027inspect.signature\u0027. The former does not respect the \u0027__wrapped__\u0027 parameter [1] (nor does it offer any way to), while \u0027inspect.signature\u0027 [2] does by default.\n\nAll this is to say yes, this totally makes sense and we don\u0027t need the \u0027__signature__\u0027 line.\n\n[1] https://docs.python.org/3.8/library/inspect.html#inspect.getfullargspec\n[2] https://docs.python.org/3.5/library/inspect.html#inspect.signature","commit_id":"6240784ff68e59573d43e6a0848ad22d64b2f3ad"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"01edc6010eb543f2fa604ab379b2fbb7c3bd8d3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"be03afdd_3ca134a7","updated":"2022-03-16 14:11:59.000000000","message":"I am ok with this change.","commit_id":"6240784ff68e59573d43e6a0848ad22d64b2f3ad"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"9bf2c82195c3c3b52a8934a4b65dbb967f1cc199","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e4749a8b_2341db97","updated":"2022-03-12 14:44:20.000000000","message":"LGTM","commit_id":"6240784ff68e59573d43e6a0848ad22d64b2f3ad"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"73455829ff1fc1a3246180dc504d8122458bca6d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"26c898b2_9ec8aa92","updated":"2022-03-09 22:37:37.000000000","message":"recheck tempest-integrated-storage - problem connecting to an instance in a servers test","commit_id":"6240784ff68e59573d43e6a0848ad22d64b2f3ad"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"e30c534298d4e4088d72d476be718a5ff0d21a94","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d3d19c4d_cbc2addb","updated":"2022-07-12 19:49:11.000000000","message":"I suppose the actual changes were done in another change -- maybe the commit message should reflect that this is just a unit test change now?","commit_id":"ca10c3025b0249fc7e8660b56cd9f3e9e8012001"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"5d304d6ac9d094c1ea6906baefe8c184a64866a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9ae634a6_92469ced","updated":"2022-07-12 05:53:48.000000000","message":"this looks good","commit_id":"ca10c3025b0249fc7e8660b56cd9f3e9e8012001"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4c0fe06db8b9b63a4c67ce85db55a7876e251f41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f35f9c73_2c7b68e1","in_reply_to":"d3d19c4d_cbc2addb","updated":"2022-07-13 09:07:42.000000000","message":"Yeah, my guess is that this was lost with a rebase. I had a similar patch to address this.","commit_id":"ca10c3025b0249fc7e8660b56cd9f3e9e8012001"}],"cinder/tests/unit/db/test_sa_api.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f38bb6c994e578948a5e4a0365d2e16e5adba6b1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2022 Red Hat, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":3,"id":"cb96c71f_03bc8e92","line":1,"updated":"2022-03-10 16:00:37.000000000","message":"In nova we usually structure and name unit tests to map to the code they\u0027re testing, so this would be \u0027cinder/tests/unit/db/sqlalchemy/test_api.py\u0027. It seems that isn\u0027t the case in cinder but I\u0027m noting it here in case this was ever a goal","commit_id":"6240784ff68e59573d43e6a0848ad22d64b2f3ad"}]}