)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"89e1217fa27c26216657d2b990c398b7cb9efc01","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"35b55d85_b47fb543","updated":"2022-03-17 16:06:11.000000000","message":"This patch is missing the negative tests suggestion from the original patch\nhttps://review.opendev.org/c/openstack/cinder/+/830538/7..8/cinder/tests/unit/volume/drivers/lightos/test_lightos_storage.py","commit_id":"9a2eed08c2ed814d2a2a29ffa97d0c414f6f588e"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"fa0c7c16d474874a41e68cf29846ab1205c8870b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"82fcab23_1433abef","in_reply_to":"35b55d85_b47fb543","updated":"2022-03-20 15:22:57.000000000","message":"I written a negative test. but then I realize - if something is not True or False\nlike \"isTrue\" -\u003e the scheduler will not send the volume creation to the backend since the backend support only [\"True\", False\"]\nanyway I can add it, its not a problem","commit_id":"9a2eed08c2ed814d2a2a29ffa97d0c414f6f588e"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"109d092bb65cbe04379ca73c9e5114326afd1d75","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5057b8f8_85cf4298","in_reply_to":"82fcab23_1433abef","updated":"2022-05-01 10:28:59.000000000","message":"Ack","commit_id":"9a2eed08c2ed814d2a2a29ffa97d0c414f6f588e"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"bc47ffb0c420a683bcdebcabca1d6b185f7b6361","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6972c4c9_a95585e0","updated":"2025-10-31 16:00:04.000000000","message":"Considering the complexity of the extra_spec ops comparison, I think it\u0027s ok that they reuse that code.","commit_id":"7bb87fd753ea5ccea5f5f170b39c7e8842d3d462"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"e751c164c470d6dfc2ea72466b633156eda88d41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"355280ab_41e7f10c","updated":"2022-08-17 12:56:40.000000000","message":"run-Lightbits CI","commit_id":"7bb87fd753ea5ccea5f5f170b39c7e8842d3d462"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"e75c1166b41e49ec959ac55d9dfb191fcae30ec0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7e0d0f65_3bb4486c","updated":"2022-03-21 08:47:29.000000000","message":"run-Lightbits CI","commit_id":"7bb87fd753ea5ccea5f5f170b39c7e8842d3d462"}],"cinder/volume/drivers/lightos.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"89e1217fa27c26216657d2b990c398b7cb9efc01","unresolved":true,"context_lines":[{"line_number":35,"context_line":"from cinder import utils"},{"line_number":36,"context_line":"from cinder.volume import configuration as config"},{"line_number":37,"context_line":"from cinder.volume import driver"},{"line_number":38,"context_line":"from cinder.scheduler.filters import extra_specs_ops"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":1,"id":"05896fc9_722ef742","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":52},"updated":"2022-03-17 16:06:11.000000000","message":"Not sure how good of an idea it is to import scheduler functions (it\u0027s not even a utility one) but will take a deeper look later","commit_id":"9a2eed08c2ed814d2a2a29ffa97d0c414f6f588e"}]}
