)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"c00fb8fb0be16a590901f46fa4ae0c1ff158c8ea","unresolved":true,"context_lines":[{"line_number":7,"context_line":"add netapp copyoffload provider location"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"By volume creation the volume database entry is created with the field provider_location \u003d null."},{"line_number":10,"context_line":"When cinder tries to register a image-cache from the new volume it gets the volume information"},{"line_number":11,"context_line":"from the database and can not derive the mountpoint for \"None\"."},{"line_number":12,"context_line":"This fix will set the provider location to prevent the error mentioned in the issue."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bd9ec2bb_a2296893","line":10,"updated":"2022-06-17 14:23:16.000000000","message":"nit: an image-cache","commit_id":"56e3a3783b4fb12a882ada9afc10cbd3edd01e8c"},{"author":{"_account_id":31307,"name":"Friedrich Hiekel","email":"friedrich.hiekel@cloudandheat.com","username":"fhiekel"},"change_message_id":"dd3a93dc54deb680d7152b2ce1770d35266ea897","unresolved":false,"context_lines":[{"line_number":7,"context_line":"add netapp copyoffload provider location"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"By volume creation the volume database entry is created with the field provider_location \u003d null."},{"line_number":10,"context_line":"When cinder tries to register a image-cache from the new volume it gets the volume information"},{"line_number":11,"context_line":"from the database and can not derive the mountpoint for \"None\"."},{"line_number":12,"context_line":"This fix will set the provider location to prevent the error mentioned in the issue."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"f9b6f072_d493e5a8","line":10,"in_reply_to":"bd9ec2bb_a2296893","updated":"2022-07-05 06:43:52.000000000","message":"fixed it","commit_id":"56e3a3783b4fb12a882ada9afc10cbd3edd01e8c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7919a32fe1d0e50049a2501585f211c31c245ad2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0b5ffad6_42906672","updated":"2022-04-29 15:51:41.000000000","message":"Coding nit noted inline.  The -1 is for a release note (since you want to backport this to queens, it should really have a release note).  It can be very short, but it should be included.  Info about release notes is here:  https://docs.openstack.org/cinder/latest/contributor/releasenotes.html\n\nThanks!","commit_id":"6f224f5be8a5f17f3ea355ecb72808828eea94f9"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"c95fddcd282933037165e35c02e67d1de064dd5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a63bf291_f3fba2fb","updated":"2022-03-25 11:16:13.000000000","message":"run-HPE Storage CI\n","commit_id":"6f224f5be8a5f17f3ea355ecb72808828eea94f9"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"47fce6cc68af1ef66e82115a06723d503108a4e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c15ab9b3_1b0240d2","updated":"2022-06-17 14:58:37.000000000","message":"Hello! Fix looks good to me. \n\nJust a note - this Copy Offload tool will be deprecated in the future - https://blueprints.launchpad.net/cinder/+spec/netapp-nfs-copy-offload-image ","commit_id":"56e3a3783b4fb12a882ada9afc10cbd3edd01e8c"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"247ed42ae7d10a9581fc72fdef33f465c47681f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"00c6e45e_1362ba3a","updated":"2022-06-17 15:11:13.000000000","message":"Instead of having the release note in a separate review, could you please include it in this patch?  It\u0027s better to have all the related files all together in one patch when possible.","commit_id":"56e3a3783b4fb12a882ada9afc10cbd3edd01e8c"},{"author":{"_account_id":31307,"name":"Friedrich Hiekel","email":"friedrich.hiekel@cloudandheat.com","username":"fhiekel"},"change_message_id":"bb3f1c38759a2f34f0f5609017114fff5a804afc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a7429b64_d275381d","updated":"2022-06-17 06:32:44.000000000","message":"recheck","commit_id":"56e3a3783b4fb12a882ada9afc10cbd3edd01e8c"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"df13baf5acd6a59d3467af723e88104b80e7b0d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"36256ac1_6d9cede4","updated":"2022-07-28 12:16:11.000000000","message":"LGTM","commit_id":"9196cd157db6d47c3e74cbd1e394d576c0657687"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"745b29b7ab42d2081b8e50a0df6c00b25b334fb3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"cb4eb136_98cdc5df","updated":"2022-07-07 13:08:15.000000000","message":"Thanks for the Fix! Just found another flow that has the same problem (at least, I think). Please, check it.","commit_id":"9196cd157db6d47c3e74cbd1e394d576c0657687"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"ac574ce85f9046233d5b593800ade2e8bc91e58b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"96dc3c1d_375c6631","updated":"2022-07-05 14:08:29.000000000","message":"looks good to me.","commit_id":"9196cd157db6d47c3e74cbd1e394d576c0657687"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f778dae109edddf84459a3dd2408222bf24b40f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"005aaa1c_28dd4f84","updated":"2022-09-16 17:13:36.000000000","message":"I believe the copyoffload tool is being removed, but might as well have it work correctly while it\u0027s still in use.","commit_id":"f9c926fe407ebf3fc8c97e6f02b45c4d32e8c493"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"a9093c0828448ee2a3ab525659ecb589ce3e154e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"4907d250_2ccb1839","updated":"2023-01-20 15:53:09.000000000","message":"Small change, look good to me","commit_id":"f9c926fe407ebf3fc8c97e6f02b45c4d32e8c493"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"927f3a5637f4ed97057d801c4a77295789d35c3c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"256f8163_3d686c08","updated":"2022-12-16 14:58:21.000000000","message":"looks good","commit_id":"f9c926fe407ebf3fc8c97e6f02b45c4d32e8c493"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"a462f42eb0a74b6f1c52740d8c26271d65f2cf56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"45aa68c0_54becbcf","updated":"2022-08-10 03:58:11.000000000","message":"looks good","commit_id":"f9c926fe407ebf3fc8c97e6f02b45c4d32e8c493"},{"author":{"_account_id":31307,"name":"Friedrich Hiekel","email":"friedrich.hiekel@cloudandheat.com","username":"fhiekel"},"change_message_id":"71ddcf50651facdd4d082b76033677d2aba17065","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8124a0d2_7d92ca85","in_reply_to":"005aaa1c_28dd4f84","updated":"2022-09-28 09:19:12.000000000","message":"thanks for the update. I am not familiar with the procress, what else needs to be done to merge this?","commit_id":"f9c926fe407ebf3fc8c97e6f02b45c4d32e8c493"}],"cinder/volume/drivers/netapp/dataontap/nfs_cmode.py":[{"author":{"_account_id":31307,"name":"Friedrich Hiekel","email":"friedrich.hiekel@cloudandheat.com","username":"fhiekel"},"change_message_id":"ab1fe70392bed2c38e21a5c3e7b6ad989e72f781","unresolved":false,"context_lines":[{"line_number":639,"context_line":"            elif (cache_copy and"},{"line_number":640,"context_line":"                  self.configuration.netapp_copyoffload_tool_path):"},{"line_number":641,"context_line":"                volume[\u0027provider_location\u0027] \u003d volume_utils.extract_host("},{"line_number":642,"context_line":"                                                volume[\u0027host\u0027], level\u003d\u0027pool\u0027)"},{"line_number":643,"context_line":"                LOG.debug(\"Trying copy from cache using copy offload.\")"},{"line_number":644,"context_line":"                self._copy_from_remote_cache(volume, image_id, cache_copy)"},{"line_number":645,"context_line":"                copied \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"601736fa_ca2555e9","line":642,"in_reply_to":"f2634056_49894659","updated":"2022-06-17 05:07:25.000000000","message":"\u003e pep8: E126 continuation line over-indented for hanging indent\n\nPlease fix.","commit_id":"4a07fcd3881fb7c164dd1c5c57bb1a96bb7360a0"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7919a32fe1d0e50049a2501585f211c31c245ad2","unresolved":true,"context_lines":[{"line_number":639,"context_line":"            elif (cache_copy and"},{"line_number":640,"context_line":"                  self.configuration.netapp_copyoffload_tool_path):"},{"line_number":641,"context_line":"                volume[\u0027provider_location\u0027] \u003d \\"},{"line_number":642,"context_line":"                    volume_utils.extract_host(volume[\u0027host\u0027], level\u003d\u0027pool\u0027)"},{"line_number":643,"context_line":"                LOG.debug(\"Trying copy from cache using copy offload.\")"},{"line_number":644,"context_line":"                self._copy_from_remote_cache(volume, image_id, cache_copy)"},{"line_number":645,"context_line":"                copied \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"901df0c3_fad55720","line":642,"updated":"2022-04-29 15:51:41.000000000","message":"nit: we try to avoid using backslash continuation, maybe format it like this:\n\n                volume[\u0027provider_location\u0027] \u003d volume_utils.extract_host(\n                    volume[\u0027host\u0027], level\u003d\u0027pool\u0027)","commit_id":"6f224f5be8a5f17f3ea355ecb72808828eea94f9"},{"author":{"_account_id":31307,"name":"Friedrich Hiekel","email":"friedrich.hiekel@cloudandheat.com","username":"fhiekel"},"change_message_id":"ab1fe70392bed2c38e21a5c3e7b6ad989e72f781","unresolved":false,"context_lines":[{"line_number":639,"context_line":"            elif (cache_copy and"},{"line_number":640,"context_line":"                  self.configuration.netapp_copyoffload_tool_path):"},{"line_number":641,"context_line":"                volume[\u0027provider_location\u0027] \u003d \\"},{"line_number":642,"context_line":"                    volume_utils.extract_host(volume[\u0027host\u0027], level\u003d\u0027pool\u0027)"},{"line_number":643,"context_line":"                LOG.debug(\"Trying copy from cache using copy offload.\")"},{"line_number":644,"context_line":"                self._copy_from_remote_cache(volume, image_id, cache_copy)"},{"line_number":645,"context_line":"                copied \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"0eb696b2_13e88378","line":642,"in_reply_to":"901df0c3_fad55720","updated":"2022-06-17 05:07:25.000000000","message":"I adjusted it","commit_id":"6f224f5be8a5f17f3ea355ecb72808828eea94f9"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"745b29b7ab42d2081b8e50a0df6c00b25b334fb3","unresolved":true,"context_lines":[{"line_number":639,"context_line":"                copied \u003d True"},{"line_number":640,"context_line":"            elif (cache_copy and"},{"line_number":641,"context_line":"                  self.configuration.netapp_copyoffload_tool_path):"},{"line_number":642,"context_line":"                volume[\u0027provider_location\u0027] \u003d volume_utils.extract_host("},{"line_number":643,"context_line":"                    volume[\u0027host\u0027], level\u003d\u0027pool\u0027)"},{"line_number":644,"context_line":"                LOG.debug(\"Trying copy from cache using copy offload.\")"},{"line_number":645,"context_line":"                self._copy_from_remote_cache(volume, image_id, cache_copy)"},{"line_number":646,"context_line":"                copied \u003d True"}],"source_content_type":"text/x-python","patch_set":6,"id":"7cc5205e_f75e64ac","line":643,"range":{"start_line":642,"start_character":16,"end_line":643,"end_character":49},"updated":"2022-07-07 13:08:15.000000000","message":"Good catch, please, could you fix it for the flow that call the method `_register_image_in_cache` passing the Cinder volume ?\n\nOn the method `_direct_nfs_clone` of `client_base.py`, it can end up calling the `_register_image_in_cache` (line #766) passing the volume, which could raise the same bug. Am I right ?!","commit_id":"9196cd157db6d47c3e74cbd1e394d576c0657687"},{"author":{"_account_id":31307,"name":"Friedrich Hiekel","email":"friedrich.hiekel@cloudandheat.com","username":"fhiekel"},"change_message_id":"731a58008b3242196a59722e8dee2b074858b93b","unresolved":true,"context_lines":[{"line_number":639,"context_line":"                copied \u003d True"},{"line_number":640,"context_line":"            elif (cache_copy and"},{"line_number":641,"context_line":"                  self.configuration.netapp_copyoffload_tool_path):"},{"line_number":642,"context_line":"                volume[\u0027provider_location\u0027] \u003d volume_utils.extract_host("},{"line_number":643,"context_line":"                    volume[\u0027host\u0027], level\u003d\u0027pool\u0027)"},{"line_number":644,"context_line":"                LOG.debug(\"Trying copy from cache using copy offload.\")"},{"line_number":645,"context_line":"                self._copy_from_remote_cache(volume, image_id, cache_copy)"},{"line_number":646,"context_line":"                copied \u003d True"}],"source_content_type":"text/x-python","patch_set":6,"id":"d1e62d74_ffa8c55a","line":643,"range":{"start_line":642,"start_character":16,"end_line":643,"end_character":49},"in_reply_to":"7cc5205e_f75e64ac","updated":"2022-07-15 11:46:12.000000000","message":"I have not face the problem there, because this is only the case when it tries to copy the image from cache. When it does a direct clone the provider was set already","commit_id":"9196cd157db6d47c3e74cbd1e394d576c0657687"},{"author":{"_account_id":31307,"name":"Friedrich Hiekel","email":"friedrich.hiekel@cloudandheat.com","username":"fhiekel"},"change_message_id":"8a1b41dd072b1f4845dc0f62e2aaac131dcd76ce","unresolved":false,"context_lines":[{"line_number":639,"context_line":"                copied \u003d True"},{"line_number":640,"context_line":"            elif (cache_copy and"},{"line_number":641,"context_line":"                  self.configuration.netapp_copyoffload_tool_path):"},{"line_number":642,"context_line":"                volume[\u0027provider_location\u0027] \u003d volume_utils.extract_host("},{"line_number":643,"context_line":"                    volume[\u0027host\u0027], level\u003d\u0027pool\u0027)"},{"line_number":644,"context_line":"                LOG.debug(\"Trying copy from cache using copy offload.\")"},{"line_number":645,"context_line":"                self._copy_from_remote_cache(volume, image_id, cache_copy)"},{"line_number":646,"context_line":"                copied \u003d True"}],"source_content_type":"text/x-python","patch_set":6,"id":"5191e72c_9c842af4","line":643,"range":{"start_line":642,"start_character":16,"end_line":643,"end_character":49},"in_reply_to":"d1e62d74_ffa8c55a","updated":"2022-07-18 05:16:44.000000000","message":"Done","commit_id":"9196cd157db6d47c3e74cbd1e394d576c0657687"}]}