)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ac616b06b34b9e6e1198125d60b2b3e1ed3e66b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"995bed31_0d53850e","updated":"2022-04-29 17:50:33.000000000","message":"Thanks, Gorka.  This is a helpful patch.","commit_id":"6474afc3dacf726c96dcc98810b2fcc0ec7831e3"}],"cinder/volume/manager.py":[{"author":{"_account_id":26693,"name":"do3meli","email":"info@dominicschlegel.ch","username":"do3meli"},"change_message_id":"22dbeffe9ed557ca6eb44e24baa49c4114273393","unresolved":true,"context_lines":[{"line_number":4958,"context_line":"        except Exception as exc:"},{"line_number":4959,"context_line":"            # Failures on detach_volume and remove_export are not considered"},{"line_number":4960,"context_line":"            # failures in terms of detaching the volume."},{"line_number":4961,"context_line":"            LOG.warning(\u0027Failed to detach volume on the backend, ignoring \u0027"},{"line_number":4962,"context_line":"                        \u0027failure %s\u0027, exc)"},{"line_number":4963,"context_line":""},{"line_number":4964,"context_line":"    # Replication group API (Tiramisu)"}],"source_content_type":"text/x-python","patch_set":1,"id":"b6d62e3a_622d4703","line":4961,"range":{"start_line":4961,"start_character":65,"end_line":4961,"end_character":73},"updated":"2022-04-01 07:18:35.000000000","message":"it might be good to quickly elaborate in the log message why ignoring this error is \"ok\". could be confusing to operators/admins otherwise.","commit_id":"6474afc3dacf726c96dcc98810b2fcc0ec7831e3"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ac616b06b34b9e6e1198125d60b2b3e1ed3e66b9","unresolved":true,"context_lines":[{"line_number":4958,"context_line":"        except Exception as exc:"},{"line_number":4959,"context_line":"            # Failures on detach_volume and remove_export are not considered"},{"line_number":4960,"context_line":"            # failures in terms of detaching the volume."},{"line_number":4961,"context_line":"            LOG.warning(\u0027Failed to detach volume on the backend, ignoring \u0027"},{"line_number":4962,"context_line":"                        \u0027failure %s\u0027, exc)"},{"line_number":4963,"context_line":""},{"line_number":4964,"context_line":"    # Replication group API (Tiramisu)"}],"source_content_type":"text/x-python","patch_set":1,"id":"67aeb4ee_76d747e1","line":4961,"range":{"start_line":4961,"start_character":65,"end_line":4961,"end_character":73},"in_reply_to":"7e4067d0_51184e9d","updated":"2022-04-29 17:50:33.000000000","message":"Let\u0027s go ahead and merge this because it will improve operator experience, and if someone can devise a better message, it can be done as a follow up.","commit_id":"6474afc3dacf726c96dcc98810b2fcc0ec7831e3"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"6408d11073aa2c1c1ff7427323ee5ad866834733","unresolved":true,"context_lines":[{"line_number":4958,"context_line":"        except Exception as exc:"},{"line_number":4959,"context_line":"            # Failures on detach_volume and remove_export are not considered"},{"line_number":4960,"context_line":"            # failures in terms of detaching the volume."},{"line_number":4961,"context_line":"            LOG.warning(\u0027Failed to detach volume on the backend, ignoring \u0027"},{"line_number":4962,"context_line":"                        \u0027failure %s\u0027, exc)"},{"line_number":4963,"context_line":""},{"line_number":4964,"context_line":"    # Replication group API (Tiramisu)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7e4067d0_51184e9d","line":4961,"range":{"start_line":4961,"start_character":65,"end_line":4961,"end_character":73},"in_reply_to":"b6d62e3a_622d4703","updated":"2022-04-05 11:47:45.000000000","message":"Makes sense, the problem I find is how to explanation it in a way that doesn\u0027t raise even more questions, because I\u0027m not 100% sold on the idea that not removing an export is reasonable...\n\nMy intent with the patch was to at least leave a log entry with the exception.\n\nDo you have any suggestion on a message that would be helpful?","commit_id":"6474afc3dacf726c96dcc98810b2fcc0ec7831e3"}]}