)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"54ecac248c66b53a0622e9fc80221491f07c1d8b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"fb72c2f4_5c226799","updated":"2023-02-21 09:49:25.000000000","message":"Forgot to mention, thanks for the detailed testing of all possible cases!","commit_id":"8e7ead7c2730231e42adb58322ea0bb49b9a1617"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"cadbda913ad52cbd9004698352e47a5ac760be43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"6e911765_bb0945d5","updated":"2023-02-21 09:38:57.000000000","message":"One comment inline but overall looks good. we are supporting code paths for shared vs non-shared in the nvme target driver.","commit_id":"8e7ead7c2730231e42adb58322ea0bb49b9a1617"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"09ac9217a8461f52ddeab1cbbb9ecec79f0f65d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"755940cd_c06d1cb7","updated":"2023-02-22 22:35:52.000000000","message":"Passing the check and written by a core team member.  Approved by the PTL who gave an FFE.  I found one typo in the code, but I don\u0027t think the code needs to be held up as a result of that.  A future fix could be proposed.","commit_id":"8e7ead7c2730231e42adb58322ea0bb49b9a1617"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"cd4b67a3c9773256fc935ebf105de3e924a40cda","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"af7f2452_d19bfc9a","updated":"2023-02-16 15:45:27.000000000","message":"recheck - cinder-tempest-plugin-lvm-lio-barbican seems unrelated since it\u0027s about a backup not being incremental","commit_id":"8e7ead7c2730231e42adb58322ea0bb49b9a1617"}],"cinder/privsep/targets/nvmet.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"2241939e0aa9acb6a572435b9584c0bacb14164e","unresolved":true,"context_lines":[{"line_number":176,"context_line":"        super().__init__(subsystem\u003dsubsystem, nsid\u003dnsid, mode\u003dmode)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    @classmethod"},{"line_number":179,"context_line":"    def setup(cls, subsys, n):"},{"line_number":180,"context_line":"        privsep_setup(cls.__name__, serialize(subsys), n)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def delete(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ca9a744d_bcdc00a6","line":179,"updated":"2022-10-05 05:16:56.000000000","message":"Just FYI, nvmet.Namespace.setup() has a different signature on my laptop:\n\n    @classmethod\n    def setup(cls, subsys, n, err_func):\n\nnvmetcli-0.7-5.fc36.noarch","commit_id":"7206af0975861b14f5a628f840046f19ebe59daa"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"379f7ca91d06adc35910e3b96a235790258b6e81","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        super().__init__(subsystem\u003dsubsystem, nsid\u003dnsid, mode\u003dmode)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    @classmethod"},{"line_number":179,"context_line":"    def setup(cls, subsys, n):"},{"line_number":180,"context_line":"        privsep_setup(cls.__name__, serialize(subsys), n)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def delete(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"19ddc957_0247c483","line":179,"in_reply_to":"1881a871_e6ea1aab","updated":"2023-01-27 12:44:24.000000000","message":"I have fixed it in the last patch and I have also created a new patch to fix it in the other setup methods  https://review.opendev.org/c/openstack/cinder/+/872013","commit_id":"7206af0975861b14f5a628f840046f19ebe59daa"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"dca653a8f3a660c3536f2412ace42f8ee34eaa77","unresolved":true,"context_lines":[{"line_number":176,"context_line":"        super().__init__(subsystem\u003dsubsystem, nsid\u003dnsid, mode\u003dmode)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    @classmethod"},{"line_number":179,"context_line":"    def setup(cls, subsys, n):"},{"line_number":180,"context_line":"        privsep_setup(cls.__name__, serialize(subsys), n)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def delete(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1881a871_e6ea1aab","line":179,"in_reply_to":"ca9a744d_bcdc00a6","updated":"2023-01-26 18:42:50.000000000","message":"Thanks!!   I\u0027ll fix it","commit_id":"7206af0975861b14f5a628f840046f19ebe59daa"}],"cinder/volume/targets/nvmeof.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"cadbda913ad52cbd9004698352e47a5ac760be43","unresolved":true,"context_lines":[{"line_number":103,"context_line":"            location.split(\u0027 \u0027))"},{"line_number":104,"context_line":"        target_portal, target_port \u003d target_connection.split(\u0027:\u0027)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        uuid \u003d self._get_nvme_uuid(volume)"},{"line_number":107,"context_line":"        return self._get_connection_properties(nqn, target_portal, target_port,"},{"line_number":108,"context_line":"                                               nvme_transport_type,"},{"line_number":109,"context_line":"                                               nvmet_ns_id, uuid)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a0252d7_50927139","line":106,"range":{"start_line":106,"start_character":8,"end_line":106,"end_character":42},"updated":"2023-02-21 09:38:57.000000000","message":"I don\u0027t understand the change here. We are moving this from the case,\nif self.configuration.nvmeof_conn_info_version \u003d\u003d 2\nbut we won\u0027t be sending this information in Connection Information Version 1 format so not sure why we\u0027re fetching this outside of v2 case.\n\nApart from this we are just refactoring code from the _get_connection_properties to this method. Am i missing something?","commit_id":"8e7ead7c2730231e42adb58322ea0bb49b9a1617"}],"cinder/volume/targets/nvmet.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"09ac9217a8461f52ddeab1cbbb9ecec79f0f65d6","unresolved":true,"context_lines":[{"line_number":135,"context_line":"            LOG.debug(\u0027Sharing subsystem, using nguid \u003d uuid \u003d %s\u0027, nguid)"},{"line_number":136,"context_line":"        else:"},{"line_number":137,"context_line":"            nguid \u003d str(uuidutils.generate_uuid())"},{"line_number":138,"context_line":"            LOG.debug(\u0027Not sharing subsystem, using randmo nguid \u003d %s\u0027, nguid)"},{"line_number":139,"context_line":"        return {"},{"line_number":140,"context_line":"            \"device\": {"},{"line_number":141,"context_line":"                \"nguid\": nguid,"}],"source_content_type":"text/x-python","patch_set":10,"id":"30f52e34_f00efa1e","line":138,"range":{"start_line":138,"start_character":52,"end_line":138,"end_character":58},"updated":"2023-02-22 22:35:52.000000000","message":"Think this was meant to be random?","commit_id":"8e7ead7c2730231e42adb58322ea0bb49b9a1617"}]}