)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"80ebeeee9d00c0c531089889a25f02b9d635da21","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch fixes a few issues with correctly updating the"},{"line_number":10,"context_line":"driver stats allocated_capacity_gb setting so the scheduler"},{"line_number":11,"context_line":"has acurate data."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch updates the volume manager\u0027s _update_allocated_capacity()"},{"line_number":14,"context_line":"to be more generic so that all methods in the volume manager can use it"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"93e8d848_324b6a19","line":11,"range":{"start_line":11,"start_character":4,"end_line":11,"end_character":11},"updated":"2022-04-11 09:50:08.000000000","message":"accurate","commit_id":"8c223a357793456674fca376609325d2cf677acb"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"02521626ba53c8d6d87aff28ffd40d1da00e79b5","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch fixes a few issues with correctly updating the"},{"line_number":10,"context_line":"driver stats allocated_capacity_gb setting so the scheduler"},{"line_number":11,"context_line":"has acurate data."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch updates the volume manager\u0027s _update_allocated_capacity()"},{"line_number":14,"context_line":"to be more generic so that all methods in the volume manager can use it"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"b7cf5355_3266c25d","line":11,"range":{"start_line":11,"start_character":4,"end_line":11,"end_character":11},"in_reply_to":"93e8d848_324b6a19","updated":"2022-04-11 12:13:28.000000000","message":"Done","commit_id":"8c223a357793456674fca376609325d2cf677acb"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"80ebeeee9d00c0c531089889a25f02b9d635da21","unresolved":true,"context_lines":[{"line_number":15,"context_line":"to correctly update the driver stats allocated_capacity_gb for pools"},{"line_number":16,"context_line":"as well as non-pools."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This patch fixes the folling areas"},{"line_number":19,"context_line":"migrate_volume"},{"line_number":20,"context_line":"delete_group"},{"line_number":21,"context_line":"extend_volume"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9abf9c39_a2f23429","line":18,"range":{"start_line":18,"start_character":21,"end_line":18,"end_character":28},"updated":"2022-04-11 09:50:08.000000000","message":"following","commit_id":"8c223a357793456674fca376609325d2cf677acb"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"6634c06ec1b8f769bcf1eb5d2e3283b7e9bc0b5a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"to correctly update the driver stats allocated_capacity_gb for pools"},{"line_number":16,"context_line":"as well as non-pools."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This patch fixes the folling areas"},{"line_number":19,"context_line":"migrate_volume"},{"line_number":20,"context_line":"delete_group"},{"line_number":21,"context_line":"extend_volume"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1addd61f_8224c699","line":18,"range":{"start_line":18,"start_character":21,"end_line":18,"end_character":28},"in_reply_to":"9abf9c39_a2f23429","updated":"2022-04-11 22:26:41.000000000","message":"Done","commit_id":"8c223a357793456674fca376609325d2cf677acb"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"e6f9014f4b02f98278b8abed6b860a9b4a49ba7e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3ba4c4fa_3b4751bb","updated":"2022-04-11 12:12:29.000000000","message":"Please be more aware of your review and the read the code thoroughly when giving a -1.  ","commit_id":"8c223a357793456674fca376609325d2cf677acb"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"6827b6fa8fdfcb95c24892da9d768648454c9721","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"71eb317b_177e643f","in_reply_to":"3ba4c4fa_3b4751bb","updated":"2022-04-11 13:00:26.000000000","message":"Sure, but i am aware of  the \u0027size\u0027 parameter in  _update_allocated_capacity at L409 and L422.\n\nWhat i meant was the parameter not explicitly used in calls you made to the method.(i know it is an optional parameter but as you introduced it, i am just trying to understand the scenario in which it will be useful)\n\nsorry for -1, you can consider it for commit message typos (which you fixed already)\n\nThanks!","commit_id":"8c223a357793456674fca376609325d2cf677acb"},{"author":{"_account_id":33543,"name":"liuhuajie","email":"liu.huajie@99cloud.net","username":"liuhuajie"},"change_message_id":"86134ad3482e3281400af53a5a08b82e7e8fc591","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"3eca11e5_89f9d396","updated":"2022-06-09 02:46:47.000000000","message":"LGTM","commit_id":"a2a78281beb128dfa391a5017439ab054ec8d5bb"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"44a8335643124c21b5f6562d5f6a51bd9424848a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"e3f0196a_6e1f557f","updated":"2022-06-16 10:18:40.000000000","message":"LGTM","commit_id":"0a7cd4b3110d4ad9a82ec0a9b94ccf8c28711887"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"c8abff8fe72bc722d5b57d691a9802a1455983c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"14c9b7dd_ad992a2f","updated":"2022-06-16 09:51:21.000000000","message":"run-storpoolci","commit_id":"0a7cd4b3110d4ad9a82ec0a9b94ccf8c28711887"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9c67d2942d8189c1a8aed00cecf21e4565adf88f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"7109ef25_d16320ab","updated":"2022-09-29 13:02:11.000000000","message":"I hate to say it (because the patch has been sitting for a while), but I agree with Rajat about getting this into RC-2.  It\u0027s a small patch, but it touches a lot of stuff.  I think it would be better to aim for early Antelope.","commit_id":"c7b7363beddcfcba5a0e7fbf8af70e1d07e535b0"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"62ecb81342d543aaa88edbabe10fcd02392f1438","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"b42f0793_952f71e4","updated":"2022-09-29 09:23:58.000000000","message":"This should include a releasenote.\n\nAlso I\u0027m quite hesitant to merge a change this close to release which changes core cinder functionality, adds a new RPC version and a new call in the migration flow. Would it be good if we merge it early next cycle and backport to zed to inlcude it in the next stable/zed release?","commit_id":"c7b7363beddcfcba5a0e7fbf8af70e1d07e535b0"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"2d89a6ce20a77691a8a2250c0f39e223e50e6909","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"75b07fc5_49d30b61","updated":"2022-09-21 14:08:46.000000000","message":"recheck","commit_id":"c7b7363beddcfcba5a0e7fbf8af70e1d07e535b0"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"84bf5bd58427e7b1e7d72b580bb597b85244fa60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"0d8bc49a_16f217c7","updated":"2022-09-26 05:01:10.000000000","message":"recheck tempest-integrated-storage failed","commit_id":"c7b7363beddcfcba5a0e7fbf8af70e1d07e535b0"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c962494356895fadaa98b1d4b79863feba2a53fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"794a6a17_440367a2","in_reply_to":"7109ef25_d16320ab","updated":"2022-09-29 14:15:27.000000000","message":"I\u0027ve added this as a topic for PTG[1] where we can live review this code. Walt can walk us through it and all doubts regarding it can be cleared so it will be merged early in the cycle.\n\n[1] https://etherpad.opendev.org/p/antelope-ptg-cinder-planning","commit_id":"c7b7363beddcfcba5a0e7fbf8af70e1d07e535b0"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"ee497a26115ccc0949ada0e7224a5ab39768a1ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"35664537_b51a4ab4","updated":"2025-07-08 19:39:49.000000000","message":"A unit test wouldn\u0027t hurt, but the previous code didn\u0027t have one either.  I\u0027m not sure the min_rpc_version decorate is necessary.","commit_id":"0e39b35c9444e04ba93e917e1ded47b02090440a"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"55ab732c127eae72b721e6aab4daf8b7382c5237","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"13c22512_e514735b","updated":"2025-07-02 14:32:33.000000000","message":"recheck","commit_id":"0e39b35c9444e04ba93e917e1ded47b02090440a"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"de530bdb9a94ed976d896ca2411e7fad56587fbc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"d372ba99_7f464113","updated":"2025-07-02 21:29:34.000000000","message":"recheck","commit_id":"0e39b35c9444e04ba93e917e1ded47b02090440a"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"246e0182edbf583641b90b3ff2eb202d050189d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"94229891_4e98c650","updated":"2025-07-16 14:06:59.000000000","message":"recheck","commit_id":"96edc326c97da0a5fbd474199587d9c65f8df3a4"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"24717153c9546881fc47f96675c3fd07eb283139","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"6e0319bf_84c6c7f5","updated":"2025-12-12 21:48:41.000000000","message":"Didn\u0027t you fix this like 5 years ago? :D","commit_id":"e426f2790ea6be954b5b910e5fa785f978f0e1a7"}],"cinder/volume/manager.py":[{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"80ebeeee9d00c0c531089889a25f02b9d635da21","unresolved":true,"context_lines":[{"line_number":406,"context_line":"                                   vol: objects.Volume,"},{"line_number":407,"context_line":"                                   decrement: bool \u003d False,"},{"line_number":408,"context_line":"                                   host: Optional[str] \u003d None,"},{"line_number":409,"context_line":"                                   size: int \u003d None) -\u003e None:"},{"line_number":410,"context_line":"        # Update allocated capacity in volume stats"},{"line_number":411,"context_line":"        host \u003d host or vol[\u0027host\u0027]"},{"line_number":412,"context_line":"        pool \u003d volume_utils.extract_host(host, \u0027pool\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"d09bfd72_cf5e075a","line":409,"range":{"start_line":409,"start_character":35,"end_line":409,"end_character":39},"updated":"2022-04-11 09:50:08.000000000","message":"iiuc , this optional parameter \u0027size\u0027 is introduced for future, it is not used in the below change.\nDoes it help in using explicit size instead of vol[size]?","commit_id":"8c223a357793456674fca376609325d2cf677acb"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"02521626ba53c8d6d87aff28ffd40d1da00e79b5","unresolved":false,"context_lines":[{"line_number":406,"context_line":"                                   vol: objects.Volume,"},{"line_number":407,"context_line":"                                   decrement: bool \u003d False,"},{"line_number":408,"context_line":"                                   host: Optional[str] \u003d None,"},{"line_number":409,"context_line":"                                   size: int \u003d None) -\u003e None:"},{"line_number":410,"context_line":"        # Update allocated capacity in volume stats"},{"line_number":411,"context_line":"        host \u003d host or vol[\u0027host\u0027]"},{"line_number":412,"context_line":"        pool \u003d volume_utils.extract_host(host, \u0027pool\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"0d6abe0d_23ce3f3b","line":409,"range":{"start_line":409,"start_character":35,"end_line":409,"end_character":39},"in_reply_to":"8755eb9c_9f79cbaa","updated":"2022-04-11 12:13:28.000000000","message":"Done","commit_id":"8c223a357793456674fca376609325d2cf677acb"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"e6f9014f4b02f98278b8abed6b860a9b4a49ba7e","unresolved":true,"context_lines":[{"line_number":406,"context_line":"                                   vol: objects.Volume,"},{"line_number":407,"context_line":"                                   decrement: bool \u003d False,"},{"line_number":408,"context_line":"                                   host: Optional[str] \u003d None,"},{"line_number":409,"context_line":"                                   size: int \u003d None) -\u003e None:"},{"line_number":410,"context_line":"        # Update allocated capacity in volume stats"},{"line_number":411,"context_line":"        host \u003d host or vol[\u0027host\u0027]"},{"line_number":412,"context_line":"        pool \u003d volume_utils.extract_host(host, \u0027pool\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"8755eb9c_9f79cbaa","line":409,"range":{"start_line":409,"start_character":35,"end_line":409,"end_character":39},"in_reply_to":"d09bfd72_cf5e075a","updated":"2022-04-11 12:12:29.000000000","message":"It is being used below.  Look at line 422.","commit_id":"8c223a357793456674fca376609325d2cf677acb"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"80ebeeee9d00c0c531089889a25f02b9d635da21","unresolved":true,"context_lines":[{"line_number":1095,"context_line":"            ctxt \u003d context.get_internal_tenant_context() or ctxt"},{"line_number":1096,"context_line":"            temp_vol \u003d self.driver._create_temp_volume_from_snapshot("},{"line_number":1097,"context_line":"                ctxt, volume, snapshot, volume_options\u003dv_options)"},{"line_number":1098,"context_line":"            self._update_allocated_capacity(temp_vol)"},{"line_number":1099,"context_line":"            self._copy_volume_data(ctxt, temp_vol, volume)"},{"line_number":1100,"context_line":"            self.driver_delete_volume(temp_vol)"},{"line_number":1101,"context_line":"            temp_vol.destroy()"}],"source_content_type":"text/x-python","patch_set":2,"id":"dc42c2b5_744a1717","line":1098,"range":{"start_line":1098,"start_character":17,"end_line":1098,"end_character":43},"updated":"2022-04-11 09:50:08.000000000","message":"I see revert_to_snapshot operation is covered, I think it is good to update commit message.","commit_id":"8c223a357793456674fca376609325d2cf677acb"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"bd2f9f7abc2352ed4630d9dc039b5154dc2eccb1","unresolved":false,"context_lines":[{"line_number":1095,"context_line":"            ctxt \u003d context.get_internal_tenant_context() or ctxt"},{"line_number":1096,"context_line":"            temp_vol \u003d self.driver._create_temp_volume_from_snapshot("},{"line_number":1097,"context_line":"                ctxt, volume, snapshot, volume_options\u003dv_options)"},{"line_number":1098,"context_line":"            self._update_allocated_capacity(temp_vol)"},{"line_number":1099,"context_line":"            self._copy_volume_data(ctxt, temp_vol, volume)"},{"line_number":1100,"context_line":"            self.driver_delete_volume(temp_vol)"},{"line_number":1101,"context_line":"            temp_vol.destroy()"}],"source_content_type":"text/x-python","patch_set":2,"id":"83248d61_5647dbd5","line":1098,"range":{"start_line":1098,"start_character":17,"end_line":1098,"end_character":43},"in_reply_to":"dc42c2b5_744a1717","updated":"2022-04-11 14:26:51.000000000","message":"Done","commit_id":"8c223a357793456674fca376609325d2cf677acb"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"80ebeeee9d00c0c531089889a25f02b9d635da21","unresolved":true,"context_lines":[{"line_number":2925,"context_line":"                    context, snapshot, event_suffix,"},{"line_number":2926,"context_line":"                    extra_usage_info\u003dextra_usage_info, host\u003dself.host)"},{"line_number":2927,"context_line":""},{"line_number":2928,"context_line":"    def extend_volume(self,"},{"line_number":2929,"context_line":"                      context: context.RequestContext,"},{"line_number":2930,"context_line":"                      volume: objects.Volume,"},{"line_number":2931,"context_line":"                      new_size: int,"}],"source_content_type":"text/x-python","patch_set":2,"id":"8347fc3a_910d803c","line":2928,"range":{"start_line":2928,"start_character":8,"end_line":2928,"end_character":21},"updated":"2022-04-11 09:50:08.000000000","message":"commit message says that this patch fixes extend_volume but i couldn\u0027t find any change.\n\nDon\u0027t we need _update_allocated_capacity inside this ?","commit_id":"8c223a357793456674fca376609325d2cf677acb"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"6827b6fa8fdfcb95c24892da9d768648454c9721","unresolved":false,"context_lines":[{"line_number":2925,"context_line":"                    context, snapshot, event_suffix,"},{"line_number":2926,"context_line":"                    extra_usage_info\u003dextra_usage_info, host\u003dself.host)"},{"line_number":2927,"context_line":""},{"line_number":2928,"context_line":"    def extend_volume(self,"},{"line_number":2929,"context_line":"                      context: context.RequestContext,"},{"line_number":2930,"context_line":"                      volume: objects.Volume,"},{"line_number":2931,"context_line":"                      new_size: int,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1b3595d5_0777b699","line":2928,"range":{"start_line":2928,"start_character":8,"end_line":2928,"end_character":21},"in_reply_to":"2d9c12f4_8762e0a6","updated":"2022-04-11 13:00:26.000000000","message":"Thanks!","commit_id":"8c223a357793456674fca376609325d2cf677acb"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"e6f9014f4b02f98278b8abed6b860a9b4a49ba7e","unresolved":true,"context_lines":[{"line_number":2925,"context_line":"                    context, snapshot, event_suffix,"},{"line_number":2926,"context_line":"                    extra_usage_info\u003dextra_usage_info, host\u003dself.host)"},{"line_number":2927,"context_line":""},{"line_number":2928,"context_line":"    def extend_volume(self,"},{"line_number":2929,"context_line":"                      context: context.RequestContext,"},{"line_number":2930,"context_line":"                      volume: objects.Volume,"},{"line_number":2931,"context_line":"                      new_size: int,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ac2cf3d0_27f5f47d","line":2928,"range":{"start_line":2928,"start_character":8,"end_line":2928,"end_character":21},"in_reply_to":"8347fc3a_910d803c","updated":"2022-04-11 12:12:29.000000000","message":"It\u0027s already being updated in line 2991","commit_id":"8c223a357793456674fca376609325d2cf677acb"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"02521626ba53c8d6d87aff28ffd40d1da00e79b5","unresolved":false,"context_lines":[{"line_number":2925,"context_line":"                    context, snapshot, event_suffix,"},{"line_number":2926,"context_line":"                    extra_usage_info\u003dextra_usage_info, host\u003dself.host)"},{"line_number":2927,"context_line":""},{"line_number":2928,"context_line":"    def extend_volume(self,"},{"line_number":2929,"context_line":"                      context: context.RequestContext,"},{"line_number":2930,"context_line":"                      volume: objects.Volume,"},{"line_number":2931,"context_line":"                      new_size: int,"}],"source_content_type":"text/x-python","patch_set":2,"id":"2d9c12f4_8762e0a6","line":2928,"range":{"start_line":2928,"start_character":8,"end_line":2928,"end_character":21},"in_reply_to":"ac2cf3d0_27f5f47d","updated":"2022-04-11 12:13:28.000000000","message":"Done","commit_id":"8c223a357793456674fca376609325d2cf677acb"},{"author":{"_account_id":33543,"name":"liuhuajie","email":"liu.huajie@99cloud.net","username":"liuhuajie"},"change_message_id":"1acd88be0e56a7ebee5f0c67105f5cd8a9f139d8","unresolved":true,"context_lines":[{"line_number":406,"context_line":"                                   vol: objects.Volume,"},{"line_number":407,"context_line":"                                   decrement: bool \u003d False,"},{"line_number":408,"context_line":"                                   host: Optional[str] \u003d None,"},{"line_number":409,"context_line":"                                   size: int \u003d None) -\u003e None:"},{"line_number":410,"context_line":"        # Update allocated capacity in volume stats"},{"line_number":411,"context_line":"        host \u003d host or vol[\u0027host\u0027]"},{"line_number":412,"context_line":"        pool \u003d volume_utils.extract_host(host, \u0027pool\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"2ca11479_1cfbd2de","line":409,"range":{"start_line":409,"start_character":35,"end_line":409,"end_character":39},"updated":"2022-05-11 03:08:28.000000000","message":"The size argument feels unnecessary because there is no place to pass size","commit_id":"ba9ab007a62c95090d1e775948e65e0432c06fd8"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"d0b09aec97180ae03bec3a2402c4e70519d3198f","unresolved":true,"context_lines":[{"line_number":406,"context_line":"                                   vol: objects.Volume,"},{"line_number":407,"context_line":"                                   decrement: bool \u003d False,"},{"line_number":408,"context_line":"                                   host: Optional[str] \u003d None,"},{"line_number":409,"context_line":"                                   size: int \u003d None) -\u003e None:"},{"line_number":410,"context_line":"        # Update allocated capacity in volume stats"},{"line_number":411,"context_line":"        host \u003d host or vol[\u0027host\u0027]"},{"line_number":412,"context_line":"        pool \u003d volume_utils.extract_host(host, \u0027pool\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7159f4c2_7a4377d9","line":409,"range":{"start_line":409,"start_character":35,"end_line":409,"end_character":39},"in_reply_to":"2ca11479_1cfbd2de","updated":"2022-06-02 12:54:00.000000000","message":"I had missed the change in extend_volume which passes in the increased size.","commit_id":"ba9ab007a62c95090d1e775948e65e0432c06fd8"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"7645401f08403dd8ab89007c87039086c923137f","unresolved":false,"context_lines":[{"line_number":406,"context_line":"                                   vol: objects.Volume,"},{"line_number":407,"context_line":"                                   decrement: bool \u003d False,"},{"line_number":408,"context_line":"                                   host: Optional[str] \u003d None,"},{"line_number":409,"context_line":"                                   size: int \u003d None) -\u003e None:"},{"line_number":410,"context_line":"        # Update allocated capacity in volume stats"},{"line_number":411,"context_line":"        host \u003d host or vol[\u0027host\u0027]"},{"line_number":412,"context_line":"        pool \u003d volume_utils.extract_host(host, \u0027pool\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9247b78d_614f7a36","line":409,"range":{"start_line":409,"start_character":35,"end_line":409,"end_character":39},"in_reply_to":"7159f4c2_7a4377d9","updated":"2022-06-07 12:29:20.000000000","message":"Done","commit_id":"ba9ab007a62c95090d1e775948e65e0432c06fd8"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"523130060f3b0eac7f15d70795d77256acd05a60","unresolved":true,"context_lines":[{"line_number":2737,"context_line":"                        updates.update(model_update)"},{"line_number":2738,"context_line":"                    if new_type_id:"},{"line_number":2739,"context_line":"                        updates[\u0027volume_type_id\u0027] \u003d new_type_id"},{"line_number":2740,"context_line":"                    original_host \u003d volume.host"},{"line_number":2741,"context_line":"                    volume.update(updates)"},{"line_number":2742,"context_line":"                    volume.save()"},{"line_number":2743,"context_line":"                    self._update_allocated_capacity(volume, decrement\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":24,"id":"84af0f9d_74613916","line":2740,"updated":"2025-07-08 17:34:54.000000000","message":"Just curious why this is necessary, can volume.host change at runtime here?","commit_id":"0e39b35c9444e04ba93e917e1ded47b02090440a"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"4cfc033bc42911144a7c584b8abe709f4ceb061f","unresolved":true,"context_lines":[{"line_number":2737,"context_line":"                        updates.update(model_update)"},{"line_number":2738,"context_line":"                    if new_type_id:"},{"line_number":2739,"context_line":"                        updates[\u0027volume_type_id\u0027] \u003d new_type_id"},{"line_number":2740,"context_line":"                    original_host \u003d volume.host"},{"line_number":2741,"context_line":"                    volume.update(updates)"},{"line_number":2742,"context_line":"                    volume.save()"},{"line_number":2743,"context_line":"                    self._update_allocated_capacity(volume, decrement\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":24,"id":"fbf54f01_e91bd4fa","line":2740,"in_reply_to":"84af0f9d_74613916","updated":"2025-07-15 17:35:03.000000000","message":"we have to call the original host via rpc here to update the allocated capacity.","commit_id":"0e39b35c9444e04ba93e917e1ded47b02090440a"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"fcda3eed1f861cb51003af51e4a828fd9cb494de","unresolved":false,"context_lines":[{"line_number":2737,"context_line":"                        updates.update(model_update)"},{"line_number":2738,"context_line":"                    if new_type_id:"},{"line_number":2739,"context_line":"                        updates[\u0027volume_type_id\u0027] \u003d new_type_id"},{"line_number":2740,"context_line":"                    original_host \u003d volume.host"},{"line_number":2741,"context_line":"                    volume.update(updates)"},{"line_number":2742,"context_line":"                    volume.save()"},{"line_number":2743,"context_line":"                    self._update_allocated_capacity(volume, decrement\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":24,"id":"98eb7655_c97d21cd","line":2740,"in_reply_to":"fbf54f01_e91bd4fa","updated":"2025-07-15 17:35:18.000000000","message":"Acknowledged","commit_id":"0e39b35c9444e04ba93e917e1ded47b02090440a"}],"cinder/volume/rpcapi.py":[{"author":{"_account_id":33543,"name":"liuhuajie","email":"liu.huajie@99cloud.net","username":"liuhuajie"},"change_message_id":"1acd88be0e56a7ebee5f0c67105f5cd8a9f139d8","unresolved":true,"context_lines":[{"line_number":319,"context_line":"        cctxt.cast(ctxt, \u0027manage_existing\u0027, ref\u003dref, volume\u003dvolume)"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"    def update_migrated_volume_capacity(self, ctxt, volume):"},{"line_number":322,"context_line":"        cctxt \u003d self._get_cctxt(volume.service_topic_queue)"},{"line_number":323,"context_line":"        cctxt.cast(ctxt, \u0027update_migrated_volume_capacity\u0027, volume\u003dvolume)"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"    def update_migrated_volume(self, ctxt, volume, new_volume,"}],"source_content_type":"text/x-python","patch_set":6,"id":"f2bde471_391e83c9","line":322,"range":{"start_line":322,"start_character":8,"end_line":322,"end_character":59},"updated":"2022-05-11 03:08:28.000000000","message":"I think you can add version.","commit_id":"ba9ab007a62c95090d1e775948e65e0432c06fd8"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"7645401f08403dd8ab89007c87039086c923137f","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        cctxt.cast(ctxt, \u0027manage_existing\u0027, ref\u003dref, volume\u003dvolume)"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"    def update_migrated_volume_capacity(self, ctxt, volume):"},{"line_number":322,"context_line":"        cctxt \u003d self._get_cctxt(volume.service_topic_queue)"},{"line_number":323,"context_line":"        cctxt.cast(ctxt, \u0027update_migrated_volume_capacity\u0027, volume\u003dvolume)"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"    def update_migrated_volume(self, ctxt, volume, new_volume,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f7199d6_251d0595","line":322,"range":{"start_line":322,"start_character":8,"end_line":322,"end_character":59},"in_reply_to":"f2bde471_391e83c9","updated":"2022-06-07 12:29:20.000000000","message":"Done","commit_id":"ba9ab007a62c95090d1e775948e65e0432c06fd8"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"ee497a26115ccc0949ada0e7224a5ab39768a1ae","unresolved":true,"context_lines":[{"line_number":327,"context_line":"        cctxt \u003d self._get_cctxt(volume.service_topic_queue)"},{"line_number":328,"context_line":"        cctxt.cast(ctxt, \u0027manage_existing\u0027, ref\u003dref, volume\u003dvolume)"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    @rpc.assert_min_rpc_version(\u00273.19\u0027)"},{"line_number":331,"context_line":"    def update_migrated_volume_capacity(self, ctxt, volume, host,"},{"line_number":332,"context_line":"                                        decrement\u003dFalse):"},{"line_number":333,"context_line":"        cctxt \u003d self._get_cctxt(host)"}],"source_content_type":"text/x-python","patch_set":24,"id":"d64f3c1c_ac3dfc6a","line":330,"updated":"2025-07-08 19:39:49.000000000","message":"Might this be unnecessary? If it is required, a company_ver or get_cctxt would need it passed in.","commit_id":"0e39b35c9444e04ba93e917e1ded47b02090440a"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"4cfc033bc42911144a7c584b8abe709f4ceb061f","unresolved":false,"context_lines":[{"line_number":327,"context_line":"        cctxt \u003d self._get_cctxt(volume.service_topic_queue)"},{"line_number":328,"context_line":"        cctxt.cast(ctxt, \u0027manage_existing\u0027, ref\u003dref, volume\u003dvolume)"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    @rpc.assert_min_rpc_version(\u00273.19\u0027)"},{"line_number":331,"context_line":"    def update_migrated_volume_capacity(self, ctxt, volume, host,"},{"line_number":332,"context_line":"                                        decrement\u003dFalse):"},{"line_number":333,"context_line":"        cctxt \u003d self._get_cctxt(host)"}],"source_content_type":"text/x-python","patch_set":24,"id":"ddb513ca_a80d97cd","line":330,"in_reply_to":"d64f3c1c_ac3dfc6a","updated":"2025-07-15 17:35:03.000000000","message":"Acknowledged","commit_id":"0e39b35c9444e04ba93e917e1ded47b02090440a"}],"releasenotes/notes/fix-allocated-capacity-tracking-46d5dd59db6ff02a.yaml":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"24717153c9546881fc47f96675c3fd07eb283139","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add some fixes for tracking the backend/pool\u0027s allocated_capacity_gb."},{"line_number":5,"context_line":"    migrate volume wasn\u0027t tracking the changes in allocated_capacity_gb when"},{"line_number":6,"context_line":"    the volume was being moved from one pool to another. Other fixes include"},{"line_number":7,"context_line":"    delete_group, revert_to_snapshot_generic and extend_volume."}],"source_content_type":"text/x-yaml","patch_set":26,"id":"29b458f9_4c80cfa6","line":5,"updated":"2025-12-12 21:48:41.000000000","message":"If you need to do another update: s/migrate/Migrate/","commit_id":"e426f2790ea6be954b5b910e5fa785f978f0e1a7"}]}