)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34541,"name":"Manish","email":"manish.laddha@ibm.com","username":"manishladdha"},"change_message_id":"d10c5762d0a8dda7f91d32ac3ac657cc2c394066","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"46c87015_0a922d20","updated":"2022-04-07 14:01:52.000000000","message":"few comments from my side","commit_id":"aced4607478d2aa3a63ee4f0dc37f3bb4501c867"},{"author":{"_account_id":32074,"name":"Harsh Ailani","email":"haailani@in.ibm.com","username":"haailani"},"change_message_id":"c447d0af67cf335d0aa2479aa8f2d842156ccbd6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"569ab3ca_61c841cc","updated":"2022-04-11 11:35:31.000000000","message":"Hi Manish,\nComments are addressed.","commit_id":"cd80eedad36ff76e5b975cb717a3d3013ad94fd8"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"9515ab3ed5d863cc7e7fc9d61f91d0297a051477","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"858f3615_119d8576","updated":"2022-04-18 18:49:16.000000000","message":"LGTM","commit_id":"cd80eedad36ff76e5b975cb717a3d3013ad94fd8"},{"author":{"_account_id":32074,"name":"Harsh Ailani","email":"haailani@in.ibm.com","username":"haailani"},"change_message_id":"7df0740395cba6e4e0ffc8561c3b427f3a9cb670","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dbd11b45_d3d03442","updated":"2022-04-12 07:25:17.000000000","message":"recheck","commit_id":"cd80eedad36ff76e5b975cb717a3d3013ad94fd8"},{"author":{"_account_id":32074,"name":"Harsh Ailani","email":"haailani@in.ibm.com","username":"haailani"},"change_message_id":"da28bbb7188a623c136d6001256607fac00dc694","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e2f9f634_2d6238a4","updated":"2022-04-12 16:54:36.000000000","message":"run-IBM Storage CI","commit_id":"cd80eedad36ff76e5b975cb717a3d3013ad94fd8"},{"author":{"_account_id":32074,"name":"Harsh Ailani","email":"haailani@in.ibm.com","username":"haailani"},"change_message_id":"ea9312e0d0acb09e22b79ab2f841c06819519a27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7347a027_179514f0","updated":"2022-04-19 05:22:08.000000000","message":"Hi Gorka, Thanks for your review. I have addressed your review comments and added a new patch.\nPlease let me know if there is anything else needed. If not, requesting you to please assign the +2 again.\nThank you.","commit_id":"b99e73e96cb6448f81a2f4b2e8e624bf36bbff0e"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"0694b8e2f82dc5b7ca840246d99d07edd9ab20b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bed47b56_9016ccb0","updated":"2022-04-20 15:13:03.000000000","message":"Passing CI and +2 from Gorka.  Should be good to go.","commit_id":"b99e73e96cb6448f81a2f4b2e8e624bf36bbff0e"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"405ef911dcedac2d8ccc053b056501ed01e4c47c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1a2b2e96_cba617a3","updated":"2022-04-19 12:25:03.000000000","message":"Thank you for fixing the nits and for your detailed responses.","commit_id":"b99e73e96cb6448f81a2f4b2e8e624bf36bbff0e"},{"author":{"_account_id":34201,"name":"Mounika Sreeram","email":"sreeram.mounika@ibm.com","username":"sreerammounika"},"change_message_id":"44049d5e176fa0d5633e7392b7988eb44d003547","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"686b1c4b_caccdd31","updated":"2022-04-20 07:35:59.000000000","message":"Zuul and IBM CI is passed.","commit_id":"b99e73e96cb6448f81a2f4b2e8e624bf36bbff0e"},{"author":{"_account_id":34541,"name":"Manish","email":"manish.laddha@ibm.com","username":"manishladdha"},"change_message_id":"eef3fb4cd45c2b5f52422715d9bb3a674b21ba57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7d2f2235_922cdd8d","updated":"2022-04-19 14:27:00.000000000","message":"changes look good","commit_id":"b99e73e96cb6448f81a2f4b2e8e624bf36bbff0e"},{"author":{"_account_id":32074,"name":"Harsh Ailani","email":"haailani@in.ibm.com","username":"haailani"},"change_message_id":"b3e8ebd010f3de3b36462e4b89a9bd7ebfcd3d9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"317bff0a_bdcab484","updated":"2022-04-19 08:58:53.000000000","message":"run-IBM Storage CI","commit_id":"b99e73e96cb6448f81a2f4b2e8e624bf36bbff0e"}],"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":34541,"name":"Manish","email":"manish.laddha@ibm.com","username":"manishladdha"},"change_message_id":"d10c5762d0a8dda7f91d32ac3ac657cc2c394066","unresolved":true,"context_lines":[{"line_number":2277,"context_line":"    def update_clean_rate(self, volume_name, new_clean_rate):"},{"line_number":2278,"context_line":"        mapping_ids \u003d self._get_vdisk_fc_mappings(volume_name)"},{"line_number":2279,"context_line":"        for map_id in mapping_ids:"},{"line_number":2280,"context_line":"            attrs \u003d self._get_flashcopy_mapping_attributes(map_id)"},{"line_number":2281,"context_line":"            if attrs[\u0027rc_controlled\u0027] !\u003d \u0027yes\u0027:"},{"line_number":2282,"context_line":"                self.ssh.chfcmap(map_id,"},{"line_number":2283,"context_line":"                                 clean_rate\u003dsix.text_type(new_clean_rate))"}],"source_content_type":"text/x-python","patch_set":2,"id":"983ea418_d822d1f5","line":2280,"updated":"2022-04-07 14:01:52.000000000","message":"Add a comment as to why this code is added for future reference.\nAlso please handle the case where FC attributes can be empty after the \u0027get\u0027 call.","commit_id":"aced4607478d2aa3a63ee4f0dc37f3bb4501c867"},{"author":{"_account_id":32074,"name":"Harsh Ailani","email":"haailani@in.ibm.com","username":"haailani"},"change_message_id":"c447d0af67cf335d0aa2479aa8f2d842156ccbd6","unresolved":false,"context_lines":[{"line_number":2277,"context_line":"    def update_clean_rate(self, volume_name, new_clean_rate):"},{"line_number":2278,"context_line":"        mapping_ids \u003d self._get_vdisk_fc_mappings(volume_name)"},{"line_number":2279,"context_line":"        for map_id in mapping_ids:"},{"line_number":2280,"context_line":"            attrs \u003d self._get_flashcopy_mapping_attributes(map_id)"},{"line_number":2281,"context_line":"            if attrs[\u0027rc_controlled\u0027] !\u003d \u0027yes\u0027:"},{"line_number":2282,"context_line":"                self.ssh.chfcmap(map_id,"},{"line_number":2283,"context_line":"                                 clean_rate\u003dsix.text_type(new_clean_rate))"}],"source_content_type":"text/x-python","patch_set":2,"id":"6375f304_f0f01711","line":2280,"in_reply_to":"983ea418_d822d1f5","updated":"2022-04-11 11:35:31.000000000","message":"The None case is addressed and UTs are now tested.\n\nComment is also added as to why the rc_controlled check is added.","commit_id":"aced4607478d2aa3a63ee4f0dc37f3bb4501c867"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"9515ab3ed5d863cc7e7fc9d61f91d0297a051477","unresolved":true,"context_lines":[{"line_number":2281,"context_line":"            # chfcmap should not be called for rc_controlled fcmap"},{"line_number":2282,"context_line":"            if attrs is not None and attrs[\u0027rc_controlled\u0027] !\u003d \u0027yes\u0027:"},{"line_number":2283,"context_line":"                self.ssh.chfcmap(map_id,"},{"line_number":2284,"context_line":"                                 clean_rate\u003dsix.text_type(new_clean_rate))"},{"line_number":2285,"context_line":""},{"line_number":2286,"context_line":"    def check_flashcopy_rate(self, flashcopy_rate):"},{"line_number":2287,"context_line":"        if not self.code_level:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba6de152_6c9ba88c","line":2284,"range":{"start_line":2284,"start_character":44,"end_line":2284,"end_character":57},"updated":"2022-04-18 18:49:16.000000000","message":"nit: Since we are already changing this line, we should replace the six.text_type with str","commit_id":"cd80eedad36ff76e5b975cb717a3d3013ad94fd8"},{"author":{"_account_id":32074,"name":"Harsh Ailani","email":"haailani@in.ibm.com","username":"haailani"},"change_message_id":"ea9312e0d0acb09e22b79ab2f841c06819519a27","unresolved":false,"context_lines":[{"line_number":2281,"context_line":"            # chfcmap should not be called for rc_controlled fcmap"},{"line_number":2282,"context_line":"            if attrs is not None and attrs[\u0027rc_controlled\u0027] !\u003d \u0027yes\u0027:"},{"line_number":2283,"context_line":"                self.ssh.chfcmap(map_id,"},{"line_number":2284,"context_line":"                                 clean_rate\u003dsix.text_type(new_clean_rate))"},{"line_number":2285,"context_line":""},{"line_number":2286,"context_line":"    def check_flashcopy_rate(self, flashcopy_rate):"},{"line_number":2287,"context_line":"        if not self.code_level:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc6146f_0ac923e7","line":2284,"range":{"start_line":2284,"start_character":44,"end_line":2284,"end_character":57},"in_reply_to":"ba6de152_6c9ba88c","updated":"2022-04-19 05:22:08.000000000","message":"Fixed.","commit_id":"cd80eedad36ff76e5b975cb717a3d3013ad94fd8"}],"releasenotes/notes/bug-1968159-ibm-svf-Retype_failure_for_replication_volume-type-4e0671b299315f4b.yaml":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"9515ab3ed5d863cc7e7fc9d61f91d0297a051477","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    IBM Spectrum Virtualize Family driver: `Bug #1968159"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/1968159\u003e`_:"},{"line_number":6,"context_line":"    Fix for retype failure for replication volume-type."},{"line_number":7,"context_line":"    Controlling chfcmap call for rc_controlled fcmap"},{"line_number":8,"context_line":"    for replication-type volumes during retype operation."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"b76817e0_e80441be","line":6,"range":{"start_line":6,"start_character":31,"end_line":6,"end_character":42},"updated":"2022-04-18 18:49:16.000000000","message":"nit: replicated","commit_id":"cd80eedad36ff76e5b975cb717a3d3013ad94fd8"},{"author":{"_account_id":32074,"name":"Harsh Ailani","email":"haailani@in.ibm.com","username":"haailani"},"change_message_id":"ea9312e0d0acb09e22b79ab2f841c06819519a27","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    IBM Spectrum Virtualize Family driver: `Bug #1968159"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/1968159\u003e`_:"},{"line_number":6,"context_line":"    Fix for retype failure for replication volume-type."},{"line_number":7,"context_line":"    Controlling chfcmap call for rc_controlled fcmap"},{"line_number":8,"context_line":"    for replication-type volumes during retype operation."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"369fa895_0d70c7af","line":6,"range":{"start_line":6,"start_character":31,"end_line":6,"end_character":42},"in_reply_to":"b76817e0_e80441be","updated":"2022-04-19 05:22:08.000000000","message":"Fixed.","commit_id":"cd80eedad36ff76e5b975cb717a3d3013ad94fd8"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"9515ab3ed5d863cc7e7fc9d61f91d0297a051477","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    IBM Spectrum Virtualize Family driver: `Bug #1968159"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/1968159\u003e`_:"},{"line_number":6,"context_line":"    Fix for retype failure for replication volume-type."},{"line_number":7,"context_line":"    Controlling chfcmap call for rc_controlled fcmap"},{"line_number":8,"context_line":"    for replication-type volumes during retype operation."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"d49d7dc6_000ff132","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":57},"updated":"2022-04-18 18:49:16.000000000","message":"?: Is this something that an admin of your storage system would be familiar with? Or are these only understood by driver maintainers?  If a system admin would not understand it, we should remove it.","commit_id":"cd80eedad36ff76e5b975cb717a3d3013ad94fd8"},{"author":{"_account_id":32074,"name":"Harsh Ailani","email":"haailani@in.ibm.com","username":"haailani"},"change_message_id":"ea9312e0d0acb09e22b79ab2f841c06819519a27","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    IBM Spectrum Virtualize Family driver: `Bug #1968159"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/1968159\u003e`_:"},{"line_number":6,"context_line":"    Fix for retype failure for replication volume-type."},{"line_number":7,"context_line":"    Controlling chfcmap call for rc_controlled fcmap"},{"line_number":8,"context_line":"    for replication-type volumes during retype operation."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"8d49b635_c365de25","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":57},"in_reply_to":"d49d7dc6_000ff132","updated":"2022-04-19 05:22:08.000000000","message":"Yes, the storage admin will understand the workings of the fcmap and how the  \"rc_controlled\" parameter of the fcmap works with respect to chfcmap command.\nThe admin will be aware that if the fcmap has \"rc_controlled\u003dyes\", then chfcmap will return error. The same error is handled by this particular change.","commit_id":"cd80eedad36ff76e5b975cb717a3d3013ad94fd8"}]}