)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"a7b51cf07d60b3e4e253347b5509c9870ea8a12c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Alexander Malashenko \u003calexander.malashenko@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-04-11 05:15:33 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add check if size exist in model_update and update size in model_update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #1968164"},{"line_number":10,"context_line":"Change-Id: Ib0334d2e1be80d1a20c26b4435076187b0e43d40"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"878d7738_58caf3de","line":7,"updated":"2022-04-20 12:15:23.000000000","message":"-1: Please follow OpenStack guidelines for line length [1].\n\nCommit messages should contain all necessary information to understand the patch without having to go to the bug in launchpad.\n\nUsually it follows something like:\n\n- Add a title line that summarizes what the patch does\n- Describe what\u0027s visible by users\n- Describe why that\u0027s happening\n- Describe what the patch does to fix this.\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#:~:text\u003dSummary%20of%20Git%20commit%20message%20structure,-Provide%20a%20brief\u0026text\u003dIf%20appropriate%2C%20include%20a%20\u0027Test,be%20wrapped%20at%2072%20characters.","commit_id":"cb2bbc92381fa26fc8f8d3b3e5eae7cf3c1f37b0"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"70b26ee0ff7a67bb6ad0c3ed8fe1378e3ba2125b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alexander Malashenko \u003calexander.malashenko@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-04-11 05:15:33 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add check if size exist in model_update and update size in model_update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #1968164"},{"line_number":10,"context_line":"Change-Id: Ib0334d2e1be80d1a20c26b4435076187b0e43d40"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3828e97d_d5de889c","line":7,"in_reply_to":"878d7738_58caf3de","updated":"2022-06-20 13:12:13.000000000","message":"Done","commit_id":"cb2bbc92381fa26fc8f8d3b3e5eae7cf3c1f37b0"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"35d83b039b3dc790c17c15b3cef9310b9098f946","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Alexander Malashenko \u003calexander.malashenko@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-07-26 00:05:52 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"PowerFlex driver - cinder displays the volume size provided"},{"line_number":8,"context_line":"by the driver, when creating the volume with enabled cache."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Now the user can see the size that would initially set by"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"db58068e_289786e2","line":7,"updated":"2022-08-05 18:40:20.000000000","message":"For future reference, please follow the commit message guidelines:\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"024c2c4097409010b24d64b47557ef83fe9e54ca"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"1fe55d4c3b669da60ebce72373b80b138a39d048","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alexander Malashenko \u003calexander.malashenko@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-07-26 00:05:52 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"PowerFlex driver - cinder displays the volume size provided"},{"line_number":8,"context_line":"by the driver, when creating the volume with enabled cache."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Now the user can see the size that would initially set by"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"ff536c40_6042b81c","line":7,"in_reply_to":"db58068e_289786e2","updated":"2022-08-08 07:52:03.000000000","message":"Thank you for comments!","commit_id":"024c2c4097409010b24d64b47557ef83fe9e54ca"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"91ac090e06953a799eceaaf209c6594cd939392b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"292750d6_b7dfd84d","updated":"2022-04-12 10:52:36.000000000","message":"LGTM","commit_id":"cb2bbc92381fa26fc8f8d3b3e5eae7cf3c1f37b0"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"a7b51cf07d60b3e4e253347b5509c9870ea8a12c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ffcf5e82_10dc6ee0","updated":"2022-04-20 12:15:23.000000000","message":"Thank you for looking into this issue and fixing it.\n\nIn my opinion a driver should **never** return the size in a model update dictionary (they should just honor what Cinder says), but since it isn\u0027t stated anywhere, we cannot go blaming drivers now.\n\nCode works, but I think it can be improved, and the patch also needs a unit tests for the case we are fixing.","commit_id":"cb2bbc92381fa26fc8f8d3b3e5eae7cf3c1f37b0"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"0ecfc9506e63711d7d9db12885fc0f6326d86830","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"45326ae2_1f777b58","in_reply_to":"ffcf5e82_10dc6ee0","updated":"2022-04-21 10:22:28.000000000","message":"Thank you for comments, i will fix it and send new patch.","commit_id":"cb2bbc92381fa26fc8f8d3b3e5eae7cf3c1f37b0"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"70b26ee0ff7a67bb6ad0c3ed8fe1378e3ba2125b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"51828652_e592d523","updated":"2022-06-20 13:12:13.000000000","message":"resolved comments, writing unit test case","commit_id":"8c89190950bdd234f5dcfd8d58407fd2075a4416"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"956fec42fd8a6e81dc95abdbff332cddf8d782d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"7690acc7_2da6179b","updated":"2022-07-18 06:47:39.000000000","message":"Looks like this is the normal behavior as cinder always return the value from the user. A new logic needs to be implemented at the cinder core with new set of specs. Suggest to abandon this patch.","commit_id":"381dab99d3d06e24c0fac3789a156a2ea0062547"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c379270f92a2fb64e82100d6222f772a5ba1ef75","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"69988ce0_bc89a696","updated":"2022-07-19 09:29:25.000000000","message":"Thank you for working on fixing this issue.\nDownvote is because there\u0027s a minor thing to change in the release note and because I believe the driver is missing a unit test.","commit_id":"f2440079cb40728f8ef13f68ba2ab4047a1be397"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"0e1f0fea0228e1c86f8876e44783e9a48e258cfa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"72a9d1f9_58ee1128","in_reply_to":"69988ce0_bc89a696","updated":"2022-07-25 15:29:54.000000000","message":"Thank you for comments!","commit_id":"f2440079cb40728f8ef13f68ba2ab4047a1be397"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"8ab256018eb76a6f30565c5d78986de48dcb1f86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"ca57d4a6_f18f7b85","updated":"2022-08-11 11:42:35.000000000","message":"My concern has been addressed - thanks!","commit_id":"b1b09d40856071727f43e1b1888124c79f84019e"},{"author":{"_account_id":28801,"name":"Cisco Cinder CI","email":"cisco-cinder-ci@cisco.com","username":"cisco-cinder-ci"},"change_message_id":"033b8c0b417601ac32e5f15b3f4ec6254531e495","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"b5f6aef2_8a354a23","updated":"2022-08-08 09:08:25.000000000","message":"cisco-cinder-ci","commit_id":"b1b09d40856071727f43e1b1888124c79f84019e"},{"author":{"_account_id":28801,"name":"Cisco Cinder CI","email":"cisco-cinder-ci@cisco.com","username":"cisco-cinder-ci"},"change_message_id":"311e69837038838aee6813425f52ef70fa1c57ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"ef277b37_d9cb7a10","updated":"2022-08-08 09:37:01.000000000","message":"cisco-cinder-ci","commit_id":"b1b09d40856071727f43e1b1888124c79f84019e"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"b797715e22f759fb269791e06b0400746a22ce6a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"73522e58_33177bb0","updated":"2022-08-15 07:19:06.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"b1b09d40856071727f43e1b1888124c79f84019e"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"4e57df0978519a16276deaef7cfd493662631c42","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"d207ef09_3a6ebab0","updated":"2022-08-09 06:18:38.000000000","message":"run-Yadro Tatlin Unified CI","commit_id":"b1b09d40856071727f43e1b1888124c79f84019e"}],"cinder/tests/unit/volume/drivers/dell_emc/powerflex/test_create_volume.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c379270f92a2fb64e82100d6222f772a5ba1ef75","unresolved":true,"context_lines":[{"line_number":82,"context_line":"        \"\"\"Valid create volume parameters\"\"\""},{"line_number":83,"context_line":"        self.driver.create_volume(self.volume)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def test_create_volume_non_8_gran(self):"},{"line_number":86,"context_line":"        self.volume.size \u003d 14"},{"line_number":87,"context_line":"        model_update \u003d self.driver.create_volume(self.volume)"},{"line_number":88,"context_line":"        self.assertEqual(16, model_update[\u0027size\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"ad941457_528a5ae4","side":"PARENT","line":85,"updated":"2022-07-19 09:29:25.000000000","message":"-1: How come there is no test that confirms what parameters are being passed to the client\u0027s create_volume method when the driver creates the volume?","commit_id":"9a8f86732131c4c5b4b647514496155598faf561"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"0e1f0fea0228e1c86f8876e44783e9a48e258cfa","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        \"\"\"Valid create volume parameters\"\"\""},{"line_number":83,"context_line":"        self.driver.create_volume(self.volume)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def test_create_volume_non_8_gran(self):"},{"line_number":86,"context_line":"        self.volume.size \u003d 14"},{"line_number":87,"context_line":"        model_update \u003d self.driver.create_volume(self.volume)"},{"line_number":88,"context_line":"        self.assertEqual(16, model_update[\u0027size\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"342aff18_45981939","side":"PARENT","line":85,"in_reply_to":"ad941457_528a5ae4","updated":"2022-07-25 15:29:54.000000000","message":"Done","commit_id":"9a8f86732131c4c5b4b647514496155598faf561"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b02034f9625481e76d3be5adc1ffd7ec0ca91ce4","unresolved":true,"context_lines":[{"line_number":102,"context_line":"        self.driver.create_volume(self.volume)"},{"line_number":103,"context_line":"        self.driver.primary_client.create_volume.assert_called_with("},{"line_number":104,"context_line":"            self.PROT_DOMAIN_NAME, self.STORAGE_POOL_NAME, self.volume.id,"},{"line_number":105,"context_line":"            self.volume.size, \u0027ThinProvisioned\u0027, \u0027None\u0027)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def test_create_volume_badstatus_response(self):"},{"line_number":108,"context_line":"        self.set_https_response_mode(self.RESPONSE_MODE.BadStatus)"}],"source_content_type":"text/x-python","patch_set":16,"id":"18bf75b3_a2380d7b","line":105,"updated":"2022-08-02 14:47:40.000000000","message":"I think I\u0027m missing something, shouldn\u0027t we be testing that we are creating a volume with a multiple of 8?","commit_id":"024c2c4097409010b24d64b47557ef83fe9e54ca"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"614ca2817ad3cb147a68cc4b515648a7575388ea","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        self.driver.create_volume(self.volume)"},{"line_number":103,"context_line":"        self.driver.primary_client.create_volume.assert_called_with("},{"line_number":104,"context_line":"            self.PROT_DOMAIN_NAME, self.STORAGE_POOL_NAME, self.volume.id,"},{"line_number":105,"context_line":"            self.volume.size, \u0027ThinProvisioned\u0027, \u0027None\u0027)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def test_create_volume_badstatus_response(self):"},{"line_number":108,"context_line":"        self.set_https_response_mode(self.RESPONSE_MODE.BadStatus)"}],"source_content_type":"text/x-python","patch_set":16,"id":"a4be2a73_d9c71879","line":105,"in_reply_to":"14ec77b3_115fd69f","updated":"2022-08-05 09:38:55.000000000","message":"After chant on IRC now I understand.\nThe driver tells the array to create a 14GB volume and it\u0027s the array the one that does the round up, not the driver, so we won\u0027t see the driver requesting for the rounded value like I expected.","commit_id":"024c2c4097409010b24d64b47557ef83fe9e54ca"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"d873ed6ce6e03ca2a173f00f662d112a9a41fb25","unresolved":true,"context_lines":[{"line_number":102,"context_line":"        self.driver.create_volume(self.volume)"},{"line_number":103,"context_line":"        self.driver.primary_client.create_volume.assert_called_with("},{"line_number":104,"context_line":"            self.PROT_DOMAIN_NAME, self.STORAGE_POOL_NAME, self.volume.id,"},{"line_number":105,"context_line":"            self.volume.size, \u0027ThinProvisioned\u0027, \u0027None\u0027)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def test_create_volume_badstatus_response(self):"},{"line_number":108,"context_line":"        self.set_https_response_mode(self.RESPONSE_MODE.BadStatus)"}],"source_content_type":"text/x-python","patch_set":16,"id":"14ec77b3_115fd69f","line":105,"in_reply_to":"18bf75b3_a2380d7b","updated":"2022-08-02 15:22:33.000000000","message":"I thought I should make sure if powerflex_round_volume_capacity is True, we can create volume without a multiple of 8. That is, if we try to create a volume and set a size of not multiple 8, it will be created successfully.","commit_id":"024c2c4097409010b24d64b47557ef83fe9e54ca"}],"cinder/volume/drivers/dell_emc/powerflex/driver.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c379270f92a2fb64e82100d6222f772a5ba1ef75","unresolved":false,"context_lines":[{"line_number":753,"context_line":"        except AttributeError:"},{"line_number":754,"context_line":"            source_size \u003d source.size"},{"line_number":755,"context_line":"        if volume.size \u003e source_size:"},{"line_number":756,"context_line":"            real_size \u003d flex_utils.round_to_num_gran(volume.size)"},{"line_number":757,"context_line":"            client.extend_volume(provider_id, real_size)"},{"line_number":758,"context_line":"        if volume.is_replicated():"},{"line_number":759,"context_line":"            self._setup_volume_replication(volume, provider_id)"},{"line_number":760,"context_line":"            model_updates[\"replication_status\"] \u003d ("}],"source_content_type":"text/x-python","patch_set":14,"id":"4c6a4ca0_a8f75419","line":757,"range":{"start_line":756,"start_character":0,"end_line":757,"end_character":56},"updated":"2022-07-19 09:29:25.000000000","message":"Unrelated to this patch, so any fix should go in another patch, but this caught my eye while reviewing it.\n\nI don\u0027t think this is correct, because cloning a 1GB volume to a 2GB destination would try to extend the destination to 8GB, which it already is.  Comparison should be done like in the driver\u0027s extend_volume.\n\nAnd what if the new volume is replicated?","commit_id":"f2440079cb40728f8ef13f68ba2ab4047a1be397"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"0e1f0fea0228e1c86f8876e44783e9a48e258cfa","unresolved":false,"context_lines":[{"line_number":753,"context_line":"        except AttributeError:"},{"line_number":754,"context_line":"            source_size \u003d source.size"},{"line_number":755,"context_line":"        if volume.size \u003e source_size:"},{"line_number":756,"context_line":"            real_size \u003d flex_utils.round_to_num_gran(volume.size)"},{"line_number":757,"context_line":"            client.extend_volume(provider_id, real_size)"},{"line_number":758,"context_line":"        if volume.is_replicated():"},{"line_number":759,"context_line":"            self._setup_volume_replication(volume, provider_id)"},{"line_number":760,"context_line":"            model_updates[\"replication_status\"] \u003d ("}],"source_content_type":"text/x-python","patch_set":14,"id":"ee6e82f8_0f4b46dd","line":757,"range":{"start_line":756,"start_character":0,"end_line":757,"end_character":56},"in_reply_to":"4c6a4ca0_a8f75419","updated":"2022-07-25 15:29:54.000000000","message":"I will create new bug and fix it.","commit_id":"f2440079cb40728f8ef13f68ba2ab4047a1be397"}],"cinder/volume/flows/manager/create_volume.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"a7b51cf07d60b3e4e253347b5509c9870ea8a12c","unresolved":true,"context_lines":[{"line_number":1029,"context_line":"                try:"},{"line_number":1030,"context_line":"                    self.driver.extend_volume(volume, original_size)"},{"line_number":1031,"context_line":"                finally:"},{"line_number":1032,"context_line":"                    if model_update and \u0027size\u0027 in model_update:"},{"line_number":1033,"context_line":"                        model_update[\u0027size\u0027] \u003d original_size"},{"line_number":1034,"context_line":"                    volume.size \u003d original_size"},{"line_number":1035,"context_line":"                    volume.save()"},{"line_number":1036,"context_line":""},{"line_number":1037,"context_line":"        return model_update"},{"line_number":1038,"context_line":""},{"line_number":1039,"context_line":"    @utils.retry(exception.SnapshotLimitReached, retries\u003d1)"}],"source_content_type":"text/x-python","patch_set":2,"id":"4db3ac86_ed4e185d","line":1036,"range":{"start_line":1032,"start_character":0,"end_line":1036,"end_character":0},"updated":"2022-04-20 12:15:23.000000000","message":"-1: While the code change works and fixes the problem, I believe there is a slightly better solution.  We should just return the new size in the model_update.  That way we avoid an additional DB write.\n\nWith current code:\n\n- DB call here: Save size\n- DB call done on the caller that receives the model_update: Saves the rest of the model update if no size was present, and if size was present (the bug PowerFlex is experiencing) it saves the rest of the model and the size (again).\n\nI think this would be better:\n\n                    if model_update:\n                        model_update[\u0027size\u0027] \u003d original_size\n                    else:\n                        model_update \u003d {\u0027size\u0027: original_size}\n\nthere\u0027s also this other alternative which I don\u0027t like as much:\n\n                    if model_update:\n                        model_update[\u0027size\u0027] \u003d original_size\n                    else:\n                        volume.size \u003d original_size\n                        volume.save()","commit_id":"cb2bbc92381fa26fc8f8d3b3e5eae7cf3c1f37b0"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"70b26ee0ff7a67bb6ad0c3ed8fe1378e3ba2125b","unresolved":false,"context_lines":[{"line_number":1029,"context_line":"                try:"},{"line_number":1030,"context_line":"                    self.driver.extend_volume(volume, original_size)"},{"line_number":1031,"context_line":"                finally:"},{"line_number":1032,"context_line":"                    if model_update and \u0027size\u0027 in model_update:"},{"line_number":1033,"context_line":"                        model_update[\u0027size\u0027] \u003d original_size"},{"line_number":1034,"context_line":"                    volume.size \u003d original_size"},{"line_number":1035,"context_line":"                    volume.save()"},{"line_number":1036,"context_line":""},{"line_number":1037,"context_line":"        return model_update"},{"line_number":1038,"context_line":""},{"line_number":1039,"context_line":"    @utils.retry(exception.SnapshotLimitReached, retries\u003d1)"}],"source_content_type":"text/x-python","patch_set":2,"id":"a6914b5e_dbe018a0","line":1036,"range":{"start_line":1032,"start_character":0,"end_line":1036,"end_character":0},"in_reply_to":"4db3ac86_ed4e185d","updated":"2022-06-20 13:12:13.000000000","message":"Done","commit_id":"cb2bbc92381fa26fc8f8d3b3e5eae7cf3c1f37b0"}],"releasenotes/notes/bug-1968164-cinder-manage-create-volume-update-size-482c76193b219341.yaml":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"e48c7fe3f61e2114baf7ef57c9cc40b96bce77f5","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #1968164 \u003chttps://bugs.launchpad.net/cinder/+bug/1968164\u003e`_: Fixed"},{"line_number":5,"context_line":"    Added check for size in model_update, if size exists, then update it"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ac643d63_90cba14a","line":2,"updated":"2022-04-13 18:06:01.000000000","message":"Please drop this file. This would be confusing to someone reading the release notes.","commit_id":"cb2bbc92381fa26fc8f8d3b3e5eae7cf3c1f37b0"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"70b26ee0ff7a67bb6ad0c3ed8fe1378e3ba2125b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #1968164 \u003chttps://bugs.launchpad.net/cinder/+bug/1968164\u003e`_: Fixed"},{"line_number":5,"context_line":"    Added check for size in model_update, if size exists, then update it"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"94a351d9_a74eee96","line":2,"in_reply_to":"ac643d63_90cba14a","updated":"2022-06-20 13:12:13.000000000","message":"Done","commit_id":"cb2bbc92381fa26fc8f8d3b3e5eae7cf3c1f37b0"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"a7b51cf07d60b3e4e253347b5509c9870ea8a12c","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #1968164 \u003chttps://bugs.launchpad.net/cinder/+bug/1968164\u003e`_: Fixed"},{"line_number":5,"context_line":"    Added check for size in model_update, if size exists, then update it"},{"line_number":6,"context_line":"    after func extend volume."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"56e8fc70_bc03722b","line":6,"updated":"2022-04-20 12:15:23.000000000","message":"-1: Thank you for including a release note, it\u0027s a very important aspect of fixing bugs and many times we forget it.  The important aspect of a release note is that the intended audience are system administrators, and this message is too developer focused.\n\nYou should phrase the release note in a way that they would know what has been fixed.  This is just a suggestion, but maybe on the lines of: \"Fixed cinder reporting incorrect volume size when cache is enabled and the image is smaller than the created volume.\"","commit_id":"cb2bbc92381fa26fc8f8d3b3e5eae7cf3c1f37b0"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"70b26ee0ff7a67bb6ad0c3ed8fe1378e3ba2125b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #1968164 \u003chttps://bugs.launchpad.net/cinder/+bug/1968164\u003e`_: Fixed"},{"line_number":5,"context_line":"    Added check for size in model_update, if size exists, then update it"},{"line_number":6,"context_line":"    after func extend volume."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"221aa5c7_3cefd6ee","line":6,"in_reply_to":"56e8fc70_bc03722b","updated":"2022-06-20 13:12:13.000000000","message":"Done","commit_id":"cb2bbc92381fa26fc8f8d3b3e5eae7cf3c1f37b0"}],"releasenotes/notes/bug-1968164-powerflex-fixed-volume-size-provided-by-driver-4555edf1abab141c.yaml":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c379270f92a2fb64e82100d6222f772a5ba1ef75","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #1968164 \u003chttps://bugs.launchpad.net/cinder/+bug/1968164\u003e`_:"},{"line_number":5,"context_line":"    Fixed cinder displays of incorrect volume size for the PowerFlex driver"},{"line_number":6,"context_line":"    that needs to round the size multiply of eight. When user creates"},{"line_number":7,"context_line":"    volume/snapshot, user will see the size that would initially set by him."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"f2d37b3e_f06d9731","line":4,"range":{"start_line":4,"start_character":3,"end_line":4,"end_character":17},"updated":"2022-07-19 09:29:25.000000000","message":"-1: The note should start with the driver name:\n\n  PowerFlex driver `bug #1968164 \u003chttps://bugs.","commit_id":"f2440079cb40728f8ef13f68ba2ab4047a1be397"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"0e1f0fea0228e1c86f8876e44783e9a48e258cfa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #1968164 \u003chttps://bugs.launchpad.net/cinder/+bug/1968164\u003e`_:"},{"line_number":5,"context_line":"    Fixed cinder displays of incorrect volume size for the PowerFlex driver"},{"line_number":6,"context_line":"    that needs to round the size multiply of eight. When user creates"},{"line_number":7,"context_line":"    volume/snapshot, user will see the size that would initially set by him."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"42979bcb_8fd4032c","line":4,"range":{"start_line":4,"start_character":3,"end_line":4,"end_character":17},"in_reply_to":"f2d37b3e_f06d9731","updated":"2022-07-25 15:29:54.000000000","message":"Done","commit_id":"f2440079cb40728f8ef13f68ba2ab4047a1be397"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"d4e0c44c44e1386ecc5b879c3bf5793b50977e9a","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    PowerFlex driver `Bug #1968164 \u003chttps://bugs.launchpad.net/cinder/+bug/1968164\u003e`_:"},{"line_number":5,"context_line":"    Fixed cinder displays of incorrect volume size for the PowerFlex driver"},{"line_number":6,"context_line":"    that needs to round the size multiply of eight. When user creates"},{"line_number":7,"context_line":"    volume/snapshot, user will see the size that would initially set by him."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"65d793d7_9357cffd","line":5,"updated":"2022-08-05 18:45:16.000000000","message":"A few grammatical things here that should be fixed.\n\nMaybe something like:\n\n\u003e Fixed the display of the incorrect volume size on volume or snapshot creation. PowerFlex storage requires volumes sizes to be a multiple of 8 GiB. This size was being reported to the end user, potentially causing confusion by being different than what they requested.\n\nAt a bare minimum, don\u0027t refer to the user as \"him\".","commit_id":"024c2c4097409010b24d64b47557ef83fe9e54ca"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"1fe55d4c3b669da60ebce72373b80b138a39d048","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    PowerFlex driver `Bug #1968164 \u003chttps://bugs.launchpad.net/cinder/+bug/1968164\u003e`_:"},{"line_number":5,"context_line":"    Fixed cinder displays of incorrect volume size for the PowerFlex driver"},{"line_number":6,"context_line":"    that needs to round the size multiply of eight. When user creates"},{"line_number":7,"context_line":"    volume/snapshot, user will see the size that would initially set by him."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"5912031d_9ffd99fc","line":5,"in_reply_to":"65d793d7_9357cffd","updated":"2022-08-08 07:52:03.000000000","message":"Done","commit_id":"024c2c4097409010b24d64b47557ef83fe9e54ca"}]}