)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7c21a0ee90f42311023a7238e902ddbda625c648","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"369fef7f_34852f99","updated":"2022-05-31 07:55:31.000000000","message":"LGTM.","commit_id":"d0b0869d45defc72efaa6b11ed62ceed04cbbdc2"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ad8496bd0ebff5ade69f56b4d24497d99f056e09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bd5d5b87_a47de9c8","updated":"2022-04-13 12:56:09.000000000","message":"Looks good.  I like the refactoring of the default_volume_type code.","commit_id":"d0b0869d45defc72efaa6b11ed62ceed04cbbdc2"}],"cinder/db/sqlalchemy/api.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ad8496bd0ebff5ade69f56b4d24497d99f056e09","unresolved":true,"context_lines":[{"line_number":5164,"context_line":"    If a project id is passed, it returns default type for that particular"},{"line_number":5165,"context_line":"    project else returns default volume types for all projects"},{"line_number":5166,"context_line":"    \"\"\""},{"line_number":5167,"context_line":"    if session:"},{"line_number":5168,"context_line":"        # This is requested by set method."},{"line_number":5169,"context_line":"        # To avoid race condition, we use the same session here"},{"line_number":5170,"context_line":"        session_ctxt \u003d contextlib.suppress()"},{"line_number":5171,"context_line":"    else:"},{"line_number":5172,"context_line":"        session \u003d get_session()"},{"line_number":5173,"context_line":"        session_ctxt \u003d session.begin()"},{"line_number":5174,"context_line":"    with session_ctxt:"},{"line_number":5175,"context_line":"        if project_id:"},{"line_number":5176,"context_line":"            return model_query(context, models.DefaultVolumeTypes,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7edf33de_ca764423","side":"PARENT","line":5173,"range":{"start_line":5167,"start_character":0,"end_line":5173,"end_character":38},"updated":"2022-04-13 12:56:09.000000000","message":"This is no longer necessary because the get code has been pulled into a private function that will use the same context.session as the set function.","commit_id":"a3e4cc0301f9855cd21e490dcd5b7913dcab894d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7c21a0ee90f42311023a7238e902ddbda625c648","unresolved":false,"context_lines":[{"line_number":5164,"context_line":"    If a project id is passed, it returns default type for that particular"},{"line_number":5165,"context_line":"    project else returns default volume types for all projects"},{"line_number":5166,"context_line":"    \"\"\""},{"line_number":5167,"context_line":"    if session:"},{"line_number":5168,"context_line":"        # This is requested by set method."},{"line_number":5169,"context_line":"        # To avoid race condition, we use the same session here"},{"line_number":5170,"context_line":"        session_ctxt \u003d contextlib.suppress()"},{"line_number":5171,"context_line":"    else:"},{"line_number":5172,"context_line":"        session \u003d get_session()"},{"line_number":5173,"context_line":"        session_ctxt \u003d session.begin()"},{"line_number":5174,"context_line":"    with session_ctxt:"},{"line_number":5175,"context_line":"        if project_id:"},{"line_number":5176,"context_line":"            return model_query(context, models.DefaultVolumeTypes,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7675baaa_660d913e","side":"PARENT","line":5173,"range":{"start_line":5167,"start_character":0,"end_line":5173,"end_character":38},"in_reply_to":"7edf33de_ca764423","updated":"2022-05-31 07:55:31.000000000","message":"Ack","commit_id":"a3e4cc0301f9855cd21e490dcd5b7913dcab894d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"405c9dfc169834f69d1df3d9cc26c4cb57067dcf","unresolved":true,"context_lines":[{"line_number":414,"context_line":"        session \u003d context.session"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"    if not session:"},{"line_number":417,"context_line":"        session \u003d get_session()"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"    conditions \u003d [model.id \u003d\u003d resource_id]"},{"line_number":420,"context_line":"    # Match non deleted resources by the id"}],"source_content_type":"text/x-python","patch_set":1,"id":"dbd7fc71_439c36cb","line":417,"range":{"start_line":417,"start_character":18,"end_line":417,"end_character":31},"updated":"2022-05-27 08:35:55.000000000","message":"shouldn\u0027t this be session or get_session() ?\nIf some caller is still passing session, we should use that instead.\nThis will be invalidated once we modify all places calling this but till then this should keep the backward compatibility.","commit_id":"d0b0869d45defc72efaa6b11ed62ceed04cbbdc2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7c21a0ee90f42311023a7238e902ddbda625c648","unresolved":false,"context_lines":[{"line_number":414,"context_line":"        session \u003d context.session"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"    if not session:"},{"line_number":417,"context_line":"        session \u003d get_session()"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"    conditions \u003d [model.id \u003d\u003d resource_id]"},{"line_number":420,"context_line":"    # Match non deleted resources by the id"}],"source_content_type":"text/x-python","patch_set":1,"id":"e7d422f2_b0520baa","line":417,"range":{"start_line":417,"start_character":18,"end_line":417,"end_character":31},"in_reply_to":"186882ee_9aaecea9","updated":"2022-05-31 07:55:31.000000000","message":"my bad, I might have misread the code to only think that we are using context.session or get_session and not the passed session.","commit_id":"d0b0869d45defc72efaa6b11ed62ceed04cbbdc2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b763990ca005644e59137bd57d37077290755aab","unresolved":true,"context_lines":[{"line_number":414,"context_line":"        session \u003d context.session"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"    if not session:"},{"line_number":417,"context_line":"        session \u003d get_session()"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"    conditions \u003d [model.id \u003d\u003d resource_id]"},{"line_number":420,"context_line":"    # Match non deleted resources by the id"}],"source_content_type":"text/x-python","patch_set":1,"id":"186882ee_9aaecea9","line":417,"range":{"start_line":417,"start_character":18,"end_line":417,"end_character":31},"in_reply_to":"dbd7fc71_439c36cb","updated":"2022-05-30 13:48:37.000000000","message":"But isn\u0027t that what we\u0027re doing here?\n\n  if not x:\n      x \u003d y\n\n(i.e. what we\u0027ve done here) is identical to\n\n  x \u003d x or y\n\nRight?\n\nLater: unless you mean we should be preferring the passed in \u0027session\u0027 argument over context.session, in which case no. What we _should_ be doing is erroring out if both are provided (and in fact that\u0027s what I do elsewhere iirc) but this isn\u0027t a big issue since all this stuff is resolved later in the series","commit_id":"d0b0869d45defc72efaa6b11ed62ceed04cbbdc2"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ad8496bd0ebff5ade69f56b4d24497d99f056e09","unresolved":true,"context_lines":[{"line_number":4579,"context_line":"    # Generate the query"},{"line_number":4580,"context_line":"    query \u003d _generate_paginate_query("},{"line_number":4581,"context_line":"        context,"},{"line_number":4582,"context_line":"        None,"},{"line_number":4583,"context_line":"        marker,"},{"line_number":4584,"context_line":"        limit,"},{"line_number":4585,"context_line":"        sort_keys,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f3551e0_61e74510","line":4582,"range":{"start_line":4582,"start_character":8,"end_line":4582,"end_character":13},"updated":"2022-04-13 12:56:09.000000000","message":"This will be removed when _generate_paginate_query() has been updated.","commit_id":"d0b0869d45defc72efaa6b11ed62ceed04cbbdc2"}]}