)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9c6cefbb839775cac32dfcacbb3eeb0abed71e17","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a9a733a5_5d06c171","updated":"2022-04-13 13:19:49.000000000","message":"Follows the non-legacy-enginefacade pattern, LGTM.","commit_id":"8a6721de63bc88bac6530ddc51ed64c1e149e789"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6399fc9047be4a6b34a3d4ef86943e78cdaf6622","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a73a8b5d_55686907","updated":"2022-05-31 08:24:10.000000000","message":"LGTM","commit_id":"8a6721de63bc88bac6530ddc51ed64c1e149e789"}],"cinder/db/sqlalchemy/api.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6399fc9047be4a6b34a3d4ef86943e78cdaf6622","unresolved":true,"context_lines":[{"line_number":5706,"context_line":"                member[\u0027consumer\u0027] \u003d spec_dict.pop(\u0027consumer\u0027)"},{"line_number":5707,"context_line":"                if spec_dict.get(\u0027updated_at\u0027):"},{"line_number":5708,"context_line":"                    member[\u0027updated_at\u0027] \u003d spec_dict.pop(\u0027updated_at\u0027)"},{"line_number":5709,"context_line":"                member.update({\u0027specs\u0027: spec_dict})"},{"line_number":5710,"context_line":"            result.append(member)"},{"line_number":5711,"context_line":"    return result"},{"line_number":5712,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"48f1d7b8_84b6e81b","line":5709,"range":{"start_line":5709,"start_character":30,"end_line":5709,"end_character":40},"updated":"2022-05-31 08:24:10.000000000","message":"does black even change the way we define type of variable?","commit_id":"8a6721de63bc88bac6530ddc51ed64c1e149e789"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5eda6a5bce31bf3b1126b1534494b84cf1d80c14","unresolved":false,"context_lines":[{"line_number":5706,"context_line":"                member[\u0027consumer\u0027] \u003d spec_dict.pop(\u0027consumer\u0027)"},{"line_number":5707,"context_line":"                if spec_dict.get(\u0027updated_at\u0027):"},{"line_number":5708,"context_line":"                    member[\u0027updated_at\u0027] \u003d spec_dict.pop(\u0027updated_at\u0027)"},{"line_number":5709,"context_line":"                member.update({\u0027specs\u0027: spec_dict})"},{"line_number":5710,"context_line":"            result.append(member)"},{"line_number":5711,"context_line":"    return result"},{"line_number":5712,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bb945db8_9267960d","line":5709,"range":{"start_line":5709,"start_character":30,"end_line":5709,"end_character":40},"in_reply_to":"48f1d7b8_84b6e81b","updated":"2022-05-31 11:29:11.000000000","message":"I suspect this one was me 😇","commit_id":"8a6721de63bc88bac6530ddc51ed64c1e149e789"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6399fc9047be4a6b34a3d4ef86943e78cdaf6622","unresolved":true,"context_lines":[{"line_number":5777,"context_line":"# TODO: Remove \u0027session\u0027 argument when all of the \u0027_get_query\u0027 helpers are"},{"line_number":5778,"context_line":"# converted"},{"line_number":5779,"context_line":"@require_admin_context"},{"line_number":5780,"context_line":"def _qos_specs_get_query(context, session\u003dNone):"},{"line_number":5781,"context_line":"    rows \u003d ("},{"line_number":5782,"context_line":"        model_query("},{"line_number":5783,"context_line":"            context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5514d762_3af4132d","line":5780,"range":{"start_line":5780,"start_character":34,"end_line":5780,"end_character":46},"updated":"2022-05-31 08:24:10.000000000","message":"are there places in future patches which are calling _qos_specs_get_query without the session parameter? That\u0027s the ultimate goal to not pass session but don\u0027t understand why we\u0027ve set the default\u003dNone in this patch.","commit_id":"8a6721de63bc88bac6530ddc51ed64c1e149e789"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5eda6a5bce31bf3b1126b1534494b84cf1d80c14","unresolved":false,"context_lines":[{"line_number":5777,"context_line":"# TODO: Remove \u0027session\u0027 argument when all of the \u0027_get_query\u0027 helpers are"},{"line_number":5778,"context_line":"# converted"},{"line_number":5779,"context_line":"@require_admin_context"},{"line_number":5780,"context_line":"def _qos_specs_get_query(context, session\u003dNone):"},{"line_number":5781,"context_line":"    rows \u003d ("},{"line_number":5782,"context_line":"        model_query("},{"line_number":5783,"context_line":"            context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"76b977e7_59413f74","line":5780,"range":{"start_line":5780,"start_character":34,"end_line":5780,"end_character":46},"in_reply_to":"5514d762_3af4132d","updated":"2022-05-31 11:29:11.000000000","message":"I\u0027d say this was an thing introduced while I was hacking on it and trying to get it working. It\u0027s harmless though certainly unnecessary. We remove it later in the series [1]\n\n[1] https://review.opendev.org/c/openstack/cinder/+/837539/3/cinder/db/sqlalchemy/api.py#5773","commit_id":"8a6721de63bc88bac6530ddc51ed64c1e149e789"}]}
