)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"19dfbcdc43ff513ae1563f4f89f9f05933f7ec8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d477d9e6_5e0bd75c","updated":"2022-04-14 01:31:24.000000000","message":"I think you may have missed a reader decorator, otherwise this looks fine.","commit_id":"630e10e5441dbb989ca5d77da30182c5032b6b12"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"049d63c5066259ae696af9bfde2b7f732ba6b520","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"de3fce25_c0e2133f","updated":"2022-04-19 13:29:59.000000000","message":"My issue is fixed in a later patch in the series (see Stephen\u0027s note inline), so this looks good to me.","commit_id":"630e10e5441dbb989ca5d77da30182c5032b6b12"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a1f0d8b9d3cf1ec435f5ee90f8f1a089c7e7f089","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6d55a8d2_e370e6df","updated":"2022-06-02 05:56:53.000000000","message":"There is one method that is missing context manager but it is fixed later in the series so LGTM.","commit_id":"630e10e5441dbb989ca5d77da30182c5032b6b12"}],"cinder/db/sqlalchemy/api.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"19dfbcdc43ff513ae1563f4f89f9f05933f7ec8c","unresolved":true,"context_lines":[{"line_number":6737,"context_line":"    return _translate_transfers(query.all())"},{"line_number":6738,"context_line":""},{"line_number":6739,"context_line":""},{"line_number":6740,"context_line":"@require_admin_context"},{"line_number":6741,"context_line":"def transfer_get_all("},{"line_number":6742,"context_line":"    context,"},{"line_number":6743,"context_line":"    marker\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"79556497_e3f20bf2","line":6740,"updated":"2022-04-14 01:31:24.000000000","message":"do we want\n\n  @main_context_manager.reader\n\nhere?","commit_id":"630e10e5441dbb989ca5d77da30182c5032b6b12"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"725165f5fa8b4aa075af9b5ee3e21e97d9406657","unresolved":true,"context_lines":[{"line_number":6737,"context_line":"    return _translate_transfers(query.all())"},{"line_number":6738,"context_line":""},{"line_number":6739,"context_line":""},{"line_number":6740,"context_line":"@require_admin_context"},{"line_number":6741,"context_line":"def transfer_get_all("},{"line_number":6742,"context_line":"    context,"},{"line_number":6743,"context_line":"    marker\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"f5a1bc76_a65540b4","line":6740,"in_reply_to":"79556497_e3f20bf2","updated":"2022-04-14 10:31:31.000000000","message":"We do, but I clearly spotted this after the fact because it is fixed later in the series [1]. Weird that I never brought it back 🤷‍♂️ Do you want me to do so now or is fixing it in the later patch okay? fwiw, this is still working here because we have the fallback in \u0027model_query\u0027 for a session value of \u0027None\u0027 (this is being called via \u0027_generate_paginate_query\u0027 -\u003e \u0027_transfer_get_query\u0027 (via \u0027PAGINATION_HELPERS\u0027 lookup) so I\u0027m not introducing a bug here per se.\n\n[1] https://review.opendev.org/c/openstack/cinder/+/837539/1/cinder/db/sqlalchemy/api.py#6731","commit_id":"630e10e5441dbb989ca5d77da30182c5032b6b12"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"882ed34e34da6fbfb4126f1e546dcceae5004d4c","unresolved":false,"context_lines":[{"line_number":6737,"context_line":"    return _translate_transfers(query.all())"},{"line_number":6738,"context_line":""},{"line_number":6739,"context_line":""},{"line_number":6740,"context_line":"@require_admin_context"},{"line_number":6741,"context_line":"def transfer_get_all("},{"line_number":6742,"context_line":"    context,"},{"line_number":6743,"context_line":"    marker\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"15205363_65421333","line":6740,"in_reply_to":"f5a1bc76_a65540b4","updated":"2022-04-14 10:32:28.000000000","message":"Yeah, I missed another one earlier in the series too [1]. Similarly not an issue.\n\nI think they\u0027re both okay so I\u0027m going to mark this as resolved\n\n[1] https://review.opendev.org/c/openstack/cinder/+/830093","commit_id":"630e10e5441dbb989ca5d77da30182c5032b6b12"}]}