)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"dabfbb184f1cc637bd6e2ff6311886be3def507e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ad2036d8_207f67a9","updated":"2022-04-19 13:27:50.000000000","message":"As Stephen points out, the issue I identified is actually addressed in the next patch, so this one LGTM.","commit_id":"1435349ee527fd59c1fc0399e7e315f67913e413"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"42738a3eee76a6a94550cda30770f6931e80b898","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e14cf465_b70b5455","updated":"2022-04-14 10:25:56.000000000","message":"I think we\u0027re good here","commit_id":"1435349ee527fd59c1fc0399e7e315f67913e413"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"44aa769704686479293f3b5859b1613f05fcab06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fb36b1c4_57c29edc","updated":"2022-04-14 01:47:45.000000000","message":"I think you missed a writer decorator, otherwise LGTM.","commit_id":"1435349ee527fd59c1fc0399e7e315f67913e413"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"386620165b53804ca717e69e601c0daf16858f60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"752afbfc_a890bc23","updated":"2022-06-02 08:08:50.000000000","message":"LGTM","commit_id":"1435349ee527fd59c1fc0399e7e315f67913e413"}],"cinder/db/sqlalchemy/api.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"44aa769704686479293f3b5859b1613f05fcab06","unresolved":true,"context_lines":[{"line_number":7259,"context_line":""},{"line_number":7260,"context_line":""},{"line_number":7261,"context_line":"@require_admin_context"},{"line_number":7262,"context_line":"def group_include_in_cluster(context, cluster, partial_rename\u003dTrue, **filters):"},{"line_number":7263,"context_line":"    \"\"\"Include all generic groups matching the filters into a cluster.\"\"\""},{"line_number":7264,"context_line":"    return _include_in_cluster(context, cluster, models.Group, partial_rename,"},{"line_number":7265,"context_line":"                               filters)"}],"source_content_type":"text/x-python","patch_set":1,"id":"db90fdf4_c41a2d39","side":"PARENT","line":7262,"updated":"2022-04-14 01:47:45.000000000","message":"Moved to line 7662.","commit_id":"630e10e5441dbb989ca5d77da30182c5032b6b12"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"42738a3eee76a6a94550cda30770f6931e80b898","unresolved":false,"context_lines":[{"line_number":7259,"context_line":""},{"line_number":7260,"context_line":""},{"line_number":7261,"context_line":"@require_admin_context"},{"line_number":7262,"context_line":"def group_include_in_cluster(context, cluster, partial_rename\u003dTrue, **filters):"},{"line_number":7263,"context_line":"    \"\"\"Include all generic groups matching the filters into a cluster.\"\"\""},{"line_number":7264,"context_line":"    return _include_in_cluster(context, cluster, models.Group, partial_rename,"},{"line_number":7265,"context_line":"                               filters)"}],"source_content_type":"text/x-python","patch_set":1,"id":"f1a05705_986c9041","side":"PARENT","line":7262,"in_reply_to":"db90fdf4_c41a2d39","updated":"2022-04-14 10:25:56.000000000","message":"Yeah, I\u0027ve attempted to ensure all operations on models.Foo are grouped together. It seems sane","commit_id":"630e10e5441dbb989ca5d77da30182c5032b6b12"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"44aa769704686479293f3b5859b1613f05fcab06","unresolved":true,"context_lines":[{"line_number":7658,"context_line":"    return sql.exists([subq]).where(match_id)"},{"line_number":7659,"context_line":""},{"line_number":7660,"context_line":""},{"line_number":7661,"context_line":"@require_admin_context"},{"line_number":7662,"context_line":"def group_include_in_cluster(context, cluster, partial_rename\u003dTrue, **filters):"},{"line_number":7663,"context_line":"    \"\"\"Include all generic groups matching the filters into a cluster.\"\"\""},{"line_number":7664,"context_line":"    return _include_in_cluster(context, cluster, models.Group, partial_rename,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ac8f6a66_2a2a43cb","line":7661,"updated":"2022-04-14 01:47:45.000000000","message":"Do we need\n\n  @main_context_manager.writer\n\nhere?","commit_id":"1435349ee527fd59c1fc0399e7e315f67913e413"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"42738a3eee76a6a94550cda30770f6931e80b898","unresolved":false,"context_lines":[{"line_number":7658,"context_line":"    return sql.exists([subq]).where(match_id)"},{"line_number":7659,"context_line":""},{"line_number":7660,"context_line":""},{"line_number":7661,"context_line":"@require_admin_context"},{"line_number":7662,"context_line":"def group_include_in_cluster(context, cluster, partial_rename\u003dTrue, **filters):"},{"line_number":7663,"context_line":"    \"\"\"Include all generic groups matching the filters into a cluster.\"\"\""},{"line_number":7664,"context_line":"    return _include_in_cluster(context, cluster, models.Group, partial_rename,"}],"source_content_type":"text/x-python","patch_set":1,"id":"8b2d2e7d_f281fbb7","line":7661,"in_reply_to":"ac8f6a66_2a2a43cb","updated":"2022-04-14 10:25:56.000000000","message":"We do but not yet. I\u0027m not actually converting this here. I\u0027m simply moving it to regroup it with it\u0027s own kind. We convert this in the next patch in the series [1]\n\n[1] https://review.opendev.org/c/openstack/cinder/+/837530/1/cinder/db/sqlalchemy/api.py#7724","commit_id":"1435349ee527fd59c1fc0399e7e315f67913e413"}]}