)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5ea227d79ff2c6b949f84f17e44cf51b3ac136ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"18f1cbf4_7b1ffcd3","updated":"2022-04-14 16:10:42.000000000","message":"Follows the non-legacy-enginefacade pattern, LGTM.","commit_id":"2727029bc67dd88af51e94debe75804f776f9f24"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f4ce1f54aa6f49b6f1486a813c564ebbb03da6ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ed25f641_554b80a4","updated":"2022-06-08 09:12:42.000000000","message":"LGTM","commit_id":"2727029bc67dd88af51e94debe75804f776f9f24"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e6ff59327dbf7d877ecc4e10a1c58e2d1101ae5e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"01a94ee5_6c55c071","updated":"2022-04-13 22:23:00.000000000","message":"recheck cinder-tempest-plugin-lvm-lio-barbican - tempest.api.compute.volumes.test_attach_volume.AttachVolumeTestJSON timeout waiting for volume","commit_id":"2727029bc67dd88af51e94debe75804f776f9f24"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d0a0514ce1ef1f046d2406db8cf0bb1077ad8fc7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f61491a4_a7baffb8","updated":"2022-04-14 13:43:53.000000000","message":"recheck tempest-slow-py3 - tempest.scenario.test_network_advanced_server_ops.TestNetworkAdvancedServerOps.test_server_connectivity_cold_migration timeout : Server b3e9a09a-dc5c-4111-a4c2-397e0d41cc2b failed to reach VERIFY_RESIZE status ","commit_id":"2727029bc67dd88af51e94debe75804f776f9f24"}],"cinder/db/sqlalchemy/api.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f4ce1f54aa6f49b6f1486a813c564ebbb03da6ee","unresolved":true,"context_lines":[{"line_number":8725,"context_line":""},{"line_number":8726,"context_line":""},{"line_number":8727,"context_line":"# TODO: (Y Release) remove method and this comment"},{"line_number":8728,"context_line":"@enginefacade.writer"},{"line_number":8729,"context_line":"def use_quota_online_data_migration(context, max_count,"},{"line_number":8730,"context_line":"                                    resource_name, calculate_use_quota):"},{"line_number":8731,"context_line":"    updated \u003d 0"}],"source_content_type":"text/x-python","patch_set":1,"id":"b706217d_96d0e4fb","side":"PARENT","line":8728,"range":{"start_line":8728,"start_character":0,"end_line":8728,"end_character":20},"updated":"2022-06-08 09:12:42.000000000","message":"IIUC this is removed because the calls to this method are from volume_use_quota_online_data_migration and snapshot_use_quota_online_data_migration methods which already have the writer decorator.","commit_id":"8c65f4b6c29b2f33f0cfc0e93cb1295cd4a5d177"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5ea227d79ff2c6b949f84f17e44cf51b3ac136ff","unresolved":true,"context_lines":[{"line_number":509,"context_line":"    \"\"\""},{"line_number":510,"context_line":"    result \u003d ~condition_db_filter(model, field, value)"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"    if auto_none and ("},{"line_number":513,"context_line":"        ("},{"line_number":514,"context_line":"            isinstance(value, abc.Iterable)"},{"line_number":515,"context_line":"            and not isinstance(value, str)"},{"line_number":516,"context_line":"            and None not in value"},{"line_number":517,"context_line":"        )"},{"line_number":518,"context_line":"        or (value is not None)"},{"line_number":519,"context_line":"    ):"},{"line_number":520,"context_line":"        orm_field \u003d getattr(model, field)"},{"line_number":521,"context_line":"        result \u003d or_(result, orm_field.is_(None))"},{"line_number":522,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"82a15823_0e19394d","line":519,"range":{"start_line":512,"start_character":0,"end_line":519,"end_character":6},"updated":"2022-04-14 16:10:42.000000000","message":"Nit: I think the original formatting was a bit more visually perspicuous about how the logical connectives hang together here.  If you have to put up another patch set, how about:\n\n    if (auto_none\n        and ((isinstance(value, abc.Iterable)\n              and not isinstance(value, str)\n              and None not in value)\n             or (value is not None)\n             )\n        ):","commit_id":"2727029bc67dd88af51e94debe75804f776f9f24"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a83ed38e05135b1e01b2768ad61be7a97512b3bb","unresolved":false,"context_lines":[{"line_number":509,"context_line":"    \"\"\""},{"line_number":510,"context_line":"    result \u003d ~condition_db_filter(model, field, value)"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"    if auto_none and ("},{"line_number":513,"context_line":"        ("},{"line_number":514,"context_line":"            isinstance(value, abc.Iterable)"},{"line_number":515,"context_line":"            and not isinstance(value, str)"},{"line_number":516,"context_line":"            and None not in value"},{"line_number":517,"context_line":"        )"},{"line_number":518,"context_line":"        or (value is not None)"},{"line_number":519,"context_line":"    ):"},{"line_number":520,"context_line":"        orm_field \u003d getattr(model, field)"},{"line_number":521,"context_line":"        result \u003d or_(result, orm_field.is_(None))"},{"line_number":522,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"24d3355a_0f40c126","line":519,"range":{"start_line":512,"start_character":0,"end_line":519,"end_character":6},"in_reply_to":"82a15823_0e19394d","updated":"2022-04-14 18:08:12.000000000","message":"That\u0027s fair. However, I didn\u0027t write any of this. I just ran all the code I was modifying through \u0027black\u0027 because I couldn\u0027t be a****d fixing formatting 😇","commit_id":"2727029bc67dd88af51e94debe75804f776f9f24"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"28bcee844d945c3cdf519d057b264e6c13d671ee","unresolved":true,"context_lines":[{"line_number":8192,"context_line":"    enable_replication,"},{"line_number":8193,"context_line":"    active_backend_id,"},{"line_number":8194,"context_line":"    backend_host,"},{"line_number":8195,"context_line":"):"},{"line_number":8196,"context_line":""},{"line_number":8197,"context_line":"    service \u003d objects.Service.get_by_host_and_topic("},{"line_number":8198,"context_line":"        context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"e4c7124a_5c5f6837","line":8195,"updated":"2022-06-01 20:45:26.000000000","message":"I really despise black\u0027s formatting of functions like this.  \n\n\nCan we undo all of the formatting changes in this file.   If you really want to adjust cinder\u0027s formatting to use black, then propose a specific change for that.","commit_id":"2727029bc67dd88af51e94debe75804f776f9f24"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f4ce1f54aa6f49b6f1486a813c564ebbb03da6ee","unresolved":false,"context_lines":[{"line_number":8192,"context_line":"    enable_replication,"},{"line_number":8193,"context_line":"    active_backend_id,"},{"line_number":8194,"context_line":"    backend_host,"},{"line_number":8195,"context_line":"):"},{"line_number":8196,"context_line":""},{"line_number":8197,"context_line":"    service \u003d objects.Service.get_by_host_and_topic("},{"line_number":8198,"context_line":"        context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"f0149b4e_b08db621","line":8195,"in_reply_to":"b829b0f5_56def330","updated":"2022-06-08 09:12:42.000000000","message":"This has been discussed several times during the life of reviewing this patch series. Everyone in the cinder has concerns with black\u0027s formatting (me as well) and the general consensus is we don\u0027t want it in cinder but we\u0027ve given the exception to these patches as we\u0027ve a 34 patch series which will require a lot of rework and not to mention the load on CI when this series is rebased. Most of the patches are merged now so there is no point in blocking it at this point but we will discuss this again after the main work of moving towards context based session is in place which should be the main focus while reviewing this series.","commit_id":"2727029bc67dd88af51e94debe75804f776f9f24"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3bf8230fe82b46c025dce7f86274716815c149eb","unresolved":false,"context_lines":[{"line_number":8192,"context_line":"    enable_replication,"},{"line_number":8193,"context_line":"    active_backend_id,"},{"line_number":8194,"context_line":"    backend_host,"},{"line_number":8195,"context_line":"):"},{"line_number":8196,"context_line":""},{"line_number":8197,"context_line":"    service \u003d objects.Service.get_by_host_and_topic("},{"line_number":8198,"context_line":"        context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"b829b0f5_56def330","line":8195,"in_reply_to":"e4c7124a_5c5f6837","updated":"2022-06-07 09:40:06.000000000","message":"I\u0027d really rather not open that can of worms. This was an extremely tedious series to produce (I guess that\u0027s why it hadn\u0027t been done before now) and having to manually fix formatting issues would have made it even more tedious. I didn\u0027t want more tediousness, naturally 😄 I\u0027ve no particular affinity for black but it made my life easier so hopefully we can just hold our noses and focus on the fact that this work is finally done 🎉","commit_id":"2727029bc67dd88af51e94debe75804f776f9f24"}]}