)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"82b99c5bae0964a71fa42daba02f60e03a80f39e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4aa8843f_530ae8c5","updated":"2022-04-13 22:24:09.000000000","message":"recheck cinder-tempest-plugin-lvm-lio-barbican - failure during job setup","commit_id":"ee580e86cf14d5c498a7b9da6ab1576ca2a1d06e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"70edfce4db5051987d2aee9671050db6bef35f1b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0b973b4c_d33abbb2","updated":"2022-04-14 19:06:03.000000000","message":"It\u0027s like you were reading my mind, the latest patch set addresses my only concerns about PS1.  So LGTM.","commit_id":"62ade4243edf8d9c732ccbe34d3d05aae242b52d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0fca10167458d9dc5262403d31d99d94ff242c6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ef63c435_161af000","updated":"2022-06-08 09:27:17.000000000","message":"LGTM","commit_id":"62ade4243edf8d9c732ccbe34d3d05aae242b52d"}],"cinder/db/sqlalchemy/api.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"966f45bafc3510cdef3fc0c65bc96fcce17926bd","unresolved":true,"context_lines":[{"line_number":169,"context_line":"            raise exception.AdminRequired()"},{"line_number":170,"context_line":"        return f(*args, **kwargs)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    wrapper.__signature__ \u003d inspect.signature(f)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    return wrapper"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"764832b2_5ab25070","line":172,"updated":"2022-06-08 09:54:07.000000000","message":"I can probably remove this now that we are using \u0027functools.wraps\u0027","commit_id":"ee580e86cf14d5c498a7b9da6ab1576ca2a1d06e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"70edfce4db5051987d2aee9671050db6bef35f1b","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            raise exception.AdminRequired()"},{"line_number":170,"context_line":"        return f(*args, **kwargs)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    wrapper.__signature__ \u003d inspect.signature(f)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    return wrapper"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"294e9dd7_580a396f","line":172,"range":{"start_line":172,"start_character":4,"end_line":172,"end_character":48},"updated":"2022-04-14 19:06:03.000000000","message":"I just realized that https://review.opendev.org/c/openstack/cinder/+/832854 was never merged.  If you need to revise this patch, you can go ahead and remove setting the __sig__ here and in the next function, and I\u0027ll abandon the other patch.  (I don\u0027t think the unit test there adds much value, tbh.)","commit_id":"ee580e86cf14d5c498a7b9da6ab1576ca2a1d06e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5d6c6137ffd2a0723a184736ae91710aa565a8b3","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            raise exception.AdminRequired()"},{"line_number":170,"context_line":"        return f(*args, **kwargs)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    wrapper.__signature__ \u003d inspect.signature(f)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    return wrapper"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"2b07bb30_65b8d4ab","line":172,"in_reply_to":"764832b2_5ab25070","updated":"2022-06-08 09:54:29.000000000","message":"Done","commit_id":"ee580e86cf14d5c498a7b9da6ab1576ca2a1d06e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"966f45bafc3510cdef3fc0c65bc96fcce17926bd","unresolved":true,"context_lines":[{"line_number":191,"context_line":"            raise exception.NotAuthorized()"},{"line_number":192,"context_line":"        return f(*args, **kwargs)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    wrapper.__signature__ \u003d inspect.signature(f)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    return wrapper"},{"line_number":197,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ca8810a3_09a1e382","line":194,"updated":"2022-06-08 09:54:07.000000000","message":"ditto","commit_id":"ee580e86cf14d5c498a7b9da6ab1576ca2a1d06e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5d6c6137ffd2a0723a184736ae91710aa565a8b3","unresolved":false,"context_lines":[{"line_number":191,"context_line":"            raise exception.NotAuthorized()"},{"line_number":192,"context_line":"        return f(*args, **kwargs)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    wrapper.__signature__ \u003d inspect.signature(f)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    return wrapper"},{"line_number":197,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"f0ee2ed3_11a56411","line":194,"in_reply_to":"ca8810a3_09a1e382","updated":"2022-06-08 09:54:29.000000000","message":"Done","commit_id":"ee580e86cf14d5c498a7b9da6ab1576ca2a1d06e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"70edfce4db5051987d2aee9671050db6bef35f1b","unresolved":false,"context_lines":[{"line_number":223,"context_line":"            raise exception.VolumeNotFound(volume_id\u003dvolume_id)"},{"line_number":224,"context_line":"        return f(context, volume_id, *args, **kwargs)"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    wrapper.__signature__ \u003d inspect.signature(f)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    return wrapper"},{"line_number":229,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ca1f8c50_40a98295","line":226,"range":{"start_line":226,"start_character":4,"end_line":226,"end_character":48},"updated":"2022-04-14 19:06:03.000000000","message":"I think that https://review.opendev.org/c/openstack/cinder/+/832854 shows that you don\u0027t need to add this for any of the functions decorated with @functools.wraps()","commit_id":"ee580e86cf14d5c498a7b9da6ab1576ca2a1d06e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"966f45bafc3510cdef3fc0c65bc96fcce17926bd","unresolved":true,"context_lines":[{"line_number":223,"context_line":"            raise exception.VolumeNotFound(volume_id\u003dvolume_id)"},{"line_number":224,"context_line":"        return f(context, volume_id, *args, **kwargs)"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    wrapper.__signature__ \u003d inspect.signature(f)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    return wrapper"},{"line_number":229,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ca7c4925_2a6af6eb","line":226,"updated":"2022-06-08 09:54:07.000000000","message":"not necessary","commit_id":"ee580e86cf14d5c498a7b9da6ab1576ca2a1d06e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5d6c6137ffd2a0723a184736ae91710aa565a8b3","unresolved":false,"context_lines":[{"line_number":223,"context_line":"            raise exception.VolumeNotFound(volume_id\u003dvolume_id)"},{"line_number":224,"context_line":"        return f(context, volume_id, *args, **kwargs)"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    wrapper.__signature__ \u003d inspect.signature(f)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    return wrapper"},{"line_number":229,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9b8c1f91_43b67944","line":226,"in_reply_to":"ca7c4925_2a6af6eb","updated":"2022-06-08 09:54:29.000000000","message":"Done","commit_id":"ee580e86cf14d5c498a7b9da6ab1576ca2a1d06e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"966f45bafc3510cdef3fc0c65bc96fcce17926bd","unresolved":true,"context_lines":[{"line_number":241,"context_line":"            raise exception.SnapshotNotFound(snapshot_id\u003dsnapshot_id)"},{"line_number":242,"context_line":"        return f(context, snapshot_id, *args, **kwargs)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    wrapper.__signature__ \u003d inspect.signature(f)"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    return wrapper"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"b40042d0_1aacc7b3","line":244,"updated":"2022-06-08 09:54:07.000000000","message":"ditto","commit_id":"ee580e86cf14d5c498a7b9da6ab1576ca2a1d06e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5d6c6137ffd2a0723a184736ae91710aa565a8b3","unresolved":false,"context_lines":[{"line_number":241,"context_line":"            raise exception.SnapshotNotFound(snapshot_id\u003dsnapshot_id)"},{"line_number":242,"context_line":"        return f(context, snapshot_id, *args, **kwargs)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    wrapper.__signature__ \u003d inspect.signature(f)"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    return wrapper"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bb6ee00d_1874d8c7","line":244,"in_reply_to":"b40042d0_1aacc7b3","updated":"2022-06-08 09:54:29.000000000","message":"Done","commit_id":"ee580e86cf14d5c498a7b9da6ab1576ca2a1d06e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"966f45bafc3510cdef3fc0c65bc96fcce17926bd","unresolved":true,"context_lines":[{"line_number":259,"context_line":"            raise exception.BackupNotFound(backup_id\u003dbackup_id)"},{"line_number":260,"context_line":"        return f(context, backup_id, *args, **kwargs)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    wrapper.__signature__ \u003d inspect.signature(f)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    return wrapper"},{"line_number":265,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"08898f6c_470ec55a","line":262,"updated":"2022-06-08 09:54:07.000000000","message":"ditto","commit_id":"ee580e86cf14d5c498a7b9da6ab1576ca2a1d06e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5d6c6137ffd2a0723a184736ae91710aa565a8b3","unresolved":false,"context_lines":[{"line_number":259,"context_line":"            raise exception.BackupNotFound(backup_id\u003dbackup_id)"},{"line_number":260,"context_line":"        return f(context, backup_id, *args, **kwargs)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    wrapper.__signature__ \u003d inspect.signature(f)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    return wrapper"},{"line_number":265,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"b0ac80d9_86ffaa65","line":262,"in_reply_to":"08898f6c_470ec55a","updated":"2022-06-08 09:54:29.000000000","message":"Done","commit_id":"ee580e86cf14d5c498a7b9da6ab1576ca2a1d06e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"966f45bafc3510cdef3fc0c65bc96fcce17926bd","unresolved":true,"context_lines":[{"line_number":281,"context_line":"            raise exception.QoSSpecsNotFound(specs_id\u003dqos_specs_id)"},{"line_number":282,"context_line":"        return f(context, qos_specs_id, *args, **kwargs)"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    wrapper.__signature__ \u003d inspect.signature(f)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    return wrapper"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"f261bda7_28f15c59","line":284,"updated":"2022-06-08 09:54:07.000000000","message":"ditto","commit_id":"ee580e86cf14d5c498a7b9da6ab1576ca2a1d06e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5d6c6137ffd2a0723a184736ae91710aa565a8b3","unresolved":false,"context_lines":[{"line_number":281,"context_line":"            raise exception.QoSSpecsNotFound(specs_id\u003dqos_specs_id)"},{"line_number":282,"context_line":"        return f(context, qos_specs_id, *args, **kwargs)"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    wrapper.__signature__ \u003d inspect.signature(f)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    return wrapper"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ada4cfaa_cb4ffe0b","line":284,"in_reply_to":"f261bda7_28f15c59","updated":"2022-06-08 09:54:29.000000000","message":"Done","commit_id":"ee580e86cf14d5c498a7b9da6ab1576ca2a1d06e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0fca10167458d9dc5262403d31d99d94ff242c6f","unresolved":true,"context_lines":[{"line_number":2759,"context_line":"        sort_dirs,"},{"line_number":2760,"context_line":"        filters,"},{"line_number":2761,"context_line":"        offset,"},{"line_number":2762,"context_line":"        models.Volume,"},{"line_number":2763,"context_line":"    )"},{"line_number":2764,"context_line":"    # No volumes would match, return empty list"},{"line_number":2765,"context_line":"    if query is None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"b4b5b03e_643698bb","line":2762,"range":{"start_line":2762,"start_character":8,"end_line":2762,"end_character":22},"updated":"2022-06-08 09:27:17.000000000","message":"not needed as this is the default","commit_id":"62ade4243edf8d9c732ccbe34d3d05aae242b52d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0fca10167458d9dc5262403d31d99d94ff242c6f","unresolved":true,"context_lines":[{"line_number":2936,"context_line":"        sort_dirs,"},{"line_number":2937,"context_line":"        filters,"},{"line_number":2938,"context_line":"        offset,"},{"line_number":2939,"context_line":"        models.Volume,"},{"line_number":2940,"context_line":"    )"},{"line_number":2941,"context_line":"    # No volumes would match, return empty list"},{"line_number":2942,"context_line":"    if query is None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"6b9d8191_252f2d4b","line":2939,"range":{"start_line":2939,"start_character":8,"end_line":2939,"end_character":22},"updated":"2022-06-08 09:27:17.000000000","message":"not needed as this is the default","commit_id":"62ade4243edf8d9c732ccbe34d3d05aae242b52d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"966f45bafc3510cdef3fc0c65bc96fcce17926bd","unresolved":true,"context_lines":[{"line_number":2936,"context_line":"        sort_dirs,"},{"line_number":2937,"context_line":"        filters,"},{"line_number":2938,"context_line":"        offset,"},{"line_number":2939,"context_line":"        models.Volume,"},{"line_number":2940,"context_line":"    )"},{"line_number":2941,"context_line":"    # No volumes would match, return empty list"},{"line_number":2942,"context_line":"    if query is None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"53753b6d_e305ce03","line":2939,"range":{"start_line":2939,"start_character":8,"end_line":2939,"end_character":22},"in_reply_to":"6b9d8191_252f2d4b","updated":"2022-06-08 09:54:07.000000000","message":"Good point. We should probably drop the default because there\u0027s no reason for it to be a default.","commit_id":"62ade4243edf8d9c732ccbe34d3d05aae242b52d"}]}