)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"be3ec5cf7f523856d1c3c709dbc3aff238a3b6cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"10e0d65b_29f56201","updated":"2022-04-19 13:01:39.000000000","message":"I\u0027ll ask people to look at this during the cinder meeting on Wednesday.  I don\u0027t think that will hold anything up since somewhere around 30 patches need to merge before this one!","commit_id":"f2aa53a503792ccc33ed3dd68af5dad4364d34d4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"30f0bae94f3f12d7f71000e42c836e785cae9337","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"13ff7410_27223030","updated":"2022-04-14 21:11:32.000000000","message":"I\u0027m not sold on some of the changes in db/api.py, but if you disagree, we can see what other reviewers think.  I still need to review db/sqlalchemy/api.py.","commit_id":"f2aa53a503792ccc33ed3dd68af5dad4364d34d4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8554690d715b7b48856d96d5ec83d189fa4dd0a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a5deebf8_8f3b7793","updated":"2022-04-14 22:50:47.000000000","message":"Reviewed db/sqlalchemy/api.py, looks good, only issue is related to a comment in db/api.py.","commit_id":"f2aa53a503792ccc33ed3dd68af5dad4364d34d4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"defbf8b0f860f5047e20e334c603f89af9117fce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f2bb19ea_d99c3f38","updated":"2022-04-26 14:02:47.000000000","message":"Updated my responses.","commit_id":"f2aa53a503792ccc33ed3dd68af5dad4364d34d4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0f12caf4d51f8b3da534354de651ce53b8296c1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b2dbb0cf_e4d89f46","updated":"2022-04-14 21:14:32.000000000","message":"recheck tempest-integrated-storage - tempest.api.compute.images.test_images_negative.ImagesNegativeTestJSON.test_create_image_from_deleted_server : test server failed to build","commit_id":"f2aa53a503792ccc33ed3dd68af5dad4364d34d4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"260c6527fc7b6da26f75113f86597e647a1b05b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e76c7e0e_71a6a440","updated":"2022-07-29 10:57:08.000000000","message":"recheck unrelated failures","commit_id":"e16aefb1ad4e05c7684da316960e9c1a56fad170"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a75550a67c92630c8b80c12a8390201278fce389","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"195765d8_eba43200","updated":"2023-03-29 15:20:05.000000000","message":"Working from my PS3 comments, the revisions LGTM.","commit_id":"4194d0ac51e0fc320f58d4a1126da26be36a4f38"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"abded55cd78c69ab72f525e4220c2a6559fad3c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"471dc719_6cfd4d5f","updated":"2023-05-09 08:51:02.000000000","message":"Few questions inline but overall changes looks good to me.","commit_id":"e9f2c711e9fc6004c91680504f0f68ceababffb0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b3717dd6af6c740dba14826ed0dfd99a02f9310d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"42ce084d_10db290d","updated":"2023-05-09 12:44:52.000000000","message":"recheck tempest timeout","commit_id":"e9f2c711e9fc6004c91680504f0f68ceababffb0"}],"cinder/api/v3/messages.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"30f0bae94f3f12d7f71000e42c836e785cae9337","unresolved":true,"context_lines":[{"line_number":70,"context_line":"        # Not found exception will be handled at the wsgi level"},{"line_number":71,"context_line":"        message \u003d self.message_api.get(context, id)"},{"line_number":72,"context_line":"        context.authorize(policy.DELETE_POLICY, target_obj\u003dmessage)"},{"line_number":73,"context_line":"        self.message_api.delete(context, id)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        return webob.Response(status_int\u003dHTTPStatus.NO_CONTENT)"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"411faeed_32eaa469","line":73,"range":{"start_line":73,"start_character":40,"end_line":73,"end_character":43},"updated":"2022-04-14 21:11:32.000000000","message":"I was going to say this is a bad bug, but I see that the sqlalchemy.db.api was ignoring the db.api signature for this function and assumed it was receiving a message object (and I see you\u0027ve made the corresponding change in sqlalchemy.db.api.message_destroy).  I think respecting the defined interface is the correct choice.","commit_id":"f2aa53a503792ccc33ed3dd68af5dad4364d34d4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1966cf497061c2979d06d747c5c248fa6c00043a","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        # Not found exception will be handled at the wsgi level"},{"line_number":71,"context_line":"        message \u003d self.message_api.get(context, id)"},{"line_number":72,"context_line":"        context.authorize(policy.DELETE_POLICY, target_obj\u003dmessage)"},{"line_number":73,"context_line":"        self.message_api.delete(context, id)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        return webob.Response(status_int\u003dHTTPStatus.NO_CONTENT)"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"59e4a3da_65f40d8a","line":73,"range":{"start_line":73,"start_character":40,"end_line":73,"end_character":43},"in_reply_to":"411faeed_32eaa469","updated":"2022-07-12 11:41:16.000000000","message":"Ack","commit_id":"f2aa53a503792ccc33ed3dd68af5dad4364d34d4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"abded55cd78c69ab72f525e4220c2a6559fad3c3","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        # Not found exception will be handled at the wsgi level"},{"line_number":71,"context_line":"        message \u003d self.message_api.get(context, id)"},{"line_number":72,"context_line":"        context.authorize(policy.DELETE_POLICY, target_obj\u003dmessage)"},{"line_number":73,"context_line":"        self.message_api.delete(context, id)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        return webob.Response(status_int\u003dHTTPStatus.NO_CONTENT)"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"da8a47be_7bec49bf","line":73,"range":{"start_line":73,"start_character":41,"end_line":73,"end_character":43},"updated":"2023-05-09 08:51:02.000000000","message":"+1 no point in sending message details when we only consume ID\n\nhttps://review.opendev.org/c/openstack/cinder/+/837542/10/cinder/db/sqlalchemy/api.py#8316","commit_id":"e9f2c711e9fc6004c91680504f0f68ceababffb0"}],"cinder/db/api.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"30f0bae94f3f12d7f71000e42c836e785cae9337","unresolved":true,"context_lines":[{"line_number":173,"context_line":"    model,"},{"line_number":174,"context_line":"    values,"},{"line_number":175,"context_line":"    expected_values,"},{"line_number":176,"context_line":"    filters\u003dNone,"},{"line_number":177,"context_line":"    include_deleted\u003d\u0027no\u0027,"},{"line_number":178,"context_line":"    project_only\u003dFalse,"},{"line_number":179,"context_line":"    order\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"112a6111_00ae3324","line":176,"updated":"2022-04-14 21:11:32.000000000","message":"I like the change you made on an earlier patch to change the default value in the sqlalchemy implementation, so I\u0027m ok with this change.","commit_id":"f2aa53a503792ccc33ed3dd68af5dad4364d34d4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2452c8a4d878de46ba29600347f45ff25403a425","unresolved":false,"context_lines":[{"line_number":173,"context_line":"    model,"},{"line_number":174,"context_line":"    values,"},{"line_number":175,"context_line":"    expected_values,"},{"line_number":176,"context_line":"    filters\u003dNone,"},{"line_number":177,"context_line":"    include_deleted\u003d\u0027no\u0027,"},{"line_number":178,"context_line":"    project_only\u003dFalse,"},{"line_number":179,"context_line":"    order\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"34a96a95_588081df","line":176,"in_reply_to":"112a6111_00ae3324","updated":"2022-04-19 11:26:42.000000000","message":"Ack","commit_id":"f2aa53a503792ccc33ed3dd68af5dad4364d34d4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"30f0bae94f3f12d7f71000e42c836e785cae9337","unresolved":true,"context_lines":[{"line_number":642,"context_line":""},{"line_number":643,"context_line":"def snapshot_get_all_for_cgsnapshot(context, cgsnapshot_id):"},{"line_number":644,"context_line":"    \"\"\"Get all snapshots belonging to a cgsnapshot.\"\"\""},{"line_number":645,"context_line":"    return IMPL.snapshot_get_all_for_cgsnapshot(context, cgsnapshot_id)"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":""},{"line_number":648,"context_line":"def snapshot_get_all_for_group_snapshot(context, group_snapshot_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"6773de94_47d117b9","line":645,"updated":"2022-04-14 21:11:32.000000000","message":"This is a good change, and it\u0027s already named \u0027cgsnapshot_id\u0027 in db.sqlalchemy.api","commit_id":"f2aa53a503792ccc33ed3dd68af5dad4364d34d4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2452c8a4d878de46ba29600347f45ff25403a425","unresolved":false,"context_lines":[{"line_number":642,"context_line":""},{"line_number":643,"context_line":"def snapshot_get_all_for_cgsnapshot(context, cgsnapshot_id):"},{"line_number":644,"context_line":"    \"\"\"Get all snapshots belonging to a cgsnapshot.\"\"\""},{"line_number":645,"context_line":"    return IMPL.snapshot_get_all_for_cgsnapshot(context, cgsnapshot_id)"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":""},{"line_number":648,"context_line":"def snapshot_get_all_for_group_snapshot(context, group_snapshot_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"dd081019_b7312409","line":645,"in_reply_to":"6773de94_47d117b9","updated":"2022-04-19 11:26:42.000000000","message":"Ack","commit_id":"f2aa53a503792ccc33ed3dd68af5dad4364d34d4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"30f0bae94f3f12d7f71000e42c836e785cae9337","unresolved":true,"context_lines":[{"line_number":1006,"context_line":"    return IMPL.volume_type_extra_specs_delete(context, volume_type_id, key)"},{"line_number":1007,"context_line":""},{"line_number":1008,"context_line":""},{"line_number":1009,"context_line":"def volume_type_extra_specs_update_or_create(context, volume_type_id, specs):"},{"line_number":1010,"context_line":"    \"\"\"Create or update volume type extra specs."},{"line_number":1011,"context_line":""},{"line_number":1012,"context_line":"    This adds or modifies the key/value pairs specified in the extra specs dict"}],"source_content_type":"text/x-python","patch_set":3,"id":"12222ff0_cc3c036d","line":1009,"range":{"start_line":1009,"start_character":70,"end_line":1009,"end_character":75},"updated":"2022-04-14 21:11:32.000000000","message":"We always refer to these as \u0027extra_specs\u0027, so IMO you should change the parameter name on the implementation side.","commit_id":"f2aa53a503792ccc33ed3dd68af5dad4364d34d4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2452c8a4d878de46ba29600347f45ff25403a425","unresolved":true,"context_lines":[{"line_number":1006,"context_line":"    return IMPL.volume_type_extra_specs_delete(context, volume_type_id, key)"},{"line_number":1007,"context_line":""},{"line_number":1008,"context_line":""},{"line_number":1009,"context_line":"def volume_type_extra_specs_update_or_create(context, volume_type_id, specs):"},{"line_number":1010,"context_line":"    \"\"\"Create or update volume type extra specs."},{"line_number":1011,"context_line":""},{"line_number":1012,"context_line":"    This adds or modifies the key/value pairs specified in the extra specs dict"}],"source_content_type":"text/x-python","patch_set":3,"id":"a70124f0_de71615b","line":1009,"range":{"start_line":1009,"start_character":70,"end_line":1009,"end_character":75},"in_reply_to":"12222ff0_cc3c036d","updated":"2022-04-19 11:26:42.000000000","message":"[Bike shedding] What about \u0027values\u0027, since every other \u0027_create\u0027 helper uses this terminology?","commit_id":"f2aa53a503792ccc33ed3dd68af5dad4364d34d4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e7047fba6a4b97b180c281e13a5690c6bd93c5f7","unresolved":false,"context_lines":[{"line_number":1006,"context_line":"    return IMPL.volume_type_extra_specs_delete(context, volume_type_id, key)"},{"line_number":1007,"context_line":""},{"line_number":1008,"context_line":""},{"line_number":1009,"context_line":"def volume_type_extra_specs_update_or_create(context, volume_type_id, specs):"},{"line_number":1010,"context_line":"    \"\"\"Create or update volume type extra specs."},{"line_number":1011,"context_line":""},{"line_number":1012,"context_line":"    This adds or modifies the key/value pairs specified in the extra specs dict"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f12b9ef_e6491836","line":1009,"range":{"start_line":1009,"start_character":70,"end_line":1009,"end_character":75},"in_reply_to":"5db94798_b7a99980","updated":"2022-06-15 10:15:27.000000000","message":"Done","commit_id":"f2aa53a503792ccc33ed3dd68af5dad4364d34d4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"defbf8b0f860f5047e20e334c603f89af9117fce","unresolved":true,"context_lines":[{"line_number":1006,"context_line":"    return IMPL.volume_type_extra_specs_delete(context, volume_type_id, key)"},{"line_number":1007,"context_line":""},{"line_number":1008,"context_line":""},{"line_number":1009,"context_line":"def volume_type_extra_specs_update_or_create(context, volume_type_id, specs):"},{"line_number":1010,"context_line":"    \"\"\"Create or update volume type extra specs."},{"line_number":1011,"context_line":""},{"line_number":1012,"context_line":"    This adds or modifies the key/value pairs specified in the extra specs dict"}],"source_content_type":"text/x-python","patch_set":3,"id":"5db94798_b7a99980","line":1009,"range":{"start_line":1009,"start_character":70,"end_line":1009,"end_character":75},"in_reply_to":"a70124f0_de71615b","updated":"2022-04-26 14:02:47.000000000","message":"Well, since you\u0027ll only have to change it in one place, I\u0027d go with extra_specs.","commit_id":"f2aa53a503792ccc33ed3dd68af5dad4364d34d4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"30f0bae94f3f12d7f71000e42c836e785cae9337","unresolved":true,"context_lines":[{"line_number":1054,"context_line":"    return IMPL.volume_type_encryption_delete(context, volume_type_id)"},{"line_number":1055,"context_line":""},{"line_number":1056,"context_line":""},{"line_number":1057,"context_line":"def volume_type_encryption_create(context, volume_type_id, values):"},{"line_number":1058,"context_line":"    return IMPL.volume_type_encryption_create(context, volume_type_id,"},{"line_number":1059,"context_line":"                                              values)"},{"line_number":1060,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"281b7502_84e61675","line":1057,"range":{"start_line":1057,"start_character":59,"end_line":1057,"end_character":65},"updated":"2022-04-14 21:11:32.000000000","message":"I think this one is better as encryption_specs as an indicator that we\u0027re expecting a dict and not a list of values or something.","commit_id":"f2aa53a503792ccc33ed3dd68af5dad4364d34d4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2452c8a4d878de46ba29600347f45ff25403a425","unresolved":true,"context_lines":[{"line_number":1054,"context_line":"    return IMPL.volume_type_encryption_delete(context, volume_type_id)"},{"line_number":1055,"context_line":""},{"line_number":1056,"context_line":""},{"line_number":1057,"context_line":"def volume_type_encryption_create(context, volume_type_id, values):"},{"line_number":1058,"context_line":"    return IMPL.volume_type_encryption_create(context, volume_type_id,"},{"line_number":1059,"context_line":"                                              values)"},{"line_number":1060,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"2891895d_7daecbe3","line":1057,"range":{"start_line":1057,"start_character":59,"end_line":1057,"end_character":65},"in_reply_to":"281b7502_84e61675","updated":"2022-04-19 11:26:42.000000000","message":"If we change this, should we change the other \u0027_create\u0027 APIs? These all use the \"values\" terminology (e.g. see \u0027qos_specs_create\u0027 below)","commit_id":"f2aa53a503792ccc33ed3dd68af5dad4364d34d4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"defbf8b0f860f5047e20e334c603f89af9117fce","unresolved":true,"context_lines":[{"line_number":1054,"context_line":"    return IMPL.volume_type_encryption_delete(context, volume_type_id)"},{"line_number":1055,"context_line":""},{"line_number":1056,"context_line":""},{"line_number":1057,"context_line":"def volume_type_encryption_create(context, volume_type_id, values):"},{"line_number":1058,"context_line":"    return IMPL.volume_type_encryption_create(context, volume_type_id,"},{"line_number":1059,"context_line":"                                              values)"},{"line_number":1060,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9e9366c6_faa11f15","line":1057,"range":{"start_line":1057,"start_character":59,"end_line":1057,"end_character":65},"in_reply_to":"2891895d_7daecbe3","updated":"2022-04-26 14:02:47.000000000","message":"No, I don\u0027t think we want to cause that much churn.  My preference here is to respect the parameter name in cinder.db.api","commit_id":"f2aa53a503792ccc33ed3dd68af5dad4364d34d4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e7047fba6a4b97b180c281e13a5690c6bd93c5f7","unresolved":false,"context_lines":[{"line_number":1054,"context_line":"    return IMPL.volume_type_encryption_delete(context, volume_type_id)"},{"line_number":1055,"context_line":""},{"line_number":1056,"context_line":""},{"line_number":1057,"context_line":"def volume_type_encryption_create(context, volume_type_id, values):"},{"line_number":1058,"context_line":"    return IMPL.volume_type_encryption_create(context, volume_type_id,"},{"line_number":1059,"context_line":"                                              values)"},{"line_number":1060,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"015b9d5a_309a3e3a","line":1057,"range":{"start_line":1057,"start_character":59,"end_line":1057,"end_character":65},"in_reply_to":"9e9366c6_faa11f15","updated":"2022-06-15 10:15:27.000000000","message":"I\u0027m going to keep this as \u0027values\u0027, if that\u0027s okay /o\\ All the other \u0027_create\u0027 APIs here use \u0027values\u0027 so it\u0027d be wholly inconsistent to use something else here.","commit_id":"f2aa53a503792ccc33ed3dd68af5dad4364d34d4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"30f0bae94f3f12d7f71000e42c836e785cae9337","unresolved":true,"context_lines":[{"line_number":1079,"context_line":"    return IMPL.qos_specs_create(context, values)"},{"line_number":1080,"context_line":""},{"line_number":1081,"context_line":""},{"line_number":1082,"context_line":"def qos_specs_get(context, qos_specs_id, inactive\u003dFalse):"},{"line_number":1083,"context_line":"    \"\"\"Get all specification for a given qos_specs.\"\"\""},{"line_number":1084,"context_line":"    return IMPL.qos_specs_get(context, qos_specs_id, inactive)"},{"line_number":1085,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1327c196_5f69dcfd","line":1082,"range":{"start_line":1082,"start_character":41,"end_line":1082,"end_character":55},"updated":"2022-04-14 21:11:32.000000000","message":"I don\u0027t think we actually use this anywhere, but it\u0027s in the implementation, so might as well expose it.","commit_id":"f2aa53a503792ccc33ed3dd68af5dad4364d34d4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"defbf8b0f860f5047e20e334c603f89af9117fce","unresolved":true,"context_lines":[{"line_number":1079,"context_line":"    return IMPL.qos_specs_create(context, values)"},{"line_number":1080,"context_line":""},{"line_number":1081,"context_line":""},{"line_number":1082,"context_line":"def qos_specs_get(context, qos_specs_id, inactive\u003dFalse):"},{"line_number":1083,"context_line":"    \"\"\"Get all specification for a given qos_specs.\"\"\""},{"line_number":1084,"context_line":"    return IMPL.qos_specs_get(context, qos_specs_id, inactive)"},{"line_number":1085,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"42bf6778_ff598eb7","line":1082,"range":{"start_line":1082,"start_character":41,"end_line":1082,"end_character":55},"in_reply_to":"08d382c8_457bfd72","updated":"2022-04-26 14:02:47.000000000","message":"Not sure ... I haven\u0027t thought it through.  Let\u0027s see what other reviewers think.","commit_id":"f2aa53a503792ccc33ed3dd68af5dad4364d34d4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2452c8a4d878de46ba29600347f45ff25403a425","unresolved":true,"context_lines":[{"line_number":1079,"context_line":"    return IMPL.qos_specs_create(context, values)"},{"line_number":1080,"context_line":""},{"line_number":1081,"context_line":""},{"line_number":1082,"context_line":"def qos_specs_get(context, qos_specs_id, inactive\u003dFalse):"},{"line_number":1083,"context_line":"    \"\"\"Get all specification for a given qos_specs.\"\"\""},{"line_number":1084,"context_line":"    return IMPL.qos_specs_get(context, qos_specs_id, inactive)"},{"line_number":1085,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"08d382c8_457bfd72","line":1082,"range":{"start_line":1082,"start_character":41,"end_line":1082,"end_character":55},"in_reply_to":"1327c196_5f69dcfd","updated":"2022-04-19 11:26:42.000000000","message":"Should I simply remove it from the implementation?","commit_id":"f2aa53a503792ccc33ed3dd68af5dad4364d34d4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e7047fba6a4b97b180c281e13a5690c6bd93c5f7","unresolved":false,"context_lines":[{"line_number":1079,"context_line":"    return IMPL.qos_specs_create(context, values)"},{"line_number":1080,"context_line":""},{"line_number":1081,"context_line":""},{"line_number":1082,"context_line":"def qos_specs_get(context, qos_specs_id, inactive\u003dFalse):"},{"line_number":1083,"context_line":"    \"\"\"Get all specification for a given qos_specs.\"\"\""},{"line_number":1084,"context_line":"    return IMPL.qos_specs_get(context, qos_specs_id, inactive)"},{"line_number":1085,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"c8b1a36f_89c3b2bb","line":1082,"range":{"start_line":1082,"start_character":41,"end_line":1082,"end_character":55},"in_reply_to":"42bf6778_ff598eb7","updated":"2022-06-15 10:15:27.000000000","message":"Removed in a separate follow-up change.","commit_id":"f2aa53a503792ccc33ed3dd68af5dad4364d34d4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"30f0bae94f3f12d7f71000e42c836e785cae9337","unresolved":true,"context_lines":[{"line_number":1127,"context_line":"    return IMPL.qos_specs_item_delete(context, qos_specs_id, key)"},{"line_number":1128,"context_line":""},{"line_number":1129,"context_line":""},{"line_number":1130,"context_line":"def qos_specs_update(context, qos_specs_id, values):"},{"line_number":1131,"context_line":"    \"\"\"Update qos specs."},{"line_number":1132,"context_line":""},{"line_number":1133,"context_line":"    This adds or modifies the key/value pairs specified in the"}],"source_content_type":"text/x-python","patch_set":3,"id":"97c4a3fb_3a6249fa","line":1130,"range":{"start_line":1130,"start_character":44,"end_line":1130,"end_character":50},"updated":"2022-04-14 21:11:32.000000000","message":"I kind of prefer \u0027specs\u0027 here, or \u0027updates\u0027 as it is currently in db.sqlalchemy.api, because they imply a dict.","commit_id":"f2aa53a503792ccc33ed3dd68af5dad4364d34d4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"defbf8b0f860f5047e20e334c603f89af9117fce","unresolved":true,"context_lines":[{"line_number":1127,"context_line":"    return IMPL.qos_specs_item_delete(context, qos_specs_id, key)"},{"line_number":1128,"context_line":""},{"line_number":1129,"context_line":""},{"line_number":1130,"context_line":"def qos_specs_update(context, qos_specs_id, values):"},{"line_number":1131,"context_line":"    \"\"\"Update qos specs."},{"line_number":1132,"context_line":""},{"line_number":1133,"context_line":"    This adds or modifies the key/value pairs specified in the"}],"source_content_type":"text/x-python","patch_set":3,"id":"eaf02c02_e9f09893","line":1130,"range":{"start_line":1130,"start_character":44,"end_line":1130,"end_character":50},"in_reply_to":"3399a308_f6afdcef","updated":"2022-04-26 14:02:47.000000000","message":"I suggest just changing it to \u0027updates\u0027 here so it matches the sqlalchemy.api and don\u0027t forget to hit the comment at line 1134.\n\nAbout all the _updates methods ... not worth doing at this time, there\u0027s been a suggestion to remove this extra db/api layer completely and only support the sqlalchemy.api","commit_id":"f2aa53a503792ccc33ed3dd68af5dad4364d34d4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2452c8a4d878de46ba29600347f45ff25403a425","unresolved":true,"context_lines":[{"line_number":1127,"context_line":"    return IMPL.qos_specs_item_delete(context, qos_specs_id, key)"},{"line_number":1128,"context_line":""},{"line_number":1129,"context_line":""},{"line_number":1130,"context_line":"def qos_specs_update(context, qos_specs_id, values):"},{"line_number":1131,"context_line":"    \"\"\"Update qos specs."},{"line_number":1132,"context_line":""},{"line_number":1133,"context_line":"    This adds or modifies the key/value pairs specified in the"}],"source_content_type":"text/x-python","patch_set":3,"id":"3399a308_f6afdcef","line":1130,"range":{"start_line":1130,"start_character":44,"end_line":1130,"end_character":50},"in_reply_to":"97c4a3fb_3a6249fa","updated":"2022-04-19 11:26:42.000000000","message":"Would \u0027updates\u0027 for all of these \u0027_updates\u0027 methods make sense, I wonder? Could do that","commit_id":"f2aa53a503792ccc33ed3dd68af5dad4364d34d4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e7047fba6a4b97b180c281e13a5690c6bd93c5f7","unresolved":false,"context_lines":[{"line_number":1127,"context_line":"    return IMPL.qos_specs_item_delete(context, qos_specs_id, key)"},{"line_number":1128,"context_line":""},{"line_number":1129,"context_line":""},{"line_number":1130,"context_line":"def qos_specs_update(context, qos_specs_id, values):"},{"line_number":1131,"context_line":"    \"\"\"Update qos specs."},{"line_number":1132,"context_line":""},{"line_number":1133,"context_line":"    This adds or modifies the key/value pairs specified in the"}],"source_content_type":"text/x-python","patch_set":3,"id":"fd3a54d8_f0c5594d","line":1130,"range":{"start_line":1130,"start_character":44,"end_line":1130,"end_character":50},"in_reply_to":"eaf02c02_e9f09893","updated":"2022-06-15 10:15:27.000000000","message":"\u003e I suggest just changing it to \u0027updates\u0027 here so it matches the sqlalchemy.api and don\u0027t forget to hit the comment at line 1134.\n\nAgain, I\u0027ve opted to keep this as \u0027values\u0027 because everything else is using this. IMO if it\u0027s a big enough issue to fix here then it\u0027s big enough to fix elsewhere. With that said...\n\n\u003e About all the _updates methods ... not worth doing at this time, there\u0027s been a suggestion to remove this extra db/api layer completely and only support the sqlalchemy.api\n\nIt was _me_ that suggested this 😄 One perk of this would be that it\u0027d be easier to update these afterwards 🤷‍♂️","commit_id":"f2aa53a503792ccc33ed3dd68af5dad4364d34d4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"30f0bae94f3f12d7f71000e42c836e785cae9337","unresolved":true,"context_lines":[{"line_number":1284,"context_line":""},{"line_number":1285,"context_line":"def quota_class_update_resource(context, old_res, new_res):"},{"line_number":1286,"context_line":"    \"\"\"Update resource name in quota_class.\"\"\""},{"line_number":1287,"context_line":"    return IMPL.quota_class_update_resource(context, old_res, new_res)"},{"line_number":1288,"context_line":""},{"line_number":1289,"context_line":""},{"line_number":1290,"context_line":"def quota_class_destroy(context, class_name, resource):"}],"source_content_type":"text/x-python","patch_set":3,"id":"4d063e95_52bf05f1","line":1287,"updated":"2022-04-14 21:11:32.000000000","message":"I was going to suggest something else, but the only place this is called from (in cinder/quotas.py) uses old_res and new_res for the arguments it passes by position.  Plus it\u0027s consistent with lines 1247 and 1345 in this file.  So this is a good change.","commit_id":"f2aa53a503792ccc33ed3dd68af5dad4364d34d4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2452c8a4d878de46ba29600347f45ff25403a425","unresolved":false,"context_lines":[{"line_number":1284,"context_line":""},{"line_number":1285,"context_line":"def quota_class_update_resource(context, old_res, new_res):"},{"line_number":1286,"context_line":"    \"\"\"Update resource name in quota_class.\"\"\""},{"line_number":1287,"context_line":"    return IMPL.quota_class_update_resource(context, old_res, new_res)"},{"line_number":1288,"context_line":""},{"line_number":1289,"context_line":""},{"line_number":1290,"context_line":"def quota_class_destroy(context, class_name, resource):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bed084b7_37cea4a6","line":1287,"in_reply_to":"4d063e95_52bf05f1","updated":"2022-04-19 11:26:42.000000000","message":"Ack","commit_id":"f2aa53a503792ccc33ed3dd68af5dad4364d34d4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"30f0bae94f3f12d7f71000e42c836e785cae9337","unresolved":true,"context_lines":[{"line_number":1605,"context_line":"        context,"},{"line_number":1606,"context_line":"        values,"},{"line_number":1607,"context_line":"        group_snapshot_id,"},{"line_number":1608,"context_line":"        source_group_id,"},{"line_number":1609,"context_line":"    )"},{"line_number":1610,"context_line":""},{"line_number":1611,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"8294ed4e_5dca7772","line":1608,"range":{"start_line":1608,"start_character":8,"end_line":1608,"end_character":15},"updated":"2022-04-14 21:11:32.000000000","message":"this is definitely better (and consistent with db.sqlalchemy.api)","commit_id":"f2aa53a503792ccc33ed3dd68af5dad4364d34d4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2452c8a4d878de46ba29600347f45ff25403a425","unresolved":false,"context_lines":[{"line_number":1605,"context_line":"        context,"},{"line_number":1606,"context_line":"        values,"},{"line_number":1607,"context_line":"        group_snapshot_id,"},{"line_number":1608,"context_line":"        source_group_id,"},{"line_number":1609,"context_line":"    )"},{"line_number":1610,"context_line":""},{"line_number":1611,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"f392e849_55159275","line":1608,"range":{"start_line":1608,"start_character":8,"end_line":1608,"end_character":15},"in_reply_to":"8294ed4e_5dca7772","updated":"2022-04-19 11:26:42.000000000","message":"Ack","commit_id":"f2aa53a503792ccc33ed3dd68af5dad4364d34d4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"abded55cd78c69ab72f525e4220c2a6559fad3c3","unresolved":true,"context_lines":[{"line_number":1056,"context_line":"    return IMPL.volume_type_encryption_delete(context, volume_type_id)"},{"line_number":1057,"context_line":""},{"line_number":1058,"context_line":""},{"line_number":1059,"context_line":"def volume_type_encryption_create(context, volume_type_id, values):"},{"line_number":1060,"context_line":"    return IMPL.volume_type_encryption_create(context, volume_type_id,"},{"line_number":1061,"context_line":"                                              values)"},{"line_number":1062,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"25651c27_b21cea28","line":1059,"range":{"start_line":1059,"start_character":59,"end_line":1059,"end_character":65},"updated":"2023-05-09 08:51:02.000000000","message":"values is pretty vague, i think encryption_specs was still better","commit_id":"e9f2c711e9fc6004c91680504f0f68ceababffb0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3dbc4c440bb1fdfc0059920f8c61664dd9728a00","unresolved":false,"context_lines":[{"line_number":1056,"context_line":"    return IMPL.volume_type_encryption_delete(context, volume_type_id)"},{"line_number":1057,"context_line":""},{"line_number":1058,"context_line":""},{"line_number":1059,"context_line":"def volume_type_encryption_create(context, volume_type_id, values):"},{"line_number":1060,"context_line":"    return IMPL.volume_type_encryption_create(context, volume_type_id,"},{"line_number":1061,"context_line":"                                              values)"},{"line_number":1062,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"ebeb2ba4_c3952f6e","line":1059,"range":{"start_line":1059,"start_character":59,"end_line":1059,"end_character":65},"in_reply_to":"25651c27_b21cea28","updated":"2023-05-09 12:47:51.000000000","message":"Yeah, probably is. However, you\u0027ll note that all other \u0027_create\u0027 methods here use \u0027values\u0027 so there is some value in this naming.","commit_id":"e9f2c711e9fc6004c91680504f0f68ceababffb0"}],"cinder/db/sqlalchemy/api.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8554690d715b7b48856d96d5ec83d189fa4dd0a9","unresolved":true,"context_lines":[{"line_number":3605,"context_line":"    context,"},{"line_number":3606,"context_line":"    volume_id,"},{"line_number":3607,"context_line":"    key,"},{"line_number":3608,"context_line":"    meta_type\u003dcommon.METADATA_TYPES.user,"},{"line_number":3609,"context_line":"):"},{"line_number":3610,"context_line":"    if meta_type \u003d\u003d common.METADATA_TYPES.user:"},{"line_number":3611,"context_line":"        query \u003d _volume_user_metadata_get_query(context, volume_id).filter_by("}],"source_content_type":"text/x-python","patch_set":3,"id":"d060c54c_635c50c7","line":3608,"range":{"start_line":3608,"start_character":13,"end_line":3608,"end_character":40},"updated":"2022-04-14 22:50:47.000000000","message":"This is in the signature in db.api, so might as well have it here, too.","commit_id":"f2aa53a503792ccc33ed3dd68af5dad4364d34d4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c4e78c9f77af8f81f54a7608a6857cee96d296c9","unresolved":false,"context_lines":[{"line_number":3605,"context_line":"    context,"},{"line_number":3606,"context_line":"    volume_id,"},{"line_number":3607,"context_line":"    key,"},{"line_number":3608,"context_line":"    meta_type\u003dcommon.METADATA_TYPES.user,"},{"line_number":3609,"context_line":"):"},{"line_number":3610,"context_line":"    if meta_type \u003d\u003d common.METADATA_TYPES.user:"},{"line_number":3611,"context_line":"        query \u003d _volume_user_metadata_get_query(context, volume_id).filter_by("}],"source_content_type":"text/x-python","patch_set":3,"id":"84a6f289_6aa2ebbf","line":3608,"range":{"start_line":3608,"start_character":13,"end_line":3608,"end_character":40},"in_reply_to":"d060c54c_635c50c7","updated":"2022-09-09 11:41:36.000000000","message":"Ack","commit_id":"f2aa53a503792ccc33ed3dd68af5dad4364d34d4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8554690d715b7b48856d96d5ec83d189fa4dd0a9","unresolved":true,"context_lines":[{"line_number":5959,"context_line":"@require_admin_context"},{"line_number":5960,"context_line":"@require_qos_specs_exists"},{"line_number":5961,"context_line":"@main_context_manager.writer"},{"line_number":5962,"context_line":"def qos_specs_update(context, qos_specs_id, values):"},{"line_number":5963,"context_line":"    \"\"\"Make updates to an existing qos specs."},{"line_number":5964,"context_line":""},{"line_number":5965,"context_line":"    Perform add, update or delete key/values to a qos specs."}],"source_content_type":"text/x-python","patch_set":3,"id":"585fdd9c_ff337818","line":5962,"range":{"start_line":5962,"start_character":44,"end_line":5962,"end_character":50},"updated":"2022-04-14 22:50:47.000000000","message":"See my comment about this in db/api.py","commit_id":"f2aa53a503792ccc33ed3dd68af5dad4364d34d4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c4e78c9f77af8f81f54a7608a6857cee96d296c9","unresolved":false,"context_lines":[{"line_number":5959,"context_line":"@require_admin_context"},{"line_number":5960,"context_line":"@require_qos_specs_exists"},{"line_number":5961,"context_line":"@main_context_manager.writer"},{"line_number":5962,"context_line":"def qos_specs_update(context, qos_specs_id, values):"},{"line_number":5963,"context_line":"    \"\"\"Make updates to an existing qos specs."},{"line_number":5964,"context_line":""},{"line_number":5965,"context_line":"    Perform add, update or delete key/values to a qos specs."}],"source_content_type":"text/x-python","patch_set":3,"id":"fa459136_19562576","line":5962,"range":{"start_line":5962,"start_character":44,"end_line":5962,"end_character":50},"in_reply_to":"585fdd9c_ff337818","updated":"2022-09-09 11:41:36.000000000","message":"Done","commit_id":"f2aa53a503792ccc33ed3dd68af5dad4364d34d4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"abded55cd78c69ab72f525e4220c2a6559fad3c3","unresolved":true,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"All functions in this module return objects that implement a dictionary-like"},{"line_number":25,"context_line":"interface. Currently, many of these objects are sqlalchemy objects that"},{"line_number":26,"context_line":"implement a dictionary interface. However, a future goal is to have all of"},{"line_number":27,"context_line":"these objects be simple dictionaries."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"**Related Flags**"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"929396c8_02cc6460","line":27,"range":{"start_line":26,"start_character":34,"end_line":27,"end_character":37},"updated":"2023-05-09 08:51:02.000000000","message":"is this goal decided community wide?","commit_id":"e9f2c711e9fc6004c91680504f0f68ceababffb0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3dbc4c440bb1fdfc0059920f8c61664dd9728a00","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"All functions in this module return objects that implement a dictionary-like"},{"line_number":25,"context_line":"interface. Currently, many of these objects are sqlalchemy objects that"},{"line_number":26,"context_line":"implement a dictionary interface. However, a future goal is to have all of"},{"line_number":27,"context_line":"these objects be simple dictionaries."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"**Related Flags**"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"de48235f_8dd69bb3","line":27,"range":{"start_line":26,"start_character":34,"end_line":27,"end_character":37},"in_reply_to":"929396c8_02cc6460","updated":"2023-05-09 12:47:51.000000000","message":"You\u0027ll have to tell me 😉 I only copied this from cinder.db.api","commit_id":"e9f2c711e9fc6004c91680504f0f68ceababffb0"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"abded55cd78c69ab72f525e4220c2a6559fad3c3","unresolved":true,"context_lines":[{"line_number":3654,"context_line":"    volume_id,"},{"line_number":3655,"context_line":"    metadata,"},{"line_number":3656,"context_line":"    delete,"},{"line_number":3657,"context_line":"    meta_type\u003dcommon.METADATA_TYPES.user,"},{"line_number":3658,"context_line":"):"},{"line_number":3659,"context_line":"    if meta_type \u003d\u003d common.METADATA_TYPES.user:"},{"line_number":3660,"context_line":"        return _volume_user_metadata_update("}],"source_content_type":"text/x-python","patch_set":10,"id":"5f03c376_b2a424b1","line":3657,"range":{"start_line":3657,"start_character":14,"end_line":3657,"end_character":40},"updated":"2023-05-09 08:51:02.000000000","message":"I think the idea here is to replicate the method signatures same as db/api.py to be able to remove the abstraction later?","commit_id":"e9f2c711e9fc6004c91680504f0f68ceababffb0"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"abded55cd78c69ab72f525e4220c2a6559fad3c3","unresolved":false,"context_lines":[{"line_number":8546,"context_line":""},{"line_number":8547,"context_line":"@require_context"},{"line_number":8548,"context_line":"@main_context_manager.reader"},{"line_number":8549,"context_line":"def worker_get_all(context, until\u003dNone, db_filters\u003dNone, **filters):"},{"line_number":8550,"context_line":"    \"\"\"Get all workers that match given criteria.\"\"\""},{"line_number":8551,"context_line":"    query \u003d _worker_query("},{"line_number":8552,"context_line":"        context,"}],"source_content_type":"text/x-python","patch_set":10,"id":"2fa5dce5_08392359","line":8549,"range":{"start_line":8549,"start_character":0,"end_line":8549,"end_character":68},"updated":"2023-05-09 08:51:02.000000000","message":"matches definition here\n\nhttps://github.com/openstack/cinder/blob/40a33360ade30abb1656aa3762051a0d96c76186/cinder/db/api.py#L1899-L1902","commit_id":"e9f2c711e9fc6004c91680504f0f68ceababffb0"}]}