)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"84fdce5d7f8f54d06af2c1a04ecea769b97783db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"529acd2a_a0861313","updated":"2022-06-02 12:56:26.000000000","message":"Black is terrible for formatting function definitions and makes code much \nharder to read, please just no.\n\nI really want to -2 this.","commit_id":"1357be1a2570415886592d014431aad885d68bcb"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"523fdfbcc3f30d8f04386e5984705497cda12717","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f9c562ed_52cd0207","updated":"2022-04-26 19:26:41.000000000","message":"Here are a few examples where I think black\u0027s formatting choices makes things look worse than before.","commit_id":"1357be1a2570415886592d014431aad885d68bcb"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ac685c151150c03aba68e2eb1294c1a82457d62a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1bd72527_9c77f28f","updated":"2022-04-27 05:11:22.000000000","message":"I agree that this contributes to the consistency of code across cinder but I must admit that at some places, it makes the code really hard to read and adds syntax to places which is really not necessary. Also with the 492 comments on pep8 failure, we can clearly see that this formatting doesn\u0027t comply with pep8 guidelines. Personally it would be a downvote from my side.","commit_id":"1357be1a2570415886592d014431aad885d68bcb"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"881ea685438941d612e4b04b941ac8da9bc60971","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0bc6c79e_9c9dc64f","updated":"2022-07-25 17:32:05.000000000","message":"Quite a few of us have voiced opinions that this change makes the code harder to read than it is currently.","commit_id":"1357be1a2570415886592d014431aad885d68bcb"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"3c8fb1864a792fdd068c01c388458288597d402e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2f058d25_61e2b205","updated":"2022-04-26 19:16:49.000000000","message":"While there is a lot to be said for consistency and objective code format feedback, I vote against this. I think black may be a good option for new code bases, but trying to switch over something like cinder at this point has more risk than advantage.\n\nThough I will admit I think black makes code harder to read and uglier, so a definitely am biased.","commit_id":"1357be1a2570415886592d014431aad885d68bcb"}],"cinder/api/contrib/admin_actions.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"d9f8a4c72eac630b7a18d59a50e2fc26fbdaebab","unresolved":true,"context_lines":[{"line_number":192,"context_line":"        # at this point, we still don\u0027t know if we\u0027re going to"},{"line_number":193,"context_line":"        # reset the volume\u0027s state.  Need to check what the caller"},{"line_number":194,"context_line":"        # is requesting first."},{"line_number":195,"context_line":"        if update.get(\u0027status\u0027) in (\u0027deleting\u0027, \u0027error_deleting\u0027 \u0027detaching\u0027):"},{"line_number":196,"context_line":"            msg \u003d _(\"Cannot reset-state to %s\" % update.get(\u0027status\u0027))"},{"line_number":197,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":198,"context_line":"        if update.get(\u0027status\u0027) \u003d\u003d \u0027in-use\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"4fb1ead4_b476527c","line":195,"range":{"start_line":195,"start_character":64,"end_line":195,"end_character":65},"updated":"2022-04-26 16:53:38.000000000","message":"I think this is a bug in our current code...?\n\nTossed up a patch to chase this:\n    https://review.opendev.org/c/openstack/cinder/+/839416","commit_id":"1357be1a2570415886592d014431aad885d68bcb"}],"cinder/api/contrib/volume_actions.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"523fdfbcc3f30d8f04386e5984705497cda12717","unresolved":true,"context_lines":[{"line_number":221,"context_line":"        image_metadata \u003d {"},{"line_number":222,"context_line":"            \"container_format\": params.get(\"container_format\", \"bare\"),"},{"line_number":223,"context_line":"            \"disk_format\": disk_format,"},{"line_number":224,"context_line":"            \"name\": params[\"image_name\"],"},{"line_number":225,"context_line":"        }"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        if volume.encryption_key_id:"}],"source_content_type":"text/x-python","patch_set":1,"id":"4da271ad_90411c03","line":224,"range":{"start_line":224,"start_character":40,"end_line":224,"end_character":41},"updated":"2022-04-26 19:26:41.000000000","message":"Not a fan of the extraneous comma additions.","commit_id":"1357be1a2570415886592d014431aad885d68bcb"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"523fdfbcc3f30d8f04386e5984705497cda12717","unresolved":true,"context_lines":[{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        if volume.encryption_key_id:"},{"line_number":228,"context_line":"            # encrypted volumes cannot be converted on upload"},{"line_number":229,"context_line":"            if ("},{"line_number":230,"context_line":"                image_metadata[\u0027disk_format\u0027] !\u003d \u0027raw\u0027"},{"line_number":231,"context_line":"                or image_metadata[\u0027container_format\u0027] !\u003d \u0027bare\u0027"},{"line_number":232,"context_line":"            ):"}],"source_content_type":"text/x-python","patch_set":1,"id":"44a5a2aa_5e1e3175","line":229,"updated":"2022-04-26 19:26:41.000000000","message":"This looks worse than before...","commit_id":"1357be1a2570415886592d014431aad885d68bcb"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"523fdfbcc3f30d8f04386e5984705497cda12717","unresolved":true,"context_lines":[{"line_number":245,"context_line":"            )"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"            image_metadata[\u0027cinder_encryption_key_id\u0027] \u003d encryption_key_id"},{"line_number":248,"context_line":"            image_metadata["},{"line_number":249,"context_line":"                \u0027cinder_encryption_key_deletion_policy\u0027"},{"line_number":250,"context_line":"            ] \u003d \u0027on_image_deletion\u0027"},{"line_number":251,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"85f5e1d1_535f438c","line":248,"updated":"2022-04-26 19:26:41.000000000","message":"The fix for this is to move past 80-length lines.","commit_id":"1357be1a2570415886592d014431aad885d68bcb"}],"cinder/api/contrib/volume_encryption_metadata.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"523fdfbcc3f30d8f04386e5984705497cda12717","unresolved":true,"context_lines":[{"line_number":53,"context_line":"        res \u003d extensions.ResourceExtension("},{"line_number":54,"context_line":"            \u0027encryption\u0027,"},{"line_number":55,"context_line":"            VolumeEncryptionMetadataController(),"},{"line_number":56,"context_line":"            parent\u003ddict(member_name\u003d\u0027volume\u0027, collection_name\u003d\u0027volumes\u0027),"},{"line_number":57,"context_line":"        )"},{"line_number":58,"context_line":"        resources.append(res)"},{"line_number":59,"context_line":"        return resources"}],"source_content_type":"text/x-python","patch_set":1,"id":"f60dd2d3_dd7aff8b","line":56,"range":{"start_line":56,"start_character":72,"end_line":56,"end_character":73},"updated":"2022-04-26 19:26:41.000000000","message":"Adding a comma here is just weird.","commit_id":"1357be1a2570415886592d014431aad885d68bcb"}],"cinder/api/contrib/volume_image_metadata.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"523fdfbcc3f30d8f04386e5984705497cda12717","unresolved":true,"context_lines":[{"line_number":110,"context_line":"                volume,"},{"line_number":111,"context_line":"                metadata,"},{"line_number":112,"context_line":"                delete\u003dFalse,"},{"line_number":113,"context_line":"                meta_type\u003dcommon.METADATA_TYPES.image,"},{"line_number":114,"context_line":"            )"},{"line_number":115,"context_line":"        # Not found exception will be handled at the wsgi level"},{"line_number":116,"context_line":"        except (ValueError, AttributeError):"}],"source_content_type":"text/x-python","patch_set":1,"id":"260964d9_92432d3e","line":113,"range":{"start_line":113,"start_character":53,"end_line":113,"end_character":54},"updated":"2022-04-26 19:26:41.000000000","message":"Adding a comma here is just weird.","commit_id":"1357be1a2570415886592d014431aad885d68bcb"}]}