)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"81808dcbc79f5987d30346d56b48761b606aa625","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ce84fc32_939c760d","updated":"2022-04-26 16:54:07.000000000","message":"Spotted while looking at formatting changes in\n    https://review.opendev.org/c/openstack/cinder/+/839405\n","commit_id":"e76e032b9b82c7c72ae2e24038e0ad4963e60f39"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"794f475eb67ef0af795bf80b771985345b6e99de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"46d06a53_b0953ae7","updated":"2022-04-28 21:59:20.000000000","message":"Question inline.","commit_id":"89e3c16580396f08fa12a568491cef8eb1a6fe3b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"43f63e4af5cf90d4f9a2beb5759bd743444c384d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5b900a22_0ae94cb5","updated":"2022-04-29 12:49:09.000000000","message":"recheck cinder-plugin-ceph-tempest - boatload of failures around not being able to ssh into instances, compute \"server has erred\"","commit_id":"89e3c16580396f08fa12a568491cef8eb1a6fe3b"}],"cinder/api/contrib/admin_actions.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"794f475eb67ef0af795bf80b771985345b6e99de","unresolved":true,"context_lines":[{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        # at this point, we still don\u0027t know if we\u0027re going to"},{"line_number":190,"context_line":"        # reset the volume\u0027s state.  Need to check what the caller"},{"line_number":191,"context_line":"        # is requesting first."},{"line_number":192,"context_line":"        if update.get(\u0027status\u0027) \u003d\u003d \u0027in-use\u0027:"},{"line_number":193,"context_line":"            attachments \u003d ("},{"line_number":194,"context_line":"                db.volume_attachment_get_all_by_volume_id(context, id))"}],"source_content_type":"text/x-python","patch_set":3,"id":"fc809f73_9ff113e6","line":191,"updated":"2022-04-28 21:59:20.000000000","message":"Maybe we want to keep the check down here?  Moving it saves us a database access, but we miss the policy check at line 187.  (That seemed important before I went down the schema-validation rabbit hole, but now I\u0027m not so sure.  If you try to reset status to \u0027charlie\u0027, you\u0027re going to get a 400 whether you\u0027re allowed to make the call or not because you\u0027ll get rejected by the schema, so what the heck.)\n\nAdditionally, validate_update() is mis-named because it doesn\u0027t really validate anything, it just provides us with a clean update dict (the input is schema-validated, though why we accept non-lowercase values in the request body is beyond me).  (That\u0027s not your fault, I\u0027m just making an observation.)","commit_id":"89e3c16580396f08fa12a568491cef8eb1a6fe3b"}]}