)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},"change_message_id":"c9c9885cd6e45bcdcc97da8040a04a76f1b8806f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"54e4ee87_5e60f6ad","updated":"2022-05-06 08:38:30.000000000","message":"Looks good to me.","commit_id":"298db63b529e2d6c8be14b95dd9db529cfbec60b"}],"cinder/tests/unit/volume/drivers/test_rbd.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"aca7f737f3ee0571736993e3144bf6d1214249c1","unresolved":true,"context_lines":[{"line_number":2204,"context_line":"        self.assertEqual((\u0027unknown\u0027, \u0027unknown\u0027), result)"},{"line_number":2205,"context_line":""},{"line_number":2206,"context_line":"    @common_mocks"},{"line_number":2207,"context_line":"    def test_get_mon_addrs(self):"},{"line_number":2208,"context_line":"        with mock.patch.object(self.driver, \u0027_execute\u0027) as mock_execute:"},{"line_number":2209,"context_line":"            mock_execute.return_value \u003d (CEPH_MON_DUMP, \u0027\u0027)"},{"line_number":2210,"context_line":"            hosts \u003d [\u0027::1\u0027, \u0027::1\u0027, \u0027::1\u0027, \u0027127.0.0.1\u0027, \u0027example.com\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"03dc328b_2ac37fe8","line":2207,"updated":"2025-07-08 20:17:31.000000000","message":"I think this needs unit tests that hit both the old and new formats, these seem to only test the new format.","commit_id":"413bdd8433cce69da4b47c580f8a4ed90e369b7f"}],"cinder/volume/drivers/rbd.py":[{"author":{"_account_id":34793,"name":"Konstantin","email":"k0ste@k0ste.ru","username":"k0ste"},"change_message_id":"b5146fdc9bac68c2cf658f0e0e2374b6adeb9984","unresolved":false,"context_lines":[{"line_number":566,"context_line":"        return ceph.CephBackupDriver.get_backup_snaps(rbd_image)"},{"line_number":567,"context_line":""},{"line_number":568,"context_line":"    def _get_mon_addrs(self) -\u003e Tuple[List[str], List[str]]:"},{"line_number":569,"context_line":"        \"\"\"Get\u0027s cluster mon\u0027s host and port."},{"line_number":570,"context_line":""},{"line_number":571,"context_line":"        By first we try to load msgr2 ports (3300), if cluster is old or without"},{"line_number":572,"context_line":"        msgr2 support - back to look for a legacy ceph-mon \u0027\u001daddr\u0027\u001cvalue"}],"source_content_type":"text/x-python","patch_set":1,"id":"e70a3a65_87b3e74b","line":569,"in_reply_to":"29de6787_35d8d521","updated":"2022-04-27 13:22:41.000000000","message":"\u003e pep8: E999 SyntaxError: invalid syntax\n\nPlease fix.","commit_id":"bc8eea2f0c8dc1ccacebe0343f18e31a6984676f"},{"author":{"_account_id":34793,"name":"Konstantin","email":"k0ste@k0ste.ru","username":"k0ste"},"change_message_id":"b5146fdc9bac68c2cf658f0e0e2374b6adeb9984","unresolved":false,"context_lines":[{"line_number":568,"context_line":"    def _get_mon_addrs(self) -\u003e Tuple[List[str], List[str]]:"},{"line_number":569,"context_line":"        \"\"\"Get\u0027s cluster mon\u0027s host and port."},{"line_number":570,"context_line":""},{"line_number":571,"context_line":"        By first we try to load msgr2 ports (3300), if cluster is old or without"},{"line_number":572,"context_line":"        msgr2 support - back to look for a legacy ceph-mon \u0027\u001daddr\u0027\u001cvalue"},{"line_number":573,"context_line":"        (port 6789)."},{"line_number":574,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"b3037a95_a19b2103","line":571,"in_reply_to":"1518a2de_50e03e5a","updated":"2022-04-27 13:22:41.000000000","message":"\u003e pep8: E501 line too long (80 \u003e 79 characters)\n\nPlease fix.","commit_id":"bc8eea2f0c8dc1ccacebe0343f18e31a6984676f"},{"author":{"_account_id":34793,"name":"Konstantin","email":"k0ste@k0ste.ru","username":"k0ste"},"change_message_id":"b5146fdc9bac68c2cf658f0e0e2374b6adeb9984","unresolved":false,"context_lines":[{"line_number":582,"context_line":"            lines \u003d lines[1:]"},{"line_number":583,"context_line":"        monmap \u003d json.loads(\u0027\\n\u0027.join(lines))"},{"line_number":584,"context_line":"        try:"},{"line_number":585,"context_line":"            addrs: List[str] \u003d [mon[\u0027public_addrs\u0027][\u0027addrvec\u0027][0][\u0027addr\u0027] \\"},{"line_number":586,"context_line":"            for mon in monmap[\u0027mons\u0027]]"},{"line_number":587,"context_line":"            host_port_delimiter \u003d \u0027\u0027"},{"line_number":588,"context_line":"        except KeyError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ee3ad6e_8b76d845","line":585,"in_reply_to":"641d1631_fc28525f","updated":"2022-04-27 13:22:41.000000000","message":"\u003e pep8: E502 the backslash is redundant between brackets\n\nPlease fix.","commit_id":"bc8eea2f0c8dc1ccacebe0343f18e31a6984676f"},{"author":{"_account_id":34793,"name":"Konstantin","email":"k0ste@k0ste.ru","username":"k0ste"},"change_message_id":"b5146fdc9bac68c2cf658f0e0e2374b6adeb9984","unresolved":false,"context_lines":[{"line_number":583,"context_line":"        monmap \u003d json.loads(\u0027\\n\u0027.join(lines))"},{"line_number":584,"context_line":"        try:"},{"line_number":585,"context_line":"            addrs: List[str] \u003d [mon[\u0027public_addrs\u0027][\u0027addrvec\u0027][0][\u0027addr\u0027] \\"},{"line_number":586,"context_line":"            for mon in monmap[\u0027mons\u0027]]"},{"line_number":587,"context_line":"            host_port_delimiter \u003d \u0027\u0027"},{"line_number":588,"context_line":"        except KeyError:"},{"line_number":589,"context_line":"            addrs: List[str] \u003d [mon[\u0027addr\u0027] for mon in monmap[\u0027mons\u0027]]"}],"source_content_type":"text/x-python","patch_set":1,"id":"18be8c31_d457bb34","line":586,"in_reply_to":"8f459f5a_24d51a00","updated":"2022-04-27 13:22:41.000000000","message":"\u003e pep8: E128 continuation line under-indented for visual indent\n\nPlease fix.","commit_id":"bc8eea2f0c8dc1ccacebe0343f18e31a6984676f"},{"author":{"_account_id":34793,"name":"Konstantin","email":"k0ste@k0ste.ru","username":"k0ste"},"change_message_id":"b5146fdc9bac68c2cf658f0e0e2374b6adeb9984","unresolved":false,"context_lines":[{"line_number":583,"context_line":"        monmap \u003d json.loads(\u0027\\n\u0027.join(lines))"},{"line_number":584,"context_line":"        try:"},{"line_number":585,"context_line":"            addrs: List[str] \u003d [mon[\u0027public_addrs\u0027][\u0027addrvec\u0027][0][\u0027addr\u0027]"},{"line_number":586,"context_line":"                for mon in monmap[\u0027mons\u0027]]"},{"line_number":587,"context_line":"            host_port_delimiter \u003d \u0027\u0027"},{"line_number":588,"context_line":"        except KeyError:"},{"line_number":589,"context_line":"            addrs: List[str] \u003d [mon[\u0027addr\u0027] for mon in monmap[\u0027mons\u0027]]"}],"source_content_type":"text/x-python","patch_set":4,"id":"a0a9e4da_5b7bbaba","line":586,"in_reply_to":"5830a2de_6ce429bd","updated":"2022-04-27 13:22:41.000000000","message":"\u003e pep8: E128 continuation line under-indented for visual indent\n\nPlease fix.","commit_id":"bc8f08e91525dee130f59b3e50b276b8fca3e5f4"}]}