)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"22bbaf56f737a581327a7cf4257400bf439ea360","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"61ee416f_db04d3b9","updated":"2022-04-28 14:49:21.000000000","message":"I think this is a bit overly complicated and touches too much code, what I think were can do is look at this:\n\nhttps://github.com/openstack/cinder/blob/1b5aad85d04b262281b9632bbc9a3ab490ee9082/cinder/image/image_utils.py#L702-L711\n\nI think we can introduce something similar called `allow_image_conversion`, and if `image_meta.get(\u0027disk_format\u0027) !\u003d volume_format`, this means that a conversion will occur since the request volume_format is not the same as the original disk format, and then we can kill it off right then and there and use the ImageNotAcceptable exception there. :)","commit_id":"ff8f374148eee861c86ce1693742b51fb53fad19"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"9a840f5983cf82aabf03a6a45daed626312eb7c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3464c1aa_773c7d8a","in_reply_to":"61ee416f_db04d3b9","updated":"2022-04-28 15:05:59.000000000","message":"If we can direct touch util, will save me a lot of nested code. Do we need to consider thrid party usage for image_util? Most drivers is under Cinder right?:)\n\nI will make allow_image_conversion in another patch set. Most drivers use fetch_to_raw function. Means the volume_format only accept `raw` for disk_format when allow_image_conversion flag is on. But I think that\u0027s not allow_image_conversion should focus on.","commit_id":"ff8f374148eee861c86ce1693742b51fb53fad19"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7ba28908462048a1ff8c8609e1c8e003541b4a22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e517f009_9a9bdbaf","updated":"2022-07-13 02:24:14.000000000","message":"Has this been superseded by Ic481d68639d9 ?  If so, please abandon this patch.","commit_id":"27a0ddafbaecbd284986ca6e63ddd776a9bc98db"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"7e6b1b1a993251d71eede9f1ced26d5392bd6442","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3adda998_e9dda0e3","updated":"2022-04-28 17:06:52.000000000","message":"found a related report: https://bugzilla.redhat.com/show_bug.cgi?id\u003d1049457","commit_id":"27a0ddafbaecbd284986ca6e63ddd776a9bc98db"}]}