)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"c6b191da69b982584b877fd97acc5cb1fccfc7e0","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     yuval brave \u003cyuval@lightbitslabs.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-09-01 14:22:25 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"lightbits driver: properly parse endpoint with urlparse"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Don\u0027t assume ipv4:port tuple, ipv6 can be a little more"},{"line_number":10,"context_line":"complicated than that, so use urlparse."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"61f2ac1c_79f6c784","line":7,"updated":"2022-09-01 12:25:35.000000000","message":"The first line in commit msg should be 50 chars.\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"c349f5f879ea969deb95f918aad543e09b57e756"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"76dd476b4492d7b59d7a56fe1d07a46303832284","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     yuval brave \u003cyuval@lightbitslabs.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-09-01 14:22:25 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"lightbits driver: properly parse endpoint with urlparse"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Don\u0027t assume ipv4:port tuple, ipv6 can be a little more"},{"line_number":10,"context_line":"complicated than that, so use urlparse."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3375c4a0_9f4a46d2","line":7,"in_reply_to":"61f2ac1c_79f6c784","updated":"2022-09-01 13:00:41.000000000","message":"Done","commit_id":"c349f5f879ea969deb95f918aad543e09b57e756"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4d2fa94ccf04df5406857e6b9077a1783b544f02","unresolved":true,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2022-04-28 16:55:34 +0300"},{"line_number":4,"context_line":"Commit:     yuval brave \u003cyuval@lightbitslabs.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-09-01 19:00:52 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"lightbits driver: parse endpoint with urlparse"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Don\u0027t assume ipv4:port tuple, ipv6 can be a little more"},{"line_number":10,"context_line":"complicated than that, so use urlparse."},{"line_number":11,"context_line":"update url_api variable."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"40c6b0ea_986a18ba","line":8,"range":{"start_line":6,"start_character":0,"end_line":8,"end_character":0},"updated":"2022-09-09 09:34:37.000000000","message":"IIUC, we are adding support of handling ipv6 addresses so this commit head doesn\u0027t covey that information.","commit_id":"67ecf9c815312b90e875dabc4935df1eef416095"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"493bacdf5078ebe2bae2d18f0f904ceddab7e619","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2022-04-28 16:55:34 +0300"},{"line_number":4,"context_line":"Commit:     yuval brave \u003cyuval@lightbitslabs.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-09-01 19:00:52 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"lightbits driver: parse endpoint with urlparse"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Don\u0027t assume ipv4:port tuple, ipv6 can be a little more"},{"line_number":10,"context_line":"complicated than that, so use urlparse."},{"line_number":11,"context_line":"update url_api variable."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"060837d9_c21be9e7","line":8,"range":{"start_line":6,"start_character":0,"end_line":8,"end_character":0},"in_reply_to":"40c6b0ea_986a18ba","updated":"2022-09-11 14:32:01.000000000","message":"fixed","commit_id":"67ecf9c815312b90e875dabc4935df1eef416095"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4d2fa94ccf04df5406857e6b9077a1783b544f02","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Don\u0027t assume ipv4:port tuple, ipv6 can be a little more"},{"line_number":10,"context_line":"complicated than that, so use urlparse."},{"line_number":11,"context_line":"update url_api variable."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Signed-off-by: Yuval Brave  \u003cyuval@lightbitslabs.com\u003e"},{"line_number":14,"context_line":"Change-Id: I8ed58b772f7ed1e5b164f0c8ca81fcb72f9f4498"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"773295f4_d70d997f","line":12,"updated":"2022-09-09 09:34:37.000000000","message":"Was there a bug when this was found out or in general we are adding support for this?\nIf there was a known failure, would be good to get a bug reported and mentioned here.","commit_id":"67ecf9c815312b90e875dabc4935df1eef416095"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"493bacdf5078ebe2bae2d18f0f904ceddab7e619","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Don\u0027t assume ipv4:port tuple, ipv6 can be a little more"},{"line_number":10,"context_line":"complicated than that, so use urlparse."},{"line_number":11,"context_line":"update url_api variable."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Signed-off-by: Yuval Brave  \u003cyuval@lightbitslabs.com\u003e"},{"line_number":14,"context_line":"Change-Id: I8ed58b772f7ed1e5b164f0c8ca81fcb72f9f4498"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"f226d0d8_34526120","line":12,"in_reply_to":"773295f4_d70d997f","updated":"2022-09-11 14:32:01.000000000","message":"hey I filled a bug:\nhttps://bugs.launchpad.net/cinder/+bug/1989281\n\nand updated the commit msg. thanks for the comment","commit_id":"67ecf9c815312b90e875dabc4935df1eef416095"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"701a3fec87601ca39c7047a78b36327ad2b6da5d","unresolved":true,"context_lines":[{"line_number":10,"context_line":"complicated than that, so use urlparse."},{"line_number":11,"context_line":"update url_api variable."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"launchpad bug report: https://bugs.launchpad.net/cinder/+bug/1989281"},{"line_number":14,"context_line":"Signed-off-by: Yuval Brave  \u003cyuval@lightbitslabs.com\u003e"},{"line_number":15,"context_line":"Change-Id: I8ed58b772f7ed1e5b164f0c8ca81fcb72f9f4498"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"38c17072_af1b34e2","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":21},"updated":"2022-09-12 19:49:34.000000000","message":"The correct format is, Closes-Bug: 1989281\nsee[1] for more details\n\n[1] https://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references","commit_id":"ac58aa7403a93c1cf484370b2bbe2975cb2f4fbe"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"d50e614ce5bd5f644d4f7cf4d52681ed4c38bb39","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d84083de_6c2e3c57","updated":"2022-04-29 16:00:24.000000000","message":"Should this have a bug on launchpad?\n\n-1: might be nice to add some test cases for ipv6 here [0]\n\n[0] https://opendev.org/openstack/cinder/src/branch/master/cinder/tests/unit/volume/drivers/lightos/test_lightos_storage.py#L37-L46","commit_id":"8b6fadf33c134fce6f746d352ea0a11e5264606d"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"03ebc8066511e506085394b88ed0ebb3ad21d877","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"861a3a58_3aebb37b","updated":"2022-08-17 13:26:53.000000000","message":"run-Lightbits CI","commit_id":"8b6fadf33c134fce6f746d352ea0a11e5264606d"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"97c7cfe68218ebc854c9ea9027fa17bbfed81d54","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"107006c7_3408bd95","in_reply_to":"d84083de_6c2e3c57","updated":"2022-08-31 12:52:21.000000000","message":"added unittest","commit_id":"8b6fadf33c134fce6f746d352ea0a11e5264606d"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"c6b191da69b982584b877fd97acc5cb1fccfc7e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e26c1569_edaed3de","updated":"2022-09-01 12:25:35.000000000","message":"Couple of points inline.","commit_id":"c349f5f879ea969deb95f918aad543e09b57e756"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"76dd476b4492d7b59d7a56fe1d07a46303832284","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"165b0ea5_6e957061","updated":"2022-09-01 13:00:41.000000000","message":"\nThanks for the comments -Raghavendra Tilay - I fixed it","commit_id":"f16abf0dec24ff9d38fbe901f27d40cf28bb1774"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"6e42851315111df58eb875accaa12922d0926428","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b6fab67d_75b53b0c","updated":"2022-09-01 15:51:24.000000000","message":"run-Lightbits CI","commit_id":"f16abf0dec24ff9d38fbe901f27d40cf28bb1774"},{"author":{"_account_id":34459,"name":"Muli Ben-Yehuda","email":"muli@lightbitslabs.com","username":"muliby"},"change_message_id":"7cc4dc7443b554670b916dec3002e3688633f634","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"60af1dd4_12de024d","updated":"2022-09-08 06:24:41.000000000","message":"LGTM and hooray for ipv6 support!","commit_id":"67ecf9c815312b90e875dabc4935df1eef416095"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"034b0b753139b8e94d095f9bbcde46c3b749a03e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b73a2d38_d1861371","updated":"2022-09-02 07:24:00.000000000","message":"My comment from previous patchset has been addressed.\nCode and UT look good. Lightbits CI and Zuul passed. So +1.\n","commit_id":"67ecf9c815312b90e875dabc4935df1eef416095"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4d2fa94ccf04df5406857e6b9077a1783b544f02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"41018b2d_3c598f4c","updated":"2022-09-09 09:34:37.000000000","message":"code and tests look good but the commit headline isn\u0027t very descriptive.","commit_id":"67ecf9c815312b90e875dabc4935df1eef416095"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"271c6108d84ccb81bb527b71e94bba995cc79058","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3fd5ed9d_3a207e80","updated":"2022-09-12 19:50:01.000000000","message":"Forgot to mention, Lightbits CI has passed.","commit_id":"ac58aa7403a93c1cf484370b2bbe2975cb2f4fbe"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"701a3fec87601ca39c7047a78b36327ad2b6da5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ee32f4a5_58992af2","updated":"2022-09-12 19:49:34.000000000","message":"The bug reference is not correct but won\u0027t block for that. LGTM.","commit_id":"ac58aa7403a93c1cf484370b2bbe2975cb2f4fbe"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"f5d7d3e430d32cb33ddc9cda91ef7fea339051b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c70356c3_f02c707c","updated":"2022-09-12 16:33:15.000000000","message":"run-Lightbits CI","commit_id":"ac58aa7403a93c1cf484370b2bbe2975cb2f4fbe"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2e77ca9936f90d707334b7e18dc2cc5966c4a85e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"72315249_dafe0614","updated":"2022-09-14 18:59:53.000000000","message":"LGTM.","commit_id":"f9201fb55ad51e0b094268369689dfbea8442d0c"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"1a984be425ef35c20d2c9c58ecc872ea523e7aeb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"93eec962_f32250cb","updated":"2022-09-14 19:55:06.000000000","message":"recheck cinder-plugin-ceph-tempest","commit_id":"f9201fb55ad51e0b094268369689dfbea8442d0c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8f85bae72f5fba19d3b1269be6d69f130d6937b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5c48c5c6_1fb686d3","updated":"2022-09-14 18:59:29.000000000","message":"recheck cinder-plugin-ceph-tempest timed out","commit_id":"f9201fb55ad51e0b094268369689dfbea8442d0c"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"e285424a99ddb1b2f30693e46702743b94858c53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"189571e1_9b2760f9","updated":"2022-09-14 20:13:06.000000000","message":"run-Lightbits CI","commit_id":"f9201fb55ad51e0b094268369689dfbea8442d0c"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"331196b4e5e8311756468302a7c0960902989942","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"765602dd_235bda48","updated":"2022-09-14 21:11:57.000000000","message":"run-Lightbits CI","commit_id":"f9201fb55ad51e0b094268369689dfbea8442d0c"}],"cinder/tests/unit/volume/drivers/lightos/test_lightos_storage.py":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"c6b191da69b982584b877fd97acc5cb1fccfc7e0","unresolved":true,"context_lines":[{"line_number":644,"context_line":"        volume \u003d test_utils.create_volume(self.ctxt, size\u003d4,"},{"line_number":645,"context_line":"                                          volume_type_id\u003dvol_type.id)"},{"line_number":646,"context_line":"        self.driver.create_volume(volume)"},{"line_number":647,"context_line":"        connection_props \u003d \\"},{"line_number":648,"context_line":"            self.driver.initialize_connection(volume,"},{"line_number":649,"context_line":"                                              get_connector_properties())"},{"line_number":650,"context_line":"        self.assertIn(\u0027driver_volume_type\u0027, connection_props)"}],"source_content_type":"text/x-python","patch_set":4,"id":"f32b0042_c2f61075","line":647,"updated":"2022-09-01 12:25:35.000000000","message":"nit: For multiline code, people prefer parenthesis () instead of backslash \\","commit_id":"c349f5f879ea969deb95f918aad543e09b57e756"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"76dd476b4492d7b59d7a56fe1d07a46303832284","unresolved":false,"context_lines":[{"line_number":644,"context_line":"        volume \u003d test_utils.create_volume(self.ctxt, size\u003d4,"},{"line_number":645,"context_line":"                                          volume_type_id\u003dvol_type.id)"},{"line_number":646,"context_line":"        self.driver.create_volume(volume)"},{"line_number":647,"context_line":"        connection_props \u003d \\"},{"line_number":648,"context_line":"            self.driver.initialize_connection(volume,"},{"line_number":649,"context_line":"                                              get_connector_properties())"},{"line_number":650,"context_line":"        self.assertIn(\u0027driver_volume_type\u0027, connection_props)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5db4bdab_a6f84193","line":647,"in_reply_to":"f32b0042_c2f61075","updated":"2022-09-01 13:00:41.000000000","message":"Done","commit_id":"c349f5f879ea969deb95f918aad543e09b57e756"}]}