)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ef852e5b05572f399072d91c2970290a13c4ffce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5b754381_e1d5c412","updated":"2022-08-02 11:44:57.000000000","message":"LGTM","commit_id":"77c886ab18ba241eaa7418f1e0d095fe6639ae19"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5eff15d1a3edce6d2b83342d80d0893e891976a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3a64378f_eafac991","updated":"2022-06-02 20:46:53.000000000","message":"Minor nit noted inline if you have to put up a new patch set.  Otherwise, code and tests look good.  Thanks for the clear explanations on the release note, commit message, and your comment on the bug.","commit_id":"77c886ab18ba241eaa7418f1e0d095fe6639ae19"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"50deda065f9f82c9552d0bbe6d43277f5ac5ddd1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3b263fd5_43fb2d0d","updated":"2022-05-30 10:06:48.000000000","message":"please review 😊","commit_id":"77c886ab18ba241eaa7418f1e0d095fe6639ae19"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"ab6c3d442bb2ca8a06c6ae7a24445cf4281f5ad0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8c4b33e8_18c4fc56","in_reply_to":"3a64378f_eafac991","updated":"2022-06-03 11:59:15.000000000","message":"Thanks Brian, I\u0027ll update the nit later or in a later PS if there is any other change requests.","commit_id":"77c886ab18ba241eaa7418f1e0d095fe6639ae19"}],"cinder/service_auth.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ef852e5b05572f399072d91c2970290a13c4ffce","unresolved":true,"context_lines":[{"line_number":62,"context_line":"                # This can happen if no auth_type is specified, which probably"},{"line_number":63,"context_line":"                # means there\u0027s no auth information in the [service_user] group"},{"line_number":64,"context_line":"                raise exception.ServiceUserTokenNoAuth()"},{"line_number":65,"context_line":"        return _SERVICE_AUTH"},{"line_number":66,"context_line":"    return None"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"def get_auth_plugin(context, auth\u003dNone):"},{"line_number":70,"context_line":"    if auth:"},{"line_number":71,"context_line":"        user_auth \u003d auth"},{"line_number":72,"context_line":"    else:"},{"line_number":73,"context_line":"        user_auth \u003d context.get_auth_plugin()"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    service_auth \u003d get_service_auth_plugin()"},{"line_number":76,"context_line":"    if service_auth is not None:"},{"line_number":77,"context_line":"        return service_token.ServiceTokenAuthWrapper("},{"line_number":78,"context_line":"            user_auth\u003duser_auth, service_auth\u003dservice_auth)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    return user_auth"}],"source_content_type":"text/x-python","patch_set":4,"id":"90afce75_36d6fed4","line":78,"range":{"start_line":65,"start_character":0,"end_line":78,"end_character":59},"updated":"2022-08-02 11:44:57.000000000","message":"I think the functionality remains the same with/without these changes","commit_id":"77c886ab18ba241eaa7418f1e0d095fe6639ae19"}],"cinder/tests/unit/backup/drivers/test_backup_swift.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5eff15d1a3edce6d2b83342d80d0893e891976a9","unresolved":true,"context_lines":[{"line_number":325,"context_line":"        mock_plugin.return_value \u003d FakeServiceAuthPlugin()"},{"line_number":326,"context_line":"        service \u003d swift_dr.SwiftBackupDriver(self.ctxt)"},{"line_number":327,"context_line":"        expected \u003d {\u0027X-Service-Token\u0027: \u0027fake\u0027}"},{"line_number":328,"context_line":"        self.assertEqual(service._headers(), expected)"},{"line_number":329,"context_line":"        expected \u003d {\u0027X-Service-Token\u0027: \u0027fake\u0027, \u0027some\u0027: \u0027header\u0027}"},{"line_number":330,"context_line":"        self.assertEqual(service._headers({\u0027some\u0027: \u0027header\u0027}), expected)"},{"line_number":331,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"8d62d039_6df67a2c","line":328,"range":{"start_line":328,"start_character":8,"end_line":328,"end_character":54},"updated":"2022-06-02 20:46:53.000000000","message":"nit: the usual ordering is: expected, actual (same thing at line 330)","commit_id":"77c886ab18ba241eaa7418f1e0d095fe6639ae19"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"ab6c3d442bb2ca8a06c6ae7a24445cf4281f5ad0","unresolved":true,"context_lines":[{"line_number":325,"context_line":"        mock_plugin.return_value \u003d FakeServiceAuthPlugin()"},{"line_number":326,"context_line":"        service \u003d swift_dr.SwiftBackupDriver(self.ctxt)"},{"line_number":327,"context_line":"        expected \u003d {\u0027X-Service-Token\u0027: \u0027fake\u0027}"},{"line_number":328,"context_line":"        self.assertEqual(service._headers(), expected)"},{"line_number":329,"context_line":"        expected \u003d {\u0027X-Service-Token\u0027: \u0027fake\u0027, \u0027some\u0027: \u0027header\u0027}"},{"line_number":330,"context_line":"        self.assertEqual(service._headers({\u0027some\u0027: \u0027header\u0027}), expected)"},{"line_number":331,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"8c0bcff1_a8b8a6a1","line":328,"range":{"start_line":328,"start_character":8,"end_line":328,"end_character":54},"in_reply_to":"8d62d039_6df67a2c","updated":"2022-06-03 11:59:15.000000000","message":"Ack","commit_id":"77c886ab18ba241eaa7418f1e0d095fe6639ae19"}]}