)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"08a468a8414cc4be6a3795535e43a4c34d4a2ad9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"816bc550_23828a85","updated":"2022-05-16 17:09:59.000000000","message":"LGTM.","commit_id":"c8b6a44f710ab4884828d3d11bbf7a0b9c0bdbcf"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"bcb06cecfa778ccd46e7eabade6c392c5a3ba362","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"be6b51ac_d9666cc4","updated":"2022-06-03 12:52:01.000000000","message":"Has had quite a few reviews.  Looks good to me.  Merging.","commit_id":"405173d477fed32c7aa2c2597a616b939911ef6a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"feb4f31b6b57d164f09f95a34b43599a4bd3fd57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"63c8f4b8_d2bd99b7","updated":"2022-06-02 21:46:21.000000000","message":"Raising the priority, as this is blocking https://review.opendev.org/c/openstack/cinder/+/839793","commit_id":"405173d477fed32c7aa2c2597a616b939911ef6a"}],"cinder/tests/unit/test_image_utils.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"08a468a8414cc4be6a3795535e43a4c34d4a2ad9","unresolved":true,"context_lines":[{"line_number":1112,"context_line":"    @mock.patch(\u0027cinder.image.image_utils.fetch\u0027)"},{"line_number":1113,"context_line":"    @mock.patch(\u0027cinder.image.image_utils.qemu_img_info\u0027)"},{"line_number":1114,"context_line":"    @mock.patch(\u0027cinder.image.image_utils.temporary_file\u0027)"},{"line_number":1115,"context_line":"    @mock.patch(\u0027cinder.image.image_utils.CONF\u0027)"},{"line_number":1116,"context_line":"    def test_defaults(self, mock_conf, mock_temp, mock_info, mock_fetch,"},{"line_number":1117,"context_line":"                      mock_is_xen, mock_repl_xen, mock_copy, mock_convert,"},{"line_number":1118,"context_line":"                      mock_check_space):"}],"source_content_type":"text/x-python","patch_set":1,"id":"d566696b_9628e66d","side":"PARENT","line":1115,"range":{"start_line":1115,"start_character":0,"end_line":1115,"end_character":48},"updated":"2022-05-16 17:09:59.000000000","message":"don\u0027t we need this mock anywhere during the life of this test? Seems strange to mock it in the first place.","commit_id":"7e04b5b0d4c91df7601e8e7f36d49fb6d651ea2b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c7b11b7bedcb5899e26edb48d02d0f4923f1b4bc","unresolved":true,"context_lines":[{"line_number":1112,"context_line":"    @mock.patch(\u0027cinder.image.image_utils.fetch\u0027)"},{"line_number":1113,"context_line":"    @mock.patch(\u0027cinder.image.image_utils.qemu_img_info\u0027)"},{"line_number":1114,"context_line":"    @mock.patch(\u0027cinder.image.image_utils.temporary_file\u0027)"},{"line_number":1115,"context_line":"    @mock.patch(\u0027cinder.image.image_utils.CONF\u0027)"},{"line_number":1116,"context_line":"    def test_defaults(self, mock_conf, mock_temp, mock_info, mock_fetch,"},{"line_number":1117,"context_line":"                      mock_is_xen, mock_repl_xen, mock_copy, mock_convert,"},{"line_number":1118,"context_line":"                      mock_check_space):"}],"source_content_type":"text/x-python","patch_set":1,"id":"d9af58a4_24fde894","side":"PARENT","line":1115,"range":{"start_line":1115,"start_character":0,"end_line":1115,"end_character":48},"in_reply_to":"d566696b_9628e66d","updated":"2022-05-26 20:25:11.000000000","message":"Yeah, that happens a lot in this file.  I imagine that there was a test that needed it, someone copied and pasted the test to test something else, and forgot to remove the unused mock, and then someone else copied \u0026 pasted that test ...","commit_id":"7e04b5b0d4c91df7601e8e7f36d49fb6d651ea2b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"08a468a8414cc4be6a3795535e43a4c34d4a2ad9","unresolved":true,"context_lines":[{"line_number":674,"context_line":"    @mock.patch(\u0027oslo_utils.fileutils.ensure_tree\u0027)"},{"line_number":675,"context_line":"    @mock.patch(\u0027cinder.image.image_utils.utils.tempdir\u0027)"},{"line_number":676,"context_line":"    def test_conv_dir_exists(self, mock_tempdir, mock_make):"},{"line_number":677,"context_line":"        self.flags(image_conversion_dir\u003d\u0027fake_conv_dir\u0027)"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"        output \u003d image_utils.temporary_dir()"},{"line_number":680,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"0dead6d3_f2eb3720","line":677,"range":{"start_line":677,"start_character":40,"end_line":677,"end_character":55},"updated":"2022-05-16 17:09:59.000000000","message":"given the amount of times we are hardcoding this string, would\u0027ve been better to store this in an instance variable in setUp or __init__ method (but we don\u0027t have one currently) since any change, similar to this, would require refactoring all hard coded strings again.","commit_id":"c8b6a44f710ab4884828d3d11bbf7a0b9c0bdbcf"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"08a468a8414cc4be6a3795535e43a4c34d4a2ad9","unresolved":false,"context_lines":[{"line_number":1772,"context_line":"    @mock.patch(\u0027cinder.image.image_utils.fetch\u0027)"},{"line_number":1773,"context_line":"    @mock.patch(\u0027cinder.image.image_utils.qemu_img_info\u0027)"},{"line_number":1774,"context_line":"    @mock.patch(\u0027cinder.image.image_utils.temporary_file\u0027)"},{"line_number":1775,"context_line":"    # FIXME: what \u0027defaults\u0027 are we talking about here?  By default"},{"line_number":1776,"context_line":"    # compression is not enabled!"},{"line_number":1777,"context_line":"    def test_defaults_compressed(self, mock_temp, mock_info,"},{"line_number":1778,"context_line":"                                 mock_fetch, mock_is_xen, mock_repl_xen,"},{"line_number":1779,"context_line":"                                 mock_copy, mock_convert, mock_check_space,"}],"source_content_type":"text/x-python","patch_set":1,"id":"93a4a93b_c1789413","line":1776,"range":{"start_line":1775,"start_character":4,"end_line":1776,"end_character":33},"updated":"2022-05-16 17:09:59.000000000","message":"Good question which I don\u0027t have an answer to atm.","commit_id":"c8b6a44f710ab4884828d3d11bbf7a0b9c0bdbcf"}]}