)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"8d89f793b08c9b7ea2d59b89ab33f797785e7feb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"68a06b1d_32716d9d","updated":"2022-05-27 15:33:45.000000000","message":"So no plan to raise this problem to the list?","commit_id":"cafdbcb581072a5e3bf0d26868301906fb030724"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8cf2a81b5144686005da9d23f37defb96ab5c269","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1f86454f_9a0f3f2a","updated":"2022-05-12 17:11:42.000000000","message":"Thanks, Gorka.  This makes the issue completely clear to anyone editing our tox.ini!","commit_id":"cafdbcb581072a5e3bf0d26868301906fb030724"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"4c92d06762ddc018e451823e75f235b000c5de9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ede1d463_64417db3","in_reply_to":"68a06b1d_32716d9d","updated":"2022-06-15 09:39:04.000000000","message":"I wasn\u0027t planning to, since cinderlib is the weird project, as it\u0027s the only project that uses a service project as a library to provide a library...","commit_id":"cafdbcb581072a5e3bf0d26868301906fb030724"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a1baa2e1eb996587e8988058234cd6af17064559","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e9652e52_d218d6f6","updated":"2022-09-06 12:05:42.000000000","message":"Didn\u0027t realize this was still sitting around.  It\u0027s important to have this documented because every so often, some joker proposes a patch to move the u-c back to deps, and we don\u0027t want that to happen.","commit_id":"9dc820f2ae32a726d8fe457f471809f57c2b97f0"}],"tox.ini":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6bdd0180fc9951ff6da4f476b8adc8ad453183fd","unresolved":true,"context_lines":[{"line_number":20,"context_line":"# NOTE: Do not remove the install_command because for most of our tox jobs we"},{"line_number":21,"context_line":"#       use the usedevelop, which means that tox will do a pip install -e on"},{"line_number":22,"context_line":"#       our source code on its own."},{"line_number":23,"context_line":"#       So it first installs deps (which has the constraints) and then cinder"},{"line_number":24,"context_line":"#       without constraints, because they are defined in deps, pulling cinder"},{"line_number":25,"context_line":"#       dependencies ignoring the constraints, pulling untested dependencies"},{"line_number":26,"context_line":"#       that can break things."},{"line_number":27,"context_line":"install_command\u003dpython -m pip install -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master} {opts} {packages}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"deps \u003d -r{toxinidir}/test-requirements.txt"}],"source_content_type":"text/x-properties","patch_set":1,"id":"182a3815_b4e71af8","line":26,"range":{"start_line":23,"start_character":0,"end_line":26,"end_character":30},"updated":"2022-05-05 14:01:19.000000000","message":"I keep getting stuck here, for some reason it\u0027s not clear to me whether you are talking about when we have the install_command defined, or when we don\u0027t.  I\u0027ll return later with a suggestion.","commit_id":"2e8db9e73102b1b0753e4d583d140f60c0588319"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"1f9e58051a7bf153d680dc87c95452fe739ebfaa","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# NOTE: Do not remove the install_command because for most of our tox jobs we"},{"line_number":21,"context_line":"#       use the usedevelop, which means that tox will do a pip install -e on"},{"line_number":22,"context_line":"#       our source code on its own."},{"line_number":23,"context_line":"#       So it first installs deps (which has the constraints) and then cinder"},{"line_number":24,"context_line":"#       without constraints, because they are defined in deps, pulling cinder"},{"line_number":25,"context_line":"#       dependencies ignoring the constraints, pulling untested dependencies"},{"line_number":26,"context_line":"#       that can break things."},{"line_number":27,"context_line":"install_command\u003dpython -m pip install -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master} {opts} {packages}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"deps \u003d -r{toxinidir}/test-requirements.txt"}],"source_content_type":"text/x-properties","patch_set":1,"id":"9a90c129_b0d26c8a","line":26,"range":{"start_line":23,"start_character":0,"end_line":26,"end_character":30},"in_reply_to":"182a3815_b4e71af8","updated":"2022-05-12 16:47:06.000000000","message":"Rephrased.","commit_id":"2e8db9e73102b1b0753e4d583d140f60c0588319"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"3c0a98bef1abd3152d92a5faea9086ce5bf93217","unresolved":true,"context_lines":[{"line_number":19,"context_line":"usedevelop \u003d True"},{"line_number":20,"context_line":"# NOTE: Do not move the constraints from the install_command into deps, as that"},{"line_number":21,"context_line":"#       may result in tox using unconstrained/untested dependencies."},{"line_number":22,"context_line":"#       We use \"usedevelop \u003d True\" for tox jobs (except bindep), so tox does 2"},{"line_number":23,"context_line":"#       install calls, one for the deps and another for the cinder source code"},{"line_number":24,"context_line":"#       as editable (pip -e)."},{"line_number":25,"context_line":"#       Without the constraints in the install_command only the first"}],"source_content_type":"text/x-properties","patch_set":2,"id":"5bae26a2_b3c9243d","line":22,"updated":"2022-06-14 13:57:09.000000000","message":"Do we need ``usedevelop \u003d True``? That could eliminate all this confusion and make things work like folks would expect it to. I don\u0027t remember if there was an actual reason to set that to True.","commit_id":"cafdbcb581072a5e3bf0d26868301906fb030724"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"4c92d06762ddc018e451823e75f235b000c5de9b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"usedevelop \u003d True"},{"line_number":20,"context_line":"# NOTE: Do not move the constraints from the install_command into deps, as that"},{"line_number":21,"context_line":"#       may result in tox using unconstrained/untested dependencies."},{"line_number":22,"context_line":"#       We use \"usedevelop \u003d True\" for tox jobs (except bindep), so tox does 2"},{"line_number":23,"context_line":"#       install calls, one for the deps and another for the cinder source code"},{"line_number":24,"context_line":"#       as editable (pip -e)."},{"line_number":25,"context_line":"#       Without the constraints in the install_command only the first"}],"source_content_type":"text/x-properties","patch_set":2,"id":"55b620eb_20c13203","line":22,"in_reply_to":"5bae26a2_b3c9243d","updated":"2022-06-15 09:39:04.000000000","message":"AFAIK that\u0027s how all openstack projects install the projects with tox to facilitate development.\n\nThis way the project is installed in editable mode \"pip -e\" (setuptools \"develop mode\") so we don\u0027t need to reinstall it on the virtual environment every time we make a change in the project\u0027s code: changing branches, rebasing, developing code...","commit_id":"cafdbcb581072a5e3bf0d26868301906fb030724"}]}