)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0ff804881cf658ca9d7923a3441f17f0c819c59d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"afb8845a_1b4b79c0","updated":"2022-05-09 15:02:58.000000000","message":"Thanks for doing this Brian. It might have been (or still be) helpful to arrange the options as a set of patches, starting with the base, and then modifying the files for the various options so we can see the diff in a browser. I downloaded this and diff\u0027d the tick2.rst and tick2-manual.rst files to get a sense of what you added manually.\n\nUnsurprisingly, I think the -manual version most closely resembles what I had in mind, although there\u0027s still quite a bit in there that I would have left out if I were doing it. It\u0027s clear that a lot of it is opinion about what is important, and maybe there\u0027s some cinder context about the important things that I don\u0027t have. Some thoughts:\n\nIn the prelude, the deprecation reminder makes sense to me, and I\u0027m guessing it\u0027s been in multiple cycles\u0027 notes already? I think this sort of thing is also why I would expect that just a blind merge would be a problem. If tick2 is where you\u0027re going to actually drop the thing that has been deprecated for many cycles, a blind merge would have that deprecation reminder from the tock, as well as \"okay we finally did it\" from tick2. The three API notes there (two microversions and a response update) seem like too much detail to me -- I would expect a lot of operators gloss over those normally anyway.\n\nIn the new features section, I guess it seems like calling out all the new driver-specific features is too much. However, since it seems like that section is just as full as it is in the tick2-plus-tock.rst version, I guess that means you think it\u0027s critical to have that stuff in there. Minor features from drivers that only a subset of people use would be a good \"if you care about all the features added, be sure to check out the previous tock release notes\" link item in my opinion. Obviously the policy thing is big and important to bring forward I think, as it impacts everyone and it\u0027s maybe even more significant than *just* being a new feature.\n\nKnown issues are probably good candidates for bringing forward, along with upgrades, and deprecations.\n\nThe things in \"Other notes\" seem too minor to be worth the noise to me, but maybe that\u0027s just lack of context.\n\nAll that said, the -manual version renders to not an insane amount of text, even with the uncharacteristically lengthy policy section. So maybe it\u0027s the right amount of detail, I dunno.","commit_id":"919fc17e06e669477a841de7b1600ba7ee221c32"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"16a4175f8aabaebdbc680b73105c74aad9677172","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9aa8d431_dddf58aa","updated":"2023-07-18 18:49:33.000000000","message":"recheck - regenerate release note examples","commit_id":"919fc17e06e669477a841de7b1600ba7ee221c32"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2e60408998ca6386bb91adf24f55d0bdf33a23f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"76c45f4c_34965077","updated":"2023-03-30 03:46:00.000000000","message":"recheck - regenerate release notes","commit_id":"919fc17e06e669477a841de7b1600ba7ee221c32"}]}