)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c47c88e72bea4920dfe07ec8a50af3f7c944c94b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c97d4c06_3551ed34","updated":"2022-05-25 21:25:02.000000000","message":"Left some comments in case you want to refactor at some point.  Tests look good.  Worth backporting.","commit_id":"f6d8353fd13fed3d2aecfc813fd9b66cb1dfdc78"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"8456e5ab031abc4071498cb23ea4d15b71d44bfb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c38104d8_cddbfed8","updated":"2022-06-02 09:12:35.000000000","message":"Thank you Brian, Jon, panhongyin, Sofia \u0026 Eric. The patch has merged.\n","commit_id":"f6d8353fd13fed3d2aecfc813fd9b66cb1dfdc78"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"bf523c8385819dff1264ecc8434395b8737ae4d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f0afcfc9_2a7cf95e","updated":"2022-05-26 07:01:02.000000000","message":"Thanks Brian for feedback.","commit_id":"f6d8353fd13fed3d2aecfc813fd9b66cb1dfdc78"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"890b5006fd18975cbf59d58e28279c6dd27f840d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"23890d05_ab5e6171","updated":"2022-05-24 13:07:09.000000000","message":"recheck cinder-plugin-ceph-tempest failed due to: /var/run/openvswitch/ovnnb_db.sock not found","commit_id":"f6d8353fd13fed3d2aecfc813fd9b66cb1dfdc78"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"d22b63cbaa602db098d8008a54b9a83fc67aee8a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"16ab2b2d_43b65fb5","updated":"2022-05-25 04:42:32.000000000","message":"recheck cinder-plugin-ceph-tempest failed due to: subnet conflict i.e One or more ports have an IP allocation from this subnet","commit_id":"f6d8353fd13fed3d2aecfc813fd9b66cb1dfdc78"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"9e9807b0ecbe6a1b282c16486a6d9fdd5d337107","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"209d3450_a896cfdd","updated":"2022-05-24 12:10:16.000000000","message":"run-HPE Storage CI\n","commit_id":"f6d8353fd13fed3d2aecfc813fd9b66cb1dfdc78"}],"cinder/volume/drivers/hpe/hpe_3par_common.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c47c88e72bea4920dfe07ec8a50af3f7c944c94b","unresolved":true,"context_lines":[{"line_number":3232,"context_line":"                    if hostname \u003d\u003d hostname_i:"},{"line_number":3233,"context_line":"                        # current host"},{"line_number":3234,"context_line":"                        count \u003d count + 1"},{"line_number":3235,"context_line":"                        if count \u003e 1:"},{"line_number":3236,"context_line":"                            # volume attached to multiple instances on"},{"line_number":3237,"context_line":"                            # current host"},{"line_number":3238,"context_line":"                            same_host \u003d True"},{"line_number":3239,"context_line":"                    else:"},{"line_number":3240,"context_line":"                        # different host"},{"line_number":3241,"context_line":"                        all_hostnames.append(hostname_i)"}],"source_content_type":"text/x-python","patch_set":1,"id":"e7fecad8_cbf177bb","line":3238,"range":{"start_line":3235,"start_character":0,"end_line":3238,"end_character":44},"updated":"2022-05-25 21:25:02.000000000","message":"You could do this *after* the for loop, and then you only have to do it once.","commit_id":"f6d8353fd13fed3d2aecfc813fd9b66cb1dfdc78"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"bf523c8385819dff1264ecc8434395b8737ae4d8","unresolved":false,"context_lines":[{"line_number":3232,"context_line":"                    if hostname \u003d\u003d hostname_i:"},{"line_number":3233,"context_line":"                        # current host"},{"line_number":3234,"context_line":"                        count \u003d count + 1"},{"line_number":3235,"context_line":"                        if count \u003e 1:"},{"line_number":3236,"context_line":"                            # volume attached to multiple instances on"},{"line_number":3237,"context_line":"                            # current host"},{"line_number":3238,"context_line":"                            same_host \u003d True"},{"line_number":3239,"context_line":"                    else:"},{"line_number":3240,"context_line":"                        # different host"},{"line_number":3241,"context_line":"                        all_hostnames.append(hostname_i)"}],"source_content_type":"text/x-python","patch_set":1,"id":"a45db67e_e03ace10","line":3238,"range":{"start_line":3235,"start_character":0,"end_line":3238,"end_character":44},"in_reply_to":"e7fecad8_cbf177bb","updated":"2022-05-26 07:01:02.000000000","message":"Ack","commit_id":"f6d8353fd13fed3d2aecfc813fd9b66cb1dfdc78"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c47c88e72bea4920dfe07ec8a50af3f7c944c94b","unresolved":true,"context_lines":[{"line_number":3251,"context_line":"                    hostnames \u003d \",\".join(all_hostnames)"},{"line_number":3252,"context_line":"                    LOG.info(\"Volume %(volume)s is attached to instances \""},{"line_number":3253,"context_line":"                             \"on multiple hosts %(hostnames)s. Proceed with \""},{"line_number":3254,"context_line":"                             \"deletion of vlun on this host.\","},{"line_number":3255,"context_line":"                             {\u0027volume\u0027: volume.name, \u0027hostnames\u0027: hostnames})"},{"line_number":3256,"context_line":""},{"line_number":3257,"context_line":"        # does 3par know this host by a different name?"}],"source_content_type":"text/x-python","patch_set":1,"id":"214aab5a_eeae4784","line":3254,"range":{"start_line":3254,"start_character":50,"end_line":3254,"end_character":59},"updated":"2022-05-25 21:25:02.000000000","message":"This is a little misleading because of line 3227--\"this host\" will appear in hostnames.  Probably would have been better not to do line 3227, and then instead of \"this host\", you could say hostname here.","commit_id":"f6d8353fd13fed3d2aecfc813fd9b66cb1dfdc78"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"bf523c8385819dff1264ecc8434395b8737ae4d8","unresolved":false,"context_lines":[{"line_number":3251,"context_line":"                    hostnames \u003d \",\".join(all_hostnames)"},{"line_number":3252,"context_line":"                    LOG.info(\"Volume %(volume)s is attached to instances \""},{"line_number":3253,"context_line":"                             \"on multiple hosts %(hostnames)s. Proceed with \""},{"line_number":3254,"context_line":"                             \"deletion of vlun on this host.\","},{"line_number":3255,"context_line":"                             {\u0027volume\u0027: volume.name, \u0027hostnames\u0027: hostnames})"},{"line_number":3256,"context_line":""},{"line_number":3257,"context_line":"        # does 3par know this host by a different name?"}],"source_content_type":"text/x-python","patch_set":1,"id":"d72c3561_560e6cb7","line":3254,"range":{"start_line":3254,"start_character":50,"end_line":3254,"end_character":59},"in_reply_to":"214aab5a_eeae4784","updated":"2022-05-26 07:01:02.000000000","message":"Ack","commit_id":"f6d8353fd13fed3d2aecfc813fd9b66cb1dfdc78"}]}
