)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"af0a19579f56ddc3aae38ac98a4fe0b42e7b7e73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d1590426_1c805acc","updated":"2022-05-26 13:57:07.000000000","message":"Answer inline.","commit_id":"332aa33404f53b39392df3fc37dddb85b5a2890c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"27c045eaa068ea604c5c8549d37de0254cef33a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"599e3e71_6e9008ea","updated":"2022-05-26 13:50:55.000000000","message":"Clean backport, merged in yoga. LGTM. one question inline though.","commit_id":"332aa33404f53b39392df3fc37dddb85b5a2890c"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"ee155b00e2e163a1cb9d8814060c6a2217b5bf2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c1d53a44_8c530c01","updated":"2022-06-02 14:04:02.000000000","message":"This looks like a good backport.  Merging.","commit_id":"332aa33404f53b39392df3fc37dddb85b5a2890c"}],"cinder/backup/api.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"27c045eaa068ea604c5c8549d37de0254cef33a6","unresolved":true,"context_lines":[{"line_number":509,"context_line":""},{"line_number":510,"context_line":"            # If record exists and it\u0027s not deleted we cannot proceed"},{"line_number":511,"context_line":"            # with the import"},{"line_number":512,"context_line":"            if backup.status !\u003d fields.BackupStatus.DELETED:"},{"line_number":513,"context_line":"                msg \u003d _(\u0027Backup already exists in database.\u0027)"},{"line_number":514,"context_line":"                raise exception.InvalidBackup(reason\u003dmsg)"},{"line_number":515,"context_line":"        except exception.BackupNotFound:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9da8a1e5_43483fc7","line":512,"range":{"start_line":512,"start_character":15,"end_line":512,"end_character":28},"updated":"2022-05-26 13:50:55.000000000","message":"If no backup exists, what does the backup variable on L#505 return? does the object returned contains status field?\nI know this is the original code which should be working but just clearing out my doubt.","commit_id":"332aa33404f53b39392df3fc37dddb85b5a2890c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7629ff93a87aefb4c58e969bc8165a6f481a2524","unresolved":false,"context_lines":[{"line_number":509,"context_line":""},{"line_number":510,"context_line":"            # If record exists and it\u0027s not deleted we cannot proceed"},{"line_number":511,"context_line":"            # with the import"},{"line_number":512,"context_line":"            if backup.status !\u003d fields.BackupStatus.DELETED:"},{"line_number":513,"context_line":"                msg \u003d _(\u0027Backup already exists in database.\u0027)"},{"line_number":514,"context_line":"                raise exception.InvalidBackup(reason\u003dmsg)"},{"line_number":515,"context_line":"        except exception.BackupNotFound:"}],"source_content_type":"text/x-python","patch_set":1,"id":"47d1cc35_0b789e1c","line":512,"range":{"start_line":512,"start_character":15,"end_line":512,"end_character":28},"in_reply_to":"22fec072_73f80922","updated":"2022-05-26 14:42:17.000000000","message":"Ack, thanks for the info.","commit_id":"332aa33404f53b39392df3fc37dddb85b5a2890c"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"af0a19579f56ddc3aae38ac98a4fe0b42e7b7e73","unresolved":true,"context_lines":[{"line_number":509,"context_line":""},{"line_number":510,"context_line":"            # If record exists and it\u0027s not deleted we cannot proceed"},{"line_number":511,"context_line":"            # with the import"},{"line_number":512,"context_line":"            if backup.status !\u003d fields.BackupStatus.DELETED:"},{"line_number":513,"context_line":"                msg \u003d _(\u0027Backup already exists in database.\u0027)"},{"line_number":514,"context_line":"                raise exception.InvalidBackup(reason\u003dmsg)"},{"line_number":515,"context_line":"        except exception.BackupNotFound:"}],"source_content_type":"text/x-python","patch_set":1,"id":"22fec072_73f80922","line":512,"range":{"start_line":512,"start_character":15,"end_line":512,"end_character":28},"in_reply_to":"9da8a1e5_43483fc7","updated":"2022-05-26 13:57:07.000000000","message":"If there\u0027s no backup, that call at line 505 raises BackupNotFound, which gets caught at line 515, so we never hit this line in that case.\n\nThe next time we use the backup variable is at line 540, where we make sure it\u0027s not None (which was set at line 497) before we do anything with it.","commit_id":"332aa33404f53b39392df3fc37dddb85b5a2890c"}]}