)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"ba9794aae517d504fdea449c8832e837a9ddde97","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Oleg \u003cOleg_Nesterenkov@Dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-08-03 08:45:33 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"PowerMax Driver - Add support for Unisphere for PowerMax 10.0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements: blueprint powermax-v4-support"},{"line_number":10,"context_line":"Change-Id: Ie9561eeb30a54539cbdfa3e0152ac5383bb02ec6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fd17e8a7_ae582889","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":8},"updated":"2022-08-19 07:26:17.000000000","message":"nit: \"Dell PowerMax\" - so that it is consistent with blueprint \u0026 release note.","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"3107705397b766e50bf74066e8272a76fce967f3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Oleg \u003cOleg_Nesterenkov@Dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-08-03 08:45:33 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"PowerMax Driver - Add support for Unisphere for PowerMax 10.0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements: blueprint powermax-v4-support"},{"line_number":10,"context_line":"Change-Id: Ie9561eeb30a54539cbdfa3e0152ac5383bb02ec6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"056c46da_ee26683e","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":8},"in_reply_to":"fd17e8a7_ae582889","updated":"2022-09-28 16:34:19.000000000","message":"Done","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ceab3579dd005028a368e4d23e40dbb0e4882f3f","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2022-08-03 08:45:33 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"PowerMax Driver - Add support for Unisphere for PowerMax 10.0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements: blueprint powermax-v4-support"},{"line_number":10,"context_line":"Change-Id: Ie9561eeb30a54539cbdfa3e0152ac5383bb02ec6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"c20ea324_d8d6ab67","line":8,"updated":"2022-08-19 08:37:20.000000000","message":"The changes in the files range for a variety of cases, I would like the changes made to support PowerMax 10.0 spelled out in the commit message. If the list of changes is long, just the major changes will do but it\u0027s hard to follow the changes by just looking at the code.","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"3107705397b766e50bf74066e8272a76fce967f3","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2022-08-03 08:45:33 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"PowerMax Driver - Add support for Unisphere for PowerMax 10.0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements: blueprint powermax-v4-support"},{"line_number":10,"context_line":"Change-Id: Ie9561eeb30a54539cbdfa3e0152ac5383bb02ec6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fd155ddb_fd8cea21","line":8,"in_reply_to":"0b6dfee0_9971ad10","updated":"2022-09-28 16:34:19.000000000","message":"The only change I see for being able to support Unisphere for PowerMax v4, is the endpoint url which was initially https://{IPaddress|hostname}:8443/univmax/restapi/92 while it\u0027s https://{IPaddress|hostname}:8443/univmax/restapi/100 in the earlier version","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"50b21dd3e058aa0c61032da4000471f6090b7b50","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2022-08-03 08:45:33 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"PowerMax Driver - Add support for Unisphere for PowerMax 10.0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements: blueprint powermax-v4-support"},{"line_number":10,"context_line":"Change-Id: Ie9561eeb30a54539cbdfa3e0152ac5383bb02ec6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"0b6dfee0_9971ad10","line":8,"in_reply_to":"c20ea324_d8d6ab67","updated":"2022-09-06 14:58:38.000000000","message":"agree with Rajat, it\u0027s a bit hard to review without a nice commit.","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"6273b7766c3d7495686ff6b9caa3107509334ff5","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2022-08-03 08:45:33 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"PowerMax Driver - Add support for Unisphere for PowerMax 10.0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements: blueprint powermax-v4-support"},{"line_number":10,"context_line":"Change-Id: Ie9561eeb30a54539cbdfa3e0152ac5383bb02ec6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"a5fb3bf0_834ebdd6","line":8,"in_reply_to":"fd155ddb_fd8cea21","updated":"2022-09-29 12:34:13.000000000","message":"I have listed the changes we needed to fix in order to support U4P v10","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"d99487ded27af6da70551037a3ea9911e1709983","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"887c7251_f306f308","updated":"2022-06-14 16:54:51.000000000","message":"recheck","commit_id":"975113a634ce11cd30ceaf7468255be5f4c6fad6"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"a21246867a4d2026037e70daca55b4024182fed2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8b3ad75c_577c5e1d","updated":"2022-06-16 19:16:19.000000000","message":"\u0027run-DellEMC PowerMAX CI","commit_id":"427515d53dcaeebc598ef871fcf11ac092b8320b"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"562d3763bc38207b078f5424f84d7a9f557b478a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"47911355_e3d5a0c2","updated":"2022-06-27 14:58:45.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"427515d53dcaeebc598ef871fcf11ac092b8320b"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"355768fb5c0659291f0433ee87771fe3d6068291","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a255b658_faf181e2","updated":"2022-06-24 12:59:11.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"427515d53dcaeebc598ef871fcf11ac092b8320b"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"24881d2ddb8f480819118a464bf5998461235cdf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"331d47e1_6aaaeffb","updated":"2022-07-12 14:36:19.000000000","message":"Looks OK, but it seems to me that this patch is more than just supporting Unisphere 10.\nThere are changes to the deleting storage group code that looks like a bug fix related to deleting the last volume in the group.\nIf this is the case it should be referenced in the release notes and the commit message","commit_id":"3b3cd960fa46911547ccf21b3a06a9fbd018be6b"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"3f7102eb1510e8f8072978379f58c9628dd49628","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"31c4cbe7_bae0696e","updated":"2022-07-01 08:56:02.000000000","message":"recheck","commit_id":"3b3cd960fa46911547ccf21b3a06a9fbd018be6b"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"808fc4dec0daac2ad79100f9930c1146bf034331","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4ec2dbe4_5cc1818a","updated":"2022-06-29 19:48:55.000000000","message":"recheck","commit_id":"3b3cd960fa46911547ccf21b3a06a9fbd018be6b"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"baf282096dfc23905f4ef9fd6495efe85a17101f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"71555ce7_7564a6f0","updated":"2022-06-30 10:46:15.000000000","message":"recheck","commit_id":"3b3cd960fa46911547ccf21b3a06a9fbd018be6b"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"be01de2b88d636b399641d16c3e07f5dc984321d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"81aff91e_f9dbaddb","updated":"2022-06-30 07:01:17.000000000","message":"recheck","commit_id":"3b3cd960fa46911547ccf21b3a06a9fbd018be6b"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"5ff554a8148e2351cdfacb0f58b27bb147acb975","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8504d01e_2f44bcab","updated":"2022-07-04 08:33:36.000000000","message":"recheck","commit_id":"3b3cd960fa46911547ccf21b3a06a9fbd018be6b"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"8eaf2e463a8a4eb41dd75fbee7877d49037da8ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"03e0dcb1_323f8cd7","updated":"2022-07-06 03:41:55.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"3b3cd960fa46911547ccf21b3a06a9fbd018be6b"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"e8611a0b640484539236370eb357fbdfe420fa6c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1209e10a_323af0c5","updated":"2022-07-19 00:20:50.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"3b3cd960fa46911547ccf21b3a06a9fbd018be6b"},{"author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"change_message_id":"dde0e2450aa571f56e1e9b6a8e81221a257ae47d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1ee67f18_0855f7c0","updated":"2022-07-27 09:14:46.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"3b3cd960fa46911547ccf21b3a06a9fbd018be6b"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"b960ced937e584deb68032b98c73a01879579216","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2552e578_fa4c78e6","updated":"2022-07-25 09:12:59.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"3b3cd960fa46911547ccf21b3a06a9fbd018be6b"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"8a915b61743a49c8ec532673e33c6378269bfcf7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2cd6e0c7_972746c1","updated":"2022-07-22 06:19:43.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"3b3cd960fa46911547ccf21b3a06a9fbd018be6b"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"d72c6c91a835553c85e783704b27fddd409f2c3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"48702f9c_226486e6","updated":"2022-07-06 23:45:20.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"3b3cd960fa46911547ccf21b3a06a9fbd018be6b"},{"author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"change_message_id":"adf5b858b4b42137e64f3591e58485caf09bf537","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"547511dc_cf6e3bd0","updated":"2022-07-26 00:43:54.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"3b3cd960fa46911547ccf21b3a06a9fbd018be6b"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"a5be87e26e0d90f208380f71206ec25a2fcd1bec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6bdb40b7_983e214a","updated":"2022-07-06 01:55:53.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"3b3cd960fa46911547ccf21b3a06a9fbd018be6b"},{"author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"change_message_id":"a0b732a3dbc32a7a6e70c07368bc6dd68c495830","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"719fe9d7_7fb23857","updated":"2022-07-25 15:07:27.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"3b3cd960fa46911547ccf21b3a06a9fbd018be6b"},{"author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"change_message_id":"9ce962f3c558a374ed860c3a1d249fdac73b60a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"75e1403e_19426462","updated":"2022-07-28 08:00:06.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"3b3cd960fa46911547ccf21b3a06a9fbd018be6b"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"4e47e94133e7c4071fe1aee679995131e523958d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"76b9579a_67fe9edd","updated":"2022-07-05 10:38:55.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"3b3cd960fa46911547ccf21b3a06a9fbd018be6b"},{"author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"change_message_id":"7e20b8cbae0083390ad7c6676dc1bbf4f2fe27f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"921c797c_992fd928","updated":"2022-07-29 07:51:03.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"3b3cd960fa46911547ccf21b3a06a9fbd018be6b"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"db1ac9a15311c3d0477bae0d6c99ebe53e5cfc7d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9665f395_e163cb0d","updated":"2022-07-12 15:15:27.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"3b3cd960fa46911547ccf21b3a06a9fbd018be6b"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"24f0711c1be46a0e213a782fb780d18750e181b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9bdd30bd_ffff903f","updated":"2022-07-18 14:28:18.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"3b3cd960fa46911547ccf21b3a06a9fbd018be6b"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"b5b26bf62ab4d5791eb8693700d1c8a62da35605","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9cf79577_372f1d9f","updated":"2022-07-18 12:51:07.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"3b3cd960fa46911547ccf21b3a06a9fbd018be6b"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"b6ad5e0895168ef4410731633877704165d83cd6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9df5bd87_fb791939","updated":"2022-07-06 07:54:35.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"3b3cd960fa46911547ccf21b3a06a9fbd018be6b"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"ec331b02d23ee245729aa4dce2d5212ea4220646","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"af095b30_80659cc4","updated":"2022-07-06 08:03:12.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"3b3cd960fa46911547ccf21b3a06a9fbd018be6b"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"363cc3a22589d9764005d9c828657f9ffb2a3c77","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b6ef0df7_abe306ee","updated":"2022-07-12 03:02:43.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"3b3cd960fa46911547ccf21b3a06a9fbd018be6b"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"7cbd941e4e95dc31c03204b821548691898d950e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d0332932_4e920dc1","updated":"2022-07-18 15:31:18.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"3b3cd960fa46911547ccf21b3a06a9fbd018be6b"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"daee49491147b447a40ececb217b740b22a51ab8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d3eee6ce_568f6644","updated":"2022-07-06 05:58:25.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"3b3cd960fa46911547ccf21b3a06a9fbd018be6b"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"071ce53184b7f2bcd052d0df423a37e22523966f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"dc633526_e6d3120e","updated":"2022-07-12 08:09:19.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"3b3cd960fa46911547ccf21b3a06a9fbd018be6b"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"6896a5461c8d9b9b7d553543ba3d76dc08c0994a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e9e260c5_b783d25e","updated":"2022-07-12 08:06:24.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"3b3cd960fa46911547ccf21b3a06a9fbd018be6b"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"e17d21ccf8fc850e136270f2f982c7fbbda84bd7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fb8bb7d1_f311068f","updated":"2022-07-13 02:43:52.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"3b3cd960fa46911547ccf21b3a06a9fbd018be6b"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"5e9ee2dd75e5801921852311c566ae969f22fba5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4a673460_8908de32","in_reply_to":"331d47e1_6aaaeffb","updated":"2022-08-03 08:49:51.000000000","message":"Hi Simon, this is an optimization that covers the edge case may occur. We haven\u0027t got any bugs related to this code yet.","commit_id":"3b3cd960fa46911547ccf21b3a06a9fbd018be6b"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"ba9794aae517d504fdea449c8832e837a9ddde97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8f5ef89c_b89def4a","updated":"2022-08-19 07:26:17.000000000","message":"Apart from couple of minor comments, code changes look good.\nThe DellEMC PowerMAX CI and Zuul have passed.\n","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"2884b21d25a203a533058791615dab403f73763a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fee586ae_998f0fa9","updated":"2022-08-27 09:03:04.000000000","message":"Hi Oleg Nesterenkov, please see my comments inline.","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":34988,"name":"Andrey Pakhomov","email":"a.pakhomov@dell.com"},"change_message_id":"bfd2711436584d8df48e129bec5311121accd36f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c1bf7b68_76118944","updated":"2022-08-09 07:51:43.000000000","message":"LGTM, PowerMax CI passed","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":31981,"name":"Tarun Mathur","email":"tarun.mathur@dell.com"},"change_message_id":"7333c89a9c4b1a56f92c3cb85dd639f4f1cd7c7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bfdb97f1_c12e0a88","updated":"2022-08-17 10:43:54.000000000","message":"May I request some eyes on this one? This patch adds support for new platforms that the Dell PowerMax team has recently released to the market.","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"50b21dd3e058aa0c61032da4000471f6090b7b50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"414ab5ca_bb7f3309","updated":"2022-09-06 14:58:38.000000000","message":"Thanks Oleg, it\u0027s a bit complicated to review the change without a robust commit message explaining it. Please, provide a better commit message.","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ceab3579dd005028a368e4d23e40dbb0e4882f3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"094829ee_9522c8eb","updated":"2022-08-19 08:37:20.000000000","message":"few questions and suggestions inline.","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"c0ad28316126089c49f5f83601ac3a4e92e52911","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"40c208c9_d2bad503","updated":"2022-08-04 01:58:13.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"9fe7c31cbf0df9b1b5bd0aa668c7d0ca10ab55c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cf5ae5e1_9e212339","updated":"2022-08-04 06:51:16.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"70e251db0cd2d164d5cdb1057db26f5355c3ca54","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"df0613db_7c73b431","updated":"2022-09-26 07:25:44.000000000","message":"recheck","commit_id":"612cfccf0eff199893488141db938b151a83ee7e"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"773a41c7da1928a6470cca6fabcb5b9616c7bb27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"fe4d5b24_0c83ef21","updated":"2022-09-26 09:49:24.000000000","message":"recheck devstack-plugin-nfs-tempest-full timed out","commit_id":"612cfccf0eff199893488141db938b151a83ee7e"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"b7b301d7ddfec28232bf47958dea9acc943a1e45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"00e446b5_0d8e4278","updated":"2022-09-26 15:27:50.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"612cfccf0eff199893488141db938b151a83ee7e"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"a5e2294438207c3b27477b722297961b6e76c94d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"9e3fec04_b9a1ddc5","updated":"2022-10-06 13:49:58.000000000","message":"Looks good, but need to see the PowerMAX CI pass for this latest patchset","commit_id":"1935c6a81a95fa8e1dd26ea425b638eda732da4a"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"b4194b6849fcb3e57652e03afc2440ce3504b73b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"08e818e5_a863c371","updated":"2022-10-06 19:10:05.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"1935c6a81a95fa8e1dd26ea425b638eda732da4a"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"c23e8c7ed8f88eef3ba53c8f7be939901f12c9e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"334dc954_0f8c6949","updated":"2022-10-06 20:13:58.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"1935c6a81a95fa8e1dd26ea425b638eda732da4a"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"243f98507190bd12babb76f0b7891a238c13b3ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"3735a2d2_8c2c9bc6","updated":"2022-10-06 13:52:07.000000000","message":"run-DellEMC PowerMax CI","commit_id":"1935c6a81a95fa8e1dd26ea425b638eda732da4a"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"2c318dedfaab102d7f6a42e37ff76658b781f9e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"0438c556_9916a663","updated":"2022-11-24 00:40:36.000000000","message":"LGTM, just an extra code recommendation, feel free to change or not.","commit_id":"142b3e0a8867df9dd3b8f06a5b73276a9b1190bd"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"1dde03632cb6fa17e2968de414e5f6d13e77ca31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"014e90b5_110c134d","updated":"2022-11-23 01:45:19.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"142b3e0a8867df9dd3b8f06a5b73276a9b1190bd"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"8e71664e9b4fc1aff95883ce9eacc6e71bc8ed68","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"02df8f45_f2593d80","updated":"2022-11-26 08:51:08.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"142b3e0a8867df9dd3b8f06a5b73276a9b1190bd"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"1e6c07f693feadbfe1a73c86cd9915d45bb2a793","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"7c031dc3_a004b58b","updated":"2022-11-23 02:26:15.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"142b3e0a8867df9dd3b8f06a5b73276a9b1190bd"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"f2620172ca7cc17ea27dd7b90e45bbf72e348be9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"82feed0f_da5ea0b2","updated":"2022-10-07 14:19:02.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"142b3e0a8867df9dd3b8f06a5b73276a9b1190bd"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"1f5fa94a793e3a9b66cb79dbc02b0908f04a80b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"8fbc9ba4_f9610416","updated":"2022-11-23 01:37:09.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"142b3e0a8867df9dd3b8f06a5b73276a9b1190bd"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"0fbbca6c89c4660a70a56c6464188a1ab3a2bf46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"bd29a589_4fa1577a","updated":"2022-11-28 02:29:16.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"142b3e0a8867df9dd3b8f06a5b73276a9b1190bd"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"b647645e1b99cffd6839f49c5141409f5dd68782","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"c69a2d31_c736fead","updated":"2022-11-23 01:53:06.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"142b3e0a8867df9dd3b8f06a5b73276a9b1190bd"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"dedb631ba8c0bf284e9dc0c60ea58d661574e7e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"e7f633df_e0d2965d","updated":"2022-11-29 01:15:13.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"142b3e0a8867df9dd3b8f06a5b73276a9b1190bd"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e2dac77753dc920b8e2a95412b0dae3f2ed4aa20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"4e5fe12b_389b21e9","updated":"2023-02-02 10:44:12.000000000","message":"Code and tests looks good. Releasenote also looks correct. PowerMax CI for iscsi and FC are passing. LGTM.","commit_id":"567f2a1b082c51b78d079497ec555fe3a608dfa0"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"3c41e26c326056e7c687d4444d3eaaab47176850","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"908e9806_d1ee46ae","updated":"2023-02-14 17:02:45.000000000","message":"Code looks ok to me.  Limited to vendor driver and it is passing 3rd Party CI.","commit_id":"567f2a1b082c51b78d079497ec555fe3a608dfa0"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"ed9195c225ae1a986abcf601fa74f0bb65190f85","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"4a28d4d4_ca653ffc","updated":"2022-12-02 17:05:27.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"567f2a1b082c51b78d079497ec555fe3a608dfa0"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"083017806b0638c5e75f02d4adc002235a24ae51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"7c5c7ac7_52a6dbd6","updated":"2022-12-06 06:49:35.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"567f2a1b082c51b78d079497ec555fe3a608dfa0"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"4ae5e7fc79d46e4509be2af484ca9b236e0cf3ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"a25c4cfe_7df0eac7","updated":"2022-12-05 09:46:26.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"567f2a1b082c51b78d079497ec555fe3a608dfa0"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"35760fdfdc08dc605484065692ea53c97e0ff97e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"a3346b34_cded8418","updated":"2022-12-05 17:54:54.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"567f2a1b082c51b78d079497ec555fe3a608dfa0"}],"cinder/volume/drivers/dell_emc/powermax/common.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ceab3579dd005028a368e4d23e40dbb0e4882f3f","unresolved":true,"context_lines":[{"line_number":229,"context_line":"                      \"configuration and note that the xml file is no \""},{"line_number":230,"context_line":"                      \"longer supported.\")"},{"line_number":231,"context_line":"        self.rest.set_rest_credentials(array_info)"},{"line_number":232,"context_line":"        self.rest.validate_unisphere_version()"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        if array_info:"},{"line_number":235,"context_line":"            serial_number \u003d array_info[\u0027SerialNumber\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"25db4949_439ca57e","line":232,"range":{"start_line":232,"start_character":8,"end_line":232,"end_character":46},"updated":"2022-08-19 08:37:20.000000000","message":"any reason for moving this check from __init__ to here?\nMoving it here will cause only callers of _gather_info to validate the version and not while initializing the driver","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"4042fe4ec4bf6e8cee7c5bc93fb4bb1272cc5717","unresolved":false,"context_lines":[{"line_number":229,"context_line":"                      \"configuration and note that the xml file is no \""},{"line_number":230,"context_line":"                      \"longer supported.\")"},{"line_number":231,"context_line":"        self.rest.set_rest_credentials(array_info)"},{"line_number":232,"context_line":"        self.rest.validate_unisphere_version()"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        if array_info:"},{"line_number":235,"context_line":"            serial_number \u003d array_info[\u0027SerialNumber\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"0b295ead_87d6795b","line":232,"range":{"start_line":232,"start_character":8,"end_line":232,"end_character":46},"in_reply_to":"25db4949_439ca57e","updated":"2022-10-04 08:00:20.000000000","message":"Moved it back to __init__","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ceab3579dd005028a368e4d23e40dbb0e4882f3f","unresolved":true,"context_lines":[{"line_number":858,"context_line":"            mv_list, sg_list \u003d ("},{"line_number":859,"context_line":"                self._get_mvs_and_sgs_from_volume("},{"line_number":860,"context_line":"                    extra_specs[utils.ARRAY],"},{"line_number":861,"context_line":"                    device_info.get(\u0027device_id\u0027)))"},{"line_number":862,"context_line":"        self.volume_metadata.capture_detach_info("},{"line_number":863,"context_line":"            volume, extra_specs, device_info.get(\u0027device_id\u0027), mv_list,"},{"line_number":864,"context_line":"            sg_list)"}],"source_content_type":"text/x-python","patch_set":5,"id":"824d5f9c_d9d03e0d","line":861,"range":{"start_line":861,"start_character":31,"end_line":861,"end_character":50},"updated":"2022-08-19 08:37:20.000000000","message":"is device_id optional now?","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"4042fe4ec4bf6e8cee7c5bc93fb4bb1272cc5717","unresolved":false,"context_lines":[{"line_number":858,"context_line":"            mv_list, sg_list \u003d ("},{"line_number":859,"context_line":"                self._get_mvs_and_sgs_from_volume("},{"line_number":860,"context_line":"                    extra_specs[utils.ARRAY],"},{"line_number":861,"context_line":"                    device_info.get(\u0027device_id\u0027)))"},{"line_number":862,"context_line":"        self.volume_metadata.capture_detach_info("},{"line_number":863,"context_line":"            volume, extra_specs, device_info.get(\u0027device_id\u0027), mv_list,"},{"line_number":864,"context_line":"            sg_list)"}],"source_content_type":"text/x-python","patch_set":5,"id":"b540f8d8_6f478dff","line":861,"range":{"start_line":861,"start_character":31,"end_line":861,"end_character":50},"in_reply_to":"16debf47_a13a83f6","updated":"2022-10-04 08:00:20.000000000","message":"Ack","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"31d18f8c7f7aa6ddd3bad93b82f54bb4478fcaaf","unresolved":true,"context_lines":[{"line_number":858,"context_line":"            mv_list, sg_list \u003d ("},{"line_number":859,"context_line":"                self._get_mvs_and_sgs_from_volume("},{"line_number":860,"context_line":"                    extra_specs[utils.ARRAY],"},{"line_number":861,"context_line":"                    device_info.get(\u0027device_id\u0027)))"},{"line_number":862,"context_line":"        self.volume_metadata.capture_detach_info("},{"line_number":863,"context_line":"            volume, extra_specs, device_info.get(\u0027device_id\u0027), mv_list,"},{"line_number":864,"context_line":"            sg_list)"}],"source_content_type":"text/x-python","patch_set":5,"id":"16debf47_a13a83f6","line":861,"range":{"start_line":861,"start_character":31,"end_line":861,"end_character":50},"in_reply_to":"824d5f9c_d9d03e0d","updated":"2022-09-29 12:45:33.000000000","message":"no, it\u0027s still required","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ceab3579dd005028a368e4d23e40dbb0e4882f3f","unresolved":true,"context_lines":[{"line_number":3005,"context_line":"        snapvx_tgt, snapvx_src, __ \u003d self.rest.is_vol_in_rep_session("},{"line_number":3006,"context_line":"            array, device_id)"},{"line_number":3007,"context_line":""},{"line_number":3008,"context_line":"        LOG.debug(\"Device %(dev)s is snapVX target: %(tgt)s and \""},{"line_number":3009,"context_line":"                  \"snapVX source: %(src)s.\","},{"line_number":3010,"context_line":"                  {\u0027dev\u0027: device_id, \u0027tgt\u0027: snapvx_tgt, \u0027src\u0027: snapvx_src})"},{"line_number":3011,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5c360452_d025a7c1","line":3008,"range":{"start_line":3008,"start_character":34,"end_line":3008,"end_character":36},"updated":"2022-08-19 08:37:20.000000000","message":"nit: has\nThe log statement is confusing to me, are we trying to state that the device \u003cdevice_id\u003e has source \u003csource_id\u003e and target \u003ctarget_id\u003e or anything else?","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"3107705397b766e50bf74066e8272a76fce967f3","unresolved":true,"context_lines":[{"line_number":3005,"context_line":"        snapvx_tgt, snapvx_src, __ \u003d self.rest.is_vol_in_rep_session("},{"line_number":3006,"context_line":"            array, device_id)"},{"line_number":3007,"context_line":""},{"line_number":3008,"context_line":"        LOG.debug(\"Device %(dev)s is snapVX target: %(tgt)s and \""},{"line_number":3009,"context_line":"                  \"snapVX source: %(src)s.\","},{"line_number":3010,"context_line":"                  {\u0027dev\u0027: device_id, \u0027tgt\u0027: snapvx_tgt, \u0027src\u0027: snapvx_src})"},{"line_number":3011,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ce89e388_d2de7cc2","line":3008,"range":{"start_line":3008,"start_character":34,"end_line":3008,"end_character":36},"in_reply_to":"5c360452_d025a7c1","updated":"2022-09-28 16:34:19.000000000","message":"This statement tells if the device_id is a snapVX target or a snapVX source, and is therefore involved into a local replication which needs to be correctly handle. snapvx_tgt and snapvx_src are boolean and don\u0027t reflect IDs.","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"b229bc6521c16c2bbd23ff9a06400ad3244e8671","unresolved":false,"context_lines":[{"line_number":3005,"context_line":"        snapvx_tgt, snapvx_src, __ \u003d self.rest.is_vol_in_rep_session("},{"line_number":3006,"context_line":"            array, device_id)"},{"line_number":3007,"context_line":""},{"line_number":3008,"context_line":"        LOG.debug(\"Device %(dev)s is snapVX target: %(tgt)s and \""},{"line_number":3009,"context_line":"                  \"snapVX source: %(src)s.\","},{"line_number":3010,"context_line":"                  {\u0027dev\u0027: device_id, \u0027tgt\u0027: snapvx_tgt, \u0027src\u0027: snapvx_src})"},{"line_number":3011,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"eb184049_3b9561ae","line":3008,"range":{"start_line":3008,"start_character":34,"end_line":3008,"end_character":36},"in_reply_to":"67979c8e_6130134e","updated":"2022-10-03 15:04:13.000000000","message":"Will refactor this piece of code to make it more crystal clear","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"b09aaea6a1ab6f9b9efb33fd94408789e80f36c7","unresolved":true,"context_lines":[{"line_number":3005,"context_line":"        snapvx_tgt, snapvx_src, __ \u003d self.rest.is_vol_in_rep_session("},{"line_number":3006,"context_line":"            array, device_id)"},{"line_number":3007,"context_line":""},{"line_number":3008,"context_line":"        LOG.debug(\"Device %(dev)s is snapVX target: %(tgt)s and \""},{"line_number":3009,"context_line":"                  \"snapVX source: %(src)s.\","},{"line_number":3010,"context_line":"                  {\u0027dev\u0027: device_id, \u0027tgt\u0027: snapvx_tgt, \u0027src\u0027: snapvx_src})"},{"line_number":3011,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"67979c8e_6130134e","line":3008,"range":{"start_line":3008,"start_character":34,"end_line":3008,"end_character":36},"in_reply_to":"ce89e388_d2de7cc2","updated":"2022-09-29 12:42:36.000000000","message":"So in my understanding, should end up with something like \u0027Device %(dev)s is snapVX target: True and snapVX source: False\u0027 if I\u0027m not mistaken","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"}],"cinder/volume/drivers/dell_emc/powermax/provision.py":[{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"2884b21d25a203a533058791615dab403f73763a","unresolved":true,"context_lines":[{"line_number":477,"context_line":"            array_reserve_percent \u003d srp_details[\u0027reserved_cap_percent\u0027]"},{"line_number":478,"context_line":"        except KeyError:"},{"line_number":479,"context_line":"            try:"},{"line_number":480,"context_line":"                srp_capacity \u003d srp_details[\u0027fba_srp_capacity\u0027]"},{"line_number":481,"context_line":"                effective_capacity \u003d srp_capacity[\u0027effective\u0027]"},{"line_number":482,"context_line":"                total_capacity_gb \u003d effective_capacity[\u0027total_tb\u0027] * units.Ki"},{"line_number":483,"context_line":"                remaining_capacity_gb \u003d ("}],"source_content_type":"text/x-python","patch_set":5,"id":"3a5ffd01_59e4ab28","line":480,"updated":"2022-08-27 09:03:04.000000000","message":"I think it would be nice to have a comment here explaining why and in which case srp reports fba_srp_capacity instead of srp_capacity.","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"6273b7766c3d7495686ff6b9caa3107509334ff5","unresolved":false,"context_lines":[{"line_number":477,"context_line":"            array_reserve_percent \u003d srp_details[\u0027reserved_cap_percent\u0027]"},{"line_number":478,"context_line":"        except KeyError:"},{"line_number":479,"context_line":"            try:"},{"line_number":480,"context_line":"                srp_capacity \u003d srp_details[\u0027fba_srp_capacity\u0027]"},{"line_number":481,"context_line":"                effective_capacity \u003d srp_capacity[\u0027effective\u0027]"},{"line_number":482,"context_line":"                total_capacity_gb \u003d effective_capacity[\u0027total_tb\u0027] * units.Ki"},{"line_number":483,"context_line":"                remaining_capacity_gb \u003d ("}],"source_content_type":"text/x-python","patch_set":5,"id":"84902ae3_0e4a800c","line":480,"in_reply_to":"1a47ad6f_ebb527bf","updated":"2022-09-29 12:34:13.000000000","message":"Done","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"9fea3dbfa9fb141c72e396fba9c847c2a6de7b5e","unresolved":true,"context_lines":[{"line_number":477,"context_line":"            array_reserve_percent \u003d srp_details[\u0027reserved_cap_percent\u0027]"},{"line_number":478,"context_line":"        except KeyError:"},{"line_number":479,"context_line":"            try:"},{"line_number":480,"context_line":"                srp_capacity \u003d srp_details[\u0027fba_srp_capacity\u0027]"},{"line_number":481,"context_line":"                effective_capacity \u003d srp_capacity[\u0027effective\u0027]"},{"line_number":482,"context_line":"                total_capacity_gb \u003d effective_capacity[\u0027total_tb\u0027] * units.Ki"},{"line_number":483,"context_line":"                remaining_capacity_gb \u003d ("}],"source_content_type":"text/x-python","patch_set":5,"id":"1a47ad6f_ebb527bf","line":480,"in_reply_to":"32072500_bc5d1da0","updated":"2022-09-28 16:42:23.000000000","message":"After further investigations, this name based upton the version of the REST API endpoint (92 vs 100)","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"3107705397b766e50bf74066e8272a76fce967f3","unresolved":true,"context_lines":[{"line_number":477,"context_line":"            array_reserve_percent \u003d srp_details[\u0027reserved_cap_percent\u0027]"},{"line_number":478,"context_line":"        except KeyError:"},{"line_number":479,"context_line":"            try:"},{"line_number":480,"context_line":"                srp_capacity \u003d srp_details[\u0027fba_srp_capacity\u0027]"},{"line_number":481,"context_line":"                effective_capacity \u003d srp_capacity[\u0027effective\u0027]"},{"line_number":482,"context_line":"                total_capacity_gb \u003d effective_capacity[\u0027total_tb\u0027] * units.Ki"},{"line_number":483,"context_line":"                remaining_capacity_gb \u003d ("}],"source_content_type":"text/x-python","patch_set":5,"id":"32072500_bc5d1da0","line":480,"in_reply_to":"3a5ffd01_59e4ab28","updated":"2022-09-28 16:34:19.000000000","message":"I think this piece of code needs to be refactored. \nSRP Capacity generally holds data for both CKD and FBA emulation. While FBA (Fixed Block Architecture) is used by most of Open systems, CKD are reserved for IBM Mainframe, which doesn\u0027t make any sense here. \nThe only reason I can see, is on an array where both CKD and FBA emulation are used.","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"}],"cinder/volume/drivers/dell_emc/powermax/rest.py":[{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"0adf374ca68d77069771955a634aabf6966bcdee","unresolved":true,"context_lines":[{"line_number":1829,"context_line":"            resource_level_id\u003darray_id, resource_type\u003d\u0027director\u0027,"},{"line_number":1830,"context_line":"            resource_type_id\u003ddirector_id, resource\u003d\u0027port\u0027)"},{"line_number":1831,"context_line":"        # This is a temporary solution"},{"line_number":1832,"context_line":"        import time"},{"line_number":1833,"context_line":"        time.sleep(2)"},{"line_number":1834,"context_line":"        port_info \u003d self.get_request("},{"line_number":1835,"context_line":"            target_uri, \u0027port IP interface\u0027, params)"}],"source_content_type":"text/x-python","patch_set":3,"id":"aa19dd0d_ce8fe06b","line":1832,"updated":"2022-06-29 12:25:13.000000000","message":"Need to move import at the beginning, because of u use time several times.","commit_id":"427515d53dcaeebc598ef871fcf11ac092b8320b"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"5adf18f58f3ab4eb7507492c1a0823defa3eef8c","unresolved":false,"context_lines":[{"line_number":1829,"context_line":"            resource_level_id\u003darray_id, resource_type\u003d\u0027director\u0027,"},{"line_number":1830,"context_line":"            resource_type_id\u003ddirector_id, resource\u003d\u0027port\u0027)"},{"line_number":1831,"context_line":"        # This is a temporary solution"},{"line_number":1832,"context_line":"        import time"},{"line_number":1833,"context_line":"        time.sleep(2)"},{"line_number":1834,"context_line":"        port_info \u003d self.get_request("},{"line_number":1835,"context_line":"            target_uri, \u0027port IP interface\u0027, params)"}],"source_content_type":"text/x-python","patch_set":3,"id":"f204a610_a157e596","line":1832,"in_reply_to":"aa19dd0d_ce8fe06b","updated":"2022-07-05 07:36:37.000000000","message":"Done","commit_id":"427515d53dcaeebc598ef871fcf11ac092b8320b"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"ba9794aae517d504fdea449c8832e837a9ddde97","unresolved":true,"context_lines":[{"line_number":36,"context_line":"SLOPROVISIONING \u003d \u0027sloprovisioning\u0027"},{"line_number":37,"context_line":"REPLICATION \u003d \u0027replication\u0027"},{"line_number":38,"context_line":"SYSTEM \u003d \u0027system\u0027"},{"line_number":39,"context_line":"U4V_10_VERSION \u003d \u0027100\u0027"},{"line_number":40,"context_line":"MIN_U4P_100_VERSION \u003d \u002710.0.0.0\u0027"},{"line_number":41,"context_line":"U4V_92_VERSION \u003d \u002792\u0027"},{"line_number":42,"context_line":"MIN_U4P_92_VERSION \u003d \u00279.2.0.0\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"e6c58804_54fbb05e","line":39,"range":{"start_line":39,"start_character":0,"end_line":39,"end_character":14},"updated":"2022-08-19 07:26:17.000000000","message":"nit: In case another patchset is submitted, this can be updated as \"U4V_100_VERSION\";\nso that it is consistent with constants defined in next 3 lines.","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"4e71ac8f7439bef871d45d0d1003f20aa61056b0","unresolved":false,"context_lines":[{"line_number":36,"context_line":"SLOPROVISIONING \u003d \u0027sloprovisioning\u0027"},{"line_number":37,"context_line":"REPLICATION \u003d \u0027replication\u0027"},{"line_number":38,"context_line":"SYSTEM \u003d \u0027system\u0027"},{"line_number":39,"context_line":"U4V_10_VERSION \u003d \u0027100\u0027"},{"line_number":40,"context_line":"MIN_U4P_100_VERSION \u003d \u002710.0.0.0\u0027"},{"line_number":41,"context_line":"U4V_92_VERSION \u003d \u002792\u0027"},{"line_number":42,"context_line":"MIN_U4P_92_VERSION \u003d \u00279.2.0.0\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa286ef6_afc8bcd8","line":39,"range":{"start_line":39,"start_character":0,"end_line":39,"end_character":14},"in_reply_to":"e6c58804_54fbb05e","updated":"2022-09-27 13:07:54.000000000","message":"Done","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"2884b21d25a203a533058791615dab403f73763a","unresolved":true,"context_lines":[{"line_number":850,"context_line":"            array_model \u003d system_info.get(\u0027model\u0027)"},{"line_number":851,"context_line":"        if system_info:"},{"line_number":852,"context_line":"            ucode \u003d system_info.get(\u0027ucode\u0027, system_info.get(\u0027microcode\u0027))"},{"line_number":853,"context_line":"            ucode_version \u003d ucode.split(\u0027.\u0027)[0]"},{"line_number":854,"context_line":"            if ucode_version \u003e\u003d UCODE_5978:"},{"line_number":855,"context_line":"                is_next_gen \u003d True"},{"line_number":856,"context_line":"        return array_model, is_next_gen"}],"source_content_type":"text/x-python","patch_set":5,"id":"d1816ce0_8133349d","line":853,"updated":"2022-08-27 09:03:04.000000000","message":"nit: Is microcode always available if ucode does not exists as key? I\u0027m asking because you are using a .get() and in case it returns its default (because microcode does no exist as a key), the split ucode.split(\u0027.\u0027)[0] in the next line will break the code.\n\nIf microcode is always available in a scenario that ucode does not exist, you could access it directly using system_info[\u0027microcode\u0027] instead.\n\nIn case of a scenario where you have both ucode and microcode missing, the stack trace would point to missing microcode key which would be easier to debug.","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"6273b7766c3d7495686ff6b9caa3107509334ff5","unresolved":false,"context_lines":[{"line_number":850,"context_line":"            array_model \u003d system_info.get(\u0027model\u0027)"},{"line_number":851,"context_line":"        if system_info:"},{"line_number":852,"context_line":"            ucode \u003d system_info.get(\u0027ucode\u0027, system_info.get(\u0027microcode\u0027))"},{"line_number":853,"context_line":"            ucode_version \u003d ucode.split(\u0027.\u0027)[0]"},{"line_number":854,"context_line":"            if ucode_version \u003e\u003d UCODE_5978:"},{"line_number":855,"context_line":"                is_next_gen \u003d True"},{"line_number":856,"context_line":"        return array_model, is_next_gen"}],"source_content_type":"text/x-python","patch_set":5,"id":"26d0360b_d3aac0a3","line":853,"in_reply_to":"ac83f0a7_cfca1beb","updated":"2022-09-29 12:34:13.000000000","message":"Done","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"76e68501a0ba3ab5f573d43a0c72a9d17c8e0e0b","unresolved":true,"context_lines":[{"line_number":850,"context_line":"            array_model \u003d system_info.get(\u0027model\u0027)"},{"line_number":851,"context_line":"        if system_info:"},{"line_number":852,"context_line":"            ucode \u003d system_info.get(\u0027ucode\u0027, system_info.get(\u0027microcode\u0027))"},{"line_number":853,"context_line":"            ucode_version \u003d ucode.split(\u0027.\u0027)[0]"},{"line_number":854,"context_line":"            if ucode_version \u003e\u003d UCODE_5978:"},{"line_number":855,"context_line":"                is_next_gen \u003d True"},{"line_number":856,"context_line":"        return array_model, is_next_gen"}],"source_content_type":"text/x-python","patch_set":5,"id":"ac83f0a7_cfca1beb","line":853,"in_reply_to":"d1816ce0_8133349d","updated":"2022-09-29 12:26:21.000000000","message":"At least ucode or microcode should be available. If we are talking to 92 endpoint, ucode should be used while ucrocode is for 100 endpoint.\nIf none of them are available, then it means the array is unreachable or not a PowerMax.","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ceab3579dd005028a368e4d23e40dbb0e4882f3f","unresolved":true,"context_lines":[{"line_number":1828,"context_line":"            category\u003dSYSTEM, resource_level\u003d\u0027symmetrix\u0027,"},{"line_number":1829,"context_line":"            resource_level_id\u003darray_id, resource_type\u003d\u0027director\u0027,"},{"line_number":1830,"context_line":"            resource_type_id\u003ddirector_id, resource\u003d\u0027port\u0027)"},{"line_number":1831,"context_line":"        # This is a temporary solution"},{"line_number":1832,"context_line":"        time.sleep(2)"},{"line_number":1833,"context_line":"        port_info \u003d self.get_request("},{"line_number":1834,"context_line":"            target_uri, \u0027port IP interface\u0027, params)"},{"line_number":1835,"context_line":"        port_key \u003d port_info.get(\u0027symmetrixPortKey\u0027, [])"}],"source_content_type":"text/x-python","patch_set":5,"id":"62972990_cc0f2a86","line":1832,"range":{"start_line":1831,"start_character":8,"end_line":1832,"end_character":21},"updated":"2022-08-19 08:37:20.000000000","message":"can you elaborate on this why we need exactly 2 second wait here?\nIf we are waiting for some resource to be ready on the backend side, I would suggest 2 other methods:\n1) Poll until we get desired result and error out if a timeout is reached\n2) Retry on an exception or undesired output for N number of times (usually 3-5) and sleep for a smaller value (maybe 0.5 seconds) in between retries","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"2884b21d25a203a533058791615dab403f73763a","unresolved":true,"context_lines":[{"line_number":1828,"context_line":"            category\u003dSYSTEM, resource_level\u003d\u0027symmetrix\u0027,"},{"line_number":1829,"context_line":"            resource_level_id\u003darray_id, resource_type\u003d\u0027director\u0027,"},{"line_number":1830,"context_line":"            resource_type_id\u003ddirector_id, resource\u003d\u0027port\u0027)"},{"line_number":1831,"context_line":"        # This is a temporary solution"},{"line_number":1832,"context_line":"        time.sleep(2)"},{"line_number":1833,"context_line":"        port_info \u003d self.get_request("},{"line_number":1834,"context_line":"            target_uri, \u0027port IP interface\u0027, params)"},{"line_number":1835,"context_line":"        port_key \u003d port_info.get(\u0027symmetrixPortKey\u0027, [])"}],"source_content_type":"text/x-python","patch_set":5,"id":"c4ad66ea_63ac8a75","line":1832,"range":{"start_line":1831,"start_character":8,"end_line":1832,"end_character":21},"in_reply_to":"62972990_cc0f2a86","updated":"2022-08-27 09:03:04.000000000","message":"-1: \n\nI would like to reinforce Rajat\u0027s comment since this solution seems a bit problematic without context.\n\nCould you please provide more details on why it is necessary to wait for a arbitrary amount of time at this point? I would like to help in figuring out a final solution, since timing can be unpredictable when running in production.","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"3107705397b766e50bf74066e8272a76fce967f3","unresolved":true,"context_lines":[{"line_number":1828,"context_line":"            category\u003dSYSTEM, resource_level\u003d\u0027symmetrix\u0027,"},{"line_number":1829,"context_line":"            resource_level_id\u003darray_id, resource_type\u003d\u0027director\u0027,"},{"line_number":1830,"context_line":"            resource_type_id\u003ddirector_id, resource\u003d\u0027port\u0027)"},{"line_number":1831,"context_line":"        # This is a temporary solution"},{"line_number":1832,"context_line":"        time.sleep(2)"},{"line_number":1833,"context_line":"        port_info \u003d self.get_request("},{"line_number":1834,"context_line":"            target_uri, \u0027port IP interface\u0027, params)"},{"line_number":1835,"context_line":"        port_key \u003d port_info.get(\u0027symmetrixPortKey\u0027, [])"}],"source_content_type":"text/x-python","patch_set":5,"id":"dca686d4_1a4a5d75","line":1832,"range":{"start_line":1831,"start_character":8,"end_line":1832,"end_character":21},"in_reply_to":"c4ad66ea_63ac8a75","updated":"2022-09-28 16:34:19.000000000","message":"The sleep waits for the target_uri to be constructed.","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"4042fe4ec4bf6e8cee7c5bc93fb4bb1272cc5717","unresolved":false,"context_lines":[{"line_number":1828,"context_line":"            category\u003dSYSTEM, resource_level\u003d\u0027symmetrix\u0027,"},{"line_number":1829,"context_line":"            resource_level_id\u003darray_id, resource_type\u003d\u0027director\u0027,"},{"line_number":1830,"context_line":"            resource_type_id\u003ddirector_id, resource\u003d\u0027port\u0027)"},{"line_number":1831,"context_line":"        # This is a temporary solution"},{"line_number":1832,"context_line":"        time.sleep(2)"},{"line_number":1833,"context_line":"        port_info \u003d self.get_request("},{"line_number":1834,"context_line":"            target_uri, \u0027port IP interface\u0027, params)"},{"line_number":1835,"context_line":"        port_key \u003d port_info.get(\u0027symmetrixPortKey\u0027, [])"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7f63ee_0250375b","line":1832,"range":{"start_line":1831,"start_character":8,"end_line":1832,"end_character":21},"in_reply_to":"dca686d4_1a4a5d75","updated":"2022-10-04 08:00:20.000000000","message":"I have tested without this statement and code works fine, don\u0027t have any idea why it was there.","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ceab3579dd005028a368e4d23e40dbb0e4882f3f","unresolved":true,"context_lines":[{"line_number":2351,"context_line":"        snapvx_src \u003d False"},{"line_number":2352,"context_line":"        snapvx_tgt \u003d False"},{"line_number":2353,"context_line":"        rdf_grp \u003d None"},{"line_number":2354,"context_line":"        time.sleep(1)"},{"line_number":2355,"context_line":"        volume_details \u003d self.get_volume(array, device_id)"},{"line_number":2356,"context_line":"        if volume_details and isinstance(volume_details, dict):"},{"line_number":2357,"context_line":"            if volume_details.get(\u0027snapvx_target\u0027):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1107cb79_498f657c","line":2354,"range":{"start_line":2354,"start_character":8,"end_line":2354,"end_character":21},"updated":"2022-08-19 08:37:20.000000000","message":"I would suggest to avoid blind sleep calls with a specific duration, better to try any of the two methods suggested above","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"2884b21d25a203a533058791615dab403f73763a","unresolved":true,"context_lines":[{"line_number":2351,"context_line":"        snapvx_src \u003d False"},{"line_number":2352,"context_line":"        snapvx_tgt \u003d False"},{"line_number":2353,"context_line":"        rdf_grp \u003d None"},{"line_number":2354,"context_line":"        time.sleep(1)"},{"line_number":2355,"context_line":"        volume_details \u003d self.get_volume(array, device_id)"},{"line_number":2356,"context_line":"        if volume_details and isinstance(volume_details, dict):"},{"line_number":2357,"context_line":"            if volume_details.get(\u0027snapvx_target\u0027):"}],"source_content_type":"text/x-python","patch_set":5,"id":"b4a90295_13be08d0","line":2354,"updated":"2022-08-27 09:03:04.000000000","message":"Same as above.","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"76e68501a0ba3ab5f573d43a0c72a9d17c8e0e0b","unresolved":true,"context_lines":[{"line_number":2351,"context_line":"        snapvx_src \u003d False"},{"line_number":2352,"context_line":"        snapvx_tgt \u003d False"},{"line_number":2353,"context_line":"        rdf_grp \u003d None"},{"line_number":2354,"context_line":"        time.sleep(1)"},{"line_number":2355,"context_line":"        volume_details \u003d self.get_volume(array, device_id)"},{"line_number":2356,"context_line":"        if volume_details and isinstance(volume_details, dict):"},{"line_number":2357,"context_line":"            if volume_details.get(\u0027snapvx_target\u0027):"}],"source_content_type":"text/x-python","patch_set":5,"id":"b47c8afa_2ee7cfdc","line":2354,"range":{"start_line":2354,"start_character":8,"end_line":2354,"end_character":21},"in_reply_to":"1107cb79_498f657c","updated":"2022-09-29 12:26:21.000000000","message":"This sleep doesn\u0027t make any sense, will remove it","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"6273b7766c3d7495686ff6b9caa3107509334ff5","unresolved":false,"context_lines":[{"line_number":2351,"context_line":"        snapvx_src \u003d False"},{"line_number":2352,"context_line":"        snapvx_tgt \u003d False"},{"line_number":2353,"context_line":"        rdf_grp \u003d None"},{"line_number":2354,"context_line":"        time.sleep(1)"},{"line_number":2355,"context_line":"        volume_details \u003d self.get_volume(array, device_id)"},{"line_number":2356,"context_line":"        if volume_details and isinstance(volume_details, dict):"},{"line_number":2357,"context_line":"            if volume_details.get(\u0027snapvx_target\u0027):"}],"source_content_type":"text/x-python","patch_set":5,"id":"b959ed6c_78a1e228","line":2354,"in_reply_to":"a0bb50ef_92b1d3a5","updated":"2022-09-29 12:34:13.000000000","message":"Done","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"6273b7766c3d7495686ff6b9caa3107509334ff5","unresolved":false,"context_lines":[{"line_number":2351,"context_line":"        snapvx_src \u003d False"},{"line_number":2352,"context_line":"        snapvx_tgt \u003d False"},{"line_number":2353,"context_line":"        rdf_grp \u003d None"},{"line_number":2354,"context_line":"        time.sleep(1)"},{"line_number":2355,"context_line":"        volume_details \u003d self.get_volume(array, device_id)"},{"line_number":2356,"context_line":"        if volume_details and isinstance(volume_details, dict):"},{"line_number":2357,"context_line":"            if volume_details.get(\u0027snapvx_target\u0027):"}],"source_content_type":"text/x-python","patch_set":5,"id":"0b83aeda_87adfb8a","line":2354,"range":{"start_line":2354,"start_character":8,"end_line":2354,"end_character":21},"in_reply_to":"b47c8afa_2ee7cfdc","updated":"2022-09-29 12:34:13.000000000","message":"Done","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"3107705397b766e50bf74066e8272a76fce967f3","unresolved":true,"context_lines":[{"line_number":2351,"context_line":"        snapvx_src \u003d False"},{"line_number":2352,"context_line":"        snapvx_tgt \u003d False"},{"line_number":2353,"context_line":"        rdf_grp \u003d None"},{"line_number":2354,"context_line":"        time.sleep(1)"},{"line_number":2355,"context_line":"        volume_details \u003d self.get_volume(array, device_id)"},{"line_number":2356,"context_line":"        if volume_details and isinstance(volume_details, dict):"},{"line_number":2357,"context_line":"            if volume_details.get(\u0027snapvx_target\u0027):"}],"source_content_type":"text/x-python","patch_set":5,"id":"a0bb50ef_92b1d3a5","line":2354,"in_reply_to":"b4a90295_13be08d0","updated":"2022-09-28 16:34:19.000000000","message":"Will remove this sleep as it doesn\u0027t make any sense here","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ceab3579dd005028a368e4d23e40dbb0e4882f3f","unresolved":true,"context_lines":[{"line_number":3431,"context_line":"                unisphere_meets_min_req \u003d ("},{"line_number":3432,"context_line":"                    self.utils.version_meet_req(version, minimum_version))"},{"line_number":3433,"context_line":"            elif running_version.lower()[0] \u003d\u003d \u0027t\u0027 or ("},{"line_number":3434,"context_line":"                    running_version.lower()[0] \u003d\u003d \u0027x\u0027):"},{"line_number":3435,"context_line":"                LOG.warning(\"%(version)s This is not a official release of \""},{"line_number":3436,"context_line":"                            \"Unisphere.\", {\u0027version\u0027: running_version})"},{"line_number":3437,"context_line":"                return int(major_version) \u003e\u003d int(self.u4p_version)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7848e153_59ce18e8","line":3434,"range":{"start_line":3434,"start_character":50,"end_line":3434,"end_character":53},"updated":"2022-08-19 08:37:20.000000000","message":"can we define the letters (v, t, x) as constants with meaningful variable names so we know what we are comparing the versions with","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"5b07d09846d19990026ce66fac2cdcd5b97a705c","unresolved":false,"context_lines":[{"line_number":3431,"context_line":"                unisphere_meets_min_req \u003d ("},{"line_number":3432,"context_line":"                    self.utils.version_meet_req(version, minimum_version))"},{"line_number":3433,"context_line":"            elif running_version.lower()[0] \u003d\u003d \u0027t\u0027 or ("},{"line_number":3434,"context_line":"                    running_version.lower()[0] \u003d\u003d \u0027x\u0027):"},{"line_number":3435,"context_line":"                LOG.warning(\"%(version)s This is not a official release of \""},{"line_number":3436,"context_line":"                            \"Unisphere.\", {\u0027version\u0027: running_version})"},{"line_number":3437,"context_line":"                return int(major_version) \u003e\u003d int(self.u4p_version)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9304d662_7873404f","line":3434,"range":{"start_line":3434,"start_character":50,"end_line":3434,"end_character":53},"in_reply_to":"7848e153_59ce18e8","updated":"2022-09-29 12:54:54.000000000","message":"t is test code, x is developer level code, v is release quality code. I\u0027ll add constants as DEV_CODE, TEST_CODE, QUAL_CODE in order","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"2884b21d25a203a533058791615dab403f73763a","unresolved":true,"context_lines":[{"line_number":3496,"context_line":""},{"line_number":3497,"context_line":"        if array_details:"},{"line_number":3498,"context_line":"            ucode \u003d array_details.get(\u0027ucode\u0027, array_details.get(\u0027microcode\u0027))"},{"line_number":3499,"context_line":"            split_ucode_level \u003d ucode.split(\u0027.\u0027)"},{"line_number":3500,"context_line":"            ucode_level \u003d [int(level) for level in split_ucode_level]"},{"line_number":3501,"context_line":"            ucode_major_level \u003d ucode_level[0]"},{"line_number":3502,"context_line":"            ucode_minor_level \u003d ucode_level[1]"}],"source_content_type":"text/x-python","patch_set":5,"id":"c344c14b_4012ea9c","line":3499,"updated":"2022-08-27 09:03:04.000000000","message":"nit: The split will raise a exception if ucode or microcode aren\u0027t available as key. It would be easier to debug if the code was changed to access microcode directly (array_details[\u0027microcode\u0027]), so the stack trace would report the missing key instead of a error in split.","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"31d18f8c7f7aa6ddd3bad93b82f54bb4478fcaaf","unresolved":false,"context_lines":[{"line_number":3496,"context_line":""},{"line_number":3497,"context_line":"        if array_details:"},{"line_number":3498,"context_line":"            ucode \u003d array_details.get(\u0027ucode\u0027, array_details.get(\u0027microcode\u0027))"},{"line_number":3499,"context_line":"            split_ucode_level \u003d ucode.split(\u0027.\u0027)"},{"line_number":3500,"context_line":"            ucode_level \u003d [int(level) for level in split_ucode_level]"},{"line_number":3501,"context_line":"            ucode_major_level \u003d ucode_level[0]"},{"line_number":3502,"context_line":"            ucode_minor_level \u003d ucode_level[1]"}],"source_content_type":"text/x-python","patch_set":5,"id":"1e8cf470_3e56c272","line":3499,"in_reply_to":"2e608f69_9e93fc4f","updated":"2022-09-29 12:45:33.000000000","message":"Done","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"3107705397b766e50bf74066e8272a76fce967f3","unresolved":true,"context_lines":[{"line_number":3496,"context_line":""},{"line_number":3497,"context_line":"        if array_details:"},{"line_number":3498,"context_line":"            ucode \u003d array_details.get(\u0027ucode\u0027, array_details.get(\u0027microcode\u0027))"},{"line_number":3499,"context_line":"            split_ucode_level \u003d ucode.split(\u0027.\u0027)"},{"line_number":3500,"context_line":"            ucode_level \u003d [int(level) for level in split_ucode_level]"},{"line_number":3501,"context_line":"            ucode_major_level \u003d ucode_level[0]"},{"line_number":3502,"context_line":"            ucode_minor_level \u003d ucode_level[1]"}],"source_content_type":"text/x-python","patch_set":5,"id":"2e608f69_9e93fc4f","line":3499,"in_reply_to":"c344c14b_4012ea9c","updated":"2022-09-28 16:34:19.000000000","message":"field is named ucode or microcode based upon the REST API endpoint (92 vs 100).\nthis field always exists unless the array is unreachable.","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"}],"cinder/volume/drivers/dell_emc/powermax/utils.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ceab3579dd005028a368e4d23e40dbb0e4882f3f","unresolved":true,"context_lines":[{"line_number":2131,"context_line":"        :param in_value: microcode"},{"line_number":2132,"context_line":"        :returns: Boolean"},{"line_number":2133,"context_line":"        \"\"\""},{"line_number":2134,"context_line":"        if int(in_value[0]) \u003d\u003d UCODE_5978:"},{"line_number":2135,"context_line":"            if int(in_value[2]) \u003e UCODE_5978_ELMSR:"},{"line_number":2136,"context_line":"                return True"},{"line_number":2137,"context_line":"        elif int(in_value[0]) \u003e UCODE_5978:"},{"line_number":2138,"context_line":"            return True"},{"line_number":2139,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":5,"id":"40d1175e_cbd1463e","line":2138,"range":{"start_line":2134,"start_character":8,"end_line":2138,"end_character":23},"updated":"2022-08-19 08:37:20.000000000","message":"nit: these can be combined in a single statement (considering proper line breaks)\n\n    if (int(in_value[0]) \u003d\u003d UCODE_5978 and int(in_value[2]) \u003e UCODE_5978_ELMSR) or (int(in_value[0]) \u003e UCODE_5978):\n        return True","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"4e71ac8f7439bef871d45d0d1003f20aa61056b0","unresolved":false,"context_lines":[{"line_number":2131,"context_line":"        :param in_value: microcode"},{"line_number":2132,"context_line":"        :returns: Boolean"},{"line_number":2133,"context_line":"        \"\"\""},{"line_number":2134,"context_line":"        if int(in_value[0]) \u003d\u003d UCODE_5978:"},{"line_number":2135,"context_line":"            if int(in_value[2]) \u003e UCODE_5978_ELMSR:"},{"line_number":2136,"context_line":"                return True"},{"line_number":2137,"context_line":"        elif int(in_value[0]) \u003e UCODE_5978:"},{"line_number":2138,"context_line":"            return True"},{"line_number":2139,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":5,"id":"1006bdd8_2e1f5785","line":2138,"range":{"start_line":2134,"start_character":8,"end_line":2138,"end_character":23},"in_reply_to":"40d1175e_cbd1463e","updated":"2022-09-27 13:07:54.000000000","message":"Done","commit_id":"4ab52092d6868753ed51a86e2495b5124b97d5c6"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"2c318dedfaab102d7f6a42e37ff76658b781f9e5","unresolved":true,"context_lines":[{"line_number":2134,"context_line":"        :param in_value: microcode"},{"line_number":2135,"context_line":"        :returns: Boolean"},{"line_number":2136,"context_line":"        \"\"\""},{"line_number":2137,"context_line":"        if ((int(in_value[0]) \u003d\u003d UCODE_5978 and"},{"line_number":2138,"context_line":"                int(in_value[2]) \u003e UCODE_5978_ELMSR) or"},{"line_number":2139,"context_line":"                (int(in_value[0]) \u003e UCODE_5978)):"},{"line_number":2140,"context_line":"            return True"},{"line_number":2141,"context_line":"        else:"},{"line_number":2142,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":15,"id":"7d717806_11aa6feb","line":2142,"range":{"start_line":2137,"start_character":8,"end_line":2142,"end_character":24},"updated":"2022-11-24 00:40:36.000000000","message":"you could directly return the boolean expression:\n\nreturn ((int(in_value[0] \u003d\u003d UCODE_5978 and\n             int(in_value[2] \u003e UCODE_5978_ELMSR or\n             (int(in_value[0] \u003e UCODE_5978))","commit_id":"142b3e0a8867df9dd3b8f06a5b73276a9b1190bd"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"a80a97b58783d3b37a857e9e1ea9a4e7ed358f46","unresolved":false,"context_lines":[{"line_number":2134,"context_line":"        :param in_value: microcode"},{"line_number":2135,"context_line":"        :returns: Boolean"},{"line_number":2136,"context_line":"        \"\"\""},{"line_number":2137,"context_line":"        if ((int(in_value[0]) \u003d\u003d UCODE_5978 and"},{"line_number":2138,"context_line":"                int(in_value[2]) \u003e UCODE_5978_ELMSR) or"},{"line_number":2139,"context_line":"                (int(in_value[0]) \u003e UCODE_5978)):"},{"line_number":2140,"context_line":"            return True"},{"line_number":2141,"context_line":"        else:"},{"line_number":2142,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":15,"id":"f157de46_1547a493","line":2142,"range":{"start_line":2137,"start_character":8,"end_line":2142,"end_character":24},"in_reply_to":"7d717806_11aa6feb","updated":"2022-12-02 12:37:01.000000000","message":"Done","commit_id":"142b3e0a8867df9dd3b8f06a5b73276a9b1190bd"}]}