)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"785be29eeba6ffe6881ee40ff06f52a23a2e98b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"211ee383_19b5c73e","updated":"2022-07-05 13:27:41.000000000","message":"This seems to complicate this driver a bit (both code and ensuring that the code is tested) for probably little performance benefit.\n\nWho handles LV activation in this case?  The iSCSI path calls activate_lv() but this new path does not.\n\nWhat happens when c-vol and n-cpu are running in separate containers on the same host?  It\u0027s not guaranteed that the compute service can even access this device.\n\nDo things like volume extend work as expected?\n\nI\u0027m not sure the tradeoffs are worthwhile here, especially given that most perf-sensitive deployments won\u0027t be using the LVM driver.  Is there any real-world usage info indicating that someone would really benefit from this?","commit_id":"82610bd5bd2f9dd55e2fe0d43f9cdb6319d72496"}],"cinder/volume/drivers/lvm.py":[{"author":{"_account_id":33493,"name":"chenwei","display_name":"chenwei","email":"jzpcoming@163.com","username":"chenwei"},"change_message_id":"03ee015eed7dc67280779927b8e832cd0bd0ea5b","unresolved":true,"context_lines":[{"line_number":822,"context_line":"            self.target_driver.ensure_export(context, volume, volume_path)"},{"line_number":823,"context_line":"        return model_update"},{"line_number":824,"context_line":""},{"line_number":825,"context_line":"    def create_export(self, context, volume, connector, vg\u003dNone):"},{"line_number":826,"context_line":"        if connector[\u0027IP\u0027] in [self.configuration.target_ip_address,"},{"line_number":827,"context_line":"                               self.configuration.my_ip]:"},{"line_number":828,"context_line":"            msg \u003d \u0027The initiator and target are in the same host,\u0027 \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"7848ee0f_09f760f0","line":825,"range":{"start_line":825,"start_character":8,"end_line":825,"end_character":29},"updated":"2022-06-07 09:35:31.000000000","message":"If changed to this, then the impact on other projects will be significant, requiring a large number of single tests\nHow much more performance does this change?","commit_id":"82610bd5bd2f9dd55e2fe0d43f9cdb6319d72496"},{"author":{"_account_id":23729,"name":"焦浩霖","display_name":"jiaohaolin","email":"jiaohaolin01@inspur.com","username":"inspur-storage"},"change_message_id":"d8fac9e83ee7ed40fd2c94708b9f1081e22a5984","unresolved":true,"context_lines":[{"line_number":822,"context_line":"            self.target_driver.ensure_export(context, volume, volume_path)"},{"line_number":823,"context_line":"        return model_update"},{"line_number":824,"context_line":""},{"line_number":825,"context_line":"    def create_export(self, context, volume, connector, vg\u003dNone):"},{"line_number":826,"context_line":"        if connector[\u0027IP\u0027] in [self.configuration.target_ip_address,"},{"line_number":827,"context_line":"                               self.configuration.my_ip]:"},{"line_number":828,"context_line":"            msg \u003d \u0027The initiator and target are in the same host,\u0027 \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"c7672586_d0b63723","line":825,"range":{"start_line":825,"start_character":8,"end_line":825,"end_character":29},"in_reply_to":"7848ee0f_09f760f0","updated":"2022-06-07 11:20:38.000000000","message":"As I know ,this function only affects the attachments of lvm volumes in good way, it does not affect any actions such as migrating virtual machines across hosts or migrating volumes.\n\nAnd because lvm-driver creates an single iscsi-target for each volume attachment. So, if there are multiple volumes attachment on one lvm cinder-volume, there will be multiple iscsi-targets, which will consume more CPU and memory resources that are not necessary.\n\nIf VM using the local path of lvm, the I/O path would go from  vm to the lv directly. In another way ,it will go from vm through iscsi-initiator, ethernet-card, to iscsi-target and then to lv.\n\nSo, it not only reduces resource consumption, but also improves some performance.","commit_id":"82610bd5bd2f9dd55e2fe0d43f9cdb6319d72496"},{"author":{"_account_id":33493,"name":"chenwei","display_name":"chenwei","email":"jzpcoming@163.com","username":"chenwei"},"change_message_id":"5836ce9753589925c7d1b52ba692908721cbca3c","unresolved":true,"context_lines":[{"line_number":822,"context_line":"            self.target_driver.ensure_export(context, volume, volume_path)"},{"line_number":823,"context_line":"        return model_update"},{"line_number":824,"context_line":""},{"line_number":825,"context_line":"    def create_export(self, context, volume, connector, vg\u003dNone):"},{"line_number":826,"context_line":"        if connector[\u0027IP\u0027] in [self.configuration.target_ip_address,"},{"line_number":827,"context_line":"                               self.configuration.my_ip]:"},{"line_number":828,"context_line":"            msg \u003d \u0027The initiator and target are in the same host,\u0027 \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"cb995c6f_ba4be41f","line":825,"range":{"start_line":825,"start_character":8,"end_line":825,"end_character":29},"in_reply_to":"c7672586_d0b63723","updated":"2022-06-09 02:03:53.000000000","message":"My doubts have been settled and I agree with your plan","commit_id":"82610bd5bd2f9dd55e2fe0d43f9cdb6319d72496"}]}