)]}'
{"cinder/objects/volume_attachment.py":[{"author":{"_account_id":33493,"name":"chenwei","display_name":"chenwei","email":"jzpcoming@163.com","username":"chenwei"},"change_message_id":"19f49ed9bb4ea9d43d553a28ad023cad2827a92e","unresolved":true,"context_lines":[{"line_number":101,"context_line":"        attachment._context \u003d context"},{"line_number":102,"context_line":"        attachment.obj_reset_changes()"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        # This is an online data migration which we should remove when enough"},{"line_number":105,"context_line":"        # time has passed and we have a blocker schema migration to check to"},{"line_number":106,"context_line":"        # make sure that the attachment_specs table is empty. Operators should"},{"line_number":107,"context_line":"        # run the \"cinder-manage db online_data_migrations\" CLI to force the"},{"line_number":108,"context_line":"        # migration on-demand."}],"source_content_type":"text/x-python","patch_set":1,"id":"1ba84a61_818c5b2b","side":"PARENT","line":105,"range":{"start_line":104,"start_character":8,"end_line":105,"end_character":76},"updated":"2022-06-07 01:46:52.000000000","message":"i think that this object need to be retained because some other drivers use this table","commit_id":"f6258d782aea3de4687a3845d32e0b3150226a2d"},{"author":{"_account_id":31464,"name":"韩春蕾","email":"1922361860@qq.com","username":"hanchl"},"change_message_id":"0ed493ae7a739c3f99babc79b29fb6f3c73151da","unresolved":true,"context_lines":[{"line_number":101,"context_line":"        attachment._context \u003d context"},{"line_number":102,"context_line":"        attachment.obj_reset_changes()"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        # This is an online data migration which we should remove when enough"},{"line_number":105,"context_line":"        # time has passed and we have a blocker schema migration to check to"},{"line_number":106,"context_line":"        # make sure that the attachment_specs table is empty. Operators should"},{"line_number":107,"context_line":"        # run the \"cinder-manage db online_data_migrations\" CLI to force the"},{"line_number":108,"context_line":"        # migration on-demand."}],"source_content_type":"text/x-python","patch_set":1,"id":"0dabab48_8fb0de04","side":"PARENT","line":105,"range":{"start_line":104,"start_character":8,"end_line":105,"end_character":76},"in_reply_to":"1ba84a61_818c5b2b","updated":"2022-06-07 02:21:36.000000000","message":"Online data migration has been implemented. \nit can be seen that in the code of the database, the attachment_specs have been marked with \"DEPRECATED\". Even explicitly annotating attachment_specs in upgrade_check should not continue to exist. \nIs it safe to assume that no driver will use this table again?\n\n    def _check_attachment_specs(self):\n        if db.attachment_specs_exist(self.context):\n            return uc.Result(\n                FAILURE,\n                \u0027There should be no more AttachmentSpecs in the system. \u0027\n                \u0027Please fix this issue by running Queens online data \u0027\n                \u0027migrations.\u0027)\n        return uc.Result(SUCCESS)","commit_id":"f6258d782aea3de4687a3845d32e0b3150226a2d"}]}