)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f3171190bac90eb6f12d5e500a2dc3339bee3c6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"188eb1a3_69307c85","updated":"2022-07-01 15:38:48.000000000","message":"recheck unrelated failure","commit_id":"d9321f263ee31ab1536e6265721e56e58bbf4805"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1c3478a24fb31dfcc645a791980be20504095141","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3be97cbd_1dc11acf","updated":"2022-09-13 09:59:55.000000000","message":"I was going through change[1] and there we are removing this additional logic we added in this patch. Not sure what we\u0027re trying to achieve here.\n\n[1] https://review.opendev.org/c/openstack/cinder/+/844962","commit_id":"0eb2d1f0a73a4c6e3363064945ac2b58f55e4057"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ff3f874e9d0ea23aa00e3320ff824741cb6cc780","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9a465adb_8adf10a4","updated":"2022-09-13 09:34:26.000000000","message":"The tests and code change are not related but we\u0027re removing a redundant decorator and improving testing so should be acceptable. LGTM.","commit_id":"0eb2d1f0a73a4c6e3363064945ac2b58f55e4057"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"8ae5a96e5fb692ee9f8a25a0b14874cfde5c94bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"aea7ef70_94971af0","updated":"2022-09-14 13:17:02.000000000","message":"run-Yadro Tatlin Unified CI","commit_id":"0eb2d1f0a73a4c6e3363064945ac2b58f55e4057"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"68d1ce1084a0c5c8929eb3afa6504b39fc175556","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"804526c9_0529c20b","updated":"2022-09-14 17:41:28.000000000","message":"🎉","commit_id":"0eb2d1f0a73a4c6e3363064945ac2b58f55e4057"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fc315ed880766e2773d2c5a400ef5ff73f18ed80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a7d318dd_2057778b","in_reply_to":"3be97cbd_1dc11acf","updated":"2022-09-13 11:49:45.000000000","message":"As I\u0027ve noted in the next patch, the pattern we\u0027ve used here is weird and has led to a bug (which we\u0027re fixing here). I\u0027d ultimately like to remove that pattern, however, it\u0027s a tricky areas so I\u0027ve decided to fix it in two steps:\n\n1. Fix the immediate mistake and add tests to prevent regressions (i.e. this patch). This is backportable.\n2. Change the pattern to something easier to understand (i.e. the next patch). This isn\u0027t really backportable IMO.\n\nI could have done everything in one patch but it would be larger and more difficult to understand. While the bugfix here is effectively useless once I migrate to the new pattern, the tests are not and the bugfix helps us understand how things are currently working before we change to a different pattern in the next file.\n\nHopefully this helps clarify things.","commit_id":"0eb2d1f0a73a4c6e3363064945ac2b58f55e4057"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"efb10e21a039591fa2da902c9d8e9373688e0cfb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d2f963d2_47e769ee","in_reply_to":"a7d318dd_2057778b","updated":"2022-09-13 12:10:27.000000000","message":"Thanks for the explanation, the code changes seems counterproductive but since we\u0027re addressing it in the end. it should be good.","commit_id":"0eb2d1f0a73a4c6e3363064945ac2b58f55e4057"}],"cinder/tests/unit/db/test_volume_type.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ff3f874e9d0ea23aa00e3320ff824741cb6cc780","unresolved":true,"context_lines":[{"line_number":68,"context_line":"        db.group_destroy(self.ctxt, group[\u0027id\u0027])"},{"line_number":69,"context_line":"        volume_types.destroy(self.ctxt, volume_type[\u0027id\u0027])"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def test_volume_type_mark_in_use_exists(self):"},{"line_number":72,"context_line":"        volume_type \u003d db.volume_type_create("},{"line_number":73,"context_line":"            self.ctxt,"},{"line_number":74,"context_line":"            {\u0027name\u0027: \u0027fake volume type\u0027},"}],"source_content_type":"text/x-python","patch_set":2,"id":"401332ae_d9a2d2dd","line":71,"range":{"start_line":71,"start_character":8,"end_line":71,"end_character":43},"updated":"2022-09-13 09:34:26.000000000","message":"The name doesn\u0027t tell what we\u0027re performing here.\nWe don\u0027t have a concept of in use volume types. Basically we are associating a volume type to a group and while trying to associate it again, we fail.\nA better name would be test_volume_type_group_mapping_exists.","commit_id":"0eb2d1f0a73a4c6e3363064945ac2b58f55e4057"}]}