)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"5f25747a70178af9ed438edca3a1c1e4e46d1e77","unresolved":true,"context_lines":[{"line_number":11,"context_line":"image_service:store_id is present in the volume type extra specs."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1978020"},{"line_number":14,"context_line":"Discussed with: Rajat Dhasmana \u003crajatdhasmana@gmail.com\u003e"},{"line_number":15,"context_line":"Change-Id: I815706f691a7d1e5a0c54eb15222417008ef1f34"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5affe376_09e2ad8c","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":14},"updated":"2022-06-14 23:48:53.000000000","message":":nit: it\u0027s not a valid tag, why not using Co-Author","commit_id":"5a0932bac786b3ffe0cc3bfa1578e12e82bdd64c"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"f2d6762b95c4ca3d46cbf9b0faa2f9765bc03fc7","unresolved":false,"context_lines":[{"line_number":11,"context_line":"image_service:store_id is present in the volume type extra specs."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1978020"},{"line_number":14,"context_line":"Discussed with: Rajat Dhasmana \u003crajatdhasmana@gmail.com\u003e"},{"line_number":15,"context_line":"Change-Id: I815706f691a7d1e5a0c54eb15222417008ef1f34"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5996f81f_fdb22fad","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":14},"in_reply_to":"5affe376_09e2ad8c","updated":"2022-06-15 09:27:55.000000000","message":"Done","commit_id":"5a0932bac786b3ffe0cc3bfa1578e12e82bdd64c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"dce95fe06f888ef8ae34b6968238580b76af913a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0db8ed0f_b49bde74","updated":"2022-06-09 07:42:53.000000000","message":"Requires a releasenote.\nCode change looks good, I\u0027ve added some comments in tests, usually it\u0027s good to emulate a real deployment scenario in our testing to catch all issues/corner cases.","commit_id":"4e2644c652b668f6898736d24ebf55c8cf98e947"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"98f11558eeb0986aab6f7cd434c37631612066b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b1248061_04d4f5bb","in_reply_to":"0db8ed0f_b49bde74","updated":"2022-06-14 23:03:31.000000000","message":"Thanks for the review! The test code was updated in patchset 4 to use the \"more realistic\" fake objects and the fake constants, thanks a lot for bringing my attention to them. I guess I\u0027ll have to fix most of the StorPool driver unit tests - in a separate commit, of course.\n\nOof, I just realized I forgot about the release note, I\u0027ll get to it shortly. Thanks again!","commit_id":"4e2644c652b668f6898736d24ebf55c8cf98e947"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"f2d6762b95c4ca3d46cbf9b0faa2f9765bc03fc7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"94ec65cd_c682d2d6","updated":"2022-06-15 09:27:55.000000000","message":"Thanks!","commit_id":"5a0932bac786b3ffe0cc3bfa1578e12e82bdd64c"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"df6a1a7a696435279c0f9e6c942afab2263f7716","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d3bb9dbe_f102e8e3","updated":"2022-06-15 09:50:22.000000000","message":"run-HPE Nimble Storage CI\n","commit_id":"5c919e3022e14b29bf2ff8dd0863858906107fa3"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a4c3bfd4db03ed4f2186eb8617d0d218372baa8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"222de005_af2add87","updated":"2022-06-16 12:20:13.000000000","message":"Note for other reviewers: the store_id is validated when the volume-type\u0027s extra-spec is created:\nhttps://opendev.org/openstack/cinder/src/commit/9a8583b2ef59f6a392b8b1a1efef8d3d270cf9ea/cinder/api/contrib/types_extra_specs.py#L95-L97\n\nCode and tests look good.  Suggestion inline for the release note.","commit_id":"202d66ac9797e9bd124ea6e06a711c59bfc93639"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"8bc59195072e72fccd513f2d0d9520af258e4111","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"77b7c9d2_1ebd679a","updated":"2022-06-20 08:57:47.000000000","message":"run-DellEMC Unity CI","commit_id":"202d66ac9797e9bd124ea6e06a711c59bfc93639"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"500581f2dfc7e5d7902b2bd6340e09c83732dd22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"3804889f_b93cff79","updated":"2022-09-06 11:50:53.000000000","message":"Sorry, I lost track of this one.  Thanks for updating the release note.","commit_id":"4af3e86c6eefc152f505f6961082644f5ee18e68"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"7c07ab1cac4029bb829d624d816f6849eae3058b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"1f798c40_fe9afc03","updated":"2022-08-02 09:02:31.000000000","message":"run-storpoolci","commit_id":"4af3e86c6eefc152f505f6961082644f5ee18e68"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"fb3655be44bb67bb01e74456cf63d66fd699eadc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"725e7ec4_3fc7d2c5","updated":"2023-01-25 14:44:39.000000000","message":"Even though I\u0027m the co-author since we discussed the idea together, Peter worked on the patch and it LGTM. Thanks!","commit_id":"08e80390f3d83f687552d268e6378fdfcddc0d34"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"2df7fb4afa5179cf5e99783fbf4032410bc36269","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"66cdb0b0_1ffa51f6","updated":"2023-01-19 17:11:45.000000000","message":"Everything looks in order to me.\n","commit_id":"08e80390f3d83f687552d268e6378fdfcddc0d34"}],"cinder/tests/unit/volume/test_volume_manager.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"dce95fe06f888ef8ae34b6968238580b76af913a","unresolved":true,"context_lines":[{"line_number":340,"context_line":"        ctx \u003d mock.MagicMock(spec\u003d[\u0027project_id\u0027])"},{"line_number":341,"context_line":"        ctx.project_id \u003d project_id"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"        volume \u003d mock.MagicMock(spec\u003d[\u0027volume_type\u0027])"},{"line_number":344,"context_line":"        volume.volume_type.extra_specs \u003d {\u0027backend\u0027: \u0027unknown\u0027}"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"        image_volume_id \u003d \u002742\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"ea1cb73b_6a6215f5","line":343,"range":{"start_line":343,"start_character":8,"end_line":343,"end_character":53},"updated":"2022-06-09 07:42:53.000000000","message":"create an actual volume OVO rather than a mock\n\nvol \u003d fake_volume.fake_volume_obj(ctxt)","commit_id":"4e2644c652b668f6898736d24ebf55c8cf98e947"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"98f11558eeb0986aab6f7cd434c37631612066b5","unresolved":false,"context_lines":[{"line_number":340,"context_line":"        ctx \u003d mock.MagicMock(spec\u003d[\u0027project_id\u0027])"},{"line_number":341,"context_line":"        ctx.project_id \u003d project_id"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"        volume \u003d mock.MagicMock(spec\u003d[\u0027volume_type\u0027])"},{"line_number":344,"context_line":"        volume.volume_type.extra_specs \u003d {\u0027backend\u0027: \u0027unknown\u0027}"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"        image_volume_id \u003d \u002742\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"14a25cbc_e7be94c3","line":343,"range":{"start_line":343,"start_character":8,"end_line":343,"end_character":53},"in_reply_to":"ea1cb73b_6a6215f5","updated":"2022-06-14 23:03:31.000000000","message":"Done","commit_id":"4e2644c652b668f6898736d24ebf55c8cf98e947"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"dce95fe06f888ef8ae34b6968238580b76af913a","unresolved":true,"context_lines":[{"line_number":341,"context_line":"        ctx.project_id \u003d project_id"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"        volume \u003d mock.MagicMock(spec\u003d[\u0027volume_type\u0027])"},{"line_number":344,"context_line":"        volume.volume_type.extra_specs \u003d {\u0027backend\u0027: \u0027unknown\u0027}"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"        image_volume_id \u003d \u002742\u0027"},{"line_number":347,"context_line":"        image_volume \u003d mock.MagicMock(spec\u003d[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"4e4dbdc1_728fe173","line":344,"range":{"start_line":344,"start_character":43,"end_line":344,"end_character":50},"updated":"2022-06-09 07:42:53.000000000","message":"backend is not a valid cinder param, use volume_backend_name","commit_id":"4e2644c652b668f6898736d24ebf55c8cf98e947"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"98f11558eeb0986aab6f7cd434c37631612066b5","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        ctx.project_id \u003d project_id"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"        volume \u003d mock.MagicMock(spec\u003d[\u0027volume_type\u0027])"},{"line_number":344,"context_line":"        volume.volume_type.extra_specs \u003d {\u0027backend\u0027: \u0027unknown\u0027}"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"        image_volume_id \u003d \u002742\u0027"},{"line_number":347,"context_line":"        image_volume \u003d mock.MagicMock(spec\u003d[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"6edf7486_3d20b438","line":344,"range":{"start_line":344,"start_character":43,"end_line":344,"end_character":50},"in_reply_to":"4e4dbdc1_728fe173","updated":"2022-06-14 23:03:31.000000000","message":"Done","commit_id":"4e2644c652b668f6898736d24ebf55c8cf98e947"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"dce95fe06f888ef8ae34b6968238580b76af913a","unresolved":true,"context_lines":[{"line_number":343,"context_line":"        volume \u003d mock.MagicMock(spec\u003d[\u0027volume_type\u0027])"},{"line_number":344,"context_line":"        volume.volume_type.extra_specs \u003d {\u0027backend\u0027: \u0027unknown\u0027}"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"        image_volume_id \u003d \u002742\u0027"},{"line_number":347,"context_line":"        image_volume \u003d mock.MagicMock(spec\u003d[\u0027id\u0027])"},{"line_number":348,"context_line":"        image_volume.id \u003d image_volume_id"},{"line_number":349,"context_line":"        url \u003d \u0027cinder://%(vol)s\u0027 % {\u0027vol\u0027: image_volume_id}"}],"source_content_type":"text/x-python","patch_set":3,"id":"b2e06bc0_c123c876","line":346,"range":{"start_line":346,"start_character":26,"end_line":346,"end_character":30},"updated":"2022-06-09 07:42:53.000000000","message":"please use UUIDs from fake constants here\n\nhttps://github.com/openstack/cinder/blob/master/cinder/tests/unit/fake_constants.py#L63","commit_id":"4e2644c652b668f6898736d24ebf55c8cf98e947"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"98f11558eeb0986aab6f7cd434c37631612066b5","unresolved":false,"context_lines":[{"line_number":343,"context_line":"        volume \u003d mock.MagicMock(spec\u003d[\u0027volume_type\u0027])"},{"line_number":344,"context_line":"        volume.volume_type.extra_specs \u003d {\u0027backend\u0027: \u0027unknown\u0027}"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"        image_volume_id \u003d \u002742\u0027"},{"line_number":347,"context_line":"        image_volume \u003d mock.MagicMock(spec\u003d[\u0027id\u0027])"},{"line_number":348,"context_line":"        image_volume.id \u003d image_volume_id"},{"line_number":349,"context_line":"        url \u003d \u0027cinder://%(vol)s\u0027 % {\u0027vol\u0027: image_volume_id}"}],"source_content_type":"text/x-python","patch_set":3,"id":"6bd8d120_790980d8","line":346,"range":{"start_line":346,"start_character":26,"end_line":346,"end_character":30},"in_reply_to":"b2e06bc0_c123c876","updated":"2022-06-14 23:03:31.000000000","message":"Done","commit_id":"4e2644c652b668f6898736d24ebf55c8cf98e947"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"dce95fe06f888ef8ae34b6968238580b76af913a","unresolved":true,"context_lines":[{"line_number":349,"context_line":"        url \u003d \u0027cinder://%(vol)s\u0027 % {\u0027vol\u0027: image_volume_id}"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        image_service \u003d mock.MagicMock(spec\u003d[\u0027add_location\u0027])"},{"line_number":352,"context_line":"        image_meta_id \u003d \u0027616\u0027"},{"line_number":353,"context_line":"        image_meta \u003d {"},{"line_number":354,"context_line":"            \u0027id\u0027: image_meta_id,"},{"line_number":355,"context_line":"            \u0027disk_format\u0027: \u0027raw\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a1cdc11_45445f18","line":352,"range":{"start_line":352,"start_character":24,"end_line":352,"end_character":29},"updated":"2022-06-09 07:42:53.000000000","message":"same","commit_id":"4e2644c652b668f6898736d24ebf55c8cf98e947"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"98f11558eeb0986aab6f7cd434c37631612066b5","unresolved":false,"context_lines":[{"line_number":349,"context_line":"        url \u003d \u0027cinder://%(vol)s\u0027 % {\u0027vol\u0027: image_volume_id}"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        image_service \u003d mock.MagicMock(spec\u003d[\u0027add_location\u0027])"},{"line_number":352,"context_line":"        image_meta_id \u003d \u0027616\u0027"},{"line_number":353,"context_line":"        image_meta \u003d {"},{"line_number":354,"context_line":"            \u0027id\u0027: image_meta_id,"},{"line_number":355,"context_line":"            \u0027disk_format\u0027: \u0027raw\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"d4cacde0_365d04ee","line":352,"range":{"start_line":352,"start_character":24,"end_line":352,"end_character":29},"in_reply_to":"7a1cdc11_45445f18","updated":"2022-06-14 23:03:31.000000000","message":"Done","commit_id":"4e2644c652b668f6898736d24ebf55c8cf98e947"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"dce95fe06f888ef8ae34b6968238580b76af913a","unresolved":true,"context_lines":[{"line_number":382,"context_line":"        \"\"\"Send a cinder://\u003cstore-id\u003e/\u003cvolume-id\u003e URL.\"\"\""},{"line_number":383,"context_line":"        manager \u003d vol_manager.VolumeManager()"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"        project_id \u003d \u002737\u0027"},{"line_number":386,"context_line":"        ctx \u003d mock.MagicMock(spec\u003d[\u0027project_id\u0027])"},{"line_number":387,"context_line":"        ctx.project_id \u003d project_id"},{"line_number":388,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"4809b8e4_5e4bed08","line":385,"range":{"start_line":385,"start_character":21,"end_line":385,"end_character":25},"updated":"2022-06-09 07:42:53.000000000","message":"we\u0027ve fake constants UUIDs for every resource -- volume, image, project so please use those instead of hardcoding it here\n\nhttps://github.com/openstack/cinder/blob/master/cinder/tests/unit/fake_constants.py#L42","commit_id":"4e2644c652b668f6898736d24ebf55c8cf98e947"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"98f11558eeb0986aab6f7cd434c37631612066b5","unresolved":false,"context_lines":[{"line_number":382,"context_line":"        \"\"\"Send a cinder://\u003cstore-id\u003e/\u003cvolume-id\u003e URL.\"\"\""},{"line_number":383,"context_line":"        manager \u003d vol_manager.VolumeManager()"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"        project_id \u003d \u002737\u0027"},{"line_number":386,"context_line":"        ctx \u003d mock.MagicMock(spec\u003d[\u0027project_id\u0027])"},{"line_number":387,"context_line":"        ctx.project_id \u003d project_id"},{"line_number":388,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"290550e4_8962aaa1","line":385,"range":{"start_line":385,"start_character":21,"end_line":385,"end_character":25},"in_reply_to":"4809b8e4_5e4bed08","updated":"2022-06-14 23:03:31.000000000","message":"Done","commit_id":"4e2644c652b668f6898736d24ebf55c8cf98e947"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"dce95fe06f888ef8ae34b6968238580b76af913a","unresolved":true,"context_lines":[{"line_number":387,"context_line":"        ctx.project_id \u003d project_id"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        store_id \u003d \u0027muninn\u0027"},{"line_number":390,"context_line":"        volume \u003d mock.MagicMock(spec\u003d[\u0027volume_type\u0027])"},{"line_number":391,"context_line":"        volume.volume_type.extra_specs \u003d {"},{"line_number":392,"context_line":"            \u0027backend\u0027: \u0027unknown\u0027,"},{"line_number":393,"context_line":"            \u0027image_service:store_id\u0027: store_id,"},{"line_number":394,"context_line":"        }"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        image_volume_id \u003d \u002742\u0027"},{"line_number":397,"context_line":"        image_volume \u003d mock.MagicMock(spec\u003d[\u0027id\u0027])"},{"line_number":398,"context_line":"        image_volume.id \u003d image_volume_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"99d3058f_f92e4bfa","line":395,"range":{"start_line":390,"start_character":8,"end_line":395,"end_character":0},"updated":"2022-06-09 07:42:53.000000000","message":"should create an actual volume type and pass it to create the volume\n\nvol_type \u003d fake_volume.fake_volume_type_obj(ctxt, extra_specs \u003d {\n            \u0027volume_backend_name\u0027: \u0027unknown\u0027,\n            \u0027image_service:store_id\u0027: store_id,\n        }\nvol \u003d fake_volume.fake_volume_obj(ctxt, {\u0027volume_type_id\u0027: vol_type.id})","commit_id":"4e2644c652b668f6898736d24ebf55c8cf98e947"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"98f11558eeb0986aab6f7cd434c37631612066b5","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        ctx.project_id \u003d project_id"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        store_id \u003d \u0027muninn\u0027"},{"line_number":390,"context_line":"        volume \u003d mock.MagicMock(spec\u003d[\u0027volume_type\u0027])"},{"line_number":391,"context_line":"        volume.volume_type.extra_specs \u003d {"},{"line_number":392,"context_line":"            \u0027backend\u0027: \u0027unknown\u0027,"},{"line_number":393,"context_line":"            \u0027image_service:store_id\u0027: store_id,"},{"line_number":394,"context_line":"        }"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        image_volume_id \u003d \u002742\u0027"},{"line_number":397,"context_line":"        image_volume \u003d mock.MagicMock(spec\u003d[\u0027id\u0027])"},{"line_number":398,"context_line":"        image_volume.id \u003d image_volume_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"72330b9c_3558702a","line":395,"range":{"start_line":390,"start_character":8,"end_line":395,"end_character":0},"in_reply_to":"99d3058f_f92e4bfa","updated":"2022-06-14 23:03:31.000000000","message":"Done","commit_id":"4e2644c652b668f6898736d24ebf55c8cf98e947"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"dce95fe06f888ef8ae34b6968238580b76af913a","unresolved":true,"context_lines":[{"line_number":393,"context_line":"            \u0027image_service:store_id\u0027: store_id,"},{"line_number":394,"context_line":"        }"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        image_volume_id \u003d \u002742\u0027"},{"line_number":397,"context_line":"        image_volume \u003d mock.MagicMock(spec\u003d[\u0027id\u0027])"},{"line_number":398,"context_line":"        image_volume.id \u003d image_volume_id"},{"line_number":399,"context_line":"        url \u003d \u0027cinder://%(store)s/%(vol)s\u0027 % {"}],"source_content_type":"text/x-python","patch_set":3,"id":"a4d8111b_3cf7136a","line":396,"range":{"start_line":396,"start_character":26,"end_line":396,"end_character":30},"updated":"2022-06-09 07:42:53.000000000","message":"same","commit_id":"4e2644c652b668f6898736d24ebf55c8cf98e947"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"98f11558eeb0986aab6f7cd434c37631612066b5","unresolved":false,"context_lines":[{"line_number":393,"context_line":"            \u0027image_service:store_id\u0027: store_id,"},{"line_number":394,"context_line":"        }"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        image_volume_id \u003d \u002742\u0027"},{"line_number":397,"context_line":"        image_volume \u003d mock.MagicMock(spec\u003d[\u0027id\u0027])"},{"line_number":398,"context_line":"        image_volume.id \u003d image_volume_id"},{"line_number":399,"context_line":"        url \u003d \u0027cinder://%(store)s/%(vol)s\u0027 % {"}],"source_content_type":"text/x-python","patch_set":3,"id":"790eb2c0_4d333f1e","line":396,"range":{"start_line":396,"start_character":26,"end_line":396,"end_character":30},"in_reply_to":"a4d8111b_3cf7136a","updated":"2022-06-14 23:03:31.000000000","message":"Done","commit_id":"4e2644c652b668f6898736d24ebf55c8cf98e947"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"dce95fe06f888ef8ae34b6968238580b76af913a","unresolved":true,"context_lines":[{"line_number":394,"context_line":"        }"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        image_volume_id \u003d \u002742\u0027"},{"line_number":397,"context_line":"        image_volume \u003d mock.MagicMock(spec\u003d[\u0027id\u0027])"},{"line_number":398,"context_line":"        image_volume.id \u003d image_volume_id"},{"line_number":399,"context_line":"        url \u003d \u0027cinder://%(store)s/%(vol)s\u0027 % {"},{"line_number":400,"context_line":"            \u0027store\u0027: store_id,"},{"line_number":401,"context_line":"            \u0027vol\u0027: image_volume_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"760a74bd_3dc579b7","line":398,"range":{"start_line":397,"start_character":8,"end_line":398,"end_character":41},"updated":"2022-06-09 07:42:53.000000000","message":"same, create an actual OVO volume obj","commit_id":"4e2644c652b668f6898736d24ebf55c8cf98e947"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"98f11558eeb0986aab6f7cd434c37631612066b5","unresolved":false,"context_lines":[{"line_number":394,"context_line":"        }"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        image_volume_id \u003d \u002742\u0027"},{"line_number":397,"context_line":"        image_volume \u003d mock.MagicMock(spec\u003d[\u0027id\u0027])"},{"line_number":398,"context_line":"        image_volume.id \u003d image_volume_id"},{"line_number":399,"context_line":"        url \u003d \u0027cinder://%(store)s/%(vol)s\u0027 % {"},{"line_number":400,"context_line":"            \u0027store\u0027: store_id,"},{"line_number":401,"context_line":"            \u0027vol\u0027: image_volume_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"8b3256f7_0c30a395","line":398,"range":{"start_line":397,"start_character":8,"end_line":398,"end_character":41},"in_reply_to":"760a74bd_3dc579b7","updated":"2022-06-14 23:03:31.000000000","message":"Done","commit_id":"4e2644c652b668f6898736d24ebf55c8cf98e947"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"dce95fe06f888ef8ae34b6968238580b76af913a","unresolved":true,"context_lines":[{"line_number":402,"context_line":"        }"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"        image_service \u003d mock.MagicMock(spec\u003d[\u0027add_location\u0027])"},{"line_number":405,"context_line":"        image_meta_id \u003d \u0027616\u0027"},{"line_number":406,"context_line":"        image_meta \u003d {"},{"line_number":407,"context_line":"            \u0027id\u0027: image_meta_id,"},{"line_number":408,"context_line":"            \u0027disk_format\u0027: \u0027raw\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"b7494cef_1df25152","line":405,"range":{"start_line":405,"start_character":24,"end_line":405,"end_character":29},"updated":"2022-06-09 07:42:53.000000000","message":"same","commit_id":"4e2644c652b668f6898736d24ebf55c8cf98e947"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"98f11558eeb0986aab6f7cd434c37631612066b5","unresolved":false,"context_lines":[{"line_number":402,"context_line":"        }"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"        image_service \u003d mock.MagicMock(spec\u003d[\u0027add_location\u0027])"},{"line_number":405,"context_line":"        image_meta_id \u003d \u0027616\u0027"},{"line_number":406,"context_line":"        image_meta \u003d {"},{"line_number":407,"context_line":"            \u0027id\u0027: image_meta_id,"},{"line_number":408,"context_line":"            \u0027disk_format\u0027: \u0027raw\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"b2913cde_23de0703","line":405,"range":{"start_line":405,"start_character":24,"end_line":405,"end_character":29},"in_reply_to":"b7494cef_1df25152","updated":"2022-06-14 23:03:31.000000000","message":"Done","commit_id":"4e2644c652b668f6898736d24ebf55c8cf98e947"}],"releasenotes/notes/bug-1978020-glance-upload-uri-8fbc70c442ac620c.yaml":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a4c3bfd4db03ed4f2186eb8617d0d218372baa8c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8ec4e90b_56c904cb","line":8,"updated":"2022-06-16 12:20:13.000000000","message":"As far as I can tell, the only documentation of this feature is in the cinder ussuri release notes.  I wonder whether it\u0027s worth adding a reminder here that while the glance store_id is validated at the time a \u0027image_service:store_id\u0027 extra-spec is created, the validation is not ongoing.  It is the responsibility of the operator to ensure that if store_ids are modified in Glance, appropriate changes are made to any affected cinder-side volume-types.","commit_id":"202d66ac9797e9bd124ea6e06a711c59bfc93639"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"a361f4f741111f4465b1d7e2378f7d6bfd188236","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c15a5c28_50d4b29c","line":8,"in_reply_to":"8ec4e90b_56c904cb","updated":"2022-06-22 08:01:00.000000000","message":"Done","commit_id":"202d66ac9797e9bd124ea6e06a711c59bfc93639"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"500581f2dfc7e5d7902b2bd6340e09c83732dd22","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"403323d6_424d328e","line":12,"updated":"2022-09-06 11:50:53.000000000","message":"nit: If you want a new paragraph (within the same bullet point) to start with \"Please\", you need a blank line before line 8 (but keep all the indentation the way it is).","commit_id":"4af3e86c6eefc152f505f6961082644f5ee18e68"}]}