)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"068cfe49f88fb82ad87166fabfda734e7a7de5ee","unresolved":true,"context_lines":[{"line_number":9,"context_line":"On Change-Id Iae63aee973932b2eef26d832a7f413a04bad0df1 we added back the"},{"line_number":10,"context_line":"support for the rbd_keyring_conf option to Cinder, but the"},{"line_number":11,"context_line":"functionality is not complete, because it only fully works when the"},{"line_number":12,"context_line":"configuration file is located under /etc/ceph."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch fixes support for non /etc/ceph locations."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"62cd14ae_79d38ac4","line":12,"updated":"2023-11-15 16:16:55.000000000","message":"Just leaving a note here for other reviewers, because I remember OSSN-0085 and this threw me off a bit.  What\u0027s going on is that the change Gorka mentions above let you configure the keyring file wherever you wanted it, it didn\u0027t have to be in /etc/ceph .... it\u0027s just that there are some contexts (like replication) where the keyring is used, and we weren\u0027t passing anything at all, and so ceph was looking in the default location of /etc/ceph.  (At least that\u0027s my understanding.)\n\nThis isn\u0027t an issue for cinder because cinder explicitly expects the keyring file to be in the standard location, and doesn\u0027t support the rbd_keyring_conf option.","commit_id":"52262f9df29029a4bcec5fcbb8f0f539901dad1f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"068cfe49f88fb82ad87166fabfda734e7a7de5ee","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"No release note has been added since this is a functionality that is"},{"line_number":17,"context_line":"only possible through cinderlib (adding the config option in cinder.conf"},{"line_number":18,"context_line":"does nothing) and we don\u0027t want to create unnecessary noise."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Idf123c4fa2b3cea1cb7b5cb78c0c610b0f29dd2f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"cb6106ed_71a3bca7","line":18,"range":{"start_line":18,"start_character":18,"end_line":18,"end_character":59},"updated":"2023-11-15 16:16:55.000000000","message":"I agree 100%.","commit_id":"52262f9df29029a4bcec5fcbb8f0f539901dad1f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"1be20d892981e3ebb354a46bc7fcaa50ea5647db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f69dde4a_50d6b3c5","updated":"2022-08-24 09:52:02.000000000","message":"recheck - ceph job failed but logs are no longer available","commit_id":"2ce9d127665a1dbb6fa99fd6ef885ac201ef8025"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"62ba3533b821fae3975b997abbf3fc2727e83cee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5cdaca84_9b00fa3d","updated":"2022-08-25 12:56:11.000000000","message":"Looks like the py38 job is hitting a problem addressed by either https://review.opendev.org/c/openstack/cinder/+/854266 or https://review.opendev.org/c/openstack/cinder/+/854261 , so we need to get those merged ASAP.","commit_id":"020b025621d034ba54c24e9d3f7ee099ad10d70f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"068cfe49f88fb82ad87166fabfda734e7a7de5ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c7e7e110_b0e3781e","updated":"2023-11-15 16:16:55.000000000","message":"LGTM, assuming that my comments inline are correct.\n\nRaising the priority because it would be nice to get this backported into stable/2023.2 and have a new cinder 2023.2 release to work with the upcoming Bobcat cinderlib release.","commit_id":"52262f9df29029a4bcec5fcbb8f0f539901dad1f"}],"cinder/volume/drivers/rbd.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"068cfe49f88fb82ad87166fabfda734e7a7de5ee","unresolved":true,"context_lines":[{"line_number":614,"context_line":"                rados_id\u003duser, clustername\u003dname, conffile\u003dconf"},{"line_number":615,"context_line":"            )"},{"line_number":616,"context_line":"            if keyring:  # cinderlib usage"},{"line_number":617,"context_line":"                kwargs[\u0027conf\u0027] \u003d {\u0027keyring\u0027: keyring}"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"            client \u003d self.rados.Rados(**kwargs)"},{"line_number":620,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5ea470d7_07931d4e","line":617,"range":{"start_line":617,"start_character":35,"end_line":617,"end_character":42},"updated":"2023-11-15 16:16:55.000000000","message":"What were these people smoking when they designed this?  As part of the \u0027data\u0027 (line 1814), \u0027keyring\u0027 is the content, but here \u0027keyring\u0027 is expected to be a filename.  And on the replication target, it\u0027s \u0027keyring_file\u0027.  Not very confusing at all!","commit_id":"52262f9df29029a4bcec5fcbb8f0f539901dad1f"}]}