)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"13a0bb73b7927995b544ab7d44c34ac2971583de","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Jesper Schmitz Mouridsen \u003cjesper@schmitz.computer\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-08-26 11:22:41 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add values of message_* properties to RequestContext"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":" When a backup driver raised an exception the"},{"line_number":10,"context_line":" message_* properties where not passed and"},{"line_number":11,"context_line":" the message handler always threw"},{"line_number":12,"context_line":" TypeError: \u0027NoneType\u0027 object is not subscriptable"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: 1978729"},{"line_number":15,"context_line":"Change-Id: Ibdaaf39abafbae6bfcb9fdf9fb7a55d968ad9f11"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"b7692595_6748acc9","line":12,"range":{"start_line":7,"start_character":0,"end_line":12,"end_character":50},"updated":"2022-08-26 14:46:28.000000000","message":"This isn\u0027t quite correct; the properties had been added, they just weren\u0027t being serialized properly.  I suggest something like:\n\nSerialize message_* properties of RequestContext\n\nChange Idc00b125b33b added the ability to store and retrieve user message data in the request context, but it neglected to add code to make sure they would persist across serialization and deserialization of the request context object, as happens in the create-backup workflow.  As a result, when a user message needed to be created to describe an error condition in the backup driver, instead we\u0027d get an exception raised: \"TypeError: \u0027NoneType\u0027 object is not subscriptable\".\n\nThis patch fixes the issue by making sure the message_* properties persist across serialization/deserialization of RequestContext objects.","commit_id":"64fc5c5615728df97f9d5b074699c4f495118449"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"bf2a7374cf0afed21902ca64ba2e768377574f25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"14cc06fb_fa6627a0","updated":"2022-07-15 15:00:15.000000000","message":"Thanks for fixing this!\n\nThe patch is missing release note and the commit message is too brief.\nCommit message should explain what was failing, why it was failing, and how it has been resolved.  In this case a summary of what\u0027s in the bug.","commit_id":"3b366f023f030f153820f9a298a374e87163b824"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c68caa8c2e5f311b8d2d627ab7b3aaac1ba82787","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ba392e43_ce63c8d4","updated":"2022-07-09 14:11:18.000000000","message":"Thanks for working on this.  Looks correct to me; I\u0027m assuming that you\u0027ve tried it out and it works.  Would be nice if you left a comment either here or on the bug showing that the issue has been fixed.\n\nWould also be nice to have a test to prevent this from happening again.  I was thinking something that introspected the __init__() parameters and verified that they are handled in to_dict and from_dict.  But now that I think about it, such a test would not have detected this particular bug, because the data members were being added directly to the context object elsewhere in the code.  I don\u0027t think we can test it in test_backup_messages either because the context and RPC calls are all mocked out, so we won\u0027t have any actual serializing/deserializing of the context object.  Anyway, think about it a bit and maybe you\u0027ll have an idea.  I don\u0027t want to hold the patch up over it, though.  Maybe you could put it on the agenda for the weekly cinder meeting and see if anyone has an idea.\n\nOnly a +1 at this point because while it looks like it hasn\u0027t broken anything, it would be good to have assurance that it actually works!","commit_id":"3b366f023f030f153820f9a298a374e87163b824"},{"author":{"_account_id":29260,"name":"Jesper Schmitz Mouridsen","email":"jesper@schmitz.computer","username":"jsmdk"},"change_message_id":"5501c4db72a49e3c7d0ff57a983b5420b8c6ee6c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"61f799fc_2c5705fb","updated":"2022-06-17 10:55:08.000000000","message":"recheck","commit_id":"3b366f023f030f153820f9a298a374e87163b824"},{"author":{"_account_id":29260,"name":"Jesper Schmitz Mouridsen","email":"jesper@schmitz.computer","username":"jsmdk"},"change_message_id":"f95b9ae95c2b09fb9eaa113bc2a773e05a57044c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ad016b5e_2bf0d1be","updated":"2022-06-21 18:09:52.000000000","message":"recheck","commit_id":"3b366f023f030f153820f9a298a374e87163b824"},{"author":{"_account_id":29260,"name":"Jesper Schmitz Mouridsen","email":"jesper@schmitz.computer","username":"jsmdk"},"change_message_id":"d3bbe446a2c5504ce0be30b790ff42fc2b7f47a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"395aacb7_3cdcec22","updated":"2022-06-17 14:32:46.000000000","message":"run-DataCore CI\n","commit_id":"3b366f023f030f153820f9a298a374e87163b824"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"13a0bb73b7927995b544ab7d44c34ac2971583de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e51939bd_cc83fd0b","updated":"2022-08-26 14:46:28.000000000","message":"Suggestion for revising the commit message.  Code and release note look fine.","commit_id":"64fc5c5615728df97f9d5b074699c4f495118449"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"909a63d9ab83a2875fa96652a5922ed7f3aa5fd4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"89121b77_1b5e3352","updated":"2022-08-27 17:20:02.000000000","message":"LGTM!","commit_id":"c46d41719e0c8199dc17ef566413889692644ef5"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"def1d2cc8824e36b89b9ca750fb94cbcbdd2fc2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4feca545_cb0aed2e","updated":"2022-08-29 12:32:45.000000000","message":"Unit tests should have been added, though I don\u0027t want to block the patch for that.","commit_id":"c46d41719e0c8199dc17ef566413889692644ef5"},{"author":{"_account_id":28801,"name":"Cisco Cinder CI","email":"cisco-cinder-ci@cisco.com","username":"cisco-cinder-ci"},"change_message_id":"e0c0683e193324f50a2d3c1427137743d3b0fa22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f2d5c831_e3c2faf9","updated":"2022-08-29 11:09:56.000000000","message":"cisco-cinder-ci","commit_id":"c46d41719e0c8199dc17ef566413889692644ef5"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b4537a1de3660e22feb51f7c1f588fa7d1e1cbe1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4c2166f3_5d51a355","updated":"2022-08-26 19:40:46.000000000","message":"recheck openstack-tox-py39 failure: Could not install packages due to an OSError: HTTPSConnectionPool(host\u003d\u0027mirror.gra1.ovh.opendev.org\u0027, port\u003d443): Max retries exceeded ... same error for py310; grenade failure is could not find apt repo","commit_id":"c46d41719e0c8199dc17ef566413889692644ef5"}],"releasenotes/notes/bug-1978729-cinder-backup-4cd87c4d71b7713e.yaml":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"def1d2cc8824e36b89b9ca750fb94cbcbdd2fc2a","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #1978729 \u003chttps://bugs.launchpad.net/cinder/+bug/1978729\u003e`_: Fixed"},{"line_number":5,"context_line":"    context.message_action is None on errors by backup drivers. The message_*"},{"line_number":6,"context_line":"    properties of the context were not passed during rpc, which caused a double"},{"line_number":7,"context_line":"    exception when a backup driver raised an exception, masking the actual backup"},{"line_number":8,"context_line":"    driver exception."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1b4aed24_f6ef3b3a","line":8,"range":{"start_line":5,"start_character":64,"end_line":8,"end_character":21},"updated":"2022-08-29 12:32:45.000000000","message":"Release note should avoid providing low level details.  They should be sysadmin level information.","commit_id":"c46d41719e0c8199dc17ef566413889692644ef5"}]}