)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"304f7ac3a0aa8969d129aac45545585ea2b4651f","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     zhouyunfei \u003c602605216@qq.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-06-21 13:09:11 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Modify comment"},{"line_number":8,"context_line":"Previous comment in this line is not correct. Accutlly the function \"backend_passes\" returns a bool."},{"line_number":9,"context_line":"Fixes: bug #1979041"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9270ebca_0adaa2c6","line":7,"updated":"2022-06-21 13:09:43.000000000","message":"Please leave a blank line after this subject line.","commit_id":"89fab5d135cad5089bb32953e312d3198b20cb02"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"304f7ac3a0aa8969d129aac45545585ea2b4651f","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2022-06-21 13:09:11 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Modify comment"},{"line_number":8,"context_line":"Previous comment in this line is not correct. Accutlly the function \"backend_passes\" returns a bool."},{"line_number":9,"context_line":"Fixes: bug #1979041"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ibe27df9670b2f972e8d6651e002027050980263f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9253c817_f9b62294","line":8,"range":{"start_line":8,"start_character":46,"end_line":8,"end_character":54},"updated":"2022-06-21 13:09:43.000000000","message":"\u0027Actually\u0027\n\nAlso, please wrap commit messages at 72 chars.","commit_id":"89fab5d135cad5089bb32953e312d3198b20cb02"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"304f7ac3a0aa8969d129aac45545585ea2b4651f","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Modify comment"},{"line_number":8,"context_line":"Previous comment in this line is not correct. Accutlly the function \"backend_passes\" returns a bool."},{"line_number":9,"context_line":"Fixes: bug #1979041"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ibe27df9670b2f972e8d6651e002027050980263f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dc3b02c8_420c8b18","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":19},"updated":"2022-06-21 13:09:43.000000000","message":"Please add a blank line before this.  Also, it should say:\n\n  Closes-bug: #1979041","commit_id":"89fab5d135cad5089bb32953e312d3198b20cb02"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"304f7ac3a0aa8969d129aac45545585ea2b4651f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"50693596_d71b8add","updated":"2022-06-21 13:09:43.000000000","message":"Some suggestions noted inline.","commit_id":"89fab5d135cad5089bb32953e312d3198b20cb02"}],"cinder/scheduler/filters/capabilities_filter.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"304f7ac3a0aa8969d129aac45545585ea2b4651f","unresolved":true,"context_lines":[{"line_number":91,"context_line":"        return True"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def backend_passes(self, backend_state, filter_properties):"},{"line_number":94,"context_line":"        \"\"\"Return a bool value which check if capabilities satisfy resource type requirements.\"\"\""},{"line_number":95,"context_line":"        # Note(zhiteng) Currently only Cinder and Nova are using"},{"line_number":96,"context_line":"        # this filter, so the resource type is either instance or"},{"line_number":97,"context_line":"        # volume."}],"source_content_type":"text/x-python","patch_set":1,"id":"526c54dc_21cebf3a","line":94,"updated":"2022-06-21 13:09:43.000000000","message":"This line is too long.  When you break it, there will be a problem because openstack documentation style is that the first line must be a one-line summary:\nhttps://docs.openstack.org/hacking/latest/user/hacking.html#docstrings\n\nBut it shouldn\u0027t be too bad to break up, because you can add a :returns: line to indicate a bool value, and while you\u0027re at it, you can add :param: lines saying what the parameters represent.","commit_id":"89fab5d135cad5089bb32953e312d3198b20cb02"}]}