)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"fa7fe152381e1e0c498f7e6741c4a4779708fd1a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dd2ffe83_5258e1d2","updated":"2023-01-26 16:41:26.000000000","message":"NEC and Hitachi CI are passing. Code looks straightforward introducing a new API call to backend to fetch the pools and return it in the get_volume_stats method. Good amount of test coverage, LGTM.\nRP+1 since it\u0027s blocking the HPE XP driver merge.","commit_id":"e9482b7f64930624ffcf07ee6581480dbd877ac0"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c57ecb6302d614975409736580af1413bad784ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1a01007d_57c6aa1e","updated":"2023-01-27 03:01:07.000000000","message":"See inline for a comment about the hitachi_pool option.\n\nCode and tests LGTM.","commit_id":"e9482b7f64930624ffcf07ee6581480dbd877ac0"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e797c9418da803301c6a8ab12168292bfb319852","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0f286083_ee029aaf","updated":"2023-01-27 08:42:09.000000000","message":"recheck failure in cinder-grenade-mn-sub-volbak\n\nfrom grenade and nova logs, looks like an issue with creating instance\n\ngrenade\n2023-01-27 04:19:30.759 | + /opt/stack/new/grenade/projects/60_nova/resources.sh:create:130 :   openstack server add floating ip nova_server1 172.24.5.88\n2023-01-27 04:24:32.938 | get() takes 1 positional argument but 2 were given\n2023-01-27 04:24:33.235 | + /opt/stack/new/grenade/projects/60_nova/resources.sh:create:1 :   exit_trap\n\n\nnova (cannot find instance)\nJan 27 04:19:32.139821 np0032880639 devstack@n-api.service[101318]: ERROR nova.api.openstack.wsgi Traceback (most recent call last):\nJan 27 04:19:32.139821 np0032880639 devstack@n-api.service[101318]: ERROR nova.api.openstack.wsgi   File \"/opt/stack/old/nova/nova/api/openstack/wsgi.py\", line 539, in _process_stack\nJan 27 04:19:32.139821 np0032880639 devstack@n-api.service[101318]: ERROR nova.api.openstack.wsgi     action_result \u003d self.dispatch(meth, request, action_args)\nJan 27 04:19:32.139821 np0032880639 devstack@n-api.service[101318]: ERROR nova.api.openstack.wsgi   File \"/opt/stack/old/nova/nova/api/openstack/wsgi.py\", line 372, in __exit__\nJan 27 04:19:32.139821 np0032880639 devstack@n-api.service[101318]: ERROR nova.api.openstack.wsgi     raise Fault(ex_value)\nJan 27 04:19:32.139821 np0032880639 devstack@n-api.service[101318]: ERROR nova.api.openstack.wsgi nova.api.openstack.wsgi.Fault: Instance nova_server1 could not be found.\nJan 27 04:19:32.139821 np0032880639 devstack@n-api.service[101318]: ERROR nova.api.openstack.wsgi \nJan 27 04:19:32.139821 np0032880639 devstack@n-api.service[101318]: DEBUG nova.api.openstack.wsgi [None req-61d4b8f8-f4e1-4340-9e70-6685a014973f nova_grenade nova_grenade] Returning 404 to user: Instance nova_server1 could not be found. {{(pid\u003d101318) __call__ /opt/stack/old/nova/nova/api/openstack/wsgi.py:942}}","commit_id":"e9482b7f64930624ffcf07ee6581480dbd877ac0"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"cdbaaa516b16ffced1b576ce0c44e88da1679177","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"27ea4c79_9cd861f1","in_reply_to":"1a01007d_57c6aa1e","updated":"2023-01-27 07:00:10.000000000","message":"Thank you.\nCould you recheck for workflow? it\u0027s failed by network problem or around.","commit_id":"e9482b7f64930624ffcf07ee6581480dbd877ac0"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"a168caf46fe4c090d882a6861593c5f27e46730d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0f3b29d1_5295cca7","in_reply_to":"dd2ffe83_5258e1d2","updated":"2023-01-27 01:26:24.000000000","message":"Thank you for reviewing.","commit_id":"e9482b7f64930624ffcf07ee6581480dbd877ac0"}],"cinder/volume/drivers/hitachi/hbsd_common.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"fa7fe152381e1e0c498f7e6741c4a4779708fd1a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        default\u003dNone,"},{"line_number":50,"context_line":"        help\u003d\u0027Product number of the storage system.\u0027),"},{"line_number":51,"context_line":"    cfg.ListOpt("},{"line_number":52,"context_line":"        \u0027hitachi_pool\u0027,"},{"line_number":53,"context_line":"        default\u003d[],"},{"line_number":54,"context_line":"        help\u003d\u0027Pool number[s] or pool name[s] of the DP pool.\u0027),"},{"line_number":55,"context_line":"    cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":2,"id":"b1639371_efa88e5f","line":52,"range":{"start_line":52,"start_character":9,"end_line":52,"end_character":21},"updated":"2023-01-26 16:41:26.000000000","message":"should\u0027ve been hitachi_pools but then again it needs to go through the deprecation cycle and a new config needs to be added so I\u0027m fine with this","commit_id":"e9482b7f64930624ffcf07ee6581480dbd877ac0"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"cdbaaa516b16ffced1b576ce0c44e88da1679177","unresolved":true,"context_lines":[{"line_number":49,"context_line":"        default\u003dNone,"},{"line_number":50,"context_line":"        help\u003d\u0027Product number of the storage system.\u0027),"},{"line_number":51,"context_line":"    cfg.ListOpt("},{"line_number":52,"context_line":"        \u0027hitachi_pool\u0027,"},{"line_number":53,"context_line":"        default\u003d[],"},{"line_number":54,"context_line":"        help\u003d\u0027Pool number[s] or pool name[s] of the DP pool.\u0027),"},{"line_number":55,"context_line":"    cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":2,"id":"645b89ee_393abc60","line":52,"range":{"start_line":52,"start_character":9,"end_line":52,"end_character":21},"in_reply_to":"250af657_640abdf9","updated":"2023-01-27 07:00:10.000000000","message":"I see. Thank you for letting me know your concern.","commit_id":"e9482b7f64930624ffcf07ee6581480dbd877ac0"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"a168caf46fe4c090d882a6861593c5f27e46730d","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        default\u003dNone,"},{"line_number":50,"context_line":"        help\u003d\u0027Product number of the storage system.\u0027),"},{"line_number":51,"context_line":"    cfg.ListOpt("},{"line_number":52,"context_line":"        \u0027hitachi_pool\u0027,"},{"line_number":53,"context_line":"        default\u003d[],"},{"line_number":54,"context_line":"        help\u003d\u0027Pool number[s] or pool name[s] of the DP pool.\u0027),"},{"line_number":55,"context_line":"    cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":2,"id":"6393a6aa_3922aa00","line":52,"range":{"start_line":52,"start_character":9,"end_line":52,"end_character":21},"in_reply_to":"b1639371_efa88e5f","updated":"2023-01-27 01:26:24.000000000","message":"I see.","commit_id":"e9482b7f64930624ffcf07ee6581480dbd877ac0"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c57ecb6302d614975409736580af1413bad784ba","unresolved":true,"context_lines":[{"line_number":49,"context_line":"        default\u003dNone,"},{"line_number":50,"context_line":"        help\u003d\u0027Product number of the storage system.\u0027),"},{"line_number":51,"context_line":"    cfg.ListOpt("},{"line_number":52,"context_line":"        \u0027hitachi_pool\u0027,"},{"line_number":53,"context_line":"        default\u003d[],"},{"line_number":54,"context_line":"        help\u003d\u0027Pool number[s] or pool name[s] of the DP pool.\u0027),"},{"line_number":55,"context_line":"    cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":2,"id":"250af657_640abdf9","line":52,"range":{"start_line":52,"start_character":9,"end_line":52,"end_character":21},"in_reply_to":"b1639371_efa88e5f","updated":"2023-01-27 03:01:07.000000000","message":"You could change the name to \u0027hitachi_pools\u0027 and add\n\n  deprecated_name\u003d\u0027hitachi_pool\u0027,\n\nto the definition and oslo.config will look for either one in the config file.\n\nI think the more important issue is that you ordinarily don\u0027t want to change the type of the option because that could break existing config files.  Luckily the default for bounds in a ListOpt is False, so oslo.config won\u0027t require the list to be enclosed in a pair of square brackets.  Thus an existing pool name will automatically converted by oslo.config into a list containing a single item, so this change shouldn\u0027t break any existing config files.","commit_id":"e9482b7f64930624ffcf07ee6581480dbd877ac0"}],"cinder/volume/drivers/nec/v/nec_v_rest.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c57ecb6302d614975409736580af1413bad784ba","unresolved":true,"context_lines":[{"line_number":28,"context_line":"        default\u003dNone,"},{"line_number":29,"context_line":"        help\u003d\u0027Product number of the storage system.\u0027),"},{"line_number":30,"context_line":"    cfg.ListOpt("},{"line_number":31,"context_line":"        \u0027nec_v_pool\u0027,"},{"line_number":32,"context_line":"        default\u003d[],"},{"line_number":33,"context_line":"        help\u003d\u0027Pool number[s] or pool name[s] of the DP pool.\u0027),"},{"line_number":34,"context_line":"    cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":2,"id":"3a1b4860_ab68bc8e","line":31,"range":{"start_line":31,"start_character":9,"end_line":31,"end_character":19},"updated":"2023-01-27 03:01:07.000000000","message":"same comment from hbsd_common applies here","commit_id":"e9482b7f64930624ffcf07ee6581480dbd877ac0"}],"releasenotes/notes/hitachi-vsp-add-multi-pool-4c4589b93399e641.yaml":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"fa7fe152381e1e0c498f7e6741c4a4779708fd1a","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"- |"},{"line_number":4,"context_line":"    Supported multi-pool for Hitachi driver and OEM storage driver."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ee7f74ad_36de7ef2","line":5,"updated":"2023-01-26 16:41:26.000000000","message":"nit: extra line","commit_id":"e9482b7f64930624ffcf07ee6581480dbd877ac0"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"a168caf46fe4c090d882a6861593c5f27e46730d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"- |"},{"line_number":4,"context_line":"    Supported multi-pool for Hitachi driver and OEM storage driver."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"780c0d01_c558903e","line":5,"in_reply_to":"ee7f74ad_36de7ef2","updated":"2023-01-27 01:26:24.000000000","message":"I would like to fix it as another patch.","commit_id":"e9482b7f64930624ffcf07ee6581480dbd877ac0"}]}