)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"c14e90a4bdf79b1491d7433ab734b6ae4aefbf76","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add the clone_across_pools driver capability"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Let drivers declare that they can clone a volume into a different pool and"},{"line_number":10,"context_line":"relax the checks when creating a volume from an image (both with and"},{"line_number":11,"context_line":"without the image cache)."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"3c4b9b21_3b75b2be","line":9,"updated":"2024-07-24 06:29:46.000000000","message":"nit: lines should be wrapped at 72 chars.\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"9b400d01660be47e73a2de7e002fdfcd4d2984b9"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"01fc3d4c397d232c556c2b3bc93f69eb9ee4f1ae","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add the clone_across_pools driver capability"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Let drivers declare that they can clone a volume into a different pool and"},{"line_number":10,"context_line":"relax the checks when creating a volume from an image (both with and"},{"line_number":11,"context_line":"without the image cache)."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"5c0997a8_a6ddf10d","line":9,"in_reply_to":"3c4b9b21_3b75b2be","updated":"2024-07-24 06:44:45.000000000","message":"Done","commit_id":"9b400d01660be47e73a2de7e002fdfcd4d2984b9"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"e5d5ec3b48b90753cafefbfc9c474bb331abcd88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fba27af2_a3fb3521","updated":"2022-06-24 10:12:14.000000000","message":"run-storpool-ci","commit_id":"bca6a2871ac3ba2a4afc6a05b23b2667e9833057"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"a3517f53be4b026ae41589539ef14396faf3f92f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5f8fb601_578fcb16","updated":"2022-06-24 10:09:47.000000000","message":"run-storpool-ci\n(I did some aggressive clean-up by hand at *just* the wrong time)","commit_id":"bca6a2871ac3ba2a4afc6a05b23b2667e9833057"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"e37ef3a3897a5f59a6d66cb9f53fef53b05bd528","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2d252495_93e97c87","updated":"2023-01-17 01:44:32.000000000","message":"recheck","commit_id":"b10b10f930edbc66e24c82012ede697f379e4241"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"fe46f9c74460f55ddb47a53b9ee628c362db8bbd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9deee6fb_366c84f1","updated":"2023-01-24 16:05:25.000000000","message":"recheck","commit_id":"b10b10f930edbc66e24c82012ede697f379e4241"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"bd8bb7f759d38440bffb3049e6a0e57302c36f5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c57e76d3_cc9d74be","updated":"2023-01-24 10:28:59.000000000","message":"recheck","commit_id":"b10b10f930edbc66e24c82012ede697f379e4241"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"ce2ae3e1cc832724382186d5b249af41556120f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9c4c4fef_a5de0e4a","updated":"2023-01-26 16:18:02.000000000","message":"recheck","commit_id":"bbfffa38d7c87d4b83c42bcc92f50dc9fd028d73"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"d714ef47f464a7801c168ac874d8d7b45ff2f926","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6a4ed6ad_9f8182d3","updated":"2023-02-13 23:51:53.000000000","message":"recheck","commit_id":"c6e23b7eb83d0b0a852d46f0fe87669fe9c0ea81"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"c36a30058d3df4a075e152fe7780781757b58ec0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"294d5fb9_376caa31","updated":"2023-02-13 10:25:45.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"c6e23b7eb83d0b0a852d46f0fe87669fe9c0ea81"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"edc304b361da0c64d4a0ade4e475d1f7db753dd3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"378a0bd1_e4f3697d","updated":"2023-03-01 23:15:46.000000000","message":"recheck","commit_id":"c47c8054fc1f6239f050a0865d8ac8f8da1b073d"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"7d27294fecacbdb71deb479f2b4f43ba213b16d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d7c8956f_72008f6a","updated":"2023-03-03 23:44:32.000000000","message":"recheck","commit_id":"c47c8054fc1f6239f050a0865d8ac8f8da1b073d"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"87d93b703590ce70ce500cb4061e3945b6f5aa7a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"ebfdaf26_79dbd831","updated":"2023-03-02 06:50:52.000000000","message":"recheck","commit_id":"c47c8054fc1f6239f050a0865d8ac8f8da1b073d"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"5f5e231357c8f15c93492e3df609f3ce11f24441","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f46bf4cd_0295d777","updated":"2023-03-02 18:55:18.000000000","message":"recheck","commit_id":"c47c8054fc1f6239f050a0865d8ac8f8da1b073d"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"77fb0ec93de3c7f5d101e780e6c52133af0f33cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"9152dfc8_3ccb1943","updated":"2023-07-21 13:23:35.000000000","message":"This looks like a very vendor specific capability (storpool) and therefore adding this to the support matrix should not be allowed.\nThe support matrix is not their to sell a feature only one vendor supports.","commit_id":"eeb95e0adfda075e395a15c1825448a92824008d"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"467acce2bf9ef9efc23387414ae53e9274e5c1c5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"7930e78f_dafe9084","in_reply_to":"129a3316_4797c5a8","updated":"2024-07-09 12:35:10.000000000","message":"\"Vendor drivers that support cloning a volume into a different\n      storage pool, e.g. when creating a volume from a Cinder-backed\n      Glance image.\"\nAgree with simon - adding a new feature to the support matrix - where the definition like \"storage pool\" is not well defined for common vendors does not seems reasonable.\ncompare with: \"online_extend - Cinder supports the ability to extend a volume that is attached to an instance, but not all drivers are able to do this.\"","commit_id":"eeb95e0adfda075e395a15c1825448a92824008d"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"bcbb5e782ba65f099ceb94eeb6205e48f9b81637","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"129a3316_4797c5a8","in_reply_to":"4c143c4f_363f7eb3","updated":"2023-08-01 18:50:25.000000000","message":"Whilst I don\u0027t have too much of an issue with the functionality, I do not agree with adding something to the support matrix that is listed for only one vendor. \n\nThere have been many instances where users have looked at the support matrix and used a \u0027missing\u0027 feature as a rod with which to beat other vendors, without any real understanding of the feature and how it does not apply to, and cannot be implemented by, many other vendors.\n\nAdd full documentation to your specific driver documentation to explain this feature.\n\nPure has recently added a new type of replication that other vendors probably could support, but we are not going to add it to the support matrix.\n\nInherently the support matrix is flawed anyway due to the lack of clarity and granularity in the features. Adding more (vendor-ish specific) features will only make this worse.\n\nI think we should have Rajat and other Core members have a say on this.","commit_id":"eeb95e0adfda075e395a15c1825448a92824008d"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"487a36caef3cf3dbafb72a146f58328215e8ef01","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ca820b3d_f628ee81","in_reply_to":"7930e78f_dafe9084","updated":"2024-07-10 06:21:24.000000000","message":"As Peter mentioned earlier \"There were at least two Cinder meetings last year where this was discussed, and I think it was Rajat\u0027s idea that this be exposed as a driver capability.\", we are pursuing this for long-time.","commit_id":"eeb95e0adfda075e395a15c1825448a92824008d"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"e2592b634b9e3e1281f7a36a4a32c1bd91487d4f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"4c143c4f_363f7eb3","in_reply_to":"9152dfc8_3ccb1943","updated":"2023-08-01 18:24:53.000000000","message":"Thanks for the review. I have a suspicion that once this goes in, it may turn out that other storage systems can also support this. In StorPool\u0027s case, it is mainly an artifact of the way we decided to expose a specific StorPool concept (templates that define volume placement properties - which disk sets a volume\u0027s data should live in) as Cinder pools; in retrospect, this may not have been the wisest decision, and we did consider the possibility of making a breaking change to the StorPool driver that brings everything back in a single pool, but we decided it would be too disruptive.\n\nThere were at least two Cinder meetings last year where this was discussed, and I think it was Rajat\u0027s idea that this be exposed as a driver capability. Of course, other options may be available, but this seemed like the cleanest way to make it possible to keep Glance images in a separate Cinder pool and then clone them into the pool that the actual volumes should live in.","commit_id":"eeb95e0adfda075e395a15c1825448a92824008d"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"15c02d3156bc81dcf98d1321780ca0af3a328f65","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"4ae95595_925f8b60","in_reply_to":"ca820b3d_f628ee81","updated":"2024-07-18 05:31:27.000000000","message":"removed support matrix as discussed in cinder meeting 17.07.24","commit_id":"eeb95e0adfda075e395a15c1825448a92824008d"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"eddc780fe3497e8ecf1a10b2f1253777e8ee29aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"b795f670_622bb3b5","updated":"2023-12-06 14:32:01.000000000","message":"run-storpoolci","commit_id":"8ce9bb75fb32c921043b14b43884c8b1660cd9b8"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"dde21448fe2a419c35465f7fcd139dfe32d7d72e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"1272303b_d42e1656","updated":"2024-07-08 16:59:15.000000000","message":"Adding more core-team folks to review","commit_id":"7431c9b36400cd86810e6c211e87019375fbd923"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f9a35d5a564e3fc5ff77fab0aca34e2ba6fcdc97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"0307ec60_359a964c","updated":"2024-07-17 13:32:20.000000000","message":"I initially had the same reaction as Simon, but I looked at Peter\u0027s blueprint where he referenced this approach being discussed at the 2022-05-25 cinder meeting.  Here\u0027s the recording, to help reviewers refresh themselves on what we agreed to:\n\nhttps://www.youtube.com/watch?v\u003dyvRVS9aic5o\n\nPeter\u0027s discussion starts at 2:18 and ends at 27:49","commit_id":"3f25a59f4cc32c19132688692b4838ddf321f7bf"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"f1ae377c9f3fc7a252a3a9ed9b082aea8d30a9ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"b9e8b0c4_04eebcc0","updated":"2024-07-09 07:59:44.000000000","message":"run-storpoolci","commit_id":"3f25a59f4cc32c19132688692b4838ddf321f7bf"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d6288a937e95227504a3d15fea207d7ff09279e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"359d8e13_2856790a","in_reply_to":"0307ec60_359a964c","updated":"2024-07-17 13:35:34.000000000","message":"Actually, the above is separate from whether this change needs to be in the support matrix.  Gorka\u0027s concern at the meeting was that this needs to be documented so that drivers that have this capability can also report it and take advantage of the optimization, but it\u0027s not obvious that we need a support matrix entry just for this capability.","commit_id":"3f25a59f4cc32c19132688692b4838ddf321f7bf"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"b36c5eac054fa52820264400be5a06f386fa4f0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"2431440c_ed7df316","updated":"2024-07-18 16:27:01.000000000","message":"Looking back at the reviewer comments it looks like there were two concerns.  The first was the updating of the Matrix.  The second was adding documentation that explains how drivers can use this if it is a feature that their storage supports.  Can we get that added to this patch please?  Otherwise, it looks ok to me.  Thanks!","commit_id":"1adf6ff1085f6246697159f4a38aca395a043d6d"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"00d9b0c15377eb75951723500274382785cff794","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"4ba7bba0_fb2c48d8","in_reply_to":"2431440c_ed7df316","updated":"2024-07-20 16:17:22.000000000","message":"ok, i have added releasenotes documentation.","commit_id":"1adf6ff1085f6246697159f4a38aca395a043d6d"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"c14e90a4bdf79b1491d7433ab734b6ae4aefbf76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"d1c77a28_8282024b","updated":"2024-07-24 06:29:46.000000000","message":"As discussed in cinder weekly meet of 17th july, the support matrix file is removed. +1.\nJust couple of minor comments.","commit_id":"9b400d01660be47e73a2de7e002fdfcd4d2984b9"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"b91765207ac830914f80652a71e4dcb9f760bc74","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"7d586995_3e87d3d1","updated":"2024-07-23 19:00:03.000000000","message":"run-storpoolci","commit_id":"9b400d01660be47e73a2de7e002fdfcd4d2984b9"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7f12ab3a1cda764321a440e986a8343ea956dd0f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"897d9e97_2403580e","updated":"2024-07-25 01:09:47.000000000","message":"Code \u0026 tests LGTM.  Meets the design we agreed to back in 2022.","commit_id":"f2427b461867e6c32a3e5573666ead748cd5e1b4"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"513d8c3819b2e1b8e499f6040224e1290c02ecae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"3128aaf9_7cd2b87b","updated":"2024-07-24 14:15:21.000000000","message":"Thank you for addressing my comments.  I think this is ok now.","commit_id":"f2427b461867e6c32a3e5573666ead748cd5e1b4"}],"1":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"c14e90a4bdf79b1491d7433ab734b6ae4aefbf76","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add the clone_across_pools driver capability"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"    Drivers can now declare that they can clone a volume into a"}],"source_content_type":"text/troff","patch_set":19,"id":"69fd3880_0347cc10","line":2,"updated":"2024-07-24 06:29:46.000000000","message":"Contents of this file are same as release notes yaml.\nIs this file required ?","commit_id":"9b400d01660be47e73a2de7e002fdfcd4d2984b9"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"01fc3d4c397d232c556c2b3bc93f69eb9ee4f1ae","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add the clone_across_pools driver capability"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"    Drivers can now declare that they can clone a volume into a"}],"source_content_type":"text/troff","patch_set":19,"id":"509cdb58_31fb2688","line":2,"in_reply_to":"69fd3880_0347cc10","updated":"2024-07-24 06:44:45.000000000","message":"added by mistake. removed..","commit_id":"9b400d01660be47e73a2de7e002fdfcd4d2984b9"}],"cinder/image/cache.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7f12ab3a1cda764321a440e986a8343ea956dd0f","unresolved":true,"context_lines":[{"line_number":40,"context_line":"        self.volume_api \u003d volume_api"},{"line_number":41,"context_line":"        self.max_cache_size_gb \u003d int(max_cache_size_gb)"},{"line_number":42,"context_line":"        self.max_cache_size_count \u003d int(max_cache_size_count)"},{"line_number":43,"context_line":"        self.clone_across_pools \u003d bool(clone_across_pools)"},{"line_number":44,"context_line":"        self.notifier \u003d rpc.get_notifier(\u0027volume\u0027, CONF.host)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def get_by_image_volume(self,"}],"source_content_type":"text/x-python","patch_set":21,"id":"d0e91deb_13b344f7","line":43,"range":{"start_line":43,"start_character":34,"end_line":43,"end_character":39},"updated":"2024-07-25 01:09:47.000000000","message":"I was going to say, you don\u0027t need this because of the type annotations, but the same would be true of lines 41-42.  So I think it\u0027s better to leave this the way you have it for consistency, and if someone finds this redundancy to be an issue, they can fix it in a different patch.","commit_id":"f2427b461867e6c32a3e5573666ead748cd5e1b4"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"4ab0500a1f1c9f8374260671253e9f2d1cad75eb","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        self.volume_api \u003d volume_api"},{"line_number":41,"context_line":"        self.max_cache_size_gb \u003d int(max_cache_size_gb)"},{"line_number":42,"context_line":"        self.max_cache_size_count \u003d int(max_cache_size_count)"},{"line_number":43,"context_line":"        self.clone_across_pools \u003d bool(clone_across_pools)"},{"line_number":44,"context_line":"        self.notifier \u003d rpc.get_notifier(\u0027volume\u0027, CONF.host)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def get_by_image_volume(self,"}],"source_content_type":"text/x-python","patch_set":21,"id":"9cd71b71_d1f8cdcc","line":43,"range":{"start_line":43,"start_character":34,"end_line":43,"end_character":39},"in_reply_to":"d0e91deb_13b344f7","updated":"2024-10-31 09:04:25.000000000","message":"Hi Brian, I think we can remove all three: https://review.opendev.org/c/openstack/cinder/+/933838","commit_id":"f2427b461867e6c32a3e5573666ead748cd5e1b4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5d5f07721afb7267336d84474e0f1061b0512554","unresolved":true,"context_lines":[{"line_number":62,"context_line":"            return {\u0027cluster_name\u0027: volume_ref.cluster_name}"},{"line_number":63,"context_line":"        if not self.clone_across_pools:"},{"line_number":64,"context_line":"            return {\u0027host\u0027: volume_ref.host}"},{"line_number":65,"context_line":"        return {}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def get_entry(self,"},{"line_number":68,"context_line":"                  context: context.RequestContext,"}],"source_content_type":"text/x-python","patch_set":21,"id":"8e807a49_4762ba8e","line":65,"range":{"start_line":65,"start_character":15,"end_line":65,"end_character":17},"updated":"2024-07-31 18:48:20.000000000","message":"have we tested this with multiple storpool clusters?\nsuppose we have 2 storpool backends configured with cinder pointing to 2 different storage arrays. The cache is created in backend1 and we want to create a volume from cache in backend2. Since we are not applying any filter here, it will try to clone from storage array 1 to storage array 2 which will fail (as we only support cross pool cloning and not across different storage arrays -- which i think is not even possible).","commit_id":"f2427b461867e6c32a3e5573666ead748cd5e1b4"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"b37bb6b92e5c6d46f056575de2ed89ee069fb6d5","unresolved":true,"context_lines":[{"line_number":62,"context_line":"            return {\u0027cluster_name\u0027: volume_ref.cluster_name}"},{"line_number":63,"context_line":"        if not self.clone_across_pools:"},{"line_number":64,"context_line":"            return {\u0027host\u0027: volume_ref.host}"},{"line_number":65,"context_line":"        return {}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def get_entry(self,"},{"line_number":68,"context_line":"                  context: context.RequestContext,"}],"source_content_type":"text/x-python","patch_set":21,"id":"934b2e86_067af700","line":65,"range":{"start_line":65,"start_character":15,"end_line":65,"end_character":17},"in_reply_to":"8e807a49_4762ba8e","updated":"2024-08-14 11:19:11.000000000","message":"Only one StorPool cluster is supported (and required) for an OpenStack\nsetup. There are cases that need connecting two clusters, but they are\nfew, highly unlikely, temporary, and require assistance from StorPool to\nproperly handle.","commit_id":"f2427b461867e6c32a3e5573666ead748cd5e1b4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4f31e2f2737b6777bd576f72216bf11b5a73096f","unresolved":true,"context_lines":[{"line_number":62,"context_line":"            return {\u0027cluster_name\u0027: volume_ref.cluster_name}"},{"line_number":63,"context_line":"        if not self.clone_across_pools:"},{"line_number":64,"context_line":"            return {\u0027host\u0027: volume_ref.host}"},{"line_number":65,"context_line":"        return {}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def get_entry(self,"},{"line_number":68,"context_line":"                  context: context.RequestContext,"}],"source_content_type":"text/x-python","patch_set":21,"id":"b3ef67f5_a4f1a9f8","line":65,"range":{"start_line":65,"start_character":15,"end_line":65,"end_character":17},"in_reply_to":"934b2e86_067af700","updated":"2024-09-25 14:28:46.000000000","message":"The problem here is that this code is not specific to the storpool driver. If some other backend that supports multiple clusters starting reporting clone across pools functionality and configure 2 storage arrays as different cinder backends, this code will not work as expected.","commit_id":"f2427b461867e6c32a3e5573666ead748cd5e1b4"}]}