)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"6b4b9bdd1fc353a0334c1c11d2a5a3f4d4da9074","unresolved":true,"context_lines":[{"line_number":12,"context_line":"  e.g. for copying an image to a volume or vice versa"},{"line_number":13,"context_line":"- iscsi_export_to:"},{"line_number":14,"context_line":"  - an empty string to use the StorPool native protocol for exporting volumes"},{"line_number":15,"context_line":"    protocol for exporting volumes)"},{"line_number":16,"context_line":"  - the string \"*\" to always use iSCSI for exporting volumes"},{"line_number":17,"context_line":"  - an experimental, not fully supported list of IQN patterns to export"},{"line_number":18,"context_line":"    volumes to using iSCSI; this results in a Cinder driver that exports"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"3a2ab6bc_6638e73d","line":15,"range":{"start_line":15,"start_character":4,"end_line":15,"end_character":34},"updated":"2024-08-05 06:34:35.000000000","message":"nit: duplicate text","commit_id":"39cb718ceb42b1c96ff5d66112a229cc50125501"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"481814b82195b1fe29d95f4ddfbe2d2e378068b1","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  e.g. for copying an image to a volume or vice versa"},{"line_number":13,"context_line":"- iscsi_export_to:"},{"line_number":14,"context_line":"  - an empty string to use the StorPool native protocol for exporting volumes"},{"line_number":15,"context_line":"    protocol for exporting volumes)"},{"line_number":16,"context_line":"  - the string \"*\" to always use iSCSI for exporting volumes"},{"line_number":17,"context_line":"  - an experimental, not fully supported list of IQN patterns to export"},{"line_number":18,"context_line":"    volumes to using iSCSI; this results in a Cinder driver that exports"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"b6500cbd_c3beccc7","line":15,"range":{"start_line":15,"start_character":4,"end_line":15,"end_character":34},"in_reply_to":"3a2ab6bc_6638e73d","updated":"2024-08-28 11:16:12.000000000","message":"Done","commit_id":"39cb718ceb42b1c96ff5d66112a229cc50125501"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"3d2210fa2462fc58db8a8ca17fae4b3f783bb176","unresolved":true,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"When exporting volumes via iSCSI, report the storage protocol as"},{"line_number":27,"context_line":"\"iSCSI\"."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Change-Id: I9de64306e0e6976268df782053b0651dd1cca96f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":26,"id":"3ae3bc17_99118d1f","line":28,"updated":"2025-01-11 03:45:42.000000000","message":"Does this feature already have a \"blueprint\" created? A link to the \"blueprint\" should be added to the commit message as follows:\n\nImplements: blueprint \u003cname-of-the-bluprint\u003e\n\nYou can take a look at this patch as a reference:\nhttps://review.opendev.org/c/openstack/cinder/+/933675","commit_id":"2acfdddf0794754aa0e32a56800e77387f75ce38"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"0857f769d6a70ad864ad25ea2297c7532f12cb16","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"When exporting volumes via iSCSI, report the storage protocol as"},{"line_number":27,"context_line":"\"iSCSI\"."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Change-Id: I9de64306e0e6976268df782053b0651dd1cca96f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":26,"id":"8910ea97_292038f0","line":28,"in_reply_to":"3ae3bc17_99118d1f","updated":"2025-01-13 14:30:52.000000000","message":"See my comment Re: https://review.opendev.org/c/openstack/cinder/+/847536/comment/1c62fbca_0ac678e2/","commit_id":"2acfdddf0794754aa0e32a56800e77387f75ce38"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"882f3fe5a3cf33e8948a023ae395cb400b81cdfe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"edaecfca_4884c997","updated":"2023-01-26 01:06:11.000000000","message":"recheck","commit_id":"51e163e721378ad280e588a2eb1195d220f6304c"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"c049659c520cd2809d5719ce5b72ae4afe309128","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c4f445a7_9308ad1e","updated":"2023-02-17 15:06:43.000000000","message":"Just adding reference for release note: https://docs.openstack.org/cinder/latest/contributor/releasenotes.html#release-notes","commit_id":"5201ea3ca3ff148c6308df16a4e5241077365d66"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"e17392675c06a81755e6e49276cefd04699bb5a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c4e72df7_2beedda1","updated":"2023-02-14 17:25:41.000000000","message":"Thank you Peter, please take a look at my suggestions","commit_id":"5201ea3ca3ff148c6308df16a4e5241077365d66"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"0c999e9c62abb4142160181a2b6a32e13d05455c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"376ac60b_f605e9c9","updated":"2023-02-14 17:00:16.000000000","message":"Thank you Peter. Please add the releasenotes.","commit_id":"5201ea3ca3ff148c6308df16a4e5241077365d66"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"d426d9382cbc4877165627c5fcbbdb5a7a741573","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a759646b_169638e3","in_reply_to":"c4f445a7_9308ad1e","updated":"2023-03-20 22:51:43.000000000","message":"There is a release note now in patchset 11, thanks a lot for the reminder!","commit_id":"5201ea3ca3ff148c6308df16a4e5241077365d66"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"91633ac10a2199cdb366371ec44cb6f00a4d2f85","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"de4b0f5a_26689960","updated":"2023-04-25 11:03:30.000000000","message":"Few minor comments inline","commit_id":"18923cb66802c71fc61873258776cba2ba1eb450"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"028cf304d2370b21a02b30c84f230093c19a07ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"039e80fc_75dfb280","updated":"2023-12-06 14:36:44.000000000","message":"run-storpoolci","commit_id":"15fe701cfc698a2d8d3ce12ba33983a42e50411e"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"93568c300bcd1680fdfd21f096389a5954e00f31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"4c5800d5_cfc27861","updated":"2024-01-22 13:00:12.000000000","message":"recheck cinder.tests.unit.backup.drivers.test_backup_ceph.BackupCephTestCase.test_restore failure","commit_id":"3ad9e10779f4bacdd47bf373ce33161c0c5cbf2f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"c63d29961fb06528f3a349deb3aa4f117240fca5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"d50fb4e4_b05fc3cf","updated":"2024-08-01 07:31:18.000000000","message":"recheck","commit_id":"08bd45cc82b1dff00795d8739ad4c058ef55e775"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"6b4b9bdd1fc353a0334c1c11d2a5a3f4d4da9074","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"985f2065_4a369454","updated":"2024-08-05 06:34:35.000000000","message":"Couple of queries/comments inline","commit_id":"39cb718ceb42b1c96ff5d66112a229cc50125501"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"965b5c94b1e348e64b999adcf172f89c7eb7f9bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"2c72b8de_7ec373d6","updated":"2024-08-28 10:55:46.000000000","message":"run-storpoolci","commit_id":"39cb718ceb42b1c96ff5d66112a229cc50125501"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"19192f90da726d88db894fa54b506585813e13b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"f5cef14d_fac938f8","updated":"2024-08-02 11:29:35.000000000","message":"run-storpoolci","commit_id":"39cb718ceb42b1c96ff5d66112a229cc50125501"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4a3ec50ba02e635c809055b8fc0005b8970f8d6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"75b4c907_ace94ca0","updated":"2024-09-11 13:19:57.000000000","message":"Code and tests mostly look good.  Only a +1 because I have some issues with some of the documentation that I\u0027d like you to address (not using a -1 because I don\u0027t want to discourage other reviewers).","commit_id":"38e93b5aa940ea4dcabd72db600771a8eaad7b1b"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"cdfbd38dd1c8ca7f85a6dcaf824b1acb33ddb355","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"55b88606_da4ded8c","updated":"2024-08-29 13:00:00.000000000","message":"Just FYI. Feature freeze date is 30aug (tomorrow).\n\nYou may add this patch in list of features (to be reviewed):\nhttps://etherpad.opendev.org/p/cinder-dalmatian-reviews","commit_id":"38e93b5aa940ea4dcabd72db600771a8eaad7b1b"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"ef5bd15b87f86f49f8d9a176883c41d1a09bcf09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"b620fc59_53ca03df","updated":"2024-08-29 12:39:57.000000000","message":"My comments have been addressed. Zuul and StorPool OpenStack CI have passed. So +1","commit_id":"38e93b5aa940ea4dcabd72db600771a8eaad7b1b"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"1f921385b08f6906ff9838d627f26f92babb0f7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"89bafe3c_d6685c76","updated":"2024-08-28 13:39:05.000000000","message":"run-storpoolci","commit_id":"38e93b5aa940ea4dcabd72db600771a8eaad7b1b"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"9a14b45ce5b8118a00a440754ecdc2209593bc22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"3c1e391f_824988d5","updated":"2024-09-17 09:15:18.000000000","message":"Hi Brian, thanks for the review! The new patchsets should take care of your comments.","commit_id":"312803fe7bf6244549fcdf987d2d8fc29d3c622c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5a24d308a9945dea90b1f44c5374965f5d2a105e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"f673f9f7_df784700","updated":"2024-09-25 14:24:10.000000000","message":"Looks like we are adding a new storpool iSCSI driver here and mixing driver code doesn\u0027t look like a good way to do it.","commit_id":"cb7afe3bdcfff27d10486d0c34360b34c6e8baa4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"552b035330ff4aa3974f38a94796e34ce966a769","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"3c1db601_fef398d0","updated":"2024-09-25 15:52:33.000000000","message":"Rajat and Eric made good points about this patch at today\u0027s cinder meeting [0], so backing off for now.\n\n[0] https://meetings.opendev.org/meetings/cinder/2024/cinder.2024-09-25-14.00.log.html#l-53","commit_id":"cb7afe3bdcfff27d10486d0c34360b34c6e8baa4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d1f85e7b0e30d39a4dcea439dd7b5a861d64e116","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"c6bc9eb2_6060dbed","updated":"2024-09-23 16:13:05.000000000","message":"Revisions LGTM.","commit_id":"cb7afe3bdcfff27d10486d0c34360b34c6e8baa4"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"8296fc80ea654058f7fce200db6c6d4814a3eed3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"b1a040ec_b7f91451","updated":"2024-09-17 14:56:37.000000000","message":"recheck","commit_id":"cb7afe3bdcfff27d10486d0c34360b34c6e8baa4"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"3aa20530da733308a9bfb1d925698ca574c01f24","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"0bb0cfda_95967e11","updated":"2024-09-19 12:55:33.000000000","message":"run-storpoolci","commit_id":"cb7afe3bdcfff27d10486d0c34360b34c6e8baa4"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"c9a981c6e55b694fcdf79a885ce9693ba27bcce4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"67165ad6_0655c62a","updated":"2024-09-17 18:34:58.000000000","message":"run-storpoolci","commit_id":"cb7afe3bdcfff27d10486d0c34360b34c6e8baa4"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"dfbc76793c7d6d4950098c52d7fc65b1d4b94d36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"6ba11417_32fd76e4","updated":"2024-09-18 12:40:40.000000000","message":"run-storpoolci","commit_id":"cb7afe3bdcfff27d10486d0c34360b34c6e8baa4"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"126f38c2a793674b8a860b5a8b416912b0f655e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"7838ac92_94891b2c","updated":"2024-09-18 10:08:14.000000000","message":"run-storpoolci","commit_id":"cb7afe3bdcfff27d10486d0c34360b34c6e8baa4"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a3bd81da4e2d257168efb7a2bdc64f5723d28281","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"f14ff479_fefd9e16","updated":"2024-09-18 15:58:07.000000000","message":"run-storpoolci","commit_id":"cb7afe3bdcfff27d10486d0c34360b34c6e8baa4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1f3a96d25be84c8487df14eedc5566a2405d7133","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"6f232cdb_37d632ab","updated":"2024-11-20 15:04:12.000000000","message":"updated my comment based on the recent discussions.","commit_id":"cb7afe3bdcfff27d10486d0c34360b34c6e8baa4"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"743a2e3c536f7e81e22dd5c86766ea36fde7c5b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"389cfead_3bacb53b","updated":"2024-11-22 09:38:09.000000000","message":"recheck\n\nNot sure that the `openstacksdk-functional-devstack` failure is related to this change.","commit_id":"bfc35f997b9ad20ac9a7ad0c363594230ab820c8"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"3d2210fa2462fc58db8a8ca17fae4b3f783bb176","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"09f5bed2_6baf0b3b","updated":"2025-01-11 03:45:42.000000000","message":"Hi Biser Milanov! I\u0027ve just started reviewing this patch, but I already have some questions I would like to discuss. I addded some comments but we can also discuss in openstack-cinder channel on irc (my user is sfernand).","commit_id":"2acfdddf0794754aa0e32a56800e77387f75ce38"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"0857f769d6a70ad864ad25ea2297c7532f12cb16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"6a889c1a_20344926","updated":"2025-01-13 14:30:52.000000000","message":"Hi Fernando, thanks for the review! I left some replies inline.","commit_id":"2acfdddf0794754aa0e32a56800e77387f75ce38"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"530d88c9eed8e79a34d0b9cfb9cb41fbcda41eda","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"01d5d0fd_6bd57d6c","updated":"2025-01-16 08:44:54.000000000","message":"Looks like all the review comments have been addressed.","commit_id":"c38275290731b71ac87065eab55e9a02e135bd8f"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"8013fd7b2768e56bd73fa4a09e31069891f94866","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"a4a88c26_96567ee7","updated":"2025-01-14 13:02:34.000000000","message":"recheck\n\ndevstack-plugin-nfs-tempest-full had a `POST_FAILURE`","commit_id":"c38275290731b71ac87065eab55e9a02e135bd8f"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"8df6a4e0cd8122cc845c71ad772406323b619d92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"8bbd655a_9a591624","updated":"2025-01-16 07:11:18.000000000","message":"recheck cinder-tempest-plugin-lvm-lio-barbican","commit_id":"c38275290731b71ac87065eab55e9a02e135bd8f"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"1848468ca947643153cbf7d9887cee18d24b757e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":38,"id":"9e71cc19_27888fc2","updated":"2025-01-30 12:59:49.000000000","message":"recheck","commit_id":"8b6c5042b388e1eb7423f808483c236de353357a"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"c93699c7aa5765341a4c8254fbdb9ec23af67958","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":39,"id":"4ae43725_6791cc17","updated":"2025-02-26 13:26:20.000000000","message":"recheck","commit_id":"96ed27b4d750c119cde797877a4118f1a8648c71"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"d68e0da580b106adf2675f8aad5daf50ae7f32d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":40,"id":"a8e774a0_a941dd08","updated":"2025-05-28 06:02:20.000000000","message":"After rebase, the StorPool OpenStack CI and Zuul have passed.\nThe comments from reviewers have been addressed.","commit_id":"a1f7f530210310bcc169f165ac07da2be9dfd80e"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"c2829cfb60aafbf9398738468024d11de4781cd5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":40,"id":"71e2be67_2e0d82b9","updated":"2025-08-27 13:59:21.000000000","message":"Looks good to me","commit_id":"a1f7f530210310bcc169f165ac07da2be9dfd80e"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"aa2faf076e5bcc72f1ea5ba591148e7f2b1f68a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":40,"id":"f04ba64e_c9386155","updated":"2025-04-15 05:54:37.000000000","message":"rebased on master, expected to merge for flamingo.","commit_id":"a1f7f530210310bcc169f165ac07da2be9dfd80e"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"930240982936465702582e02884f97661fabee4c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"538acb98_4c720db3","updated":"2025-10-17 09:22:38.000000000","message":"run-storpoolci","commit_id":"8d570b7e4203e9bb7321996a9043b76fb8b0c780"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"fe1699257eae33bee481ee56f9a79d6dcc446c48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"7c1f5631_6f2e48f4","updated":"2025-10-24 16:17:25.000000000","message":"run-storpoolci","commit_id":"8d570b7e4203e9bb7321996a9043b76fb8b0c780"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"15f303ced71e8c85364f22e54d3f6cf98f4268a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"ffc218b4_dc82a02e","updated":"2025-10-22 09:40:36.000000000","message":"run-storpoolci","commit_id":"8d570b7e4203e9bb7321996a9043b76fb8b0c780"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"8457d607de40a242ca8febd3a9507bbaf810f4e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"2ac854bc_c722e5b5","updated":"2025-11-13 14:26:09.000000000","message":"run-storpoolci\n\nThere was an issue with StorPool\u0027s third-party CI that is now fixed.","commit_id":"8d570b7e4203e9bb7321996a9043b76fb8b0c780"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"eae08aabf06bfc6c93cfe65dd7af1e22da506b57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"39bacaad_61b00325","updated":"2026-02-06 16:09:23.000000000","message":"recheck\n\nfailures seem unrelated","commit_id":"c72ab7f5e1e2892f5c128fc0bb3bb803d9e88df2"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"a9dc53e2cb341a28d11faf1dbf26af9655d8bfdd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":43,"id":"adb0a031_51471cca","updated":"2026-05-11 09:29:56.000000000","message":"run-storpoolci","commit_id":"765d41de10e597dfb71c61f47b85f62f499c536b"}],"cinder/tests/unit/volume/drivers/test_storpool.py":[{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"3d2210fa2462fc58db8a8ca17fae4b3f783bb176","unresolved":true,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from __future__ import annotations"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import dataclasses"},{"line_number":20,"context_line":"import itertools"}],"source_content_type":"text/x-python","patch_set":26,"id":"3b97b5d9_b508a4ec","line":17,"updated":"2025-01-11 03:45:42.000000000","message":"Is this really required?","commit_id":"2acfdddf0794754aa0e32a56800e77387f75ce38"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"0857f769d6a70ad864ad25ea2297c7532f12cb16","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from __future__ import annotations"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import dataclasses"},{"line_number":20,"context_line":"import itertools"}],"source_content_type":"text/x-python","patch_set":26,"id":"b729ccc9_ee192fa3","line":17,"in_reply_to":"3b97b5d9_b508a4ec","updated":"2025-01-13 14:30:52.000000000","message":"Yes, so we can use `Self`, which has been released with Python 3.11 [1].\nPython 3.9 is one of the recommended minimum versions we should be\ntesting with [2].\n\n[1]: https://peps.python.org/pep-0673/\n[2]: https://governance.openstack.org/tc/reference/runtimes/2025.1.html","commit_id":"2acfdddf0794754aa0e32a56800e77387f75ce38"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"3d2210fa2462fc58db8a8ca17fae4b3f783bb176","unresolved":true,"context_lines":[{"line_number":49,"context_line":"from cinder.volume.drivers import storpool as driver"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"_ISCSI_IQN_OURS \u003d \u0027beleriand\u0027"},{"line_number":53,"context_line":"_ISCSI_IQN_OTHER \u003d \u0027rohan\u0027"},{"line_number":54,"context_line":"_ISCSI_IQN_THIRD \u003d \u0027gondor\u0027"},{"line_number":55,"context_line":"_ISCSI_PAT_OTHER \u003d \u0027roh*\u0027"}],"source_content_type":"text/x-python","patch_set":26,"id":"fa7cd6b8_6120e316","line":52,"updated":"2025-01-11 03:45:42.000000000","message":"NIT: This is not a big issue, but we usually don\u0027t add underscore for constants. I may be wrong, but I don\u0027t recall seeing it anywhere in Cinder\u0027s code.","commit_id":"2acfdddf0794754aa0e32a56800e77387f75ce38"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"0857f769d6a70ad864ad25ea2297c7532f12cb16","unresolved":false,"context_lines":[{"line_number":49,"context_line":"from cinder.volume.drivers import storpool as driver"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"_ISCSI_IQN_OURS \u003d \u0027beleriand\u0027"},{"line_number":53,"context_line":"_ISCSI_IQN_OTHER \u003d \u0027rohan\u0027"},{"line_number":54,"context_line":"_ISCSI_IQN_THIRD \u003d \u0027gondor\u0027"},{"line_number":55,"context_line":"_ISCSI_PAT_OTHER \u003d \u0027roh*\u0027"}],"source_content_type":"text/x-python","patch_set":26,"id":"d3fd4cdb_2085ebaf","line":52,"in_reply_to":"fa7cd6b8_6120e316","updated":"2025-01-13 14:30:52.000000000","message":"Done","commit_id":"2acfdddf0794754aa0e32a56800e77387f75ce38"}],"cinder/volume/drivers/storpool.py":[{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"e17392675c06a81755e6e49276cefd04699bb5a6","unresolved":true,"context_lines":[{"line_number":248,"context_line":"        will be needed to create, ensure, or remove the iSCSI export of"},{"line_number":249,"context_line":"        the specified volume to the specified initiator."},{"line_number":250,"context_line":"        \"\"\""},{"line_number":251,"context_line":"        cfg \u003d self._attach.api().iSCSIConfig()"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        pg_name \u003d self.configuration.iscsi_portal_group"},{"line_number":254,"context_line":"        pg_found \u003d ["}],"source_content_type":"text/x-python","patch_set":8,"id":"4e6c5e30_2923cf7d","line":251,"updated":"2023-02-14 17:25:41.000000000","message":"Please improve the coverage of this block of code, some new functions added seems to not be in the cover of Unit Tests\nRef: https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_113/847536/8/check/cinder-code-coverage/113b560/cover/d_2751295e1ac4fa14_storpool_py.html#t254","commit_id":"5201ea3ca3ff148c6308df16a4e5241077365d66"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"d426d9382cbc4877165627c5fcbbdb5a7a741573","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        will be needed to create, ensure, or remove the iSCSI export of"},{"line_number":249,"context_line":"        the specified volume to the specified initiator."},{"line_number":250,"context_line":"        \"\"\""},{"line_number":251,"context_line":"        cfg \u003d self._attach.api().iSCSIConfig()"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        pg_name \u003d self.configuration.iscsi_portal_group"},{"line_number":254,"context_line":"        pg_found \u003d ["}],"source_content_type":"text/x-python","patch_set":8,"id":"f3675c84_cf79c542","line":251,"in_reply_to":"4e6c5e30_2923cf7d","updated":"2023-03-20 22:51:43.000000000","message":"Done in patchset 11. Thanks!","commit_id":"5201ea3ca3ff148c6308df16a4e5241077365d66"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"91633ac10a2199cdb366371ec44cb6f00a4d2f85","unresolved":true,"context_lines":[{"line_number":119,"context_line":"        1.2.2   - Reintroduce the driver into OpenStack Queens,"},{"line_number":120,"context_line":"                  add ignore_errors to the internal _detach_volume() method"},{"line_number":121,"context_line":"        1.2.3   - Advertise some more driver capabilities."},{"line_number":122,"context_line":"    \"\"\""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    VERSION \u003d \u00271.2.3\u0027"},{"line_number":125,"context_line":"    CI_WIKI_NAME \u003d \u0027StorPool_distributed_storage_CI\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"f215ba31_8a7d0b03","line":122,"updated":"2023-04-25 11:03:30.000000000","message":"can this version be incremented.\n1.2.4 - Add iSCSI export support","commit_id":"18923cb66802c71fc61873258776cba2ba1eb450"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f9598067962e2c62738eaa8e31ee7c017a4ea894","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        1.2.2   - Reintroduce the driver into OpenStack Queens,"},{"line_number":120,"context_line":"                  add ignore_errors to the internal _detach_volume() method"},{"line_number":121,"context_line":"        1.2.3   - Advertise some more driver capabilities."},{"line_number":122,"context_line":"    \"\"\""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    VERSION \u003d \u00271.2.3\u0027"},{"line_number":125,"context_line":"    CI_WIKI_NAME \u003d \u0027StorPool_distributed_storage_CI\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"2fcf518a_8f953555","line":122,"in_reply_to":"f215ba31_8a7d0b03","updated":"2024-08-01 05:28:41.000000000","message":"Done","commit_id":"18923cb66802c71fc61873258776cba2ba1eb450"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"6b4b9bdd1fc353a0334c1c11d2a5a3f4d4da9074","unresolved":true,"context_lines":[{"line_number":132,"context_line":"        self._ourId \u003d None"},{"line_number":133,"context_line":"        self._ourIdInt \u003d None"},{"line_number":134,"context_line":"        self._attach \u003d None"},{"line_number":135,"context_line":"        self._use_iscsi \u003d None"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    @staticmethod"},{"line_number":138,"context_line":"    def get_driver_options():"}],"source_content_type":"text/x-python","patch_set":16,"id":"2c4498e4_2da24653","line":135,"updated":"2024-08-05 06:34:35.000000000","message":"nit: just a suggestion: it may be better to set default value as:\nself._use_iscsi \u003d False","commit_id":"39cb718ceb42b1c96ff5d66112a229cc50125501"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"481814b82195b1fe29d95f4ddfbe2d2e378068b1","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        self._ourId \u003d None"},{"line_number":133,"context_line":"        self._ourIdInt \u003d None"},{"line_number":134,"context_line":"        self._attach \u003d None"},{"line_number":135,"context_line":"        self._use_iscsi \u003d None"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    @staticmethod"},{"line_number":138,"context_line":"    def get_driver_options():"}],"source_content_type":"text/x-python","patch_set":16,"id":"808054e8_1f47ca6e","line":135,"in_reply_to":"2c4498e4_2da24653","updated":"2024-08-28 11:16:12.000000000","message":"Done","commit_id":"39cb718ceb42b1c96ff5d66112a229cc50125501"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"6b4b9bdd1fc353a0334c1c11d2a5a3f4d4da9074","unresolved":true,"context_lines":[{"line_number":708,"context_line":"            \u0027total_capacity_gb\u0027: total / units.Gi,"},{"line_number":709,"context_line":"            \u0027free_capacity_gb\u0027: free / units.Gi,"},{"line_number":710,"context_line":"            \u0027reserved_percentage\u0027: 0,"},{"line_number":711,"context_line":"            \u0027multiattach\u0027: self._use_iscsi,"},{"line_number":712,"context_line":"            \u0027QoS_support\u0027: False,"},{"line_number":713,"context_line":"            \u0027thick_provisioning_support\u0027: False,"},{"line_number":714,"context_line":"            \u0027thin_provisioning_support\u0027: True,"}],"source_content_type":"text/x-python","patch_set":16,"id":"b135272a_fcebe00e","line":711,"updated":"2024-08-05 06:34:35.000000000","message":"query: In commit message, it is mentioned ...\nWhen exporting volumes via iSCSI, report the storage protocol as \"iSCSI\" and\ndisable multiattach\nThen, multiattach value should be false, if iSCSI is used ?","commit_id":"39cb718ceb42b1c96ff5d66112a229cc50125501"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"481814b82195b1fe29d95f4ddfbe2d2e378068b1","unresolved":false,"context_lines":[{"line_number":708,"context_line":"            \u0027total_capacity_gb\u0027: total / units.Gi,"},{"line_number":709,"context_line":"            \u0027free_capacity_gb\u0027: free / units.Gi,"},{"line_number":710,"context_line":"            \u0027reserved_percentage\u0027: 0,"},{"line_number":711,"context_line":"            \u0027multiattach\u0027: self._use_iscsi,"},{"line_number":712,"context_line":"            \u0027QoS_support\u0027: False,"},{"line_number":713,"context_line":"            \u0027thick_provisioning_support\u0027: False,"},{"line_number":714,"context_line":"            \u0027thin_provisioning_support\u0027: True,"}],"source_content_type":"text/x-python","patch_set":16,"id":"431d9232_729fe3c9","line":711,"in_reply_to":"b135272a_fcebe00e","updated":"2024-08-28 11:16:12.000000000","message":"We found out the issue was a node misconfiguration in the CI. Tests should be passing now.","commit_id":"39cb718ceb42b1c96ff5d66112a229cc50125501"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4a3ec50ba02e635c809055b8fc0005b8970f8d6f","unresolved":true,"context_lines":[{"line_number":53,"context_line":"    cfg.StrOpt(\u0027iscsi_export_to\u0027,"},{"line_number":54,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":55,"context_line":"               help\u003d\u0027Whether to export volumes using iSCSI. \u0027"},{"line_number":56,"context_line":"                    \u0027An empty string (the default) makes the driver export \u0027"},{"line_number":57,"context_line":"                    \u0027all volumes using the StorPool native network protocol. \u0027"},{"line_number":58,"context_line":"                    \u0027The value \"*\" makes the driver export all volumes using \u0027"},{"line_number":59,"context_line":"                    \u0027iSCSI. \u0027"},{"line_number":60,"context_line":"                    \u0027Any other value leads to an experimental not fully \u0027"}],"source_content_type":"text/x-python","patch_set":20,"id":"eb098e6d_7a7160f2","line":57,"range":{"start_line":56,"start_character":21,"end_line":57,"end_character":76},"updated":"2024-09-11 13:19:57.000000000","message":"This isn\u0027t quite true according to what you say in the driver documentation.  I don\u0027t know whether it\u0027s better to add the Glance store complication here, or just add a sentence at the end of this help string saying \"See the Cinder StorPool driver documentation for details.\" or something like that.","commit_id":"38e93b5aa940ea4dcabd72db600771a8eaad7b1b"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"9a14b45ce5b8118a00a440754ecdc2209593bc22","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    cfg.StrOpt(\u0027iscsi_export_to\u0027,"},{"line_number":54,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":55,"context_line":"               help\u003d\u0027Whether to export volumes using iSCSI. \u0027"},{"line_number":56,"context_line":"                    \u0027An empty string (the default) makes the driver export \u0027"},{"line_number":57,"context_line":"                    \u0027all volumes using the StorPool native network protocol. \u0027"},{"line_number":58,"context_line":"                    \u0027The value \"*\" makes the driver export all volumes using \u0027"},{"line_number":59,"context_line":"                    \u0027iSCSI. \u0027"},{"line_number":60,"context_line":"                    \u0027Any other value leads to an experimental not fully \u0027"}],"source_content_type":"text/x-python","patch_set":20,"id":"5160b0c2_9795fc21","line":57,"range":{"start_line":56,"start_character":21,"end_line":57,"end_character":76},"in_reply_to":"eb098e6d_7a7160f2","updated":"2024-09-17 09:15:18.000000000","message":"That sounds good, I added an extra \"see the driver docs for details\".","commit_id":"38e93b5aa940ea4dcabd72db600771a8eaad7b1b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4a3ec50ba02e635c809055b8fc0005b8970f8d6f","unresolved":true,"context_lines":[{"line_number":119,"context_line":"                  add ignore_errors to the internal _detach_volume() method"},{"line_number":120,"context_line":"        1.2.3   - Advertise some more driver capabilities."},{"line_number":121,"context_line":"        2.0.0   - Implement revert_to_snapshot()."},{"line_number":122,"context_line":"        2.0.1   - Add iSCSI export support."},{"line_number":123,"context_line":"    \"\"\""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    VERSION \u003d \u00272.0.1\u0027"}],"source_content_type":"text/x-python","patch_set":20,"id":"56633e15_3373c1e6","line":122,"range":{"start_line":122,"start_character":8,"end_line":122,"end_character":13},"updated":"2024-09-11 13:19:57.000000000","message":"nit: this seems like a big feature to me, maybe make this 2.1.0 ?","commit_id":"38e93b5aa940ea4dcabd72db600771a8eaad7b1b"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"9a14b45ce5b8118a00a440754ecdc2209593bc22","unresolved":false,"context_lines":[{"line_number":119,"context_line":"                  add ignore_errors to the internal _detach_volume() method"},{"line_number":120,"context_line":"        1.2.3   - Advertise some more driver capabilities."},{"line_number":121,"context_line":"        2.0.0   - Implement revert_to_snapshot()."},{"line_number":122,"context_line":"        2.0.1   - Add iSCSI export support."},{"line_number":123,"context_line":"    \"\"\""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    VERSION \u003d \u00272.0.1\u0027"}],"source_content_type":"text/x-python","patch_set":20,"id":"7ff57f5d_2d61cd27","line":122,"range":{"start_line":122,"start_character":8,"end_line":122,"end_character":13},"in_reply_to":"56633e15_3373c1e6","updated":"2024-09-17 09:15:18.000000000","message":"Done","commit_id":"38e93b5aa940ea4dcabd72db600771a8eaad7b1b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4a3ec50ba02e635c809055b8fc0005b8970f8d6f","unresolved":true,"context_lines":[{"line_number":470,"context_line":"                if e.name not in (\u0027objectExists\u0027, \u0027objectDoesNotExist\u0027):"},{"line_number":471,"context_line":"                    raise"},{"line_number":472,"context_line":"                LOG.info(\u0027Looks like somebody beat us to it\u0027)"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"        if cfg[\u0027target\u0027] is not None:"},{"line_number":475,"context_line":"            last \u003d True"},{"line_number":476,"context_line":"            for initiator in cfg[\u0027cfg\u0027].iscsi.initiators.values():"},{"line_number":477,"context_line":"                if initiator.name \u003d\u003d cfg[\u0027initiator\u0027].name:"},{"line_number":478,"context_line":"                    continue"},{"line_number":479,"context_line":"                for exp in initiator.exports:"},{"line_number":480,"context_line":"                    if exp.target \u003d\u003d cfg[\u0027target\u0027].name:"},{"line_number":481,"context_line":"                        last \u003d False"},{"line_number":482,"context_line":"                        break"},{"line_number":483,"context_line":"                if not last:"},{"line_number":484,"context_line":"                    break"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"            if last:"},{"line_number":487,"context_line":"                LOG.info("}],"source_content_type":"text/x-python","patch_set":20,"id":"20bbabd1_9ae3d142","line":484,"range":{"start_line":473,"start_character":0,"end_line":484,"end_character":25},"updated":"2024-09-11 13:19:57.000000000","message":"Just want to note that according to the coverage report, this block isn\u0027t touched by any unit tests.  (Not saying that you must add one, just that you might want to take another look here to make sure the code is functioning as expected.)\n\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_398/847536/20/check/cinder-code-coverage/3987751/cover/z_2751295e1ac4fa14_storpool_py.html","commit_id":"38e93b5aa940ea4dcabd72db600771a8eaad7b1b"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"9a14b45ce5b8118a00a440754ecdc2209593bc22","unresolved":true,"context_lines":[{"line_number":470,"context_line":"                if e.name not in (\u0027objectExists\u0027, \u0027objectDoesNotExist\u0027):"},{"line_number":471,"context_line":"                    raise"},{"line_number":472,"context_line":"                LOG.info(\u0027Looks like somebody beat us to it\u0027)"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"        if cfg[\u0027target\u0027] is not None:"},{"line_number":475,"context_line":"            last \u003d True"},{"line_number":476,"context_line":"            for initiator in cfg[\u0027cfg\u0027].iscsi.initiators.values():"},{"line_number":477,"context_line":"                if initiator.name \u003d\u003d cfg[\u0027initiator\u0027].name:"},{"line_number":478,"context_line":"                    continue"},{"line_number":479,"context_line":"                for exp in initiator.exports:"},{"line_number":480,"context_line":"                    if exp.target \u003d\u003d cfg[\u0027target\u0027].name:"},{"line_number":481,"context_line":"                        last \u003d False"},{"line_number":482,"context_line":"                        break"},{"line_number":483,"context_line":"                if not last:"},{"line_number":484,"context_line":"                    break"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"            if last:"},{"line_number":487,"context_line":"                LOG.info("}],"source_content_type":"text/x-python","patch_set":20,"id":"451c5d00_f46120fd","line":484,"range":{"start_line":473,"start_character":0,"end_line":484,"end_character":25},"in_reply_to":"20bbabd1_9ae3d142","updated":"2024-09-17 09:15:18.000000000","message":"Added a test for that, waiting to see the coverage results.","commit_id":"38e93b5aa940ea4dcabd72db600771a8eaad7b1b"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"4ad7c872101bd41a16e461924ecf7ebfbf9bd310","unresolved":false,"context_lines":[{"line_number":470,"context_line":"                if e.name not in (\u0027objectExists\u0027, \u0027objectDoesNotExist\u0027):"},{"line_number":471,"context_line":"                    raise"},{"line_number":472,"context_line":"                LOG.info(\u0027Looks like somebody beat us to it\u0027)"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"        if cfg[\u0027target\u0027] is not None:"},{"line_number":475,"context_line":"            last \u003d True"},{"line_number":476,"context_line":"            for initiator in cfg[\u0027cfg\u0027].iscsi.initiators.values():"},{"line_number":477,"context_line":"                if initiator.name \u003d\u003d cfg[\u0027initiator\u0027].name:"},{"line_number":478,"context_line":"                    continue"},{"line_number":479,"context_line":"                for exp in initiator.exports:"},{"line_number":480,"context_line":"                    if exp.target \u003d\u003d cfg[\u0027target\u0027].name:"},{"line_number":481,"context_line":"                        last \u003d False"},{"line_number":482,"context_line":"                        break"},{"line_number":483,"context_line":"                if not last:"},{"line_number":484,"context_line":"                    break"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"            if last:"},{"line_number":487,"context_line":"                LOG.info("}],"source_content_type":"text/x-python","patch_set":20,"id":"ff74be32_aaa8e11a","line":484,"range":{"start_line":473,"start_character":0,"end_line":484,"end_character":25},"in_reply_to":"451c5d00_f46120fd","updated":"2024-11-21 11:54:37.000000000","message":"Done","commit_id":"38e93b5aa940ea4dcabd72db600771a8eaad7b1b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4a3ec50ba02e635c809055b8fc0005b8970f8d6f","unresolved":true,"context_lines":[{"line_number":708,"context_line":"            \u0027total_capacity_gb\u0027: total / units.Gi,"},{"line_number":709,"context_line":"            \u0027free_capacity_gb\u0027: free / units.Gi,"},{"line_number":710,"context_line":"            \u0027reserved_percentage\u0027: 0,"},{"line_number":711,"context_line":"            \u0027multiattach\u0027: self._use_iscsi,"},{"line_number":712,"context_line":"            \u0027QoS_support\u0027: False,"},{"line_number":713,"context_line":"            \u0027thick_provisioning_support\u0027: False,"},{"line_number":714,"context_line":"            \u0027thin_provisioning_support\u0027: True,"}],"source_content_type":"text/x-python","patch_set":20,"id":"4f2dda53_7a0c4148","line":711,"range":{"start_line":711,"start_character":12,"end_line":711,"end_character":43},"updated":"2024-09-11 13:19:57.000000000","message":"This is kind of a big change; I think you need to call it out more explicitly in the release note and the documentation.","commit_id":"38e93b5aa940ea4dcabd72db600771a8eaad7b1b"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"9a14b45ce5b8118a00a440754ecdc2209593bc22","unresolved":true,"context_lines":[{"line_number":708,"context_line":"            \u0027total_capacity_gb\u0027: total / units.Gi,"},{"line_number":709,"context_line":"            \u0027free_capacity_gb\u0027: free / units.Gi,"},{"line_number":710,"context_line":"            \u0027reserved_percentage\u0027: 0,"},{"line_number":711,"context_line":"            \u0027multiattach\u0027: self._use_iscsi,"},{"line_number":712,"context_line":"            \u0027QoS_support\u0027: False,"},{"line_number":713,"context_line":"            \u0027thick_provisioning_support\u0027: False,"},{"line_number":714,"context_line":"            \u0027thin_provisioning_support\u0027: True,"}],"source_content_type":"text/x-python","patch_set":20,"id":"e9c7cbaa_a7324b66","line":711,"range":{"start_line":711,"start_character":12,"end_line":711,"end_character":43},"in_reply_to":"4f2dda53_7a0c4148","updated":"2024-09-17 09:15:18.000000000","message":"As you suggested in the other comments, I added a note both in the release notes and in the driver documentation.","commit_id":"38e93b5aa940ea4dcabd72db600771a8eaad7b1b"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"4ad7c872101bd41a16e461924ecf7ebfbf9bd310","unresolved":false,"context_lines":[{"line_number":708,"context_line":"            \u0027total_capacity_gb\u0027: total / units.Gi,"},{"line_number":709,"context_line":"            \u0027free_capacity_gb\u0027: free / units.Gi,"},{"line_number":710,"context_line":"            \u0027reserved_percentage\u0027: 0,"},{"line_number":711,"context_line":"            \u0027multiattach\u0027: self._use_iscsi,"},{"line_number":712,"context_line":"            \u0027QoS_support\u0027: False,"},{"line_number":713,"context_line":"            \u0027thick_provisioning_support\u0027: False,"},{"line_number":714,"context_line":"            \u0027thin_provisioning_support\u0027: True,"}],"source_content_type":"text/x-python","patch_set":20,"id":"01a1875c_00426fc7","line":711,"range":{"start_line":711,"start_character":12,"end_line":711,"end_character":43},"in_reply_to":"e9c7cbaa_a7324b66","updated":"2024-11-21 11:54:37.000000000","message":"Done","commit_id":"38e93b5aa940ea4dcabd72db600771a8eaad7b1b"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a452f90a8f7059979efd26074247a274dcd88e78","unresolved":true,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"storpool_opts \u003d ["},{"line_number":47,"context_line":"    cfg.BoolOpt(\u0027iscsi_cinder_volume\u0027,"},{"line_number":48,"context_line":"                default\u003dFalse,"},{"line_number":49,"context_line":"                help\u003d\u0027Let the cinder-volume service use iSCSI instead of \u0027"},{"line_number":50,"context_line":"                     \u0027the StorPool block device driver for accessing \u0027"}],"source_content_type":"text/x-python","patch_set":23,"id":"34384600_f132faf3","line":47,"updated":"2024-09-25 14:20:58.000000000","message":"These new options should be prefixed as \"storpool_iscsi_cinder_volume\", \"storpool_iscsi_export_to\", etc.","commit_id":"cb7afe3bdcfff27d10486d0c34360b34c6e8baa4"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"4ad7c872101bd41a16e461924ecf7ebfbf9bd310","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"storpool_opts \u003d ["},{"line_number":47,"context_line":"    cfg.BoolOpt(\u0027iscsi_cinder_volume\u0027,"},{"line_number":48,"context_line":"                default\u003dFalse,"},{"line_number":49,"context_line":"                help\u003d\u0027Let the cinder-volume service use iSCSI instead of \u0027"},{"line_number":50,"context_line":"                     \u0027the StorPool block device driver for accessing \u0027"}],"source_content_type":"text/x-python","patch_set":23,"id":"cc2994ec_f1169819","line":47,"in_reply_to":"34384600_f132faf3","updated":"2024-11-21 11:54:37.000000000","message":"Done","commit_id":"cb7afe3bdcfff27d10486d0c34360b34c6e8baa4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5a24d308a9945dea90b1f44c5374965f5d2a105e","unresolved":true,"context_lines":[{"line_number":509,"context_line":"                    LOG.info(\u0027Looks like somebody beat us to it\u0027)"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"    def initialize_connection(self, volume, connector):"},{"line_number":512,"context_line":"        if self._connector_wants_iscsi(connector):"},{"line_number":513,"context_line":"            return self._create_iscsi_export(volume, connector)"},{"line_number":514,"context_line":"        return {\u0027driver_volume_type\u0027: \u0027storpool\u0027,"},{"line_number":515,"context_line":"                \u0027data\u0027: {"},{"line_number":516,"context_line":"                    \u0027client_id\u0027: self._storpool_client_id(connector),"}],"source_content_type":"text/x-python","patch_set":23,"id":"e2ef5922_2c57db21","line":513,"range":{"start_line":512,"start_character":0,"end_line":513,"end_character":63},"updated":"2024-09-25 14:24:10.000000000","message":"This doesn\u0027t look right, we should have a separate class for the iSCSI driver and not combine different protocols under the same method.\nyou can take reference from Pure driver[1] or netapp driver[2]. Netapp driver also has a common file for sharing code between different drivers.\nSo there should be 2 drivers that StorPool supports, StorPooliSCSI and StorPool\u003cthe original driver\u003e\n\n[1] https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/pure.py#L3069\n[2] https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/netapp/dataontap/iscsi_cmode.py#L26","commit_id":"cb7afe3bdcfff27d10486d0c34360b34c6e8baa4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1f3a96d25be84c8487df14eedc5566a2405d7133","unresolved":false,"context_lines":[{"line_number":509,"context_line":"                    LOG.info(\u0027Looks like somebody beat us to it\u0027)"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"    def initialize_connection(self, volume, connector):"},{"line_number":512,"context_line":"        if self._connector_wants_iscsi(connector):"},{"line_number":513,"context_line":"            return self._create_iscsi_export(volume, connector)"},{"line_number":514,"context_line":"        return {\u0027driver_volume_type\u0027: \u0027storpool\u0027,"},{"line_number":515,"context_line":"                \u0027data\u0027: {"},{"line_number":516,"context_line":"                    \u0027client_id\u0027: self._storpool_client_id(connector),"}],"source_content_type":"text/x-python","patch_set":23,"id":"a57a7aed_7581ece9","line":513,"range":{"start_line":512,"start_character":0,"end_line":513,"end_character":63},"in_reply_to":"e2ef5922_2c57db21","updated":"2024-11-20 15:04:12.000000000","message":"Based on the discussion we had in IRC, the use case here is that the consumer (nova) might not support either storpool or the iSCSI protocol. We cannot know that until a volume map request comes to Cinder.\nCurrently, cinder uses the host/cluster field to determine on which cinder-volume service we want to redirect the request to so if the volume was created by the cinder-volume service based on the iSCSI backend, it will redirect the volume MAP request to the same backend and not based on the protocol supported in the connector info.\nSo since the use case is unique to the storpool driver, we can make the exception here to support multiple protocols in the same driver.\nThough I would still encourage to try other strategies like segregating compute nodes based on the storage protocol they support and redirecting it to the right cinder-volume backend but i won\u0027t block the patch for this.","commit_id":"cb7afe3bdcfff27d10486d0c34360b34c6e8baa4"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"3d2210fa2462fc58db8a8ca17fae4b3f783bb176","unresolved":true,"context_lines":[{"line_number":120,"context_line":"                  add ignore_errors to the internal _detach_volume() method"},{"line_number":121,"context_line":"        1.2.3   - Advertise some more driver capabilities."},{"line_number":122,"context_line":"        2.0.0   - Implement revert_to_snapshot()."},{"line_number":123,"context_line":"        2.1.0   - Add iSCSI export support."},{"line_number":124,"context_line":"    \"\"\""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    VERSION \u003d \u00272.1.0\u0027"}],"source_content_type":"text/x-python","patch_set":26,"id":"07d50ded_036c7c54","line":123,"updated":"2025-01-11 03:45:42.000000000","message":"Opting for iscsi changes the data-plane completely. This is not a blocker, but I think this feature shouldn\u0027t be considered a minor update to this driver.","commit_id":"2acfdddf0794754aa0e32a56800e77387f75ce38"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"0857f769d6a70ad864ad25ea2297c7532f12cb16","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                  add ignore_errors to the internal _detach_volume() method"},{"line_number":121,"context_line":"        1.2.3   - Advertise some more driver capabilities."},{"line_number":122,"context_line":"        2.0.0   - Implement revert_to_snapshot()."},{"line_number":123,"context_line":"        2.1.0   - Add iSCSI export support."},{"line_number":124,"context_line":"    \"\"\""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    VERSION \u003d \u00272.1.0\u0027"}],"source_content_type":"text/x-python","patch_set":26,"id":"df9d5d1c_18a8bdd9","line":123,"in_reply_to":"07d50ded_036c7c54","updated":"2025-01-13 14:30:52.000000000","message":"Brian suggested bumping only the minor version previously [1], so I want\nto stick with that.\n\n[1]: https://review.opendev.org/c/openstack/cinder/+/847536/comment/56633e15_3373c1e6/","commit_id":"2acfdddf0794754aa0e32a56800e77387f75ce38"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"3d2210fa2462fc58db8a8ca17fae4b3f783bb176","unresolved":true,"context_lines":[{"line_number":200,"context_line":"        if connector is None:"},{"line_number":201,"context_line":"            return False"},{"line_number":202,"context_line":"        if self._use_iscsi:"},{"line_number":203,"context_line":"            LOG.debug(\u0027  - forcing iSCSI for all exported volumes\u0027)"},{"line_number":204,"context_line":"            return True"},{"line_number":205,"context_line":"        if connector.get(\u0027storpool_wants_iscsi\u0027):"},{"line_number":206,"context_line":"            LOG.debug(\u0027  - forcing iSCSI for the controller\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"d6ee81eb_3ad25ff0","line":203,"updated":"2025-01-11 03:45:42.000000000","message":"Question: Why add spaces to the beginning of the debug message? I don\u0027t see other messages using this pattern in the Storpool driver.","commit_id":"2acfdddf0794754aa0e32a56800e77387f75ce38"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"0857f769d6a70ad864ad25ea2297c7532f12cb16","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        if connector is None:"},{"line_number":201,"context_line":"            return False"},{"line_number":202,"context_line":"        if self._use_iscsi:"},{"line_number":203,"context_line":"            LOG.debug(\u0027  - forcing iSCSI for all exported volumes\u0027)"},{"line_number":204,"context_line":"            return True"},{"line_number":205,"context_line":"        if connector.get(\u0027storpool_wants_iscsi\u0027):"},{"line_number":206,"context_line":"            LOG.debug(\u0027  - forcing iSCSI for the controller\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"066bdfe8_c26c5d0d","line":203,"in_reply_to":"d6ee81eb_3ad25ff0","updated":"2025-01-13 14:30:52.000000000","message":"Even better, I removed all prefixes with `-` in them, thanks.","commit_id":"2acfdddf0794754aa0e32a56800e77387f75ce38"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"3d2210fa2462fc58db8a8ca17fae4b3f783bb176","unresolved":true,"context_lines":[{"line_number":202,"context_line":"        if self._use_iscsi:"},{"line_number":203,"context_line":"            LOG.debug(\u0027  - forcing iSCSI for all exported volumes\u0027)"},{"line_number":204,"context_line":"            return True"},{"line_number":205,"context_line":"        if connector.get(\u0027storpool_wants_iscsi\u0027):"},{"line_number":206,"context_line":"            LOG.debug(\u0027  - forcing iSCSI for the controller\u0027)"},{"line_number":207,"context_line":"            return True"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"3e8b3af1_5115f25f","line":205,"updated":"2025-01-11 03:45:42.000000000","message":"Question: Is this some kind of fallback to the generic iscsi connection in case native storpool isn\u0027t available? I\u0027m asking because storpool_wants_iscsi isn\u0027t something the iscsi connector from os-brick would output.","commit_id":"2acfdddf0794754aa0e32a56800e77387f75ce38"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"3d2210fa2462fc58db8a8ca17fae4b3f783bb176","unresolved":true,"context_lines":[{"line_number":202,"context_line":"        if self._use_iscsi:"},{"line_number":203,"context_line":"            LOG.debug(\u0027  - forcing iSCSI for all exported volumes\u0027)"},{"line_number":204,"context_line":"            return True"},{"line_number":205,"context_line":"        if connector.get(\u0027storpool_wants_iscsi\u0027):"},{"line_number":206,"context_line":"            LOG.debug(\u0027  - forcing iSCSI for the controller\u0027)"},{"line_number":207,"context_line":"            return True"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"b52e2ccc_3ccfdcb3","line":205,"updated":"2025-01-11 03:45:42.000000000","message":"This seems confusing to me. An operator might not configure iscsi for the backend, but still the driver would force using it. Is it possible to have both native Storpool and iscsi as options to connect to a volume at the same time? If so, I think it would be difficult for operators to predict what is the driver\u0027s behavior without proper documentation.","commit_id":"2acfdddf0794754aa0e32a56800e77387f75ce38"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"0857f769d6a70ad864ad25ea2297c7532f12cb16","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        if self._use_iscsi:"},{"line_number":203,"context_line":"            LOG.debug(\u0027  - forcing iSCSI for all exported volumes\u0027)"},{"line_number":204,"context_line":"            return True"},{"line_number":205,"context_line":"        if connector.get(\u0027storpool_wants_iscsi\u0027):"},{"line_number":206,"context_line":"            LOG.debug(\u0027  - forcing iSCSI for the controller\u0027)"},{"line_number":207,"context_line":"            return True"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"f9179090_d6743169","line":205,"in_reply_to":"3e8b3af1_5115f25f","updated":"2025-01-13 14:30:52.000000000","message":"`storpool_wants_iscsi` is used to check if Cinder is configured to use\niSCSI for the Cinder/Glance volume management. It does not come from the\nconnector, but computed from the `storpool_iscsi_cinder_volume` option\nin `_attach_volume()`.","commit_id":"2acfdddf0794754aa0e32a56800e77387f75ce38"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"0857f769d6a70ad864ad25ea2297c7532f12cb16","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        if self._use_iscsi:"},{"line_number":203,"context_line":"            LOG.debug(\u0027  - forcing iSCSI for all exported volumes\u0027)"},{"line_number":204,"context_line":"            return True"},{"line_number":205,"context_line":"        if connector.get(\u0027storpool_wants_iscsi\u0027):"},{"line_number":206,"context_line":"            LOG.debug(\u0027  - forcing iSCSI for the controller\u0027)"},{"line_number":207,"context_line":"            return True"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"90fdd81a_eb520ec5","line":205,"in_reply_to":"b52e2ccc_3ccfdcb3","updated":"2025-01-13 14:30:52.000000000","message":"\u003e An operator might not configure iscsi for the backend, but still the\n\u003e driver would force using it.\n\nThe driver will not use iSCSI on unless the operator has defined\n`storpool_iscsi_*` options.\n\n\u003e Is it possible to have both native Storpool and iscsi as options to\n\u003e connect to a volume at the same time?\n\nYes, each \"client\" can connect volumes either via the block protocol or\nvia iSCSI.\n\n\u003e If so, I think it would be difficult for operators to predict what is\n\u003e the driver\u0027s behavior without proper documentation.\n\nExamples of specific edits are welcome, even though from my point of\nview this has been explained in [1] and [2].\n\n[1]: https://review.opendev.org/c/openstack/cinder/+/847536/26/doc/source/configuration/block-storage/drivers/storpool-volume-driver.rst#104\n[2]: https://review.opendev.org/c/openstack/cinder/+/847536/26/doc/source/configuration/block-storage/drivers/storpool-volume-driver.rst#40\n[3]: https://review.opendev.org/c/openstack/cinder/+/847536/26/doc/source/configuration/block-storage/drivers/storpool-volume-driver.rst#89","commit_id":"2acfdddf0794754aa0e32a56800e77387f75ce38"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"3d2210fa2462fc58db8a8ca17fae4b3f783bb176","unresolved":true,"context_lines":[{"line_number":207,"context_line":"            return True"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        try:"},{"line_number":210,"context_line":"            iqn \u003d connector.get(\u0027initiator\u0027)"},{"line_number":211,"context_line":"        except Exception:"},{"line_number":212,"context_line":"            iqn \u003d None"},{"line_number":213,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":26,"id":"74a24f31_a2c75ddc","line":210,"updated":"2025-01-11 03:45:42.000000000","message":"You can use `connector.get(\u0027initiator\u0027, None)` then check for None instead of handling an exception.","commit_id":"2acfdddf0794754aa0e32a56800e77387f75ce38"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"0857f769d6a70ad864ad25ea2297c7532f12cb16","unresolved":false,"context_lines":[{"line_number":207,"context_line":"            return True"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        try:"},{"line_number":210,"context_line":"            iqn \u003d connector.get(\u0027initiator\u0027)"},{"line_number":211,"context_line":"        except Exception:"},{"line_number":212,"context_line":"            iqn \u003d None"},{"line_number":213,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":26,"id":"e44d797f_8baaa5e4","line":210,"in_reply_to":"74a24f31_a2c75ddc","updated":"2025-01-13 14:30:52.000000000","message":"Done","commit_id":"2acfdddf0794754aa0e32a56800e77387f75ce38"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"3d2210fa2462fc58db8a8ca17fae4b3f783bb176","unresolved":true,"context_lines":[{"line_number":211,"context_line":"        except Exception:"},{"line_number":212,"context_line":"            iqn \u003d None"},{"line_number":213,"context_line":"        try:"},{"line_number":214,"context_line":"            host \u003d connector.get(\u0027host\u0027)"},{"line_number":215,"context_line":"        except Exception:"},{"line_number":216,"context_line":"            host \u003d None"},{"line_number":217,"context_line":"        if iqn is None or host is None:"}],"source_content_type":"text/x-python","patch_set":26,"id":"1f8d03cc_97e5733a","line":214,"updated":"2025-01-11 03:45:42.000000000","message":"You can use `connector.get(\u0027host\u0027, None)` then check for None instead of handling an exception.","commit_id":"2acfdddf0794754aa0e32a56800e77387f75ce38"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"0857f769d6a70ad864ad25ea2297c7532f12cb16","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        except Exception:"},{"line_number":212,"context_line":"            iqn \u003d None"},{"line_number":213,"context_line":"        try:"},{"line_number":214,"context_line":"            host \u003d connector.get(\u0027host\u0027)"},{"line_number":215,"context_line":"        except Exception:"},{"line_number":216,"context_line":"            host \u003d None"},{"line_number":217,"context_line":"        if iqn is None or host is None:"}],"source_content_type":"text/x-python","patch_set":26,"id":"96577c3c_26af182e","line":214,"in_reply_to":"1f8d03cc_97e5733a","updated":"2025-01-13 14:30:52.000000000","message":"Done","commit_id":"2acfdddf0794754aa0e32a56800e77387f75ce38"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"3d2210fa2462fc58db8a8ca17fae4b3f783bb176","unresolved":true,"context_lines":[{"line_number":215,"context_line":"        except Exception:"},{"line_number":216,"context_line":"            host \u003d None"},{"line_number":217,"context_line":"        if iqn is None or host is None:"},{"line_number":218,"context_line":"            LOG.debug(\u0027  - this connector certainly does not want iSCSI\u0027)"},{"line_number":219,"context_line":"            return False"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        LOG.debug(\u0027  - check whether %(host)s (%(iqn)s) wants iSCSI\u0027,"}],"source_content_type":"text/x-python","patch_set":26,"id":"95a046f4_8223d09e","line":218,"updated":"2025-01-11 03:45:42.000000000","message":"Question: why so many ways to indicate to the driver that a iscsi connection needs to be made? In the case iscsi isn\u0027t configured for the volume, will the connection fail for nodes that don\u0027t have the native storpool software installed?","commit_id":"2acfdddf0794754aa0e32a56800e77387f75ce38"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"0857f769d6a70ad864ad25ea2297c7532f12cb16","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        except Exception:"},{"line_number":216,"context_line":"            host \u003d None"},{"line_number":217,"context_line":"        if iqn is None or host is None:"},{"line_number":218,"context_line":"            LOG.debug(\u0027  - this connector certainly does not want iSCSI\u0027)"},{"line_number":219,"context_line":"            return False"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        LOG.debug(\u0027  - check whether %(host)s (%(iqn)s) wants iSCSI\u0027,"}],"source_content_type":"text/x-python","patch_set":26,"id":"ec556e06_3336121f","line":218,"in_reply_to":"95a046f4_8223d09e","updated":"2025-01-13 14:30:52.000000000","message":"If I have understood your question correctly, `_connector_wants_iscsi()`\nis as complex as it is in order to handle the several combinations of\nconnector and configured driver options in a fall-through fashion:\n\n1. We don\u0027t want iSCSI if there is no connector\n2. We want iSCSI if `storpool_iscsi_export_to` is set\n3. We want iSCSI if this is a Cinder/Glance connection [1]\n4. We don\u0027t want iSCSI if the connector has no IQN and host information\n5. We don\u0027t want iSCSI if the initiator IQN is not in\n   `storpool_iscsi_export_to` or `storpool_iscsi_export_to` is not `*`\n\n[1]: https://review.opendev.org/c/openstack/cinder/+/847536/26/doc/source/configuration/block-storage/drivers/storpool-volume-driver.rst#56","commit_id":"2acfdddf0794754aa0e32a56800e77387f75ce38"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"3d2210fa2462fc58db8a8ca17fae4b3f783bb176","unresolved":true,"context_lines":[{"line_number":231,"context_line":"        for pat in export_to.split():"},{"line_number":232,"context_line":"            LOG.debug(\u0027    - matching against %(pat)s\u0027, {\u0027pat\u0027: pat})"},{"line_number":233,"context_line":"            if fnmatch.fnmatch(iqn, pat):"},{"line_number":234,"context_line":"                LOG.debug(\u0027      - got it!\u0027)"},{"line_number":235,"context_line":"                return True"},{"line_number":236,"context_line":"        LOG.debug(\u0027    - nope\u0027)"},{"line_number":237,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":26,"id":"9b51a390_2687b2ad","line":234,"updated":"2025-01-11 03:45:42.000000000","message":"This doesn\u0027t lead to useful information in cinder-volume logs when running multiple backends from different vendors.","commit_id":"2acfdddf0794754aa0e32a56800e77387f75ce38"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"0857f769d6a70ad864ad25ea2297c7532f12cb16","unresolved":true,"context_lines":[{"line_number":231,"context_line":"        for pat in export_to.split():"},{"line_number":232,"context_line":"            LOG.debug(\u0027    - matching against %(pat)s\u0027, {\u0027pat\u0027: pat})"},{"line_number":233,"context_line":"            if fnmatch.fnmatch(iqn, pat):"},{"line_number":234,"context_line":"                LOG.debug(\u0027      - got it!\u0027)"},{"line_number":235,"context_line":"                return True"},{"line_number":236,"context_line":"        LOG.debug(\u0027    - nope\u0027)"},{"line_number":237,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":26,"id":"714d4475_b7fc6e26","line":234,"in_reply_to":"9b51a390_2687b2ad","updated":"2025-01-13 14:30:52.000000000","message":"Why wouldn\u0027t it if debug logs add a `cinder.volume.drivers.storpool` prefix and\nfilename:line-number suffix to the output so the operator knows which\nbackend has generated the message? [1]\n\n[1]: https://spfactory.storpool.com/logs/63/916063/8/check/cinder-storpool-tempest-iscsi-multipath/fa5a178/controller/logs/screen-c-vol.txt","commit_id":"2acfdddf0794754aa0e32a56800e77387f75ce38"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"3d2210fa2462fc58db8a8ca17fae4b3f783bb176","unresolved":true,"context_lines":[{"line_number":707,"context_line":"            \u0027total_capacity_gb\u0027: total / units.Gi,"},{"line_number":708,"context_line":"            \u0027free_capacity_gb\u0027: free / units.Gi,"},{"line_number":709,"context_line":"            \u0027reserved_percentage\u0027: 0,"},{"line_number":710,"context_line":"            \u0027multiattach\u0027: self._use_iscsi,"},{"line_number":711,"context_line":"            \u0027QoS_support\u0027: False,"},{"line_number":712,"context_line":"            \u0027thick_provisioning_support\u0027: False,"},{"line_number":713,"context_line":"            \u0027thin_provisioning_support\u0027: True,"}],"source_content_type":"text/x-python","patch_set":26,"id":"91af5152_a033e440","line":710,"updated":"2025-01-11 03:45:42.000000000","message":"I believe this requires updating the support matrix as the iscsi version of this driver won\u0027t support as many features as the native storpool version. It would make sense to have a new column just for Storpool running iSCSI informing its limitations, as we have for other drivers.\n\nhttps://docs.openstack.org/cinder/latest/reference/support-matrix.html","commit_id":"2acfdddf0794754aa0e32a56800e77387f75ce38"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"0857f769d6a70ad864ad25ea2297c7532f12cb16","unresolved":true,"context_lines":[{"line_number":707,"context_line":"            \u0027total_capacity_gb\u0027: total / units.Gi,"},{"line_number":708,"context_line":"            \u0027free_capacity_gb\u0027: free / units.Gi,"},{"line_number":709,"context_line":"            \u0027reserved_percentage\u0027: 0,"},{"line_number":710,"context_line":"            \u0027multiattach\u0027: self._use_iscsi,"},{"line_number":711,"context_line":"            \u0027QoS_support\u0027: False,"},{"line_number":712,"context_line":"            \u0027thick_provisioning_support\u0027: False,"},{"line_number":713,"context_line":"            \u0027thin_provisioning_support\u0027: True,"}],"source_content_type":"text/x-python","patch_set":26,"id":"d00a9d0b_cf406ac1","line":710,"in_reply_to":"91af5152_a033e440","updated":"2025-01-13 14:30:52.000000000","message":"It is actually the reverse, the StorPool over iSCSI supports\nmulti-attach, block does not. I think rephrasing the existing entry with\nsomething like:\n\n    [operation.multi-attach]\n    driver.storpool\u003d\"only over iSCSI\"\n\nwould be better. Not sure if this breaks any automation though.","commit_id":"2acfdddf0794754aa0e32a56800e77387f75ce38"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"3d2210fa2462fc58db8a8ca17fae4b3f783bb176","unresolved":true,"context_lines":[{"line_number":727,"context_line":"            \u0027vendor_name\u0027: \u0027StorPool\u0027,"},{"line_number":728,"context_line":"            \u0027driver_version\u0027: self.VERSION,"},{"line_number":729,"context_line":"            \u0027storage_protocol\u0027: ("},{"line_number":730,"context_line":"                constants.ISCSI if self._use_iscsi else constants.STORPOOL"},{"line_number":731,"context_line":"            ),"},{"line_number":732,"context_line":"            # Driver capabilities"},{"line_number":733,"context_line":"            \u0027clone_across_pools\u0027: True,"}],"source_content_type":"text/x-python","patch_set":26,"id":"1c62fbca_0ac678e2","line":730,"updated":"2025-01-11 03:45:42.000000000","message":"Draft\n12:13 AM\nIt seems weird to report a specific storage protocol as backend capabilities but later fallback to another depending on which compute node the volume will be attached to. The possibility of allowing some dynamic storage protocol selection based on compute node requirements would need to be thought and designed as a core feature first IMO.","commit_id":"2acfdddf0794754aa0e32a56800e77387f75ce38"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"0857f769d6a70ad864ad25ea2297c7532f12cb16","unresolved":false,"context_lines":[{"line_number":727,"context_line":"            \u0027vendor_name\u0027: \u0027StorPool\u0027,"},{"line_number":728,"context_line":"            \u0027driver_version\u0027: self.VERSION,"},{"line_number":729,"context_line":"            \u0027storage_protocol\u0027: ("},{"line_number":730,"context_line":"                constants.ISCSI if self._use_iscsi else constants.STORPOOL"},{"line_number":731,"context_line":"            ),"},{"line_number":732,"context_line":"            # Driver capabilities"},{"line_number":733,"context_line":"            \u0027clone_across_pools\u0027: True,"}],"source_content_type":"text/x-python","patch_set":26,"id":"888498b3_aed2a3c2","line":730,"in_reply_to":"1c62fbca_0ac678e2","updated":"2025-01-13 14:30:52.000000000","message":"The patch has been discussed already in IRC [1], with Rajat being OK\nwith having it as-is [2].\n\n[1]: https://meetings.opendev.org/irclogs/%23openstack-meeting-alt/%23openstack-meeting-alt.2024-11-20.log.html\n[2]: https://review.opendev.org/c/openstack/cinder/+/847536/comment/e2ef5922_2c57db21/","commit_id":"2acfdddf0794754aa0e32a56800e77387f75ce38"},{"author":{"_account_id":37888,"name":"Akshay Ranade","display_name":"Akshay Ranade","email":"akshay.ranade@ibm.com","username":"rakshay"},"change_message_id":"2f4a9d1bc6dc6b309423fb953b3faf45a7be21f8","unresolved":true,"context_lines":[{"line_number":734,"context_line":"            \u0027vendor_name\u0027: \u0027StorPool\u0027,"},{"line_number":735,"context_line":"            \u0027driver_version\u0027: self.VERSION,"},{"line_number":736,"context_line":"            \u0027storage_protocol\u0027: ("},{"line_number":737,"context_line":"                constants.ISCSI if self._use_iscsi else constants.STORPOOL"},{"line_number":738,"context_line":"            ),"},{"line_number":739,"context_line":"            # Driver capabilities"},{"line_number":740,"context_line":"            \u0027clone_across_pools\u0027: True,"}],"source_content_type":"text/x-python","patch_set":41,"id":"6280dc59_2db7c6c5","line":737,"updated":"2025-12-19 15:05:44.000000000","message":"This will report cinder the protocol as \u0027storpool\u0027 in case if user gives a list of IQNs and not \u0027*\u0027 specifically. I am not sure if this is intentional, but this may never let scheduler to place the volume(s) that would require iSCSI as protocol to this backend.","commit_id":"8d570b7e4203e9bb7321996a9043b76fb8b0c780"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"5183386c0b9b825fb3de1fb3b498f3b4afd2bbab","unresolved":true,"context_lines":[{"line_number":249,"context_line":"            cfg[\u0027iscsi\u0027][\u0027portalGroups\u0027].values() if pg[\u0027name\u0027] \u003d\u003d pg_name"},{"line_number":250,"context_line":"        ]"},{"line_number":251,"context_line":"        if not pg_found:"},{"line_number":252,"context_line":"            raise Exception(\u0027StorPool Cinder iSCSI configuration error: \u0027"},{"line_number":253,"context_line":"                            \u0027no portal group \"{pg}\"\u0027.format(pg\u003dpg_name))"},{"line_number":254,"context_line":"        pg \u003d pg_found[0]"},{"line_number":255,"context_line":""}],"source_content_type":"text/x-python","patch_set":42,"id":"2a5e11a9_1fadbeaf","line":252,"updated":"2026-03-06 18:47:24.000000000","message":"generic exception is raised...Any reason? Can you narrow down to VolumeBackendAPIException?","commit_id":"c72ab7f5e1e2892f5c128fc0bb3bb803d9e88df2"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"5183386c0b9b825fb3de1fb3b498f3b4afd2bbab","unresolved":true,"context_lines":[{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        if cfg[\u0027initiator\u0027] is None:"},{"line_number":320,"context_line":"            if not (self.configuration.storpool_iscsi_learn_initiator_iqns or"},{"line_number":321,"context_line":"                    self.configuration.storpool_iscsi_cinder_volume and"},{"line_number":322,"context_line":"                    connector.get(\u0027storpool_wants_iscsi\u0027)):"},{"line_number":323,"context_line":"                raise Exception(\u0027The \"{iqn}\" initiator IQN for the \"{host}\" \u0027"},{"line_number":324,"context_line":"                                \u0027host is not defined in the StorPool \u0027"}],"source_content_type":"text/x-python","patch_set":42,"id":"4a6d456b_f7370504","line":321,"updated":"2026-03-06 18:47:24.000000000","message":"and will be having high priority over or. in your statment or is earlier. is this intended?","commit_id":"c72ab7f5e1e2892f5c128fc0bb3bb803d9e88df2"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"5183386c0b9b825fb3de1fb3b498f3b4afd2bbab","unresolved":true,"context_lines":[{"line_number":456,"context_line":"                    \u0027commands\u0027: ["},{"line_number":457,"context_line":"                        {"},{"line_number":458,"context_line":"                            \u0027exportDelete\u0027: {"},{"line_number":459,"context_line":"                                \u0027initiator\u0027: cfg[\u0027initiator\u0027][\u0027name\u0027],"},{"line_number":460,"context_line":"                                \u0027portalGroup\u0027: cfg[\u0027pg\u0027][\u0027name\u0027],"},{"line_number":461,"context_line":"                                \u0027volumeName\u0027: cfg[\u0027volume_name\u0027],"},{"line_number":462,"context_line":"                            },"}],"source_content_type":"text/x-python","patch_set":42,"id":"a5c1f445_7f8afc57","line":459,"updated":"2026-03-06 18:47:24.000000000","message":"TypeError may come if initiator is None. Defensive programing is better hear.","commit_id":"c72ab7f5e1e2892f5c128fc0bb3bb803d9e88df2"}],"doc/source/configuration/block-storage/drivers/storpool-volume-driver.rst":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"91633ac10a2199cdb366371ec44cb6f00a4d2f85","unresolved":true,"context_lines":[{"line_number":66,"context_line":"A valid ``/etc/storpool.conf`` file is required; please contact the StorPool"},{"line_number":67,"context_line":"support team for assistance."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"The StorPool Cinder volume driver has two configuration options that may"},{"line_number":70,"context_line":"be specified both in the global configuration (e.g. in a ``cinder.conf``"},{"line_number":71,"context_line":"volume backend definition) and per volume type:"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"183f59c9_737fd196","line":69,"range":{"start_line":69,"start_character":38,"end_line":69,"end_character":63},"updated":"2023-04-25 11:03:30.000000000","message":"nit: now there are additional 3 options (lines 84 to 97)","commit_id":"18923cb66802c71fc61873258776cba2ba1eb450"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f9598067962e2c62738eaa8e31ee7c017a4ea894","unresolved":false,"context_lines":[{"line_number":66,"context_line":"A valid ``/etc/storpool.conf`` file is required; please contact the StorPool"},{"line_number":67,"context_line":"support team for assistance."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"The StorPool Cinder volume driver has two configuration options that may"},{"line_number":70,"context_line":"be specified both in the global configuration (e.g. in a ``cinder.conf``"},{"line_number":71,"context_line":"volume backend definition) and per volume type:"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"461046d7_c8b29a9a","line":69,"range":{"start_line":69,"start_character":38,"end_line":69,"end_character":63},"in_reply_to":"183f59c9_737fd196","updated":"2024-08-01 05:28:41.000000000","message":"Below two are applicable for type as well as cinder.conf while newly added are cinder.conf only. So separately mentioned.","commit_id":"18923cb66802c71fc61873258776cba2ba1eb450"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"91633ac10a2199cdb366371ec44cb6f00a4d2f85","unresolved":true,"context_lines":[{"line_number":95,"context_line":"  has its default empty value, the ``cinder-volume`` service will use iSCSI"},{"line_number":96,"context_line":"  to attach the volumes and snapshots for transferring data to and from"},{"line_number":97,"context_line":"  Glance images."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Using the StorPool volume driver"},{"line_number":100,"context_line":"--------------------------------"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"4f313c9d_8c9dfb66","line":98,"updated":"2023-04-25 11:03:30.000000000","message":"nit: can we add some info about option ``iscsi_learn_initiator_iqns`` ?","commit_id":"18923cb66802c71fc61873258776cba2ba1eb450"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f9598067962e2c62738eaa8e31ee7c017a4ea894","unresolved":false,"context_lines":[{"line_number":95,"context_line":"  has its default empty value, the ``cinder-volume`` service will use iSCSI"},{"line_number":96,"context_line":"  to attach the volumes and snapshots for transferring data to and from"},{"line_number":97,"context_line":"  Glance images."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Using the StorPool volume driver"},{"line_number":100,"context_line":"--------------------------------"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"eb4ab244_3e1943df","line":98,"in_reply_to":"4f313c9d_8c9dfb66","updated":"2024-08-01 05:28:41.000000000","message":"Done","commit_id":"18923cb66802c71fc61873258776cba2ba1eb450"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4a3ec50ba02e635c809055b8fc0005b8970f8d6f","unresolved":true,"context_lines":[{"line_number":59,"context_line":"the ``iscsi_cinder_volume`` option configures the StorPool Cinder driver"},{"line_number":60,"context_line":"so that only the ``cinder-volume`` service will use the iSCSI protocol when"},{"line_number":61,"context_line":"attaching volumes and snapshots to transfer data to and from Glance images."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Configuring the StorPool volume driver"},{"line_number":64,"context_line":"--------------------------------------"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":20,"id":"85127b78_a4873c5d","line":62,"updated":"2024-09-11 13:19:57.000000000","message":"I think you also need to mention somewhere about multiattach only being supported when using iscsi exports.","commit_id":"38e93b5aa940ea4dcabd72db600771a8eaad7b1b"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"9a14b45ce5b8118a00a440754ecdc2209593bc22","unresolved":false,"context_lines":[{"line_number":59,"context_line":"the ``iscsi_cinder_volume`` option configures the StorPool Cinder driver"},{"line_number":60,"context_line":"so that only the ``cinder-volume`` service will use the iSCSI protocol when"},{"line_number":61,"context_line":"attaching volumes and snapshots to transfer data to and from Glance images."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Configuring the StorPool volume driver"},{"line_number":64,"context_line":"--------------------------------------"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":20,"id":"80168c5a_c2e21f80","line":62,"in_reply_to":"85127b78_a4873c5d","updated":"2024-09-17 09:15:18.000000000","message":"I added the note from the release note here as well.","commit_id":"38e93b5aa940ea4dcabd72db600771a8eaad7b1b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4a3ec50ba02e635c809055b8fc0005b8970f8d6f","unresolved":true,"context_lines":[{"line_number":98,"context_line":"- ``iscsi_cinder_volume``: if enabled, even if the ``iscsi_export_to`` option"},{"line_number":99,"context_line":"  has its default empty value, the ``cinder-volume`` service will use iSCSI"},{"line_number":100,"context_line":"  to attach the volumes and snapshots for transferring data to and from"},{"line_number":101,"context_line":"  Glance images."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"- ``iscsi_learn_initiator_iqns``: if enabled, the StorPool Cinder driver will"},{"line_number":104,"context_line":"  automatically use the StorPool API to create definitions for new initiators"}],"source_content_type":"text/x-rst","patch_set":20,"id":"7bd245d3_a6340ff8","line":101,"range":{"start_line":101,"start_character":15,"end_line":101,"end_character":16},"updated":"2024-09-11 13:19:57.000000000","message":"suggestion: add \"if Glance is configured to use the cinder glance_store\" to the end of this sentence","commit_id":"38e93b5aa940ea4dcabd72db600771a8eaad7b1b"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"9a14b45ce5b8118a00a440754ecdc2209593bc22","unresolved":false,"context_lines":[{"line_number":98,"context_line":"- ``iscsi_cinder_volume``: if enabled, even if the ``iscsi_export_to`` option"},{"line_number":99,"context_line":"  has its default empty value, the ``cinder-volume`` service will use iSCSI"},{"line_number":100,"context_line":"  to attach the volumes and snapshots for transferring data to and from"},{"line_number":101,"context_line":"  Glance images."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"- ``iscsi_learn_initiator_iqns``: if enabled, the StorPool Cinder driver will"},{"line_number":104,"context_line":"  automatically use the StorPool API to create definitions for new initiators"}],"source_content_type":"text/x-rst","patch_set":20,"id":"4872c90d_4d5dd62d","line":101,"range":{"start_line":101,"start_character":15,"end_line":101,"end_character":16},"in_reply_to":"7bd245d3_a6340ff8","updated":"2024-09-17 09:15:18.000000000","message":"Done","commit_id":"38e93b5aa940ea4dcabd72db600771a8eaad7b1b"}],"releasenotes/notes/storpool-iscsi-cefcfe590a07c5c7.yaml":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4a3ec50ba02e635c809055b8fc0005b8970f8d6f","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    the Cinder documentation for more information on the ``iscsi_export_to``,"},{"line_number":9,"context_line":"    ``iscsi_portal_group``, ``iscsi_cinder_volume``, and"},{"line_number":10,"context_line":"    ``iscsi_learn_initiator_iqns`` options."},{"line_number":11,"context_line":"    Note that multiattach support for StorPool is now only enabled if"},{"line_number":12,"context_line":"    ``iscsi_export_to`` is set to ``*``, that is, all StorPool volumes will be"},{"line_number":13,"context_line":"    exported via iSCSI to all initiators."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"d0dcb11e_2fc7c29f","line":11,"updated":"2024-09-11 13:19:57.000000000","message":"nit: need a blank line after line 10 if you want this to display as a separate paragraph within this bullet point.  On the other hand, this looks fine in HTML as it is, so completely up to you.","commit_id":"38e93b5aa940ea4dcabd72db600771a8eaad7b1b"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"9a14b45ce5b8118a00a440754ecdc2209593bc22","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    the Cinder documentation for more information on the ``iscsi_export_to``,"},{"line_number":9,"context_line":"    ``iscsi_portal_group``, ``iscsi_cinder_volume``, and"},{"line_number":10,"context_line":"    ``iscsi_learn_initiator_iqns`` options."},{"line_number":11,"context_line":"    Note that multiattach support for StorPool is now only enabled if"},{"line_number":12,"context_line":"    ``iscsi_export_to`` is set to ``*``, that is, all StorPool volumes will be"},{"line_number":13,"context_line":"    exported via iSCSI to all initiators."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"7035c122_c7e9b8fe","line":11,"in_reply_to":"d0dcb11e_2fc7c29f","updated":"2024-09-17 09:15:18.000000000","message":"Went ahead with the `.. note::` option.","commit_id":"38e93b5aa940ea4dcabd72db600771a8eaad7b1b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4a3ec50ba02e635c809055b8fc0005b8970f8d6f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":20,"id":"7752d37e_ab91fdfc","line":14,"updated":"2024-09-11 13:19:57.000000000","message":"Re-thinking the above comment, I think it\u0027s an important change, so in its own paragraph will make it stand out.  Other option would be to add it as an actual sphinx \u0027note\u0027 like this:\n\n```\nfeatures:\n  - |\n    StorPool driver: Added support for exporting the StorPool-backed volumes\n    using the iSCSI protocol, so that the Cinder volume service and/or\n    the Nova or Glance consumers do not need to have the StorPool block\n    device third-party service installed. See the StorPool driver section in\n    the Cinder documentation for more information on the ``iscsi_export_to``,\n    ``iscsi_portal_group``, ``iscsi_cinder_volume``, and\n    ``iscsi_learn_initiator_iqns`` options.\n\n    .. note::\n       Multiattach support for StorPool is now only enabled if\n       ``iscsi_export_to`` is set to ``*``, that is, when all StorPool volumes\n       will be exported via iSCSI to all initiators.\n\n```","commit_id":"38e93b5aa940ea4dcabd72db600771a8eaad7b1b"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"9a14b45ce5b8118a00a440754ecdc2209593bc22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"1ea125c3_507e8afa","line":14,"in_reply_to":"7752d37e_ab91fdfc","updated":"2024-09-17 09:15:18.000000000","message":"Done","commit_id":"38e93b5aa940ea4dcabd72db600771a8eaad7b1b"}]}