)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"48d0631cb784f00347b98067d673cff9a8c2a74f","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ceph minimum client on cinder-plugin-ceph-tempest job enable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since e222cc976918a331bacff150e84069fda8f4960a, it is possible to enable"},{"line_number":10,"context_line":"the minimum client version. The goal of this patch is to enable the"},{"line_number":11,"context_line":"*mimic* client version for the current cinder-plugin-ceph-tempest job."},{"line_number":12,"context_line":"As a result, we will be able to test this feature with our current CI"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"08dcda36_25c62c3e","line":9,"range":{"start_line":9,"start_character":66,"end_line":9,"end_character":72},"updated":"2022-07-15 15:24:31.000000000","message":"nit: set","commit_id":"612d623e4d523d362f5012348eb1a223fc79cb3c"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"a1327a92f9924caf0358f537972df6ece273cd77","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ceph minimum client on cinder-plugin-ceph-tempest job enable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since e222cc976918a331bacff150e84069fda8f4960a, it is possible to enable"},{"line_number":10,"context_line":"the minimum client version. The goal of this patch is to enable the"},{"line_number":11,"context_line":"*mimic* client version for the current cinder-plugin-ceph-tempest job."},{"line_number":12,"context_line":"As a result, we will be able to test this feature with our current CI"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"533e6ee6_dde66e8d","line":9,"range":{"start_line":9,"start_character":66,"end_line":9,"end_character":72},"in_reply_to":"08dcda36_25c62c3e","updated":"2022-09-19 16:29:41.000000000","message":"Done","commit_id":"612d623e4d523d362f5012348eb1a223fc79cb3c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"48d0631cb784f00347b98067d673cff9a8c2a74f","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Since e222cc976918a331bacff150e84069fda8f4960a, it is possible to enable"},{"line_number":10,"context_line":"the minimum client version. The goal of this patch is to enable the"},{"line_number":11,"context_line":"*mimic* client version for the current cinder-plugin-ceph-tempest job."},{"line_number":12,"context_line":"As a result, we will be able to test this feature with our current CI"},{"line_number":13,"context_line":"and test future features with this feature enabled."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I8ffb0c1130b30a19f336a98a9efef05905786af2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f03e0d5_83427e68","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":51},"updated":"2022-07-15 15:24:31.000000000","message":"This is kind of vague and doesn\u0027t justify setting the minimum client version to mimic, I think we should be more explicit about the ceph feature that allows deletion of volumes that are dependent on snapshots (if that is what we are setting this for)","commit_id":"612d623e4d523d362f5012348eb1a223fc79cb3c"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"a1327a92f9924caf0358f537972df6ece273cd77","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Since e222cc976918a331bacff150e84069fda8f4960a, it is possible to enable"},{"line_number":10,"context_line":"the minimum client version. The goal of this patch is to enable the"},{"line_number":11,"context_line":"*mimic* client version for the current cinder-plugin-ceph-tempest job."},{"line_number":12,"context_line":"As a result, we will be able to test this feature with our current CI"},{"line_number":13,"context_line":"and test future features with this feature enabled."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I8ffb0c1130b30a19f336a98a9efef05905786af2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3177a12c_04f08847","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":51},"in_reply_to":"7f03e0d5_83427e68","updated":"2022-09-19 16:29:41.000000000","message":"+1 I\u0027ve updated the commit message.","commit_id":"612d623e4d523d362f5012348eb1a223fc79cb3c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"794462406d12a6b1f44b8181d508ef7501c7f776","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a122789a_31c11223","updated":"2022-07-15 14:41:25.000000000","message":"I think officially cinder is supporting ceph N, O, P, Q now [0], so this is a conservative change.  LGTM.\n\n[0] https://docs.openstack.org/cinder/latest/configuration/block-storage/drivers/ceph-rbd-volume-driver.html","commit_id":"612d623e4d523d362f5012348eb1a223fc79cb3c"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"a4de8d128b8ef50c645b146b04597c9e5409d55b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b0c0bf3a_d56e014a","updated":"2022-08-22 13:28:31.000000000","message":"LGTM","commit_id":"612d623e4d523d362f5012348eb1a223fc79cb3c"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"31820411548245975c3f9360e9a1c39d11cf7b94","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"17b86463_deb22e8c","updated":"2022-12-16 15:05:20.000000000","message":"LGTM","commit_id":"5e2fc9a58d0c7824f81eb43d20eec86eb5f2d880"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6ac61ca79000067911d7f303ac3f5006aec22619","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"df5086e8_91318235","updated":"2023-02-17 17:25:42.000000000","message":"Makes sense, and is working: https://zuul.opendev.org/t/openstack/build/506ce85450d844e18f9d052097dad6bf/log/controller/logs/_.localrc_auto.txt#36","commit_id":"5e2fc9a58d0c7824f81eb43d20eec86eb5f2d880"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"d65b892cf35a324835862eac0e6b0e4d9119fe2c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"aa71e19e_4e51072f","updated":"2022-09-29 04:47:00.000000000","message":"already have a +2 we can move ahead to merge this right?","commit_id":"5e2fc9a58d0c7824f81eb43d20eec86eb5f2d880"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"d5d728e030d8a9b8625522a84cfc228685ff02ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c70b3753_a6abf6be","updated":"2023-01-20 15:52:55.000000000","message":"even without job results the change makes sense","commit_id":"5e2fc9a58d0c7824f81eb43d20eec86eb5f2d880"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"fc37276f73a31b907cc4060a4b1ad2fe9308abb2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"99ce9e80_04d6ca3d","updated":"2023-01-20 15:52:39.000000000","message":"recheck for fresh logs to see if it\u0027s being set in the ceph job","commit_id":"5e2fc9a58d0c7824f81eb43d20eec86eb5f2d880"}]}