)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c08130761bf23a3cd93f8ab8a5d2da86fcfa5774","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[SVf] Optimize lsmdiskgrp calls in creation of replicated volumes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"[Spectrum Virtualize family] During creation of replicated volumes,"},{"line_number":10,"context_line":"lsmdiskgrp calls are made as the secondary pools information is not"},{"line_number":11,"context_line":"available in stats."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Hence, Optimized the lsmdiskgrp SSH calls to reduce the computational"},{"line_number":14,"context_line":"time by storing the secondary pools information in stats."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ae0d7b4_cbc14e73","line":11,"range":{"start_line":9,"start_character":29,"end_line":11,"end_character":19},"updated":"2022-12-19 09:49:41.000000000","message":"would\u0027ve been good to mention the code line where this call is made","commit_id":"040ab06d8e05f5abf73fccbb6b31a239fb1930f2"},{"author":{"_account_id":34201,"name":"Mounika Sreeram","email":"sreeram.mounika@ibm.com","username":"sreerammounika"},"change_message_id":"e138f390b412cb647191e525a5864e277ebc5ca9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[SVf] Optimize lsmdiskgrp calls in creation of replicated volumes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"[Spectrum Virtualize family] During creation of replicated volumes,"},{"line_number":10,"context_line":"lsmdiskgrp calls are made as the secondary pools information is not"},{"line_number":11,"context_line":"available in stats."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Hence, Optimized the lsmdiskgrp SSH calls to reduce the computational"},{"line_number":14,"context_line":"time by storing the secondary pools information in stats."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ed658170_4d960594","line":11,"range":{"start_line":9,"start_character":29,"end_line":11,"end_character":19},"in_reply_to":"1ae0d7b4_cbc14e73","updated":"2022-12-19 13:25:08.000000000","message":"Updated the line number in commit message.\nCode link: https://opendev.org/openstack/cinder/src/branch/master/cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py#L919","commit_id":"040ab06d8e05f5abf73fccbb6b31a239fb1930f2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c0d4b3446280fc715561bbef2feb3657be7bc04e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[SVf] Optimize lsmdiskgrp calls in creation of replicated volumes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"[Spectrum Virtualize family] During creation of replicated volumes,"},{"line_number":10,"context_line":"lsmdiskgrp calls are made as the secondary pools information is not"},{"line_number":11,"context_line":"available in stats."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Hence, Optimized the lsmdiskgrp SSH calls to reduce the computational"},{"line_number":14,"context_line":"time by storing the secondary pools information in stats."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"90dd9b6b_528ec501","line":11,"range":{"start_line":9,"start_character":29,"end_line":11,"end_character":19},"in_reply_to":"ed658170_4d960594","updated":"2022-12-19 13:47:30.000000000","message":"Would\u0027ve been good to include a permanent link like this[1] since line number and file name could change in future.\n\n[1] https://opendev.org/openstack/cinder/src/commit/12fb54ad60762017da4aa02290bc2c5c7d5b697b/cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py","commit_id":"040ab06d8e05f5abf73fccbb6b31a239fb1930f2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c08130761bf23a3cd93f8ab8a5d2da86fcfa5774","unresolved":true,"context_lines":[{"line_number":10,"context_line":"lsmdiskgrp calls are made as the secondary pools information is not"},{"line_number":11,"context_line":"available in stats."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Hence, Optimized the lsmdiskgrp SSH calls to reduce the computational"},{"line_number":14,"context_line":"time by storing the secondary pools information in stats."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1978290"},{"line_number":17,"context_line":"Change-Id: Iea7a7b7d7ce226b3c29aba9641b052ee7fe8614f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"be50bda4_e6af6131","line":14,"range":{"start_line":13,"start_character":7,"end_line":14,"end_character":57},"updated":"2022-12-19 09:49:41.000000000","message":"is there a case where this information gets stale? we would need to refresh it in this case else we might have wrong info in the volume stats","commit_id":"040ab06d8e05f5abf73fccbb6b31a239fb1930f2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c0d4b3446280fc715561bbef2feb3657be7bc04e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"lsmdiskgrp calls are made as the secondary pools information is not"},{"line_number":11,"context_line":"available in stats."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Hence, Optimized the lsmdiskgrp SSH calls to reduce the computational"},{"line_number":14,"context_line":"time by storing the secondary pools information in stats."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1978290"},{"line_number":17,"context_line":"Change-Id: Iea7a7b7d7ce226b3c29aba9641b052ee7fe8614f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"91284e2c_924e41aa","line":14,"range":{"start_line":13,"start_character":7,"end_line":14,"end_character":57},"in_reply_to":"965a557b_10a7cb5a","updated":"2022-12-19 13:47:30.000000000","message":"Ack, i missed the data is stored in _update_volume_stats so we should be good.","commit_id":"040ab06d8e05f5abf73fccbb6b31a239fb1930f2"},{"author":{"_account_id":34201,"name":"Mounika Sreeram","email":"sreeram.mounika@ibm.com","username":"sreerammounika"},"change_message_id":"e138f390b412cb647191e525a5864e277ebc5ca9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"lsmdiskgrp calls are made as the secondary pools information is not"},{"line_number":11,"context_line":"available in stats."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Hence, Optimized the lsmdiskgrp SSH calls to reduce the computational"},{"line_number":14,"context_line":"time by storing the secondary pools information in stats."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1978290"},{"line_number":17,"context_line":"Change-Id: Iea7a7b7d7ce226b3c29aba9641b052ee7fe8614f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"965a557b_10a7cb5a","line":14,"range":{"start_line":13,"start_character":7,"end_line":14,"end_character":57},"in_reply_to":"be50bda4_e6af6131","updated":"2022-12-19 13:25:08.000000000","message":"The parameter \"backend_stats_polling_interval\" is 60 seconds by default. So, for every 60 seconds, the stats information will be refreshed. \nThe time interval can be updated as per user requirement.\nhttps://opendev.org/openstack/cinder/src/branch/master/cinder/volume/manager.py#L135","commit_id":"040ab06d8e05f5abf73fccbb6b31a239fb1930f2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c0d4b3446280fc715561bbef2feb3657be7bc04e","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"[Spectrum Virtualize family] During creation of replicated volumes,"},{"line_number":10,"context_line":"lsmdiskgrp calls are made at L919 in storwize_svc_common.py file as"},{"line_number":11,"context_line":"the secondary pools information is not available in stats. "},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Hence, Optimized the lsmdiskgrp SSH calls to reduce the computational"},{"line_number":14,"context_line":"time by storing the secondary pools information in stats."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"01906ee4_b1ec7437","line":11,"range":{"start_line":11,"start_character":58,"end_line":11,"end_character":59},"updated":"2022-12-19 13:47:30.000000000","message":"nit: extra whitespace","commit_id":"c34ba3c9756c78f6a3b7361c30de4f0eb766dbaf"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c08130761bf23a3cd93f8ab8a5d2da86fcfa5774","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9df44501_ee2373eb","updated":"2022-12-19 09:49:41.000000000","message":"Code LGTM, few questions inline.","commit_id":"040ab06d8e05f5abf73fccbb6b31a239fb1930f2"},{"author":{"_account_id":32074,"name":"Harsh Ailani","email":"haailani@in.ibm.com","username":"haailani"},"change_message_id":"accef1e1951ce8021879123965c14e582b700b44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"91cf084a_088827d9","updated":"2022-07-26 09:48:22.000000000","message":"Code looks good.\nUT and release notes are also implemented.","commit_id":"040ab06d8e05f5abf73fccbb6b31a239fb1930f2"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"7eaf460a0f994e42e9a731b22a2ee36784bf3e39","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c35278b0_c7f125f9","updated":"2022-08-08 09:29:51.000000000","message":"LGTM! Last CI has post failure but previous was okay.","commit_id":"040ab06d8e05f5abf73fccbb6b31a239fb1930f2"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"e44ca265ab2322a1f1c11f8cae7a60af50a507b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ee6d66cf_833d54a8","updated":"2022-09-29 09:35:57.000000000","message":"Looks good","commit_id":"040ab06d8e05f5abf73fccbb6b31a239fb1930f2"},{"author":{"_account_id":34201,"name":"Mounika Sreeram","email":"sreeram.mounika@ibm.com","username":"sreerammounika"},"change_message_id":"76cde08ac64d29966686291bc22c2d413eb8cc88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ae960f31_4b55ec7e","updated":"2022-07-22 05:49:51.000000000","message":"recheck","commit_id":"040ab06d8e05f5abf73fccbb6b31a239fb1930f2"},{"author":{"_account_id":34201,"name":"Mounika Sreeram","email":"sreeram.mounika@ibm.com","username":"sreerammounika"},"change_message_id":"330b11de1018814d9a0e0b42f0d4986bd204d5a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c906cfa1_1ea45f78","updated":"2022-07-25 05:01:01.000000000","message":"recheck","commit_id":"040ab06d8e05f5abf73fccbb6b31a239fb1930f2"},{"author":{"_account_id":34201,"name":"Mounika Sreeram","email":"sreeram.mounika@ibm.com","username":"sreerammounika"},"change_message_id":"d37a1fd30e79a962197ee6381dfaa44051fe10d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"521bbdcf_fd5c87bd","updated":"2022-12-16 05:13:56.000000000","message":"run-IBM Storage CI","commit_id":"040ab06d8e05f5abf73fccbb6b31a239fb1930f2"},{"author":{"_account_id":32425,"name":"saikrishnagk","email":"gopalakrishna.krishna@ibm.com","username":"gksk"},"change_message_id":"ca435f615365437a9745dd3415ca1485b2fe38dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5b75640b_9ecd4334","updated":"2022-12-06 08:26:14.000000000","message":"run-IBM Storage CI","commit_id":"040ab06d8e05f5abf73fccbb6b31a239fb1930f2"},{"author":{"_account_id":32425,"name":"saikrishnagk","email":"gopalakrishna.krishna@ibm.com","username":"gksk"},"change_message_id":"b644b32a668bcce64f378bb8fe83ed353cf6a55b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cd8e6d65_2e8307c3","updated":"2022-12-06 11:55:11.000000000","message":"run-IBM Storage CI","commit_id":"040ab06d8e05f5abf73fccbb6b31a239fb1930f2"},{"author":{"_account_id":32074,"name":"Harsh Ailani","email":"haailani@in.ibm.com","username":"haailani"},"change_message_id":"3435f9b1f46cac86aedcad222caa314fab09cde2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4044ba8e_5419e164","updated":"2022-12-27 12:59:07.000000000","message":"LGTM","commit_id":"c34ba3c9756c78f6a3b7361c30de4f0eb766dbaf"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"3cf0a8d6143de41e8b4d6661d1d95b8315131a4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c480125d_5d00aba8","updated":"2022-12-21 14:32:57.000000000","message":"Looks good. Passing CIs","commit_id":"c34ba3c9756c78f6a3b7361c30de4f0eb766dbaf"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c0d4b3446280fc715561bbef2feb3657be7bc04e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2c7dd6f4_17b702ce","updated":"2022-12-19 13:47:30.000000000","message":"My queries are answered, wouldn\u0027t block this for commit message. Storwize CI has passed in last PS and there has only been commit message change so LGTM.","commit_id":"c34ba3c9756c78f6a3b7361c30de4f0eb766dbaf"},{"author":{"_account_id":34201,"name":"Mounika Sreeram","email":"sreeram.mounika@ibm.com","username":"sreerammounika"},"change_message_id":"e138f390b412cb647191e525a5864e277ebc5ca9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cc38069b_01277928","updated":"2022-12-19 13:25:08.000000000","message":"Thank you Rajat for the review.\nUpdated answers inline.","commit_id":"c34ba3c9756c78f6a3b7361c30de4f0eb766dbaf"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"518eb3f5044b0d6b15c4f4111c1edc09d89ef947","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f006c762_4eaacad2","updated":"2023-01-04 15:13:16.000000000","message":"This looks good to me.  Passing CI.  Thanks!","commit_id":"c34ba3c9756c78f6a3b7361c30de4f0eb766dbaf"},{"author":{"_account_id":34201,"name":"Mounika Sreeram","email":"sreeram.mounika@ibm.com","username":"sreerammounika"},"change_message_id":"5251b949c254a3447cf84f94210842d31d50ec64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"499c214d_10344eb1","updated":"2022-12-19 15:19:23.000000000","message":"recheck","commit_id":"c34ba3c9756c78f6a3b7361c30de4f0eb766dbaf"},{"author":{"_account_id":34201,"name":"Mounika Sreeram","email":"sreeram.mounika@ibm.com","username":"sreerammounika"},"change_message_id":"04654db52d5c87338a7e33dbea407ceb25ab45a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f494d906_9dc9e000","updated":"2022-12-19 13:28:31.000000000","message":"run-IBM Storage CI","commit_id":"c34ba3c9756c78f6a3b7361c30de4f0eb766dbaf"}]}