)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"aa2406dad5ea2843b79fc1186022dd8a8174e322","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3cb3b120_45a31fc0","updated":"2022-07-06 16:01:00.000000000","message":"Some suggestions inline.  Looks like a good idea; the Zuul -1 is from this new check detecting a problematic file.","commit_id":"3882bfec82b74a4f1262f56c3b1a8d895ff52746"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"347acc0f461c579b2ba5c09954879bb4c9390aa1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"96e1b39d_bd78762e","updated":"2024-01-30 14:51:15.000000000","message":"Ah, this is nice ! I agree with adding the check. Wondering if we can include the test files as well.\n\nAlso as I mentioned in [1] we can now modify the release note file without messing up where a note is added. So we may want to check release note files as well.\n\n[1] https://review.opendev.org/c/openstack/cinder/+/906925","commit_id":"9130dce56b4221b0f1317553a1066160a7d66b11"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"602deed15bc2e96c26218025ed714f199d9fcbc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"44b0f89d_7e6e2211","updated":"2025-11-26 13:36:04.000000000","message":"I think this is covered by pre-commit now, which was merged with change I7dd14b4087d92f6bdae575581e03f991c519d57a ; if that is indeed the case, you can abandon this patch.","commit_id":"9130dce56b4221b0f1317553a1066160a7d66b11"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f0491815cc909c97f94d96805792d16eafd7574e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9d2f97ce_d61d4c30","updated":"2022-08-17 16:20:04.000000000","message":"Maybe it would be better to add a `.gitattributes` file with:\n\n```\n*.py   text eol\u003dlf\n```\n\nThat would make it a little more proactive I think.\n\nhttps://www.git-scm.com/docs/gitattributes","commit_id":"9130dce56b4221b0f1317553a1066160a7d66b11"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5601bb06a45322039a95a2c91bb04cdb8782450c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e33dbb3a_6a060185","updated":"2023-09-02 14:25:08.000000000","message":"Sorry this has been sitting so long.  I prefer this to Sean\u0027s proposal, although I don\u0027t have a good argument, just a feeling that this is a bit more explicit and flexible (directories instead of file extensions, though of course, it could also be less flexible depending on what you want to do).  In any case, hopefully a +2 will get more eyes/opinions on this patch.","commit_id":"9130dce56b4221b0f1317553a1066160a7d66b11"}],"cinder/volume/drivers/dell_emc/powermax/performance.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f44bb5cf700033f5ea0e5477cfa5616c17e92d10","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2020 Dell Inc. or its subsidiaries."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa5a8063_f643f1b7","line":1,"updated":"2022-07-20 14:45:38.000000000","message":"Reminder: review with \"git show -w\".","commit_id":"9130dce56b4221b0f1317553a1066160a7d66b11"}],"tools/check_crlf.sh":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"9b310e43bff6eff303a3f2e20c156b89de43f796","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"DIRS\u003d\"cinder/volume/drivers etc/cinder doc/source\""},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"for d in $DIRS; do"},{"line_number":6,"context_line":"    files\u003d$(find $d -type f | xargs file | grep \"with CRLF\")"}],"source_content_type":"text/x-sh","patch_set":1,"id":"04acbadd_25631db1","line":3,"updated":"2022-07-12 16:38:09.000000000","message":"Would also be good to check releasenotes/notes, but it has a number of CRLF files already, and folks have been reticent about making changes to existing release notes.  Hmm.","commit_id":"3882bfec82b74a4f1262f56c3b1a8d895ff52746"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"55890ece91b33079c4b2e683b07c4307ba6dff80","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"DIRS\u003d\"cinder/volume/drivers etc/cinder doc/source\""},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"for d in $DIRS; do"},{"line_number":6,"context_line":"    files\u003d$(find $d -type f | xargs file | grep \"with CRLF\")"}],"source_content_type":"text/x-sh","patch_set":1,"id":"d74a9d3e_0f2c17d3","line":3,"in_reply_to":"04acbadd_25631db1","updated":"2022-08-11 17:09:29.000000000","message":"Ack","commit_id":"3882bfec82b74a4f1262f56c3b1a8d895ff52746"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"aa2406dad5ea2843b79fc1186022dd8a8174e322","unresolved":true,"context_lines":[{"line_number":5,"context_line":"for d in $DIRS; do"},{"line_number":6,"context_line":"    files\u003d$(find $d -type f | xargs file | grep \"with CRLF\")"},{"line_number":7,"context_line":"    if [ -n \"$files\" ]; then"},{"line_number":8,"context_line":"\t\techo \"Files with CRLF terminators:\""},{"line_number":9,"context_line":"\t\techo $files"},{"line_number":10,"context_line":"\t\texit 1"},{"line_number":11,"context_line":"\tfi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"28a21dbe_a92e6890","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":2},"updated":"2022-07-06 16:01:00.000000000","message":"probably don\u0027t want these tabs","commit_id":"3882bfec82b74a4f1262f56c3b1a8d895ff52746"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"55890ece91b33079c4b2e683b07c4307ba6dff80","unresolved":false,"context_lines":[{"line_number":5,"context_line":"for d in $DIRS; do"},{"line_number":6,"context_line":"    files\u003d$(find $d -type f | xargs file | grep \"with CRLF\")"},{"line_number":7,"context_line":"    if [ -n \"$files\" ]; then"},{"line_number":8,"context_line":"\t\techo \"Files with CRLF terminators:\""},{"line_number":9,"context_line":"\t\techo $files"},{"line_number":10,"context_line":"\t\texit 1"},{"line_number":11,"context_line":"\tfi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"6ec170e5_8c72c3ec","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":2},"in_reply_to":"28a21dbe_a92e6890","updated":"2022-08-11 17:09:29.000000000","message":"Done","commit_id":"3882bfec82b74a4f1262f56c3b1a8d895ff52746"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"aa2406dad5ea2843b79fc1186022dd8a8174e322","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6ead7659_7ea467a7","line":13,"updated":"2022-07-06 16:01:00.000000000","message":"This may be overengineering, but maybe you could check all dirs before exiting?  something like\n\n  exitcode\u003d0\n\nbefore line 5, then remove line 8 (the output for each line from grep already has the \u0027with CRLF\u0027 message), change line 10 to\n\n  ((exitcode++))\n  \nand then add\n\n  exit $exitcode\n  \nafter line 12.","commit_id":"3882bfec82b74a4f1262f56c3b1a8d895ff52746"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0d2422cc7ce0f31db6a9c18300662dd08ae23b51","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"97a5de0a_00a11c3d","line":13,"in_reply_to":"6ead7659_7ea467a7","updated":"2022-07-12 16:34:43.000000000","message":"Thanks, cleaned this up.\n\nI also fixed file\u0027s output padding.","commit_id":"3882bfec82b74a4f1262f56c3b1a8d895ff52746"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"55890ece91b33079c4b2e683b07c4307ba6dff80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"41f1f470_6c964f66","line":13,"in_reply_to":"97a5de0a_00a11c3d","updated":"2022-08-11 17:09:29.000000000","message":"Done","commit_id":"3882bfec82b74a4f1262f56c3b1a8d895ff52746"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"f3b7c8e56982b71e19ec496aaaa2a6022e8d00db","unresolved":true,"context_lines":[{"line_number":6,"context_line":"for d in $DIRS; do"},{"line_number":7,"context_line":"    files\u003d$(find $d -type f | xargs file -N | grep \"with CRLF\")"},{"line_number":8,"context_line":"    if [ -n \"$files\" ]; then"},{"line_number":9,"context_line":"        echo \"Files with CRLF terminators:\""},{"line_number":10,"context_line":"        echo \"$files\""},{"line_number":11,"context_line":"        exitcode\u003d1"},{"line_number":12,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7c78c1a3_0600015c","line":9,"updated":"2024-01-30 17:26:20.000000000","message":"People always neglect doing this:\necho \u0027error message\u0027 \u003e\u00262\n\nI guess it does not matter in CI, where everything is captured anyway.","commit_id":"9130dce56b4221b0f1317553a1066160a7d66b11"}]}