)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5e4b9b17a6a55683f9f4513605b868ac749554bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fcef30fc_49571c6c","updated":"2022-07-11 15:51:21.000000000","message":"Typo noted inline, also a note about the zuul failures.","commit_id":"6365c0a6b9f46fdb1f17c9d03d8896fcbaaadf0c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"f7d3f3f409d02c441c3973b7e7b10bada0a85a03","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7de513f4_0645897e","in_reply_to":"fcef30fc_49571c6c","updated":"2022-07-12 09:29:33.000000000","message":"Me, the king of typos having a typo?  Lies!!","commit_id":"6365c0a6b9f46fdb1f17c9d03d8896fcbaaadf0c"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"08bdaadafcbea4eb30730227486ad003c1a0a7e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7b690e1c_ba7b9100","updated":"2022-07-14 21:45:25.000000000","message":"I downloaded this patch and added git+https://review.opendev.org/openstack/os-brick@refs/changes/24/849324/4#egg\u003dos-brick to the tox deps and ran genconfig, and this shows up in cinder.conf.sample:\n\n  [os_brick]\n  \n  #\n  # From os_brick\n  #\n  \n  # Directory to use for os-brick lock files. Defaults to\n  # oslo_concurrency.lock_path which is a sensible default for compute notes, but\n  # not for HCI deployments or controllers where Glance uses Cinder as a backend,\n  # as locks should use the same directory. (string value)\n  #lock_path \u003d \u003cNone\u003e\n\nSo the config generation is definitely working as expected.","commit_id":"8e21506878c21e4cfa88663faa5a4656c052ee92"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4862ec7fdc5a4ccbb8a6cd0034ef9ef9fa6540c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d0a1ae89_764064e9","updated":"2022-07-13 03:17:13.000000000","message":"I think I agree with Sean\u0027s suggestion that we get the brick change merged \u0026 released before merging the service patches.","commit_id":"8e21506878c21e4cfa88663faa5a4656c052ee92"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"afb7fbe584797eeb66d84ed90551bc3aecdb0923","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e69bfb69_819c221c","updated":"2022-07-15 08:58:15.000000000","message":"LGTM","commit_id":"8e21506878c21e4cfa88663faa5a4656c052ee92"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"fce01caf900c1a29b71cfe7b06da387869b70eb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"48a5ae65_44599def","updated":"2022-07-12 16:41:00.000000000","message":"recheck - cinder-tempest-plugin-lvm-lio-barbican POST_FAILURE","commit_id":"8e21506878c21e4cfa88663faa5a4656c052ee92"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1978d9af0f6019ac2f05610f28ee9aa9f27cf353","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9e7a2b40_20bb7a01","updated":"2022-08-24 12:26:16.000000000","message":"Verified that https://opendev.org/openstack/os-brick/commit/b72c034885e76a258cad0b3b4e2a79eadc424480 is in os-brick 6.0.0\n\nCode and release note LGTM.","commit_id":"2e74ad63afd23eb0bc8cd19debc10db26ae6ba5a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2e8fb0711e1a5d86484e5d92ca6eda609efe57da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b127ac7a_97780546","updated":"2022-09-09 14:04:42.000000000","message":"We need this in Zed.","commit_id":"2e74ad63afd23eb0bc8cd19debc10db26ae6ba5a"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"4cd0d1f0c71b8181e50a0b719de453ca49ffda27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2e60bf06_66a1685b","updated":"2022-08-24 14:25:33.000000000","message":"recheck - cinder-tempest-plugin-lvm-lio-barbican failure on POST_FAILURE, nothing to do with the patch","commit_id":"2e74ad63afd23eb0bc8cd19debc10db26ae6ba5a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"05e579a95c6005ac36907fe1745a3c99c932b090","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"53b4449f_15414620","updated":"2022-08-24 12:11:15.000000000","message":"recheck cinder-tempest-plugin-lvm-lio-barbican - POST_FAILURE during devstack setup","commit_id":"2e74ad63afd23eb0bc8cd19debc10db26ae6ba5a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"cc8639bf9963cbac17e2f45a36d3df20bbadd260","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b3d458ba_80250dd6","updated":"2022-09-09 19:49:06.000000000","message":"LGTM.","commit_id":"ecefc7d67ad3b3257e5f3f04533ea8ee1fbbcfd3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1f1c4c3a02978bfdad7621b55f2a98007e0b5d1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"95ac3a97_380d5af4","updated":"2022-09-09 19:47:49.000000000","message":"corrected a nit in releasenote, else LGTM.","commit_id":"ecefc7d67ad3b3257e5f3f04533ea8ee1fbbcfd3"}],"cinder/cmd/backup.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5e4b9b17a6a55683f9f4513605b868ac749554bf","unresolved":true,"context_lines":[{"line_number":109,"context_line":"    priv_context.init(root_helper\u003dshlex.split(utils.get_root_helper()))"},{"line_number":110,"context_line":"    utils.monkey_patch()"},{"line_number":111,"context_line":"    gmr.TextGuruMeditation.setup_autorun(version, conf\u003dCONF)"},{"line_number":112,"context_line":"    getattr(os_brick, \u0027setup\u0027, lambda: None)(CONF)"},{"line_number":113,"context_line":"    global LOG"},{"line_number":114,"context_line":"    LOG \u003d logging.getLogger(__name__)"},{"line_number":115,"context_line":"    semaphore \u003d utils.semaphore_factory(CONF.backup_max_operations,"}],"source_content_type":"text/x-python","patch_set":1,"id":"4b8da819_1acba1c7","line":112,"range":{"start_line":112,"start_character":31,"end_line":112,"end_character":43},"updated":"2022-07-11 15:51:21.000000000","message":"I think this need an argument, something like\n\n  lambda c: None","commit_id":"6365c0a6b9f46fdb1f17c9d03d8896fcbaaadf0c"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4862ec7fdc5a4ccbb8a6cd0034ef9ef9fa6540c3","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    priv_context.init(root_helper\u003dshlex.split(utils.get_root_helper()))"},{"line_number":110,"context_line":"    utils.monkey_patch()"},{"line_number":111,"context_line":"    gmr.TextGuruMeditation.setup_autorun(version, conf\u003dCONF)"},{"line_number":112,"context_line":"    getattr(os_brick, \u0027setup\u0027, lambda: None)(CONF)"},{"line_number":113,"context_line":"    global LOG"},{"line_number":114,"context_line":"    LOG \u003d logging.getLogger(__name__)"},{"line_number":115,"context_line":"    semaphore \u003d utils.semaphore_factory(CONF.backup_max_operations,"}],"source_content_type":"text/x-python","patch_set":1,"id":"be89a7ca_62031365","line":112,"range":{"start_line":112,"start_character":31,"end_line":112,"end_character":43},"in_reply_to":"3af37a44_bc85c04b","updated":"2022-07-13 03:17:13.000000000","message":"That\u0027s a good idea, that way we know for sure we\u0027re dealing with an os_brick that contains the setup method.  You could add something to the release note mentioning that the feature requires os-brick \u003e\u003d 5.3.0 (or maybe the requirements change is enough and we don\u0027t have to mention it.","commit_id":"6365c0a6b9f46fdb1f17c9d03d8896fcbaaadf0c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"f7d3f3f409d02c441c3973b7e7b10bada0a85a03","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    priv_context.init(root_helper\u003dshlex.split(utils.get_root_helper()))"},{"line_number":110,"context_line":"    utils.monkey_patch()"},{"line_number":111,"context_line":"    gmr.TextGuruMeditation.setup_autorun(version, conf\u003dCONF)"},{"line_number":112,"context_line":"    getattr(os_brick, \u0027setup\u0027, lambda: None)(CONF)"},{"line_number":113,"context_line":"    global LOG"},{"line_number":114,"context_line":"    LOG \u003d logging.getLogger(__name__)"},{"line_number":115,"context_line":"    semaphore \u003d utils.semaphore_factory(CONF.backup_max_operations,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3af37a44_bc85c04b","line":112,"range":{"start_line":112,"start_character":31,"end_line":112,"end_character":43},"in_reply_to":"4b8da819_1acba1c7","updated":"2022-07-12 09:29:33.000000000","message":"/me facepalms\n\nOn a related note, in the Nova review smooney suggests we merge the os-brick patch, do a new release, and then add it as the minimum version. That way we don\u0027t need to do the whole lambda thing.\n\nWhat do you think?","commit_id":"6365c0a6b9f46fdb1f17c9d03d8896fcbaaadf0c"}],"releasenotes/notes/lock_path-940af881b2112bbe.yaml":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5e4b9b17a6a55683f9f4513605b868ac749554bf","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    os-brick file lock location can be specified independently of the Cinder"},{"line_number":5,"context_line":"    service lock location using ``lock_path`` in the ``[os_brick]``"},{"line_number":6,"context_line":"    configuration section.  Useful for HCI deployments and when running Cinder"},{"line_number":7,"context_line":"    and Glance with Cinder bakcned on the same same host."},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    On HCI deployments and when running Cinder and Glance with Cinder backend"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4a7d93da_6f3013bc","line":7,"range":{"start_line":7,"start_character":27,"end_line":7,"end_character":33},"updated":"2022-07-11 15:51:21.000000000","message":"backend","commit_id":"6365c0a6b9f46fdb1f17c9d03d8896fcbaaadf0c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"f7d3f3f409d02c441c3973b7e7b10bada0a85a03","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    os-brick file lock location can be specified independently of the Cinder"},{"line_number":5,"context_line":"    service lock location using ``lock_path`` in the ``[os_brick]``"},{"line_number":6,"context_line":"    configuration section.  Useful for HCI deployments and when running Cinder"},{"line_number":7,"context_line":"    and Glance with Cinder bakcned on the same same host."},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    On HCI deployments and when running Cinder and Glance with Cinder backend"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f4e20d77_643d2e96","line":7,"range":{"start_line":7,"start_character":27,"end_line":7,"end_character":33},"in_reply_to":"4a7d93da_6f3013bc","updated":"2022-07-12 09:29:33.000000000","message":"Ack","commit_id":"6365c0a6b9f46fdb1f17c9d03d8896fcbaaadf0c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"79a48e3a1f21e8c060079c6da4ec51455ddcf81c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    os-brick file lock location can be specified independently of the Cinder"},{"line_number":5,"context_line":"    service lock location using ``lock_path`` in the ``[os_brick]``"},{"line_number":6,"context_line":"    configuration section.  Useful for HCI deployments and when running Cinder"},{"line_number":7,"context_line":"    and Glance with Cinder backend on the same same host."},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    On HCI deployments and when running Cinder and Glance with Cinder backend"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"b9ff80fe_ce7cbc8f","line":7,"range":{"start_line":7,"start_character":42,"end_line":7,"end_character":46},"updated":"2022-09-09 19:43:20.000000000","message":"repeated \"same\"","commit_id":"2e74ad63afd23eb0bc8cd19debc10db26ae6ba5a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1f1c4c3a02978bfdad7621b55f2a98007e0b5d1e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    os-brick file lock location can be specified independently of the Cinder"},{"line_number":5,"context_line":"    service lock location using ``lock_path`` in the ``[os_brick]``"},{"line_number":6,"context_line":"    configuration section.  Useful for HCI deployments and when running Cinder"},{"line_number":7,"context_line":"    and Glance with Cinder backend on the same same host."},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    On HCI deployments and when running Cinder and Glance with Cinder backend"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"12d93e05_4ce3c6d3","line":7,"range":{"start_line":7,"start_character":42,"end_line":7,"end_character":46},"in_reply_to":"b9ff80fe_ce7cbc8f","updated":"2022-09-09 19:47:49.000000000","message":"Done","commit_id":"2e74ad63afd23eb0bc8cd19debc10db26ae6ba5a"}]}