)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"5925bf97570d2c3ba103ab4a4bf826eaec19a651","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9939573c_e70a8aba","updated":"2022-07-13 19:55:16.000000000","message":"recheck","commit_id":"3192967a694bb879749f7110307f7c5fac9bb688"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"6f7e18cadbc82a0d1f8c43ad6eec435464d5ddc1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2a7bd6ae_385e77d9","updated":"2022-07-20 20:41:18.000000000","message":"recheck","commit_id":"1439a8cf40122b443442f7eb00daddfe6e4c79b3"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"68198c09288afe7a6c77362f4e4e2d787a471e78","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"45c573d4_16f5f0ee","updated":"2022-07-27 15:07:13.000000000","message":"Downvote is only for the unnecessary changes from \u0027 to \" to enclose strings.","commit_id":"72977dfc1a91834c4c4d979d3708dee67e39a674"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"868bd2d977e8ca14402dca7e9b13361db1855fe8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fdbbf3d3_7ec13b4c","updated":"2022-07-27 14:25:20.000000000","message":"run-DellEMC PowerStore CI","commit_id":"72977dfc1a91834c4c4d979d3708dee67e39a674"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"394c63f2308e3658142b5afb52f324747f5e51a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"02cb6246_8e6a1aad","updated":"2022-07-29 17:21:08.000000000","message":"Looks good.","commit_id":"c54e6b26e1ba74aba9022844a6e2f17d533a8672"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"1cbee49e285357ed0f7421ed35321023dbce0495","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ea16156e_0d795643","updated":"2022-07-29 17:23:14.000000000","message":"Looks like the comments are resolved and the code is short and clean","commit_id":"c54e6b26e1ba74aba9022844a6e2f17d533a8672"}],"cinder/common/constants.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"68198c09288afe7a6c77362f4e4e2d787a471e78","unresolved":true,"context_lines":[{"line_number":28,"context_line":"LOG_BINARIES \u003d (SCHEDULER_BINARY, VOLUME_BINARY, BACKUP_BINARY, API_BINARY)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# The encryption key ID used by the legacy fixed-key ConfKeyMgr"},{"line_number":31,"context_line":"FIXED_KEY_ID \u003d \"00000000-0000-0000-0000-000000000000\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Storage protocol constants"},{"line_number":34,"context_line":"CEPH \u003d \"ceph\""},{"line_number":35,"context_line":"DRBD \u003d \"DRBD\""},{"line_number":36,"context_line":"FC \u003d \"FC\""},{"line_number":37,"context_line":"FC_VARIANT_1 \u003d \"fibre_channel\""},{"line_number":38,"context_line":"FC_VARIANT_2 \u003d \"fc\""},{"line_number":39,"context_line":"FILE \u003d \"file\""},{"line_number":40,"context_line":"ISCSI \u003d \"iSCSI\""},{"line_number":41,"context_line":"ISCSI_VARIANT \u003d \"iscsi\""},{"line_number":42,"context_line":"ISER \u003d \"iSER\""},{"line_number":43,"context_line":"LIGHTOS \u003d \"lightos\""},{"line_number":44,"context_line":"NFS \u003d \"NFS\""},{"line_number":45,"context_line":"NFS_VARIANT \u003d \"nfs\""},{"line_number":46,"context_line":"NVMEOF \u003d \"NVMe-oF\""},{"line_number":47,"context_line":"NVMEOF_VARIANT_1 \u003d \"NVMeOF\""},{"line_number":48,"context_line":"NVMEOF_VARIANT_2 \u003d \"nvmeof\""},{"line_number":49,"context_line":"NVMEOF_ROCE \u003d \"NVMe-RoCE\""},{"line_number":50,"context_line":"NVMEOF_FC \u003d \"NVMe-FC\""},{"line_number":51,"context_line":"NVMEOF_TCP \u003d \"NVMe-TCP\""}],"source_content_type":"text/x-python","patch_set":5,"id":"17d2ee15_741b4b25","line":48,"range":{"start_line":31,"start_character":0,"end_line":48,"end_character":27},"updated":"2022-07-27 15:07:13.000000000","message":"-1: These are unnecessary changes, and I happen to prefer using \u0027 instead of \"","commit_id":"72977dfc1a91834c4c4d979d3708dee67e39a674"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"cf24e6d2971e17702df63b53498a3210830646a7","unresolved":false,"context_lines":[{"line_number":28,"context_line":"LOG_BINARIES \u003d (SCHEDULER_BINARY, VOLUME_BINARY, BACKUP_BINARY, API_BINARY)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# The encryption key ID used by the legacy fixed-key ConfKeyMgr"},{"line_number":31,"context_line":"FIXED_KEY_ID \u003d \"00000000-0000-0000-0000-000000000000\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Storage protocol constants"},{"line_number":34,"context_line":"CEPH \u003d \"ceph\""},{"line_number":35,"context_line":"DRBD \u003d \"DRBD\""},{"line_number":36,"context_line":"FC \u003d \"FC\""},{"line_number":37,"context_line":"FC_VARIANT_1 \u003d \"fibre_channel\""},{"line_number":38,"context_line":"FC_VARIANT_2 \u003d \"fc\""},{"line_number":39,"context_line":"FILE \u003d \"file\""},{"line_number":40,"context_line":"ISCSI \u003d \"iSCSI\""},{"line_number":41,"context_line":"ISCSI_VARIANT \u003d \"iscsi\""},{"line_number":42,"context_line":"ISER \u003d \"iSER\""},{"line_number":43,"context_line":"LIGHTOS \u003d \"lightos\""},{"line_number":44,"context_line":"NFS \u003d \"NFS\""},{"line_number":45,"context_line":"NFS_VARIANT \u003d \"nfs\""},{"line_number":46,"context_line":"NVMEOF \u003d \"NVMe-oF\""},{"line_number":47,"context_line":"NVMEOF_VARIANT_1 \u003d \"NVMeOF\""},{"line_number":48,"context_line":"NVMEOF_VARIANT_2 \u003d \"nvmeof\""},{"line_number":49,"context_line":"NVMEOF_ROCE \u003d \"NVMe-RoCE\""},{"line_number":50,"context_line":"NVMEOF_FC \u003d \"NVMe-FC\""},{"line_number":51,"context_line":"NVMEOF_TCP \u003d \"NVMe-TCP\""}],"source_content_type":"text/x-python","patch_set":5,"id":"20477c51_db77cba7","line":48,"range":{"start_line":31,"start_character":0,"end_line":48,"end_character":27},"in_reply_to":"17d2ee15_741b4b25","updated":"2022-07-27 15:48:11.000000000","message":"autopep8 did this change.... i\u0027ll put it back","commit_id":"72977dfc1a91834c4c4d979d3708dee67e39a674"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"68198c09288afe7a6c77362f4e4e2d787a471e78","unresolved":true,"context_lines":[{"line_number":47,"context_line":"NVMEOF_VARIANT_1 \u003d \"NVMeOF\""},{"line_number":48,"context_line":"NVMEOF_VARIANT_2 \u003d \"nvmeof\""},{"line_number":49,"context_line":"NVMEOF_ROCE \u003d \"NVMe-RoCE\""},{"line_number":50,"context_line":"NVMEOF_FC \u003d \"NVMe-FC\""},{"line_number":51,"context_line":"NVMEOF_TCP \u003d \"NVMe-TCP\""},{"line_number":52,"context_line":"SCALEIO \u003d \"scaleio\""},{"line_number":53,"context_line":"SCSI \u003d \"SCSI\""}],"source_content_type":"text/x-python","patch_set":5,"id":"9dbeb160_86f0bc01","line":50,"range":{"start_line":50,"start_character":12,"end_line":50,"end_character":21},"updated":"2022-07-27 15:07:13.000000000","message":"I believe the standard is called \u0027FC-NVMe\u0027, but I\u0027ve seen it like this in enough places to consider it ok to use it here.  (Plus I prefer it in this format).","commit_id":"72977dfc1a91834c4c4d979d3708dee67e39a674"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"a0fc5d6dc0bdbe22d761985bb6f1bbc8a3bdf303","unresolved":false,"context_lines":[{"line_number":47,"context_line":"NVMEOF_VARIANT_1 \u003d \"NVMeOF\""},{"line_number":48,"context_line":"NVMEOF_VARIANT_2 \u003d \"nvmeof\""},{"line_number":49,"context_line":"NVMEOF_ROCE \u003d \"NVMe-RoCE\""},{"line_number":50,"context_line":"NVMEOF_FC \u003d \"NVMe-FC\""},{"line_number":51,"context_line":"NVMEOF_TCP \u003d \"NVMe-TCP\""},{"line_number":52,"context_line":"SCALEIO \u003d \"scaleio\""},{"line_number":53,"context_line":"SCSI \u003d \"SCSI\""}],"source_content_type":"text/x-python","patch_set":5,"id":"e60233b8_ef0561da","line":50,"range":{"start_line":50,"start_character":12,"end_line":50,"end_character":21},"in_reply_to":"9dbeb160_86f0bc01","updated":"2022-07-27 15:07:59.000000000","message":"(forgot to mark it as resolved, since there\u0027s nothing to do here)","commit_id":"72977dfc1a91834c4c4d979d3708dee67e39a674"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"cf24e6d2971e17702df63b53498a3210830646a7","unresolved":false,"context_lines":[{"line_number":47,"context_line":"NVMEOF_VARIANT_1 \u003d \"NVMeOF\""},{"line_number":48,"context_line":"NVMEOF_VARIANT_2 \u003d \"nvmeof\""},{"line_number":49,"context_line":"NVMEOF_ROCE \u003d \"NVMe-RoCE\""},{"line_number":50,"context_line":"NVMEOF_FC \u003d \"NVMe-FC\""},{"line_number":51,"context_line":"NVMEOF_TCP \u003d \"NVMe-TCP\""},{"line_number":52,"context_line":"SCALEIO \u003d \"scaleio\""},{"line_number":53,"context_line":"SCSI \u003d \"SCSI\""}],"source_content_type":"text/x-python","patch_set":5,"id":"ca98cf02_73c44eb1","line":50,"range":{"start_line":50,"start_character":12,"end_line":50,"end_character":21},"in_reply_to":"e60233b8_ef0561da","updated":"2022-07-27 15:48:11.000000000","message":"SNIA refernce these as NVMe-\u003cprotocol\u003e","commit_id":"72977dfc1a91834c4c4d979d3708dee67e39a674"}]}