)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":935,"name":"James Page","email":"ringo.page@gmail.com","username":"james-page"},"change_message_id":"8ba5348ee9502dca0e313c2528e46ab85e0871d6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"091962ec_0b148747","updated":"2022-07-22 14:14:59.000000000","message":"Other than the minor inconsistency between the release note and the code this LGTM.","commit_id":"663ffc3724c7da9b8b35271fa4df09209210f36b"},{"author":{"_account_id":28801,"name":"Cisco Cinder CI","email":"cisco-cinder-ci@cisco.com","username":"cisco-cinder-ci"},"change_message_id":"6a4c0a09b41bb82f9eb2e80f2a06ed9de6f9eeab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cc66cbf6_4006c4a2","updated":"2022-07-22 05:54:52.000000000","message":"cisco-cinder-ci","commit_id":"663ffc3724c7da9b8b35271fa4df09209210f36b"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"0948927a7709587b741e3bdacef12c0118d57bdc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c0c99ae6_1dc447c5","in_reply_to":"091962ec_0b148747","updated":"2022-07-31 13:27:46.000000000","message":"Hello James,\n\nThank you very much for the review!\nI did extensive testing of all available TLS/SSL options and found that InfiniSDK does not support certificate-based client authentication and non default path to a CA_BUNDLE file. So I removed the unsupported options and updated my pull request.\n\nThank you","commit_id":"663ffc3724c7da9b8b35271fa4df09209210f36b"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"ae7dc8a501c6a4dadb69ac96514303e78a219c16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"6c349c84_14f31050","updated":"2022-09-14 15:42:24.000000000","message":"Please resolve merge conflicts","commit_id":"98f52d72cf64351e3f006cd963d4e5c1c1a062e3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"49a70f557f9fa92f67da99165e087c058d4982c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"fd6b34f0_12d9ef9e","updated":"2022-09-06 19:31:16.000000000","message":"Some suggestions for test but that is a separate effort on it\u0027s own.\nCI passed, LGTM.","commit_id":"98f52d72cf64351e3f006cd963d4e5c1c1a062e3"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"42e75925ccca95c492f42b6f3f25db33e8507905","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"dd2c7579_0ff78ffb","updated":"2022-08-07 17:31:10.000000000","message":"recheck cinder-plugin-ceph-tempest","commit_id":"98f52d72cf64351e3f006cd963d4e5c1c1a062e3"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"c3d7aee2efcacac7d2cabb14f5a0d85d87c6fe67","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"e333f4e3_bfbb4490","in_reply_to":"6c349c84_14f31050","updated":"2022-09-15 00:00:04.000000000","message":"Hello Eric,\n\nThank you very much for the review!\nI fixed this comment in patch set 10.\nPlease review.\n\nThank you!","commit_id":"98f52d72cf64351e3f006cd963d4e5c1c1a062e3"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2ef3d295c36984cfbc50d849ceaba68ce81d6519","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"879b208c_c64a3f57","updated":"2022-09-15 13:48:36.000000000","message":"Code and tests look good.  Nice use of override_config in the unit tests, happy to see that.  CI is green.","commit_id":"ee67921a724c29a17e74f3112100c356e8c1312a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"67d751b5bd1983b4a5af73e783bacf6f1bf8675a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"5e757014_f10330fa","updated":"2022-09-15 07:40:16.000000000","message":"LGTM. My comments are addressed and CI is passing.","commit_id":"ee67921a724c29a17e74f3112100c356e8c1312a"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"ceefca99842068a3348ef59fd7148593c33e5234","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"40887609_a22f5279","updated":"2022-09-15 18:34:02.000000000","message":"recheck cinder-tempest-plugin-lvm-lio-barbican","commit_id":"ee67921a724c29a17e74f3112100c356e8c1312a"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"fc478120a5361f21123eb9e9b75ca9daa0b40368","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"bfdbaba2_fbe57c76","updated":"2022-09-15 15:39:47.000000000","message":"recheck tempest-integrated-storage","commit_id":"ee67921a724c29a17e74f3112100c356e8c1312a"}],"cinder/tests/unit/volume/drivers/test_infinidat.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"49a70f557f9fa92f67da99165e087c058d4982c4","unresolved":true,"context_lines":[{"line_number":86,"context_line":"        self.configuration.san_thin_provision \u003d True"},{"line_number":87,"context_line":"        self.configuration.san_login \u003d \u0027user\u0027"},{"line_number":88,"context_line":"        self.configuration.san_password \u003d \u0027pass\u0027"},{"line_number":89,"context_line":"        self.configuration.driver_use_ssl \u003d True"},{"line_number":90,"context_line":"        self.configuration.volume_backend_name \u003d \u0027mock\u0027"},{"line_number":91,"context_line":"        self.configuration.volume_dd_blocksize \u003d \u00271M\u0027"},{"line_number":92,"context_line":"        self.configuration.use_multipath_for_image_xfer \u003d False"}],"source_content_type":"text/x-python","patch_set":9,"id":"76ecae4a_e63d7b1d","line":89,"range":{"start_line":89,"start_character":8,"end_line":89,"end_character":48},"updated":"2022-09-06 19:31:16.000000000","message":"Since it is done similarly for all config options, I won\u0027t block for this but we use override_config to set a config value for a particular test\n\n    self.override_config(\u0027driver_use_ssl\u0027, True)","commit_id":"98f52d72cf64351e3f006cd963d4e5c1c1a062e3"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"c3d7aee2efcacac7d2cabb14f5a0d85d87c6fe67","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        self.configuration.san_thin_provision \u003d True"},{"line_number":87,"context_line":"        self.configuration.san_login \u003d \u0027user\u0027"},{"line_number":88,"context_line":"        self.configuration.san_password \u003d \u0027pass\u0027"},{"line_number":89,"context_line":"        self.configuration.driver_use_ssl \u003d True"},{"line_number":90,"context_line":"        self.configuration.volume_backend_name \u003d \u0027mock\u0027"},{"line_number":91,"context_line":"        self.configuration.volume_dd_blocksize \u003d \u00271M\u0027"},{"line_number":92,"context_line":"        self.configuration.use_multipath_for_image_xfer \u003d False"}],"source_content_type":"text/x-python","patch_set":9,"id":"3d76ed79_7ec682ad","line":89,"range":{"start_line":89,"start_character":8,"end_line":89,"end_character":48},"in_reply_to":"76ecae4a_e63d7b1d","updated":"2022-09-15 00:00:04.000000000","message":"Hello Rajat,\n\nThank you very much for the review!\nYes, I agree with you!\nI fixed this comment in patch set 10.\nPlease review.\n\nThank you!","commit_id":"98f52d72cf64351e3f006cd963d4e5c1c1a062e3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"49a70f557f9fa92f67da99165e087c058d4982c4","unresolved":true,"context_lines":[{"line_number":203,"context_line":"        self.driver.do_setup(None)"},{"line_number":204,"context_line":"        infinibox.assert_called_once_with("},{"line_number":205,"context_line":"            self.configuration.san_ip, auth\u003dauth,"},{"line_number":206,"context_line":"            use_ssl\u003dself.configuration.driver_use_ssl)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def test_initialize_connection(self):"},{"line_number":209,"context_line":"        self._system.hosts.safe_get.return_value \u003d None"}],"source_content_type":"text/x-python","patch_set":9,"id":"71dea9ea_7d038edb","line":206,"range":{"start_line":206,"start_character":20,"end_line":206,"end_character":53},"updated":"2022-09-06 19:31:16.000000000","message":"Since we\u0027re setting it to True, this will only assert for True which is Fine but would\u0027ve been better with a DDT supplying True/False values and we could use override_config to set and assert it inside the test.","commit_id":"98f52d72cf64351e3f006cd963d4e5c1c1a062e3"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"c3d7aee2efcacac7d2cabb14f5a0d85d87c6fe67","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        self.driver.do_setup(None)"},{"line_number":204,"context_line":"        infinibox.assert_called_once_with("},{"line_number":205,"context_line":"            self.configuration.san_ip, auth\u003dauth,"},{"line_number":206,"context_line":"            use_ssl\u003dself.configuration.driver_use_ssl)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def test_initialize_connection(self):"},{"line_number":209,"context_line":"        self._system.hosts.safe_get.return_value \u003d None"}],"source_content_type":"text/x-python","patch_set":9,"id":"86f1b44a_bc14b1fb","line":206,"range":{"start_line":206,"start_character":20,"end_line":206,"end_character":53},"in_reply_to":"71dea9ea_7d038edb","updated":"2022-09-15 00:00:04.000000000","message":"Hello Rajat,\n\nThank you very much for the review!\nYes, I agree with you!\nI fixed this comment in patch set 10.\nPlease review.\n\nThank you!","commit_id":"98f52d72cf64351e3f006cd963d4e5c1c1a062e3"}],"cinder/volume/drivers/infinidat.py":[{"author":{"_account_id":935,"name":"James Page","email":"ringo.page@gmail.com","username":"james-page"},"change_message_id":"fd026204e6562728ad3002071973444ce7444da2","unresolved":true,"context_lines":[{"line_number":135,"context_line":"        additional_opts \u003d cls._get_oslo_driver_opts("},{"line_number":136,"context_line":"            \u0027san_ip\u0027, \u0027san_login\u0027, \u0027san_password\u0027, \u0027use_chap_auth\u0027,"},{"line_number":137,"context_line":"            \u0027chap_username\u0027, \u0027chap_password\u0027, \u0027san_thin_provision\u0027,"},{"line_number":138,"context_line":"            \u0027driver_use_ssl\u0027, \u0027driver_ssl_cert_path\u0027,"},{"line_number":139,"context_line":"            \u0027use_multipath_for_image_xfer\u0027, \u0027enforce_multipath_for_image_xfer\u0027,"},{"line_number":140,"context_line":"            \u0027num_volume_device_scan_tries\u0027, \u0027volume_dd_blocksize\u0027,"},{"line_number":141,"context_line":"            \u0027max_over_subscription_ratio\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"97b26fb2_8f547ea6","line":138,"range":{"start_line":138,"start_character":12,"end_line":138,"end_character":52},"updated":"2022-07-20 18:15:00.000000000","message":"The drive_ prefix here seems superfluous - these are all driver specific extra options so use_ssl and ssl_cert_path would seem sufficient.","commit_id":"525e41c67402f5189930878f1c01911c72d1e27c"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"5f1a1c6452da173183094daa5295905fefa5b68c","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        additional_opts \u003d cls._get_oslo_driver_opts("},{"line_number":136,"context_line":"            \u0027san_ip\u0027, \u0027san_login\u0027, \u0027san_password\u0027, \u0027use_chap_auth\u0027,"},{"line_number":137,"context_line":"            \u0027chap_username\u0027, \u0027chap_password\u0027, \u0027san_thin_provision\u0027,"},{"line_number":138,"context_line":"            \u0027driver_use_ssl\u0027, \u0027driver_ssl_cert_path\u0027,"},{"line_number":139,"context_line":"            \u0027use_multipath_for_image_xfer\u0027, \u0027enforce_multipath_for_image_xfer\u0027,"},{"line_number":140,"context_line":"            \u0027num_volume_device_scan_tries\u0027, \u0027volume_dd_blocksize\u0027,"},{"line_number":141,"context_line":"            \u0027max_over_subscription_ratio\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"706b197c_60dfaa65","line":138,"range":{"start_line":138,"start_character":12,"end_line":138,"end_character":52},"in_reply_to":"97b26fb2_8f547ea6","updated":"2022-07-21 07:24:35.000000000","message":"Hello James,\n\nThank you very much for the review!\nI double checked and found that use_ssl option is valid only for vault (castellan) section. And there is no ssl_cert_path option.\n\nReference: https://docs.openstack.org/cinder/latest/configuration/block-storage/samples/cinder.conf.html\n\nSo for the driver code we can use the recommended options:\ndriver_use_ssl and driver_ssl_cert_verify.\n\nReference: https://opendev.org/openstack/cinder/src/branch/master/cinder/volume/driver.py#L151\n\nThank you!","commit_id":"525e41c67402f5189930878f1c01911c72d1e27c"}],"releasenotes/notes/bug-1981982-infinidat-fix-ssl-options-6ddd852c24b16760.yaml":[{"author":{"_account_id":935,"name":"James Page","email":"ringo.page@gmail.com","username":"james-page"},"change_message_id":"350ef38d9e01a3b142cb970f2022a44d0e623cbe","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Infinidat Driver `bug #1981982"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/1981982\u003e`_:"},{"line_number":6,"context_line":"    Fixed Infinidat driver to use SSL options."},{"line_number":7,"context_line":"    Admin can set `True` or `False` for `driver_ssl_cert_verify`"},{"line_number":8,"context_line":"    to enable or disable this feature and alternatively set the"},{"line_number":9,"context_line":"    `driver_ssl_cert_path\u003d\u003cPATH\u003e` to configure the CA path."},{"line_number":10,"context_line":"    Both of the above two options should be in the driver section."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"8a90245f_9366acf4","line":7,"range":{"start_line":7,"start_character":41,"end_line":7,"end_character":63},"updated":"2022-07-21 15:42:06.000000000","message":"driver_use_ssl","commit_id":"663ffc3724c7da9b8b35271fa4df09209210f36b"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"0948927a7709587b741e3bdacef12c0118d57bdc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Infinidat Driver `bug #1981982"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/1981982\u003e`_:"},{"line_number":6,"context_line":"    Fixed Infinidat driver to use SSL options."},{"line_number":7,"context_line":"    Admin can set `True` or `False` for `driver_ssl_cert_verify`"},{"line_number":8,"context_line":"    to enable or disable this feature and alternatively set the"},{"line_number":9,"context_line":"    `driver_ssl_cert_path\u003d\u003cPATH\u003e` to configure the CA path."},{"line_number":10,"context_line":"    Both of the above two options should be in the driver section."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5cc47702_e2aab06a","line":7,"range":{"start_line":7,"start_character":41,"end_line":7,"end_character":63},"in_reply_to":"8a90245f_9366acf4","updated":"2022-07-31 13:27:46.000000000","message":"Hello James,\n\nThank you very much for the review!\nFixed in the patchset 4.\n\nThank you","commit_id":"663ffc3724c7da9b8b35271fa4df09209210f36b"}]}