)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"ad710dac832651d1e79f059427b9587f99f20af2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5ce71d22_6b0338be","updated":"2022-07-15 16:28:03.000000000","message":"Any consideration for the suggestion I raised in the first comment -- just not storing credentials in a temp file and using Cinder DB fields instead?","commit_id":"74c48e4ee71cb0752214ee72bc51c8538c79ad25"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"9c302b2971a305267027a4149a0374351926fa65","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8d4be01b_6efe32b6","updated":"2022-07-15 14:30:24.000000000","message":"Assuming this passes the CI then It is simple enough","commit_id":"74c48e4ee71cb0752214ee72bc51c8538c79ad25"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"dc4e2c3cd401bf2460d39a0c119e71de8bc575c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"19d16683_690cd080","updated":"2022-11-16 12:22:41.000000000","message":"Doc note looks good! ","commit_id":"74c48e4ee71cb0752214ee72bc51c8538c79ad25"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"bcefe92d34ffdb84f79b162b3f1ec3baef391ef1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"951082f8_f8a16eee","updated":"2022-07-15 14:34:58.000000000","message":"I think Eric raised this concern at some point, good to get this documented somewhere. LGTM.","commit_id":"74c48e4ee71cb0752214ee72bc51c8538c79ad25"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"bdaf86f66ce6c425fcb0a6a23fdd74f4aa03453a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ad085fef_b934f5fc","updated":"2022-11-10 15:57:06.000000000","message":"LGTM","commit_id":"74c48e4ee71cb0752214ee72bc51c8538c79ad25"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8e6864eedd348842b4e64975c613e8e9e065e573","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"395764c0_3a35cc3a","updated":"2022-07-14 14:59:44.000000000","message":"Note to DataCore maintainers -- I think you could store the CHAP secrets in the provider_location/provider_auth fields like the Cinder LVM driver does and not need an external file.  Has this been considered?","commit_id":"74c48e4ee71cb0752214ee72bc51c8538c79ad25"},{"author":{"_account_id":22248,"name":"HPE AlletraMP iSCSI CI","email":"hp.cinder.blr.ci@groups.ext.hpe.com","username":"hp-storage-blr-ci","tags":["SERVICE_USER"]},"change_message_id":"9504a11c27c395bf2b4b5ddb64c35cfea9212a0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6727fe2a_2a543eb0","updated":"2022-07-21 10:22:21.000000000","message":"run-HPE Nimble Storage CI","commit_id":"74c48e4ee71cb0752214ee72bc51c8538c79ad25"},{"author":{"_account_id":22248,"name":"HPE AlletraMP iSCSI CI","email":"hp.cinder.blr.ci@groups.ext.hpe.com","username":"hp-storage-blr-ci","tags":["SERVICE_USER"]},"change_message_id":"ca77879cbef6100bc544d7d6d97ce73872145510","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"48ee68a6_ad5b47d1","updated":"2022-07-21 10:16:39.000000000","message":"run-Nimble Storage Alletra 6k CI","commit_id":"74c48e4ee71cb0752214ee72bc51c8538c79ad25"},{"author":{"_account_id":34791,"name":"Arun KV","email":"arun.kv@datacore.com","username":"dcarun"},"change_message_id":"00aa0c31b6a94e9573f5fed895592e6a4cdd124a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2493114c_b4b94daa","in_reply_to":"395764c0_3a35cc3a","updated":"2022-07-15 05:03:32.000000000","message":"We tested the driver with multiple backends and it works. $state_path/.datacore_chap will store chap details for all the backend server. below details are from $state_path/.datacore_chap which has multiple SSY backend servers.\n\n{\"145ca74e-e32e-4042-ab97-ff6a8debe946\": {\"iqn.2005-03.org.open-iscsi:ff64e86663b\": \"Dkb3bNnsUKCE8oG\"}, \"1fb6e280-0b7e-457f-8737-ac2f195f7a45\": {\"iqn.2005-03.org.open-iscsi:ff64e86663b\": \"5NKbh44wgn6ZzQ5\"}}\n\n145ca74e-e32e-4042-ab97-ff6a8debe946,1fb6e280-0b7e-457f-8737-ac2f195f7a45 these are the SSY server uuid.","commit_id":"74c48e4ee71cb0752214ee72bc51c8538c79ad25"},{"author":{"_account_id":34791,"name":"Arun KV","email":"arun.kv@datacore.com","username":"dcarun"},"change_message_id":"35816e84c8670d62a1802cee39acf2433503abba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"adc053d0_915c7be3","in_reply_to":"5ce71d22_6b0338be","updated":"2022-07-18 08:20:56.000000000","message":"Sure Eric. I will work on it. Thanks.","commit_id":"74c48e4ee71cb0752214ee72bc51c8538c79ad25"},{"author":{"_account_id":34791,"name":"Arun KV","email":"arun.kv@datacore.com","username":"dcarun"},"change_message_id":"8107c8b3ad6930b21349353244a36a944952dc32","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f4fdd835_66cc7f8e","in_reply_to":"adc053d0_915c7be3","updated":"2022-07-21 11:50:42.000000000","message":"Hi Eric, sorry, I have some confusion about the provider_auth,\n\nIn $state_path/.datacore_chap we are storing the \"autogenerated\" CHAP credentials for an Initiator node. This happens only when in cinder.conf use_chap_auth\u003dTrue and chap_username and chap_password are not set.\n\nNow if I store this autogenerated credentials in \u0027provider_auth\u0027 then how to retrieve the previous autogenerated password  when a new volume is created(because I should not generated a new password again, as the previous password is already set in the DataCore server)\n\nIs there any other global location where I can store this information?","commit_id":"74c48e4ee71cb0752214ee72bc51c8538c79ad25"}],"cinder/volume/drivers/datacore/iscsi.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"0c8c042fa9032b95c13c3f599e38633c76051a05","unresolved":true,"context_lines":[{"line_number":45,"context_line":"    cfg.StrOpt(\u0027datacore_iscsi_chap_storage\u0027,"},{"line_number":46,"context_line":"               default\u003d\u0027$state_path/.datacore_chap\u0027,"},{"line_number":47,"context_line":"               help\u003d\u0027Fully qualified file name where dynamically generated \u0027"},{"line_number":48,"context_line":"                    \u0027iSCSI CHAP secrets are stored.  This must be changed \u0027"},{"line_number":49,"context_line":"                    \u0027to a unique per-backend value if deploying multiple \u0027"},{"line_number":50,"context_line":"                    \u0027DataCore backends on the same host.\u0027),"},{"line_number":51,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"36b828f6_73e93fe3","line":48,"range":{"start_line":48,"start_character":53,"end_line":48,"end_character":73},"updated":"2022-11-04 02:19:25.000000000","message":"Would it make more sense to update the driver to write out unique names inside the same base folder? This seems like it puts unnecessary burden on the administrator.","commit_id":"74c48e4ee71cb0752214ee72bc51c8538c79ad25"}]}