)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32074,"name":"Harsh Ailani","email":"haailani@in.ibm.com","username":"haailani"},"change_message_id":"e73196feffbfe7b07582cfed70ca40bfd70f1aea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"26fa6e80_33ee7baa","updated":"2022-09-15 08:08:36.000000000","message":"As the IBM CI physically down, the UTs will be added for this fix in the upcoming review. For now this code fixes the bug that the customer is facing.\nSame has been informed on the IRC Channel and its approved.","commit_id":"374efd15798beefbf95754d7950e782a53f88553"},{"author":{"_account_id":32425,"name":"saikrishnagk","email":"gopalakrishna.krishna@ibm.com","username":"gksk"},"change_message_id":"f1158c773f077ab4fa5aa0598021f88225251ced","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0364bf55_936572c8","updated":"2022-08-12 03:31:54.000000000","message":"CI Passed","commit_id":"374efd15798beefbf95754d7950e782a53f88553"},{"author":{"_account_id":34201,"name":"Mounika Sreeram","email":"sreeram.mounika@ibm.com","username":"sreerammounika"},"change_message_id":"a07650f2b9260100f12520e2bd71cb6a81ca0f59","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"58909b38_65e95e56","updated":"2022-08-12 08:08:05.000000000","message":"CI passed. LGTM","commit_id":"374efd15798beefbf95754d7950e782a53f88553"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4337f9d17211f1f7347d9345e7705e299e203a98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f7f3469b_9a34fa12","updated":"2022-09-15 13:38:58.000000000","message":"Change addresses the bug and looks like it doesn\u0027t break anything for anyone else (Zuul is green), and you have confirmation from your customer that it is working as expected.  Please do follow up on the tests you\u0027ve promised to add, however.","commit_id":"374efd15798beefbf95754d7950e782a53f88553"},{"author":{"_account_id":34201,"name":"Mounika Sreeram","email":"sreeram.mounika@ibm.com","username":"sreerammounika"},"change_message_id":"1fbe418171e3830b57a6ffd19f2806bb6e7a071c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1f171b50_42847585","updated":"2022-07-29 06:35:04.000000000","message":"Code looks good. Once UT\u0027s are done and CI passed, will change to +1","commit_id":"374efd15798beefbf95754d7950e782a53f88553"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"84da7ab19bc70ec938e6c800079b1369e338e296","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8d7ed4fc_57bc4399","updated":"2022-09-15 08:10:16.000000000","message":"I\u0027ve talked to Harsh on IRC and since their CI is currently down, they\u0027ve agreed to add a UT in a followup patch. apart from that CI is green on this and code LGTM.","commit_id":"374efd15798beefbf95754d7950e782a53f88553"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"bf8cd59dc90a1435e0c78881a56b4edd126fca4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b1881641_5c239b69","updated":"2022-09-01 15:25:07.000000000","message":"LGTM","commit_id":"374efd15798beefbf95754d7950e782a53f88553"},{"author":{"_account_id":32074,"name":"Harsh Ailani","email":"haailani@in.ibm.com","username":"haailani"},"change_message_id":"121bd9c3b832c83d7e4038fda47cc010cd88251a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cff8efe3_7554554d","updated":"2022-07-19 10:43:26.000000000","message":"Please Note: UTs will be provided after i get a confirmation from the customer.","commit_id":"374efd15798beefbf95754d7950e782a53f88553"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"c6bfb5122e2969fad12d9d17e22a2c6ab466b3ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8a0adf2a_4ff30154","updated":"2022-11-15 13:22:26.000000000","message":"Should this fix be backported to the older branches? If so, please start the backporting process.","commit_id":"374efd15798beefbf95754d7950e782a53f88553"},{"author":{"_account_id":34760,"name":"Stephane Vigan","email":"svigan@redhat.com","username":"svigan"},"change_message_id":"59d940c20ba171c0782555874964dad0be846af5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c144a92e_6aeae249","updated":"2022-09-01 14:35:50.000000000","message":"Tested with IBM storwize code level 8.4.2.1 and RHSOP 16.2.2","commit_id":"374efd15798beefbf95754d7950e782a53f88553"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"51f88015e2565564ddae10c2c0a41ce35198a640","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"580d181f_4488b3e9","updated":"2022-09-15 08:05:11.000000000","message":"We need a test to see if overriding the config option passes the right value during initialization","commit_id":"374efd15798beefbf95754d7950e782a53f88553"},{"author":{"_account_id":32425,"name":"saikrishnagk","email":"gopalakrishna.krishna@ibm.com","username":"gksk"},"change_message_id":"1ba77b80e5ab5dc0ef9be37625eb75bdc68be537","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0f1c06e3_a2169600","updated":"2022-08-12 00:53:48.000000000","message":"run-IBM Storage CI","commit_id":"374efd15798beefbf95754d7950e782a53f88553"},{"author":{"_account_id":32425,"name":"saikrishnagk","email":"gopalakrishna.krishna@ibm.com","username":"gksk"},"change_message_id":"c2bd28e1beb0bfdb2469c09e02a409d626b86c63","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7ec285e1_1fe3a1dd","updated":"2022-08-11 18:37:35.000000000","message":"run-IBM Storage CI","commit_id":"374efd15798beefbf95754d7950e782a53f88553"}],"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"51f88015e2565564ddae10c2c0a41ce35198a640","unresolved":true,"context_lines":[{"line_number":3382,"context_line":"        state[\u0027storage_nodes\u0027] \u003d helper.get_node_info()"},{"line_number":3383,"context_line":""},{"line_number":3384,"context_line":"        # Add the iSCSI IP addresses and WWPNs to the storage node info"},{"line_number":3385,"context_line":"        helper.add_iscsi_ip_addrs(state[\u0027storage_nodes\u0027], state[\u0027code_level\u0027],"},{"line_number":3386,"context_line":"                                  portset\u003dself._storwize_portset)"},{"line_number":3387,"context_line":"        helper.add_fc_wwpns(state[\u0027storage_nodes\u0027], state[\u0027code_level\u0027])"},{"line_number":3388,"context_line":""},{"line_number":3389,"context_line":"        # For each node, check what connection modes it supports.  Delete any"}],"source_content_type":"text/x-python","patch_set":1,"id":"f56b32fb_ccfdfecc","line":3386,"range":{"start_line":3385,"start_character":8,"end_line":3386,"end_character":65},"updated":"2022-09-15 08:05:11.000000000","message":"there should be a test for this checking if the configured value is passed or not","commit_id":"374efd15798beefbf95754d7950e782a53f88553"},{"author":{"_account_id":32074,"name":"Harsh Ailani","email":"haailani@in.ibm.com","username":"haailani"},"change_message_id":"1225d5471b815e0a8c6d04598c3b7ec366da18db","unresolved":false,"context_lines":[{"line_number":3382,"context_line":"        state[\u0027storage_nodes\u0027] \u003d helper.get_node_info()"},{"line_number":3383,"context_line":""},{"line_number":3384,"context_line":"        # Add the iSCSI IP addresses and WWPNs to the storage node info"},{"line_number":3385,"context_line":"        helper.add_iscsi_ip_addrs(state[\u0027storage_nodes\u0027], state[\u0027code_level\u0027],"},{"line_number":3386,"context_line":"                                  portset\u003dself._storwize_portset)"},{"line_number":3387,"context_line":"        helper.add_fc_wwpns(state[\u0027storage_nodes\u0027], state[\u0027code_level\u0027])"},{"line_number":3388,"context_line":""},{"line_number":3389,"context_line":"        # For each node, check what connection modes it supports.  Delete any"}],"source_content_type":"text/x-python","patch_set":1,"id":"4f14cb21_fbcfcd01","line":3386,"range":{"start_line":3385,"start_character":8,"end_line":3386,"end_character":65},"in_reply_to":"f56b32fb_ccfdfecc","updated":"2022-09-15 08:12:57.000000000","message":"As the IBM CI physical server is down, the UTs will be added for this fix in the upcoming review. For now this code fixes the bug that the customer is facing.\nSame has been informed on the IRC Channel and its approved.","commit_id":"374efd15798beefbf95754d7950e782a53f88553"}]}
