)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"408e1d55a0bb22a8bab796bed544f1e0af6bc532","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     yangzhe \u003c17839227138@163.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-07-21 15:22:54 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":" reimage api image  invalid,volume status rollback"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I08093238df618772f240b0685d98b7a8079e9b81"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fcb2a4c4_5a69adca","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":50},"updated":"2022-07-21 15:05:56.000000000","message":"need a more clear heading like\n\n\"Add volume status rollback in reimage API\"\n\nAlso requires description and Closes-Bug tag","commit_id":"eba6fe5c4e28eb551b5137073b0b37cc75b1bab8"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4ca7cb47c5cb07627fff944ce70536ac4c43efbf","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     yangzhe \u003c17839227138@163.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-07-21 15:22:54 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":" reimage api image  invalid,volume status rollback"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I08093238df618772f240b0685d98b7a8079e9b81"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"68b450cb_a7037f1c","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":50},"in_reply_to":"fcb2a4c4_5a69adca","updated":"2022-08-02 08:31:26.000000000","message":"Done","commit_id":"eba6fe5c4e28eb551b5137073b0b37cc75b1bab8"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5c50a07df09b998a00f754676c0491d5f0013c90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"236fbf03_30a5bcf6","updated":"2022-07-21 04:58:53.000000000","message":"Thanks for working on this.\nApart from the inline changes mentioned, it requires a unit test and releasenote as well.","commit_id":"bd47e56ec24ca6ee421d197d981a47814ad14022"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"87716f1aa93aaec5cba3f722434dc83ca9a952db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1b4c6b8d_77756f33","updated":"2022-07-21 06:07:43.000000000","message":"my comments from last PS still apply","commit_id":"aa059119e69c0df27a42624dec0c37ad712a074d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"408e1d55a0bb22a8bab796bed544f1e0af6bc532","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cfa7f0ce_92b68ac1","updated":"2022-07-21 15:05:56.000000000","message":"Lot of unrelated changes since last patchset, please restore them.\nstill requires unit test and releasenote","commit_id":"eba6fe5c4e28eb551b5137073b0b37cc75b1bab8"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4ca7cb47c5cb07627fff944ce70536ac4c43efbf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f250fa0c_d8034431","in_reply_to":"cfa7f0ce_92b68ac1","updated":"2022-08-02 08:31:26.000000000","message":"Done","commit_id":"eba6fe5c4e28eb551b5137073b0b37cc75b1bab8"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4ca7cb47c5cb07627fff944ce70536ac4c43efbf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"75621bdd_3979fea1","updated":"2022-08-02 08:31:26.000000000","message":"Updated with tests and releasenote, also addressed the pep8 failure.","commit_id":"064cbadafa54e7c74cac1c1c3fc4f648dfaab296"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"1ece52429656cd4c1e62a2ecda3515433e810b01","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e5605b19_7a5e50b8","updated":"2022-08-04 07:05:28.000000000","message":"Minor query inline.\n","commit_id":"36fab54725ca03a6dbb814678798302381307ce3"}],"cinder/volume/api.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5c50a07df09b998a00f754676c0491d5f0013c90","unresolved":true,"context_lines":[{"line_number":2566,"context_line":"        values \u003d {\u0027status\u0027: \u0027downloading\u0027,"},{"line_number":2567,"context_line":"                  \u0027previous_status\u0027: volume.model.status}"},{"line_number":2568,"context_line":""},{"line_number":2569,"context_line":"        previous_status \u003d volume.model.status"},{"line_number":2570,"context_line":"        values \u003d {\u0027status\u0027: \u0027downloading\u0027,"},{"line_number":2571,"context_line":"                  \u0027previous_status\u0027: previous_status}"},{"line_number":2572,"context_line":""},{"line_number":2573,"context_line":"        result \u003d volume.conditional_update(values, expected)"},{"line_number":2574,"context_line":"        if not result:"}],"source_content_type":"text/x-python","patch_set":2,"id":"c7999cd8_e7ec5076","line":2571,"range":{"start_line":2569,"start_character":8,"end_line":2571,"end_character":53},"updated":"2022-07-21 04:58:53.000000000","message":"this is same as above two lines with a new variable previous_status\ni think you should remove the above similar lines","commit_id":"bd47e56ec24ca6ee421d197d981a47814ad14022"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4ca7cb47c5cb07627fff944ce70536ac4c43efbf","unresolved":false,"context_lines":[{"line_number":2566,"context_line":"        values \u003d {\u0027status\u0027: \u0027downloading\u0027,"},{"line_number":2567,"context_line":"                  \u0027previous_status\u0027: volume.model.status}"},{"line_number":2568,"context_line":""},{"line_number":2569,"context_line":"        previous_status \u003d volume.model.status"},{"line_number":2570,"context_line":"        values \u003d {\u0027status\u0027: \u0027downloading\u0027,"},{"line_number":2571,"context_line":"                  \u0027previous_status\u0027: previous_status}"},{"line_number":2572,"context_line":""},{"line_number":2573,"context_line":"        result \u003d volume.conditional_update(values, expected)"},{"line_number":2574,"context_line":"        if not result:"}],"source_content_type":"text/x-python","patch_set":2,"id":"0f57f97b_e4d3cd0b","line":2571,"range":{"start_line":2569,"start_character":8,"end_line":2571,"end_character":53},"in_reply_to":"c7999cd8_e7ec5076","updated":"2022-08-02 08:31:26.000000000","message":"Done","commit_id":"bd47e56ec24ca6ee421d197d981a47814ad14022"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5c50a07df09b998a00f754676c0491d5f0013c90","unresolved":true,"context_lines":[{"line_number":2582,"context_line":"            image_meta \u003d self.image_service.show(context, image_id)"},{"line_number":2583,"context_line":"            volume_utils.check_image_metadata(image_meta, volume[\u0027size\u0027])"},{"line_number":2584,"context_line":"        except Exception as err:"},{"line_number":2585,"context_line":"            result \u003d volume.conditional_update({\u0027status\u0027: previous_status, \u0027previous_status\u0027: \u0027downloading\u0027},"},{"line_number":2586,"context_line":"                                               {\u0027status\u0027: \u0027downloading\u0027})"},{"line_number":2587,"context_line":"            if not result:"},{"line_number":2588,"context_line":"                msg \u003d (_(\u0027Volume %(vol_id)s status must be %(statuses)s, but \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"8bbadcea_7e2af246","line":2585,"range":{"start_line":2585,"start_character":47,"end_line":2585,"end_character":108},"updated":"2022-07-21 04:58:53.000000000","message":"This is exceeding pep8 character limit (i.e. 79 chars)\nbetter create a new dict,\n\nrollback_values \u003d {\u0027status\u0027: previous_status, \u0027previous_status\u0027: \u0027downloading\u0027}","commit_id":"bd47e56ec24ca6ee421d197d981a47814ad14022"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4ca7cb47c5cb07627fff944ce70536ac4c43efbf","unresolved":false,"context_lines":[{"line_number":2582,"context_line":"            image_meta \u003d self.image_service.show(context, image_id)"},{"line_number":2583,"context_line":"            volume_utils.check_image_metadata(image_meta, volume[\u0027size\u0027])"},{"line_number":2584,"context_line":"        except Exception as err:"},{"line_number":2585,"context_line":"            result \u003d volume.conditional_update({\u0027status\u0027: previous_status, \u0027previous_status\u0027: \u0027downloading\u0027},"},{"line_number":2586,"context_line":"                                               {\u0027status\u0027: \u0027downloading\u0027})"},{"line_number":2587,"context_line":"            if not result:"},{"line_number":2588,"context_line":"                msg \u003d (_(\u0027Volume %(vol_id)s status must be %(statuses)s, but \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"fe492498_57f71cbd","line":2585,"range":{"start_line":2585,"start_character":47,"end_line":2585,"end_character":108},"in_reply_to":"8bbadcea_7e2af246","updated":"2022-08-02 08:31:26.000000000","message":"Done","commit_id":"bd47e56ec24ca6ee421d197d981a47814ad14022"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5c50a07df09b998a00f754676c0491d5f0013c90","unresolved":true,"context_lines":[{"line_number":2583,"context_line":"            volume_utils.check_image_metadata(image_meta, volume[\u0027size\u0027])"},{"line_number":2584,"context_line":"        except Exception as err:"},{"line_number":2585,"context_line":"            result \u003d volume.conditional_update({\u0027status\u0027: previous_status, \u0027previous_status\u0027: \u0027downloading\u0027},"},{"line_number":2586,"context_line":"                                               {\u0027status\u0027: \u0027downloading\u0027})"},{"line_number":2587,"context_line":"            if not result:"},{"line_number":2588,"context_line":"                msg \u003d (_(\u0027Volume %(vol_id)s status must be %(statuses)s, but \u0027"},{"line_number":2589,"context_line":"                         \u0027current status is %(status)s.\u0027) %"}],"source_content_type":"text/x-python","patch_set":2,"id":"bd300865_f9a3bb6e","line":2586,"range":{"start_line":2586,"start_character":47,"end_line":2586,"end_character":72},"updated":"2022-07-21 04:58:53.000000000","message":"would be good to define this as a variable as well\n\nexpected_rollback \u003d {\u0027status\u0027: \u0027downloading\u0027}","commit_id":"bd47e56ec24ca6ee421d197d981a47814ad14022"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4ca7cb47c5cb07627fff944ce70536ac4c43efbf","unresolved":false,"context_lines":[{"line_number":2583,"context_line":"            volume_utils.check_image_metadata(image_meta, volume[\u0027size\u0027])"},{"line_number":2584,"context_line":"        except Exception as err:"},{"line_number":2585,"context_line":"            result \u003d volume.conditional_update({\u0027status\u0027: previous_status, \u0027previous_status\u0027: \u0027downloading\u0027},"},{"line_number":2586,"context_line":"                                               {\u0027status\u0027: \u0027downloading\u0027})"},{"line_number":2587,"context_line":"            if not result:"},{"line_number":2588,"context_line":"                msg \u003d (_(\u0027Volume %(vol_id)s status must be %(statuses)s, but \u0027"},{"line_number":2589,"context_line":"                         \u0027current status is %(status)s.\u0027) %"}],"source_content_type":"text/x-python","patch_set":2,"id":"e1f7aa9b_f9a69171","line":2586,"range":{"start_line":2586,"start_character":47,"end_line":2586,"end_character":72},"in_reply_to":"bd300865_f9a3bb6e","updated":"2022-08-02 08:31:26.000000000","message":"Done","commit_id":"bd47e56ec24ca6ee421d197d981a47814ad14022"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"1ece52429656cd4c1e62a2ecda3515433e810b01","unresolved":true,"context_lines":[{"line_number":2588,"context_line":"                msg \u003d (_(\u0027Volume %(vol_id)s status must be %(statuses)s, but \u0027"},{"line_number":2589,"context_line":"                         \u0027current status is %(status)s.\u0027) %"},{"line_number":2590,"context_line":"                       {\u0027vol_id\u0027: volume.id,"},{"line_number":2591,"context_line":"                        \u0027statuses\u0027: \u0027downloading\u0027,"},{"line_number":2592,"context_line":"                        \u0027status\u0027: volume.status})"},{"line_number":2593,"context_line":"                raise exception.InvalidVolume(reason\u003dmsg)"},{"line_number":2594,"context_line":"            raise exception.InvalidVolume(str(err))"}],"source_content_type":"text/x-python","patch_set":7,"id":"df111325_c5aff48c","line":2591,"updated":"2022-08-04 07:05:28.000000000","message":"Query: Here \u0027statuses\u0027 has only one value i.e \u0027downloading\u0027.\nSo can it be skipped in this line \u0026 line 2588.\nOR\nKeep it as it is ... to be consistent with lines 2571 to 2575","commit_id":"36fab54725ca03a6dbb814678798302381307ce3"}]}