)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"7098cfa11b1382c7ae597d16e5551ee0d21f744a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"077740e2_6eae6490","updated":"2022-09-02 08:39:20.000000000","message":"recheck","commit_id":"b4b17f66fc0b5a6851c561777d37736911bad705"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"84690e3c2f20e5066c06a00aa83293dd0f0adac4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c52b0ed2_b71a56ab","updated":"2022-09-07 00:57:51.000000000","message":"\u003e Patch Set 4:\n\u003e \n\u003e * hitachi_vsp_fc http://ec2-18-177-230-241.ap-northeast-1.compute.amazonaws.com/refs/changes/31/850831/4/fc : SUCCESS in 1h 09m 53s\n\u003e * hitachi_vsp_iscsi http://ec2-18-177-230-241.ap-northeast-1.compute.amazonaws.com/refs/changes/31/850831/4/iscsi : FAILURE in 4h 17m 35s\n\nWe\u0027re retrying iscsi test to run successfully","commit_id":"b9cc20b35193bece837d6ee759008292437ced86"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"4cbc92211326132c546e540a6a20d015ce3c448e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a5bc43fe_ba89a47e","updated":"2023-02-17 14:49:20.000000000","message":"This patch is in merge conflict with https://review.opendev.org/c/openstack/cinder/+/842905\n\nSince #842905 is approved, would you mind updating this patch to solve the merge conflict?","commit_id":"65ca4408abe92bbf62bf59cbab2b7770802f26da"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"6eece43ea100e379de144bfbb5f83054781602ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"db0bf151_a5f3812c","in_reply_to":"a5bc43fe_ba89a47e","updated":"2023-02-20 15:29:15.000000000","message":"I\u0027ve updated(rebased) this patch.","commit_id":"65ca4408abe92bbf62bf59cbab2b7770802f26da"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"24e1907b7f4c02446ad9e2eb18939b0a82a51d4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0a50b99b_ba4e79e4","updated":"2023-02-21 01:59:59.000000000","message":"Patchset 7 is to upload correct test_hitachi_hbsd_mirror_fc.py. it means the file in patchset6 is wrong.","commit_id":"6ebc0e75411526978de3798c69a8dd82592b6061"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"47056da58d9ca39a0ee0aabd2bf3f67fa4c0d781","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4aabd7b5_37dfb9ad","updated":"2023-02-21 12:52:37.000000000","message":"I\u0027m checking the cause of Zuul failure","commit_id":"4cc1cd8c3b8c1fda8aa7034fa5fc29d5627ad5ad"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"860c80e83a293c27d5bea2399fb8a367ad569519","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e5d55d55_53392b32","updated":"2023-02-21 12:00:47.000000000","message":"I\u0027ve uploaded patchset 7 which is fixed along a review comment by Rajat.","commit_id":"4cc1cd8c3b8c1fda8aa7034fa5fc29d5627ad5ad"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"fd1ca5ed79e382886b8a6b5dcd88b0a23fdb853b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6536da60_5b5fd940","updated":"2023-02-22 06:17:29.000000000","message":"recheck unrelated failure in tempest-slow-py3\n\ntest_subnet_details","commit_id":"4cc1cd8c3b8c1fda8aa7034fa5fc29d5627ad5ad"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"d34fe33c8de8b4ba65897c74e98a0c2d3de5828f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"7b723b1a_608a88d3","updated":"2023-02-22 07:43:21.000000000","message":"Patchset 10 is fixed bug in patchset 8 occurred in Zuul.","commit_id":"b9fa392ab3d1afe8023fd45dbbc3ed47e753f7dc"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"202f4c1eb0f7460b95b2697a65d3216c789046c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"96ae8392_dfa608dc","updated":"2023-02-22 12:56:23.000000000","message":"my comments are addressed, Waiting for hitachi CI.","commit_id":"b9fa392ab3d1afe8023fd45dbbc3ed47e753f7dc"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b4efea0ccc7848cc4a95c04196b10a38347acdb8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"495612f3_d236b01b","updated":"2023-02-22 10:03:01.000000000","message":"recheck patch is merged to fix the failure\n\nhttps://review.opendev.org/c/openstack/devstack/+/874625","commit_id":"b9fa392ab3d1afe8023fd45dbbc3ed47e753f7dc"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b1af70e37e18b098fc9f747233ef3e4edcd4082b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"d98a4961_bdd22cc3","updated":"2023-02-23 03:45:16.000000000","message":"Code and tests look good.  I assume you\u0027ll add something to doc/source/configuration/block-storage/drivers/hitachi-vsp-driver.rst in a followup patch.  Zuul and the Hitachi VSP CI are both green.","commit_id":"5b38bd138c6f43abdd1f16068cd7ec92f1991007"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"fdeb4e6500f2f7b7c9e82cebec277c47904a22ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"e0466c49_d1643cbf","updated":"2023-02-23 03:53:58.000000000","message":"Hitachi CI is green, zuul is passing now. All my comments are addressed, LGTM.","commit_id":"5b38bd138c6f43abdd1f16068cd7ec92f1991007"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"790bfc0987798fe950f80e6b35343849d2a69787","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"1ce8922e_56cd81cf","updated":"2023-02-22 16:26:35.000000000","message":"patchset 11 fixed silly bugs, but it does not have all required files.\npatchset 12 contains all files.","commit_id":"5b38bd138c6f43abdd1f16068cd7ec92f1991007"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ad66dab2997e94a1fd744088ce97b129b3934f12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"d8cb1547_a7c890cb","updated":"2023-02-24 20:48:39.000000000","message":"recheck tempest-integrated-storage \"Image status transition from saving to saving is not allowed\"","commit_id":"5b38bd138c6f43abdd1f16068cd7ec92f1991007"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3cfef057f8589ddd87283640b6c18211ff13c0fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"593f97da_e00637fa","updated":"2023-02-24 15:04:08.000000000","message":"recheck tempest-integrated-storage - bunch of oslo_db.exception.DBConnectionError reported by the compute API - not related to this patch, but we\u0027ll need to keep an eye on these, looks like mysqld got harvested by the oom reaper:\n\nFeb 23 04:39:33 np0033230608 kernel: Out of memory: Killed process 47826 (mysqld) ","commit_id":"5b38bd138c6f43abdd1f16068cd7ec92f1991007"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"27fcc33b7fc53c35266962fedf5d36cdd495ca26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"46f8a04f_d656c44c","in_reply_to":"d98a4961_bdd22cc3","updated":"2023-02-23 03:54:29.000000000","message":"+1 a lot of hitachi features are added this cycle, would be good to add some documentation around it.","commit_id":"5b38bd138c6f43abdd1f16068cd7ec92f1991007"}],"cinder/tests/unit/volume/drivers/hitachi/test_hitachi_hbsd_mirror_fc.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2df0c789a544887d19e00cd8db676d655a84043c","unresolved":true,"context_lines":[{"line_number":1505,"context_line":"#    @mock.patch.object(requests.Session, \"request\")"},{"line_number":1506,"context_line":"#    @mock.patch.object(volume_types, \u0027get_volume_type\u0027)"},{"line_number":1507,"context_line":"#    @mock.patch.object(volume_types, \u0027get_volume_type_extra_specs\u0027)"},{"line_number":1508,"context_line":"#    def test_create_rep_ldev_and_pair_capacity_saving_deduplication_compression("},{"line_number":1509,"context_line":"#            self, get_volume_type_extra_specs, get_volume_type, request):"},{"line_number":1510,"context_line":"#        get_volume_type_extra_specs.return_value \u003d {"},{"line_number":1511,"context_line":"#            \u0027hbsd:topology\u0027: \u0027active_active_mirror_volume\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"f9d0262b_14e86bfe","line":1508,"range":{"start_line":1508,"start_character":0,"end_line":1508,"end_character":81},"updated":"2023-02-20 17:12:29.000000000","message":"I assume this is the test that I asked for to test hbsd:capacity_saving:deduplication_compression property.\nWhy is this commented out? Please uncomment it.","commit_id":"79c57fd09d84b9355fb6950bbedaa386ae9e95ad"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"c34bfcd510d6e41bf26377efb0b8a2a5c0759abf","unresolved":true,"context_lines":[{"line_number":1505,"context_line":"#    @mock.patch.object(requests.Session, \"request\")"},{"line_number":1506,"context_line":"#    @mock.patch.object(volume_types, \u0027get_volume_type\u0027)"},{"line_number":1507,"context_line":"#    @mock.patch.object(volume_types, \u0027get_volume_type_extra_specs\u0027)"},{"line_number":1508,"context_line":"#    def test_create_rep_ldev_and_pair_capacity_saving_deduplication_compression("},{"line_number":1509,"context_line":"#            self, get_volume_type_extra_specs, get_volume_type, request):"},{"line_number":1510,"context_line":"#        get_volume_type_extra_specs.return_value \u003d {"},{"line_number":1511,"context_line":"#            \u0027hbsd:topology\u0027: \u0027active_active_mirror_volume\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ce76b030_5fb37098","line":1508,"range":{"start_line":1508,"start_character":0,"end_line":1508,"end_character":81},"in_reply_to":"1ace6392_6fcbaab0","updated":"2023-02-21 03:54:53.000000000","message":"I\u0027m sorry. Thw file in patchset 7 does not have the testcase which you commented.\nI\u0027ll update and upload the correct file. please ignore this patchset.","commit_id":"79c57fd09d84b9355fb6950bbedaa386ae9e95ad"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"3128046852d3f91cfa67e6879fdc0036ad1ce9fc","unresolved":false,"context_lines":[{"line_number":1505,"context_line":"#    @mock.patch.object(requests.Session, \"request\")"},{"line_number":1506,"context_line":"#    @mock.patch.object(volume_types, \u0027get_volume_type\u0027)"},{"line_number":1507,"context_line":"#    @mock.patch.object(volume_types, \u0027get_volume_type_extra_specs\u0027)"},{"line_number":1508,"context_line":"#    def test_create_rep_ldev_and_pair_capacity_saving_deduplication_compression("},{"line_number":1509,"context_line":"#            self, get_volume_type_extra_specs, get_volume_type, request):"},{"line_number":1510,"context_line":"#        get_volume_type_extra_specs.return_value \u003d {"},{"line_number":1511,"context_line":"#            \u0027hbsd:topology\u0027: \u0027active_active_mirror_volume\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"44454fbc_5361b571","line":1508,"range":{"start_line":1508,"start_character":0,"end_line":1508,"end_character":81},"in_reply_to":"211529e8_be06072b","updated":"2023-02-22 18:04:52.000000000","message":"Done by patchset 10.","commit_id":"79c57fd09d84b9355fb6950bbedaa386ae9e95ad"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"87f7051b6bc0230dded74c34c3723f43ff4642d0","unresolved":true,"context_lines":[{"line_number":1505,"context_line":"#    @mock.patch.object(requests.Session, \"request\")"},{"line_number":1506,"context_line":"#    @mock.patch.object(volume_types, \u0027get_volume_type\u0027)"},{"line_number":1507,"context_line":"#    @mock.patch.object(volume_types, \u0027get_volume_type_extra_specs\u0027)"},{"line_number":1508,"context_line":"#    def test_create_rep_ldev_and_pair_capacity_saving_deduplication_compression("},{"line_number":1509,"context_line":"#            self, get_volume_type_extra_specs, get_volume_type, request):"},{"line_number":1510,"context_line":"#        get_volume_type_extra_specs.return_value \u003d {"},{"line_number":1511,"context_line":"#            \u0027hbsd:topology\u0027: \u0027active_active_mirror_volume\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"211529e8_be06072b","line":1508,"range":{"start_line":1508,"start_character":0,"end_line":1508,"end_character":81},"in_reply_to":"45712e6c_fbe7187a","updated":"2023-02-22 09:04:47.000000000","message":"I am sorry. Patchset 10 have a bug, either.\nI\u0027m fixing it. The bug is issued when merged retype feature and this feature.\nPlease wait for a while.","commit_id":"79c57fd09d84b9355fb6950bbedaa386ae9e95ad"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"d34fe33c8de8b4ba65897c74e98a0c2d3de5828f","unresolved":false,"context_lines":[{"line_number":1505,"context_line":"#    @mock.patch.object(requests.Session, \"request\")"},{"line_number":1506,"context_line":"#    @mock.patch.object(volume_types, \u0027get_volume_type\u0027)"},{"line_number":1507,"context_line":"#    @mock.patch.object(volume_types, \u0027get_volume_type_extra_specs\u0027)"},{"line_number":1508,"context_line":"#    def test_create_rep_ldev_and_pair_capacity_saving_deduplication_compression("},{"line_number":1509,"context_line":"#            self, get_volume_type_extra_specs, get_volume_type, request):"},{"line_number":1510,"context_line":"#        get_volume_type_extra_specs.return_value \u003d {"},{"line_number":1511,"context_line":"#            \u0027hbsd:topology\u0027: \u0027active_active_mirror_volume\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"45712e6c_fbe7187a","line":1508,"range":{"start_line":1508,"start_character":0,"end_line":1508,"end_character":81},"in_reply_to":"49478cbb_59086aef","updated":"2023-02-22 07:43:21.000000000","message":"I\u0027ve fixed following points as patchset10:\n- adding testcase requested by rajat\n- fixing the failure in Zuul","commit_id":"79c57fd09d84b9355fb6950bbedaa386ae9e95ad"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"860c80e83a293c27d5bea2399fb8a367ad569519","unresolved":false,"context_lines":[{"line_number":1505,"context_line":"#    @mock.patch.object(requests.Session, \"request\")"},{"line_number":1506,"context_line":"#    @mock.patch.object(volume_types, \u0027get_volume_type\u0027)"},{"line_number":1507,"context_line":"#    @mock.patch.object(volume_types, \u0027get_volume_type_extra_specs\u0027)"},{"line_number":1508,"context_line":"#    def test_create_rep_ldev_and_pair_capacity_saving_deduplication_compression("},{"line_number":1509,"context_line":"#            self, get_volume_type_extra_specs, get_volume_type, request):"},{"line_number":1510,"context_line":"#        get_volume_type_extra_specs.return_value \u003d {"},{"line_number":1511,"context_line":"#            \u0027hbsd:topology\u0027: \u0027active_active_mirror_volume\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"d4f80c73_c8ec6721","line":1508,"range":{"start_line":1508,"start_character":0,"end_line":1508,"end_character":81},"in_reply_to":"ce76b030_5fb37098","updated":"2023-02-21 12:00:47.000000000","message":"Excuse me to late response.\nI\u0027ve uploaded fixed the file, which adds a testcase to test hbsd:capacity_saving:deduplication_compression.\nPlease check it.","commit_id":"79c57fd09d84b9355fb6950bbedaa386ae9e95ad"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"47056da58d9ca39a0ee0aabd2bf3f67fa4c0d781","unresolved":true,"context_lines":[{"line_number":1505,"context_line":"#    @mock.patch.object(requests.Session, \"request\")"},{"line_number":1506,"context_line":"#    @mock.patch.object(volume_types, \u0027get_volume_type\u0027)"},{"line_number":1507,"context_line":"#    @mock.patch.object(volume_types, \u0027get_volume_type_extra_specs\u0027)"},{"line_number":1508,"context_line":"#    def test_create_rep_ldev_and_pair_capacity_saving_deduplication_compression("},{"line_number":1509,"context_line":"#            self, get_volume_type_extra_specs, get_volume_type, request):"},{"line_number":1510,"context_line":"#        get_volume_type_extra_specs.return_value \u003d {"},{"line_number":1511,"context_line":"#            \u0027hbsd:topology\u0027: \u0027active_active_mirror_volume\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"49478cbb_59086aef","line":1508,"range":{"start_line":1508,"start_character":0,"end_line":1508,"end_character":81},"in_reply_to":"d4f80c73_c8ec6721","updated":"2023-02-21 12:52:37.000000000","message":"I\u0027m checking the cause of Zuul failure","commit_id":"79c57fd09d84b9355fb6950bbedaa386ae9e95ad"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"24e1907b7f4c02446ad9e2eb18939b0a82a51d4a","unresolved":false,"context_lines":[{"line_number":1505,"context_line":"#    @mock.patch.object(requests.Session, \"request\")"},{"line_number":1506,"context_line":"#    @mock.patch.object(volume_types, \u0027get_volume_type\u0027)"},{"line_number":1507,"context_line":"#    @mock.patch.object(volume_types, \u0027get_volume_type_extra_specs\u0027)"},{"line_number":1508,"context_line":"#    def test_create_rep_ldev_and_pair_capacity_saving_deduplication_compression("},{"line_number":1509,"context_line":"#            self, get_volume_type_extra_specs, get_volume_type, request):"},{"line_number":1510,"context_line":"#        get_volume_type_extra_specs.return_value \u003d {"},{"line_number":1511,"context_line":"#            \u0027hbsd:topology\u0027: \u0027active_active_mirror_volume\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ace6392_6fcbaab0","line":1508,"range":{"start_line":1508,"start_character":0,"end_line":1508,"end_character":81},"in_reply_to":"f9d0262b_14e86bfe","updated":"2023-02-21 01:59:59.000000000","message":"I\u0027m sorry. I uploaded a wrong file, which is in debugging.\nI\u0027ve uploaded a correct file. Please check it.","commit_id":"79c57fd09d84b9355fb6950bbedaa386ae9e95ad"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"202f4c1eb0f7460b95b2697a65d3216c789046c1","unresolved":true,"context_lines":[{"line_number":1501,"context_line":"        )"},{"line_number":1502,"context_line":"        self.assertTupleEqual(actual, ret)"},{"line_number":1503,"context_line":""},{"line_number":1504,"context_line":"    @mock.patch.object(requests.Session, \"request\")"},{"line_number":1505,"context_line":"    @mock.patch.object(volume_types, \u0027get_volume_type\u0027)"},{"line_number":1506,"context_line":"    @mock.patch.object(volume_types, \u0027get_volume_type_extra_specs\u0027)"},{"line_number":1507,"context_line":"    def test_create_rep_ldev_and_pair_deduplication_compression("}],"source_content_type":"text/x-python","patch_set":10,"id":"466c0e46_816b2322","line":1504,"updated":"2023-02-22 12:56:23.000000000","message":"would\u0027ve been good to assert that copy_on_storage is called with extra_specs but i don\u0027t see it tested anywhere? anyway, good for future improvement.","commit_id":"b9fa392ab3d1afe8023fd45dbbc3ed47e753f7dc"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"3128046852d3f91cfa67e6879fdc0036ad1ce9fc","unresolved":false,"context_lines":[{"line_number":1501,"context_line":"        )"},{"line_number":1502,"context_line":"        self.assertTupleEqual(actual, ret)"},{"line_number":1503,"context_line":""},{"line_number":1504,"context_line":"    @mock.patch.object(requests.Session, \"request\")"},{"line_number":1505,"context_line":"    @mock.patch.object(volume_types, \u0027get_volume_type\u0027)"},{"line_number":1506,"context_line":"    @mock.patch.object(volume_types, \u0027get_volume_type_extra_specs\u0027)"},{"line_number":1507,"context_line":"    def test_create_rep_ldev_and_pair_deduplication_compression("}],"source_content_type":"text/x-python","patch_set":10,"id":"e868701b_19e32993","line":1504,"in_reply_to":"466c0e46_816b2322","updated":"2023-02-22 18:04:52.000000000","message":"Thanks. I would like to think what we do for future improvment.","commit_id":"b9fa392ab3d1afe8023fd45dbbc3ed47e753f7dc"}],"cinder/volume/drivers/hitachi/hbsd_common.py":[{"author":{"_account_id":28403,"name":"Naoki Saito","email":"nasaito@nec.com","username":"n-saito"},"change_message_id":"b8bb2bbdf70a4e55bbab60554c7dd3b8574b8540","unresolved":true,"context_lines":[{"line_number":31,"context_line":"_STR_VOLUME \u003d \u0027volume\u0027"},{"line_number":32,"context_line":"_STR_SNAPSHOT \u003d \u0027snapshot\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"DEDUPLICATION_COMPRESSION \u003d \u0027deduplication_compression\u0027"},{"line_number":35,"context_line":"DRIVER_CAPACITY_SAVING \u003d \u0027:capacity_saving\u0027"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"_INHERITED_VOLUME_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"4bb249d5_c14a85c1","line":34,"updated":"2022-08-26 07:42:09.000000000","message":"This variable is not used.","commit_id":"57bc340425f148dd3f87668bfcb177c4467b44e6"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"75691c46bb42d743c35cd75a4bf4ecc8363ac38a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"_STR_VOLUME \u003d \u0027volume\u0027"},{"line_number":32,"context_line":"_STR_SNAPSHOT \u003d \u0027snapshot\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"DEDUPLICATION_COMPRESSION \u003d \u0027deduplication_compression\u0027"},{"line_number":35,"context_line":"DRIVER_CAPACITY_SAVING \u003d \u0027:capacity_saving\u0027"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"_INHERITED_VOLUME_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"a31947bf_4a9dde73","line":34,"in_reply_to":"4bb249d5_c14a85c1","updated":"2022-09-05 22:27:59.000000000","message":"Done in patchset4","commit_id":"57bc340425f148dd3f87668bfcb177c4467b44e6"},{"author":{"_account_id":28403,"name":"Naoki Saito","email":"nasaito@nec.com","username":"n-saito"},"change_message_id":"b8bb2bbdf70a4e55bbab60554c7dd3b8574b8540","unresolved":true,"context_lines":[{"line_number":32,"context_line":"_STR_SNAPSHOT \u003d \u0027snapshot\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"DEDUPLICATION_COMPRESSION \u003d \u0027deduplication_compression\u0027"},{"line_number":35,"context_line":"DRIVER_CAPACITY_SAVING \u003d \u0027:capacity_saving\u0027"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"_INHERITED_VOLUME_OPTS \u003d ["},{"line_number":38,"context_line":"    \u0027volume_backend_name\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ebabc10d_01439e03","line":35,"updated":"2022-08-26 07:42:09.000000000","message":"Same","commit_id":"57bc340425f148dd3f87668bfcb177c4467b44e6"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"75691c46bb42d743c35cd75a4bf4ecc8363ac38a","unresolved":false,"context_lines":[{"line_number":32,"context_line":"_STR_SNAPSHOT \u003d \u0027snapshot\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"DEDUPLICATION_COMPRESSION \u003d \u0027deduplication_compression\u0027"},{"line_number":35,"context_line":"DRIVER_CAPACITY_SAVING \u003d \u0027:capacity_saving\u0027"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"_INHERITED_VOLUME_OPTS \u003d ["},{"line_number":38,"context_line":"    \u0027volume_backend_name\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"52dd0196_22615c60","line":35,"in_reply_to":"ebabc10d_01439e03","updated":"2022-09-05 22:27:59.000000000","message":"Done in patchset4","commit_id":"57bc340425f148dd3f87668bfcb177c4467b44e6"},{"author":{"_account_id":28403,"name":"Naoki Saito","email":"nasaito@nec.com","username":"n-saito"},"change_message_id":"b8bb2bbdf70a4e55bbab60554c7dd3b8574b8540","unresolved":true,"context_lines":[{"line_number":305,"context_line":"            self.raise_error(msg)"},{"line_number":306,"context_line":"        size \u003d snapshot[\u0027volume_size\u0027]"},{"line_number":307,"context_line":"        extra_specs \u003d self.get_volume_extra_specs(snapshot[\u0027volume\u0027])"},{"line_number":308,"context_line":"        new_ldev \u003d self._copy_on_storage(ldev, size, extra_specs, True)"},{"line_number":309,"context_line":"        return {"},{"line_number":310,"context_line":"            \u0027provider_location\u0027: str(new_ldev),"},{"line_number":311,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":1,"id":"de93b2f0_e6ae2a75","line":308,"range":{"start_line":308,"start_character":66,"end_line":308,"end_character":70},"updated":"2022-08-26 07:42:09.000000000","message":"I suggest that this \"True\" should be made into \"is_snapshot\u003dTrue\".","commit_id":"57bc340425f148dd3f87668bfcb177c4467b44e6"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"75691c46bb42d743c35cd75a4bf4ecc8363ac38a","unresolved":false,"context_lines":[{"line_number":305,"context_line":"            self.raise_error(msg)"},{"line_number":306,"context_line":"        size \u003d snapshot[\u0027volume_size\u0027]"},{"line_number":307,"context_line":"        extra_specs \u003d self.get_volume_extra_specs(snapshot[\u0027volume\u0027])"},{"line_number":308,"context_line":"        new_ldev \u003d self._copy_on_storage(ldev, size, extra_specs, True)"},{"line_number":309,"context_line":"        return {"},{"line_number":310,"context_line":"            \u0027provider_location\u0027: str(new_ldev),"},{"line_number":311,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":1,"id":"6ccedb74_4107c50d","line":308,"range":{"start_line":308,"start_character":66,"end_line":308,"end_character":70},"in_reply_to":"de93b2f0_e6ae2a75","updated":"2022-09-05 22:27:59.000000000","message":"Done in patchset4","commit_id":"57bc340425f148dd3f87668bfcb177c4467b44e6"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"972023a9048ffc2cb0fcb4f143141123c331974d","unresolved":true,"context_lines":[{"line_number":324,"context_line":"                type\u003d\u0027volume\u0027, id\u003dsrc_vref[\u0027id\u0027])"},{"line_number":325,"context_line":"            self.raise_error(msg)"},{"line_number":326,"context_line":"        size \u003d snapshot[\u0027volume_size\u0027]"},{"line_number":327,"context_line":"        extra_specs \u003d self.get_volume_extra_specs(snapshot[\u0027volume\u0027])"},{"line_number":328,"context_line":"        pool_id \u003d self.get_pool_id_of_volume(snapshot[\u0027volume\u0027])"},{"line_number":329,"context_line":"        new_ldev \u003d self._copy_on_storage("},{"line_number":330,"context_line":"            ldev, size, extra_specs, pool_id, is_snapshot\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7d9ea7b1_1d93231d","line":327,"range":{"start_line":327,"start_character":50,"end_line":327,"end_character":68},"updated":"2023-02-17 14:51:41.000000000","message":"nit: snapshot.volume","commit_id":"65ca4408abe92bbf62bf59cbab2b7770802f26da"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"6eece43ea100e379de144bfbb5f83054781602ba","unresolved":false,"context_lines":[{"line_number":324,"context_line":"                type\u003d\u0027volume\u0027, id\u003dsrc_vref[\u0027id\u0027])"},{"line_number":325,"context_line":"            self.raise_error(msg)"},{"line_number":326,"context_line":"        size \u003d snapshot[\u0027volume_size\u0027]"},{"line_number":327,"context_line":"        extra_specs \u003d self.get_volume_extra_specs(snapshot[\u0027volume\u0027])"},{"line_number":328,"context_line":"        pool_id \u003d self.get_pool_id_of_volume(snapshot[\u0027volume\u0027])"},{"line_number":329,"context_line":"        new_ldev \u003d self._copy_on_storage("},{"line_number":330,"context_line":"            ldev, size, extra_specs, pool_id, is_snapshot\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"f10903a8_8a7c74a1","line":327,"range":{"start_line":327,"start_character":50,"end_line":327,"end_character":68},"in_reply_to":"7d9ea7b1_1d93231d","updated":"2023-02-20 15:29:15.000000000","message":"Yes, although it ccould be so, similar cases in this file are xxx[\u0027yyy\u0027].\nSo, please hold on this","commit_id":"65ca4408abe92bbf62bf59cbab2b7770802f26da"}],"cinder/volume/drivers/hitachi/hbsd_rest.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"972023a9048ffc2cb0fcb4f143141123c331974d","unresolved":true,"context_lines":[{"line_number":93,"context_line":"}"},{"line_number":94,"context_line":"_CAPACITY_SAVING_DR_MODE \u003d {"},{"line_number":95,"context_line":"    \u0027disable\u0027: \u0027disabled\u0027,"},{"line_number":96,"context_line":"    \u0027deduplication_compression\u0027: \u0027compression_deduplication\u0027,"},{"line_number":97,"context_line":"    \u0027\u0027: \u0027disabled\u0027,"},{"line_number":98,"context_line":"    None: \u0027disabled\u0027,"},{"line_number":99,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":5,"id":"14b233a5_f4dea0f1","line":96,"range":{"start_line":96,"start_character":5,"end_line":96,"end_character":30},"updated":"2023-02-17 14:51:41.000000000","message":"I couldn\u0027t find a test where this is set in volume type extra specs.","commit_id":"65ca4408abe92bbf62bf59cbab2b7770802f26da"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"6eece43ea100e379de144bfbb5f83054781602ba","unresolved":false,"context_lines":[{"line_number":93,"context_line":"}"},{"line_number":94,"context_line":"_CAPACITY_SAVING_DR_MODE \u003d {"},{"line_number":95,"context_line":"    \u0027disable\u0027: \u0027disabled\u0027,"},{"line_number":96,"context_line":"    \u0027deduplication_compression\u0027: \u0027compression_deduplication\u0027,"},{"line_number":97,"context_line":"    \u0027\u0027: \u0027disabled\u0027,"},{"line_number":98,"context_line":"    None: \u0027disabled\u0027,"},{"line_number":99,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":5,"id":"b3e9b850_3960f0a8","line":96,"range":{"start_line":96,"start_character":5,"end_line":96,"end_character":30},"in_reply_to":"14b233a5_f4dea0f1","updated":"2023-02-20 15:29:15.000000000","message":"I added the case into test_hitachi_hbsd_mirror_fc.py.","commit_id":"65ca4408abe92bbf62bf59cbab2b7770802f26da"}],"releasenotes/notes/hitachi-vsp-support-dedup-comp-4e27d95b34681f66.yaml":[{"author":{"_account_id":28403,"name":"Naoki Saito","email":"nasaito@nec.com","username":"n-saito"},"change_message_id":"b8bb2bbdf70a4e55bbab60554c7dd3b8574b8540","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Support data deduplication and compression, by storage assist. "},{"line_number":5,"context_line":"    The feature can be worked, if user enable deduplication and compression"},{"line_number":6,"context_line":"    for the DP-pool, by Configuration Manager REST API, and set the extra "},{"line_number":7,"context_line":"    spec \"hbsd:capacity_saving\" to \"deduplication_compression\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"46fe63c1_9f923009","line":4,"updated":"2022-08-26 07:42:09.000000000","message":"You should add that it is an enhancement to your driver.","commit_id":"57bc340425f148dd3f87668bfcb177c4467b44e6"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"75691c46bb42d743c35cd75a4bf4ecc8363ac38a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Support data deduplication and compression, by storage assist. "},{"line_number":5,"context_line":"    The feature can be worked, if user enable deduplication and compression"},{"line_number":6,"context_line":"    for the DP-pool, by Configuration Manager REST API, and set the extra "},{"line_number":7,"context_line":"    spec \"hbsd:capacity_saving\" to \"deduplication_compression\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5d0df107_79fd778c","line":4,"in_reply_to":"46fe63c1_9f923009","updated":"2022-09-05 22:27:59.000000000","message":"I added our driver name at the top of line #4 in patchset4","commit_id":"57bc340425f148dd3f87668bfcb177c4467b44e6"}]}